1. 12 Jan, 2020 1 commit
    • Sergei Petrunia's avatar
      MDEV-21243: Join buffer: condition is checked in wrong place for range access · 9c3eca85
      Sergei Petrunia authored
      In this scenario:
      - There is a possible range access for table T
      - And there is a ref access on the same index which uses fewer key parts
      - The join optimizer picks the ref access (because it is cheaper)
      - make_join_select applies this heuristic to switch to range:
        /* Range uses longer key;  Use this instead of ref on key */
      
      Join buffer will be used without having called
      JOIN_TAB::make_scan_filter(). This means, conditions that should be
      checked when reading table T will be checked after T is joined with the
      contents of the join buffer, instead.
      
      Fixed this by adding a make_scan_filter() check.
      (updated patch after backport to 10.3)
      (Fix testcase on Windows)
      9c3eca85
  2. 08 Jan, 2020 2 commits
  3. 07 Jan, 2020 16 commits
    • Sujatha's avatar
      Merge branch '10.1' into 10.2 · 8317f77c
      Sujatha authored
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events
      
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following assert when ASAN is enabled.
      
      uint32 binlog_get_uncompress_len(const char*):
        Assertion `(buf[0] & 0xe0) == 0x80' failed
      
      Fix:
      ===
      **Part11: Converted debug assert to error handler code**
      8317f77c
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · cb204e11
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following ASAN error.
      
      AddressSanitizer: heap-buffer-overflow on address
      READ of size 1 at 0x60e00009cf71 thread T28
      #0 0x55e37e034ae2 in net_field_length
      
      Fix:
      ===
      **Part10: Avoid reading out of buffer**
      cb204e11
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · d05c511d
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following assert when ASAN is enabled.
      
      Query_log_event::Query_log_event(const char*, uint,
          const Format_description_log_event*, Log_event_type):
        Assertion `(pos) + (6) <= (end)' failed
      
      Fix:
      ===
      **Part9: Removed additional DBUG_ASSERT**
      d05c511d
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · bac33533
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following ASAN error
      
      AddressSanitizer: SEGV on unknown address
      The signal is caused by a READ memory access.
      User_var_log_event::User_var_log_event(char const*, unsigned int,
          Format_description_log_event const*)
      
      Implemented part of upstream patch.
      commit: mysql/mysql-server@a3a497ccf7ecacc900551fb1e47ea4078b45c351
      
      Fix:
      ===
      **Part8: added checks to avoid reading out of buffer limits**
      bac33533
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · 2187f1c2
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following ASAN error
      "heap-buffer-overflow on address" and some times it asserts.
      
      Table_map_log_event::Table_map_log_event(const char*, uint,
          const Format_description_log_event*)
      Assertion `m_field_metadata_size <= (m_colcnt * 2)' failed.
      
      Fix:
      ===
      **Part7: Avoid reading out of buffer**
      
      
      Converted debug assert to error handler code.
      2187f1c2
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · d6fa69e4
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following ASAN error
      
      AddressSanitizer: heap-buffer-overflow on address 0x60400002acb8
      Load_log_event::copy_log_event(char const*, unsigned long, int,
          Format_description_log_event const*)
      
      Fix:
      ===
      **Part6: Moved the event_len validation to the begin of copy_log_event function**
      d6fa69e4
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · 15781283
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following ASAN error
      
      AddressSanitizer: heap-buffer-overflow on address
      String::append(char const*, unsigned int)
      Query_log_event::pack_info(Protocol*)
      
      Fix:
      ===
      **Part5: Added check to catch buffer overflow**
      15781283
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · a42ef108
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following ASAN error
      
      heap-buffer-overflow within "my_strndup" in Rotate_log_event
      
      my_strndup /mysys/my_malloc.c:254
      Rotate_log_event::Rotate_log_event(char const*, unsigned int,
          Format_description_log_event const*)
      
      Fix:
      ===
      **Part4: Improved the check for event_len validation**
      a42ef108
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · 5a54e84e
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following crash when ASAN is enabled.
      
      SEGV on unknown address
      in inline_mysql_mutex_destroy
      in my_bitmap_free
      in Update_rows_log_event::~Update_rows_log_event()
      
      Fix:
      ===
      **Part3: Initialize m_cols_ai.bitmap to NULL**
      5a54e84e
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · 913f405d
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> reports following assert when ASAN is enabled.
      
      Rows_log_event::Rows_log_event(const char*, uint,
          const Format_description_log_event*):
      Assertion `var_header_len >= 2'
      
      Implemented part of upstream patch.
      commit: mysql/mysql-server@a3a497ccf7ecacc900551fb1e47ea4078b45c351
      
      Fix:
      ===
      **Part2: Avoid reading out of buffer limits**
      913f405d
    • Sujatha's avatar
      MDEV-18046: Assortment of crashes, assertion failures and ASAN errors in mysql_show_binlog_events · a6dd827a
      Sujatha authored
      Problem:
      ========
      SHOW BINLOG EVENTS FROM <pos> causes a variety of failures, some of which are
      listed below. It is not a race condition issue, but there is some
      non-determinism in it.
      
      Analysis:
      ========
      "show binlog events from <pos>" code considers the user given position as a
      valid event start position. The code starts reading data from this event start
      position onwards and tries to map it to a set of known events. Each event has
      a specific event structure and asserts have been added to ensure that read
      event data satisfies the event specific requirements. When a random position
      is supplied to "show binlog events command" the event structure specific
      checks will fail and they result in assert.
      
      Fix:
      ====
      The fix is split into different parts. Each part addresses either an ASAN
      issue or an assert/crash.
      
      **Part1: Checksum based position validation when checksum is enabled**
      
      
      Using checksum validate the very first event read at the user specified
      position. If there is a checksum mismatch report an appropriate error for the
      invalid event.
      a6dd827a
    • Marko Mäkelä's avatar
      Fixup MDEV-21429: Correct a definition · 0b4ae672
      Marko Mäkelä authored
      INNOBASE_ALTER_NOVALIDATE: Remove the set of operations
      INNOBASE_ONLINE_CREATE that was accidentally included in the
      definition.
      
      In the merge of 82187a12 to 10.3
      (in commit eda71979) the flags
      were defined correctly.
      
      This bug was caught by the test innodb_zip.index_large_prefix.
      0b4ae672
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · eda71979
      Marko Mäkelä authored
      eda71979
    • Marko Mäkelä's avatar
      MDEV-21429 TRUNCATE and OPTIMIZE are being refused due to "row size too large" · 82187a12
      Marko Mäkelä authored
      By default (innodb_strict_mode=ON), InnoDB attempts to guarantee
      at DDL time that any INSERT to the table can succeed.
      MDEV-19292 recently revised the "row size too large" check in InnoDB.
      The check still is somewhat inaccurate;
      that should be addressed in MDEV-20194.
      
      Note: If a table contains multiple long string columns so that each column
      is part of a column prefix index, then an UPDATE that attempts to modify
      all those columns at once may fail, because the undo log record might
      not fit in a single undo log page (of innodb_page_size). In the worst case,
      the undo log record would grow by about 3KiB of for each updated column.
      
      The DDL-time check (since the InnoDB Plugin for MySQL 5.1) is optional
      in the sense that when the maximum B-tree record size or undo log
      record size would be exceeded, the DML operation will fail and the
      transaction will be properly rolled back.
      
      create_table_info_t::row_size_is_acceptable(): Add the parameter
      'bool strict' so that innodb_strict_mode=ON can be overridden during
      TRUNCATE, OPTIMIZE and ALTER TABLE...FORCE (when the storage format
      is not changing).
      
      create_table_info_t::create_table(): Perform a sloppy check for
      TRUNCATE TABLE (create_fk=false).
      
      prepare_inplace_alter_table_dict(): Perform a sloppy check for
      simple operations.
      
      trx_is_strict(): Remove. The function became unused in
      commit 98694ab0 (MDEV-20949).
      82187a12
    • Jan Lindström's avatar
      MDEV-13569: wsrep_info.plugin failed in buildbot with "no nodes coming from prim view · 5824e9f8
      Jan Lindström authored
      Modify configuration so that all nodes are part of galera cluster
      i.e. wsrep_on=ON. Add missing wait conditions.
      
      test changes only.
      5824e9f8
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · e99ba4ba
      Marko Mäkelä authored
      e99ba4ba
  4. 04 Jan, 2020 1 commit
    • Eugene Kosov's avatar
      Lets add another intrusive double linked list! · fd899b3b
      Eugene Kosov authored
      Features:
      * STL-like interface
      * Fast modification: no branches on insertion or deletion
      * Fast iteration: one pointer dereference and one pointer comparison
      * Your class can be a part of several lists
      
      Modeled after std::list<T> but currently has fewer methods (not complete yet)
      
      For even more performance it's possible to customize list with templates so
      it won't have size counter variable or won't NULLify unlinked node.
      
      How existing lists differ?
      
      No existing lists support STL-like interface.
      
      I_List:
      * slower iteration (one more branch on iteration)
      * element can't be a part of two lists simultaneously
      
      I_P_List:
      * slower modification (branches, except for the fastest push_back() case)
      * slower iteration (one more branch on iteration)
      
      UT_LIST_BASE_NODE_T:
      * slower modification (branches)
      
      Three UT_LISTs were replaced: two in fil_system_t and one in dyn_buf_t.
      fd899b3b
  5. 03 Jan, 2020 5 commits
  6. 02 Jan, 2020 2 commits
  7. 30 Dec, 2019 2 commits
    • Marko Mäkelä's avatar
      Post-fix for MDEV-12253: Remove redundant log writes · 4a012ce2
      Marko Mäkelä authored
      The 8 bytes at FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION
      will be overwritten at page flush, in buf_page_encrypt_before_write(),
      ever since commit 765a4360
      (MariaDB 10.1.23, 10.2.6, 10.3.1).
      
      btr_store_big_rec_extern_fields(): Remove useless writes to the
      page header (and to the redo log) for ROW_FORMAT=COMPRESSED BLOB pages.
      4a012ce2
    • Marko Mäkelä's avatar
      MDEV-21405 Assertion failed on instant ADD COLUMN · 02e30069
      Marko Mäkelä authored
      btr_cur_pessimistic_insert(): Relax a too strict debug assertion that
      would fail when the function is invoked by btr_cur_pessimistic_update()
      during innobase_add_instant_try(), that is, when updating the hidden
      metadata record during a subsequent ADD COLUMN operation involves
      splitting the leftmost clustered index leaf page.
      
      This is a partial backport of 301bd62b
      from 10.4.
      02e30069
  8. 29 Dec, 2019 2 commits
    • Nikita Malyavin's avatar
      MDEV-18865 Assertion `t->first->versioned_by_id()' failed in innodb_prepare_commit_versioned · 4923604e
      Nikita Malyavin authored
      Cause:
      * row_start != 0 treated as it exists. Probably, possible row permutations had not been taken in mind.
      
      Solution:
      * Checking both row_start and row_end is correct, so versioned() function is used
      4923604e
    • Nikita Malyavin's avatar
      MDEV-18875 Assertion `thd->transaction.stmt.ha_list == __null || trans ==... · 720e9bd5
      Nikita Malyavin authored
      MDEV-18875 Assertion `thd->transaction.stmt.ha_list == __null || trans == &thd->transaction.stmt' failed or bogus ER_DUP_ENTRY upon ALTER TABLE with versioning
      
      Cause:
      * when autocommit=0 (or transaction is issued by user),
       `ha_commit_trans` is called twice on ALTER TABLE, causing a duplicated
       insert into `transaction_registry` (ER_DUP_ENTRY).
      
      Solution:
      * ALTER TABLE makes an implicit commit by a second call. We actually
       need to make an insert only when it is a real commit. So is_real
       variable is additionally checked.
      720e9bd5
  9. 27 Dec, 2019 4 commits
  10. 26 Dec, 2019 2 commits
    • Varun Gupta's avatar
      MDEV-19680:: Assertion `!table || (!table->read_set ||... · 359d91aa
      Varun Gupta authored
      MDEV-19680:: Assertion `!table || (!table->read_set || bitmap_is_set(table->read_set, field_index) || (!(ptr >= table->record[0] && ptr < table->record[0] + table->s->reclength)))' or alike failed upon SELECT with mix of functions from simple view
      
      Set read_set bitmap for view from the JOIN::all_fields list instead of JOIN::fields_list
      as split_sum_func would have added items to the all_fields list.
      359d91aa
    • Varun Gupta's avatar
      MDEV-21318: Wrong results with window functions and implicit grouping · 891609b5
      Varun Gupta authored
      The issue here is for degenerate joins we should execute the window
      function but it is not getting executed in all the cases.
      
      To get the window function values window function needs to be executed
      always. This currently does not happen in few cases
      where the join would return 0 or 1 row like
        1) IMPOSSIBLE WHERE
        2) MIN/MAX optimization
        3) EMPTY CONST TABLE
      
      The fix is to make sure that window functions get executed
      and the temporary table is setup for the execution of window functions
      891609b5
  11. 25 Dec, 2019 1 commit
  12. 24 Dec, 2019 2 commits