1. 06 Nov, 2007 10 commits
    • unknown's avatar
      bug#27571 · 9c4b1f65
      unknown authored
      tests fixing: refreshing the results file.
      
      
      mysql-test/suite/binlog/r/binlog_killed.result:
        results changed
      9c4b1f65
    • unknown's avatar
      results from 5.0 is not needed · 20f5aff4
      unknown authored
      
      BitKeeper/deleted/.del-binlog_killed_simulate.result:
        Delete: mysql-test/r/binlog_killed_simulate.result
      20f5aff4
    • unknown's avatar
      Merge koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/BARE/5.0 · f7be180b
      unknown authored
      into  koti.dsl.inet.fi:/home/elkin/MySQL/merge-5.1
      
      
      BitKeeper/deleted/.del-binlog_killed_bug27571-master.opt:
        Auto merged
      BitKeeper/deleted/.del-binlog_killed_bug27571.test:
        Auto merged
      f7be180b
    • unknown's avatar
      bug#27571 · 06a48161
      unknown authored
      fixing tests
      
      
      mysql-test/r/binlog_killed_simulate.result:
        the new tests' result
      06a48161
    • unknown's avatar
      bug#27571 · 71cb6a6f
      unknown authored
      removing extra tests (on 5.1 that's been already done)
      
      
      BitKeeper/deleted/.del-binlog_killed_bug27571-master.opt:
        Delete: mysql-test/t/binlog_killed_bug27571-master.opt
      BitKeeper/deleted/.del-binlog_killed_bug27571.test:
        Delete: mysql-test/t/binlog_killed_bug27571.test
      71cb6a6f
    • unknown's avatar
      Merge koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/BARE/5.0 · 8f882c5c
      unknown authored
      into  koti.dsl.inet.fi:/home/elkin/MySQL/merge-5.1
      
      
      mysql-test/suite/binlog/r/binlog_killed.result:
        manual merge ul
      mysql-test/suite/binlog/t/binlog_killed.test:
        manual merge with 5.0 specific tests; use local
      mysql-test/suite/binlog/t/binlog_killed_simulate.test:
         manual merge with 5.0 specific tests; use local
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/func_regexp.test:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        automerge
      mysql-test/r/ctype_utf8.result:
        automerge
      mysql-test/r/func_regexp.result:
        automerge
      mysql-test/t/ctype_utf8.test:
        automerge
      sql/item_cmpfunc.cc:
        automerge
      sql/item_cmpfunc.h:
        automerge
      sql/sql_class.h:
        automerge
      sql/sql_insert.cc:
        automerge
      sql/sql_parse.cc:
        automerge
      sql/sql_update.cc:
        automerge
      8f882c5c
    • unknown's avatar
      bug#27571 · 61d0ece4
      unknown authored
      commit is specific for 5.0 to eliminated non-deterministic tests.
      Those tests run only in 5.1 env where there is a necessary devices such
      as processlist table of info_schema.
      
      
      mysql-test/r/binlog_killed.result:
        results changed
      mysql-test/t/binlog_killed.test:
        removing non-deterministic part of the test
      mysql-test/t/binlog_killed_simulate.test:
        adding the guard same as for 5.1 version
      61d0ece4
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · 1a12422b
      unknown authored
      into  koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.0/bug27571_asyn_killed_flags
      
      
      sql/sql_insert.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      1a12422b
    • unknown's avatar
      bug#27571 · 9b524eae
      unknown authored
      non-deterministic tests refining.
      This particular patch tested on two archs.
      
      
      mysql-test/suite/binlog/t/binlog_killed.test:
        deploying synchronization of killing with reaching the explected state
        of the prey's connection.
      9b524eae
    • unknown's avatar
      bug#27571 · 30774977
      unknown authored
      non-deterministic tests execution on some platforms.
      
      
      mysql-test/suite/binlog/r/binlog_killed.result:
        results changed
      mysql-test/suite/binlog/t/binlog_killed.test:
        correcting the prev test's cleanup;
        increasing time to wait by to be killed query;
        adding the masking out error due to Bug@32140 wrong error code caught when an SF() call is interruped with KILL query
      30774977
  2. 05 Nov, 2007 1 commit
    • unknown's avatar
      bug#27571 asynchronous setting mysql_`query`::error and Query_log_e::error_code · 4cbfccca
      unknown authored
      refining tests as they appear to be non-deterministic.
      
      
      mysql-test/suite/binlog/r/binlog_killed.result:
        results changed
      mysql-test/suite/binlog/t/binlog_killed.test:
        restructuring the test to deliver more deterministic outcome.
        order-by for update and delete did not guaratee the order of scanning.
        --error are masked with zero in order to catch more info if killing
        really will happen to be non-deterministic on some platform (witnessed
        something like that on dl145j)
      mysql-test/suite/binlog/t/binlog_killed_simulate.test:
        important guard added
      4cbfccca
  3. 02 Nov, 2007 5 commits
    • unknown's avatar
      Merge skozlov@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · c8de13d3
      unknown authored
      into  mysql.com:/home/ksm/commits/mysql-5.1-new-rpl
      
      c8de13d3
    • unknown's avatar
      WL#3949. Added an option for support "combinations" of mysqld arguments for a suite · 2f193e82
      unknown authored
      
      mysql-test/lib/mtr_cases.pl:
        updated mtr_cases.pl
      mysql-test/mysql-test-run.pl:
        updated mtr
      2f193e82
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.1-rpl · ded0beb6
      unknown authored
      into  koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.1/bug31554-rpl_truncate
      
      ded0beb6
    • unknown's avatar
      Bug #31554 rpl.rpl_truncate_2myisam test failure: wrong master binlog file name · b504eae7
      unknown authored
      Actually, the failure happened with 3innodb as well. Most probably
      the reason is in failing to delete a binlog file on __NT__ so that
      that master increments the index of the binlog file.
      The test results hide valueable warning that windows could generate
      about that.
      
      The scope of this fix is to make sure we have such warning and
      to lessen chances for binlog file being held at time of closing.
      The dump thread is getting a good chance to leave and 
      release the file for its successful deletion.
      
      We shall watch over the two tests as regression is not excluded.
      In that case we would have an extra info possibly explaining why
      __NT__ env can not close/delete the file.
      However, regardless of that reason, there is alwasy workaround to mask out
      non-deterministic binlog index number.
      
      
      
      mysql-test/extra/rpl_tests/rpl_truncate_helper.test:
        enable warnings for other than DROP queries;
        wait for slave's full stop which ensures io thread left and that
        will be regarded by dump thread to leave and close the binlog file;
        relocating reset master to the end of the test so that the caller of
        this helper should start with the binlog name which has not yet been
        affected/reset since its creation.
      mysql-test/suite/rpl/r/rpl_truncate_2myisam.result:
        results changed
      mysql-test/suite/rpl/r/rpl_truncate_3innodb.result:
        results changed
      b504eae7
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-rpl · def77da1
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.1-rpl
      
      def77da1
  4. 31 Oct, 2007 3 commits
    • unknown's avatar
      rpl_extraSlave_Col.test: · 3f81710e
      unknown authored
        Corrected issues found in preparing to push code
      
      
      mysql-test/extra/rpl_tests/rpl_extraSlave_Col.test:
        Corrected issues found in preparing to push code
      3f81710e
    • unknown's avatar
      Merge jmiller@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · 8bf11e74
      unknown authored
      into  mysql.com:/usr/clones/rpl-push
      
      8bf11e74
    • unknown's avatar
      bug#27571 merging. Fixing offsets and moving tests to the corrent · 323ded6e
      unknown authored
      destination. Removing wrong (local temp) tests.
      
      
      mysql-test/suite/binlog/t/binlog_killed_simulate-master.opt:
        Rename: mysql-test/t/binlog_killed_simulate-master.opt -> mysql-test/suite/binlog/t/binlog_killed_simulate-master.opt
      BitKeeper/deleted/.del-binlog_killed_bug27571.test:
        Delete: mysql-test/t/binlog_killed_bug27571.test
      BitKeeper/deleted/.del-binlog_killed_bug27571-master.opt:
        Delete: mysql-test/t/binlog_killed_bug27571-master.opt
      mysql-test/suite/binlog/r/binlog_killed.result:
        results changed
      mysql-test/suite/binlog/t/binlog_killed.test:
        binlog offset made 5.1 specific
      mysql-test/suite/binlog/t/binlog_killed_simulate.test:
        binlog offset + guard to run the test with stmt/mixed format
      mysql-test/suite/binlog/r/binlog_killed_simulate.result:
        new results file
      323ded6e
  5. 30 Oct, 2007 7 commits
    • unknown's avatar
      Merge mysql.com:/usr/clones/mysql-5.1-new-rpl · b6b37b8f
      unknown authored
      into  mysql.com:/usr/clones/rpl-push
      
      
      mysql-test/extra/rpl_tests/rpl_extraSlave_Col.test:
        Auto merged
      mysql-test/suite/rpl/r/rpl_extraCol_innodb.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_extraCol_myisam.result:
        Auto merged
      mysql-test/suite/rpl_ndb/r/rpl_ndb_extraCol.result:
        Auto merged
      b6b37b8f
    • unknown's avatar
      manual merge · 89bf4e14
      unknown authored
      
      BitKeeper/deleted/.del-rpl_slave_skip-slave.opt:
        Delete: mysql-test/t/rpl_slave_skip-slave.opt
      BitKeeper/deleted/.del-rpl_slave_skip.test:
        Delete: mysql-test/t/rpl_slave_skip.test
      BitKeeper/deleted/.del-rpl_slave_skip.result:
        Delete: mysql-test/r/rpl_slave_skip.result
      89bf4e14
    • unknown's avatar
      Manual merge 5.0-rpl -> 5.1-rpl. · 0ce3426d
      unknown authored
      involved bug#12691, bug#27571
      
      
      mysql-test/suite/rpl/r/rpl_sp_effects.result:
        results changed
      sql/slave.cc:
        pended manual merge done (mats)
      sql/sql_delete.cc:
        manual merge
      sql/sql_insert.cc:
        manual merge
      sql/sql_load.cc:
        manual merge
      sql/sql_update.cc:
        manual merge.
      0ce3426d
    • unknown's avatar
      Merge koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.0/bug27571_asyn_killed_flags · c73c1812
      unknown authored
      into  koti.dsl.inet.fi:/home/elkin/MySQL/5.1-merge-bug27571
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/suite/binlog/r/binlog_killed.result:
        Auto merged
      mysql-test/suite/binlog/t/binlog_killed.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      strings/ctype-euc_kr.c:
        Auto merged
      mysql-test/suite/rpl/r/rpl_sp_effects.result:
        manual merge ul
      mysql-test/suite/rpl/t/rpl_sp_effects.test:
        manual merge
      sql/slave.cc:
        leaving for manual merge
      sql/sql_delete.cc:
        leaving for manual merge
      sql/sql_insert.cc:
        leaving for manual merge
      sql/sql_load.cc:
        leaving for manual merge
      sql/sql_update.cc:
        leaving for manual merge
      c73c1812
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · c52e7706
      unknown authored
      into  koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.0/bug27571_asyn_killed_flags
      
      c52e7706
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-5.0 · f4f21f73
      unknown authored
      into  mysql.com:/home/bar/mysql-work/mysql-5.0-rpl-merge
      
      
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/func_regexp.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      mysql-test/t/func_regexp.test:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        After merge fix
      mysql-test/t/ctype_ucs.test:
        After merge fix
      f4f21f73
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-5.1 · f0470aa2
      unknown authored
      into  mysql.com:/home/bar/mysql-work/mysql-5.1-new-rpl-merge
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/r/func_regexp.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_bug31076.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      mysql-test/t/func_regexp.test:
        Auto merged
      mysql-test/t/partition.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_xmlfunc.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log.h:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_repl.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      strings/ctype-euc_kr.c:
        Auto merged
      sql/sql_yacc.yy:
        Reverting Rafal's changes: TRANSACTIONAL_SYM was removed in a mistake.
      mysql-test/r/ctype_ucs.result:
        After merge fix
      mysql-test/suite/rpl/t/rpl_bug31076.test:
        After merge fix.
      mysql-test/t/ctype_ucs.test:
        After megre fix
      f0470aa2
  6. 29 Oct, 2007 2 commits
    • unknown's avatar
      Bug #27571 asynchronousity in setting mysql_`query`::error and · cfa56c2f
      unknown authored
                 Query_log_event::error_code
      
      A query can perform completely having the local var error of mysql_$query
      zero, where $query in insert, update, delete, load,
      and be  binlogged with error_code e.g KILLED_QUERY while there is no
      reason do to so.
      That can happen because Query_log_event consults thd->killed flag to
      evaluate error_code.
      
      Fixed with implementing a scheme suggested and partly implemented at
      time of bug@22725 work-on. error_status is cached immediatly after the
      control leaves the main rows-loop and that instance always corresponds
      to `error' the local of mysql_$query functions. The cached value
      is passed to Query_log_event constructor, not the default thd->killed
      which can be changed in between of the caching and the constructing.
      
      
      mysql-test/r/binlog_killed.result:
        results changed
      mysql-test/t/binlog_killed.test:
        Demonstrating that effective killing during rows-loop execution leads to the speficied actions:
        binlogging with the error for a query modified a not-transactional table or
        rolling back effects for transactional table;
        
        fixing possible non-determinism with ID when query_log_enabled;
        
        leave commented out tests for multi-update,delete due to another bug;
        
        removing an obsolete tests template;
        
        changing system rm to --remove_file.
      sql/log_event.cc:
        adding killed status arg
      sql/log_event.h:
        added killed status arg
      sql/sql_delete.cc:
        deploying the update part patch for delete, multi-delete
      sql/sql_insert.cc:
        deploying the update-part patch for insert..select
      sql/sql_load.cc:
        deploying the update-part patch for load data.
        simulation added.
      sql/sql_update.cc:
        Impementing the fix as described in the comments left by bug@22725.
        Also simulation of killing after the loop that would affect binlogging in the old code.
      mysql-test/t/binlog_killed_bug27571-master.opt:
        post rows-loop killing simulation's options
      mysql-test/t/binlog_killed_bug27571.test:
        Checking that if killing happens inbetween of the end of rows loop and
        recording into binlog that will not lead to recording any error incl
        the killed error.
      mysql-test/t/binlog_killed_simulate-master.opt:
        simulation options
      mysql-test/t/binlog_killed_simulate.test:
        tests for 
        a query (update is choosen) being killed after the row-loop;
        load data killed within the loop - effective killed error in the event is gained.
      cfa56c2f
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1 · 2a934d94
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      2a934d94
  7. 26 Oct, 2007 3 commits
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.0-rpl · 5cb39eea
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b12691-mysql-5.0-rpl
      
      
      sql/slave.cc:
        Auto merged
      5cb39eea
    • unknown's avatar
      BUG#12691 (Exec_master_log_pos corrupted with SQL_SLAVE_SKIP_COUNTER): · 193c3b0d
      unknown authored
        
      Adding code to keep skipping events while inside a transaction. Execution
      will start just after the transaction has been skipped.
      
      
      sql/slave.cc:
        Adding code to set the thd->options flag for the slave SQL thread
        even when BEGIN, ROLLBACK, COMMIT, and XID events are being skipped.
            
        Adding code to not decrease the slave skip counter from 1 to 0 if we
        are inside a transaction. This will keep the counter at 1, and keep
        skipping events, until a transaction terminator is read. At that point,
        the slave skip counter will be decreased to 0, and events will be read
        and executed instead of read and skipped.
      mysql-test/r/rpl_slave_skip.result:
        New BitKeeper file ``mysql-test/r/rpl_slave_skip.result''
      mysql-test/t/rpl_slave_skip-slave.opt:
        New BitKeeper file ``mysql-test/t/rpl_slave_skip-slave.opt''
      mysql-test/t/rpl_slave_skip.test:
        New BitKeeper file ``mysql-test/t/rpl_slave_skip.test''
      193c3b0d
    • unknown's avatar
      Bug#28772 rpl_row_until fails in pushbuild · 54afeecb
      unknown authored
      
      mysql-test/suite/rpl/t/rpl_row_until.test:
           - Add a "wait_for_slave_to_stop.inc" after the two "stop slave"
             commands after wich we want to show the slaves status
      mysql-test/suite/rpl/t/rpl_stm_until.test:
           - Add a "wait_for_slave_to_stop.inc" after the two "stop slave"
             commands after wich we want to show the slaves status
      54afeecb
  8. 25 Oct, 2007 3 commits
    • unknown's avatar
      Merge aelkin@bk-internal.mysql.com:/home/bk/mysql-5.1-rpl · a9325db8
      unknown authored
      into  koti.dsl.inet.fi:/home/elkin/MySQL/TEAM/FIXES/5.1/bug30594-rpl.rpl_skip_error_is_nondeterministic
      
      a9325db8
    • unknown's avatar
      Mimic a rename which Daniel already did in 6.0, · 3e6acc9a
      unknown authored
      to get rid of a name clash among *deleted* files on case-insignificant file systems.
      
      
      BitKeeper/deleted/.del-changelog-bleh:
        Rename: BitKeeper/deleted/.del-changelog -> BitKeeper/deleted/.del-changelog-bleh
      3e6acc9a
    • unknown's avatar
      WL#4078: Document binary format of binlog entries · f5084038
      unknown authored
      Documented some binlog events using doxygen. More will be done later.
      Also fixed typos in other comments and added remarks about dubious code.
      Only comments are affected, there is no change to the actual code.
      
      
      sql/log_event.cc:
        Fixed typos in some comments.
        Added remarks (as comments) about questionable code.
      sql/log_event.h:
        Documented the binary format of following binlog events:
        Log_event
        Query_log_event
        Muted_query_log_event
        Slave_log_event (partial)
        Load_log_event
        Intvar_log_event
        Rand_log_event
        Rotate_log_event (partial)
      sql/sql_class.h:
        Fixed typo in comment.
      f5084038
  9. 24 Oct, 2007 6 commits
    • unknown's avatar
      Merge kindahl-laptop.dnsalias.net:/home/bkroot/mysql-5.1-rpl · f41ec6ec
      unknown authored
      into  kindahl-laptop.dnsalias.net:/home/bk/b24860-mysql-5.1-rpl
      
      
      sql/log_event.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      sql/slave.cc:
        Auto merged
      f41ec6ec
    • unknown's avatar
      BUG#31702 (Missing row on slave causes assertion failure under row-based · 732b89c0
      unknown authored
      replication):
      
      Incremental patch to enable idempotency support for update events again.
      The final handling of errors will be done in BUG#31609, and until then
      the handling of errors should be consistent between the different types
      of changes.
      
      
      mysql-test/suite/rpl/r/rpl_row_basic_11bugs.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_temporary_errors.result:
        Result change.
      mysql-test/suite/rpl/t/rpl_row_basic_11bugs.test:
        Changing test to assume idempotency handling of update event.
      mysql-test/suite/rpl/t/rpl_temporary_errors.test:
        Changing test to assume idempotency handling of update event.
      sql/log_event.cc:
        Incremental patch to enable idempotency support for the update events again.
        The real error handling will be implemented in BUG#31609.
      732b89c0
    • unknown's avatar
      result fix · 611a8972
      unknown authored
      611a8972
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · db1dc9d8
      unknown authored
      into  mysql.com:/home/bar/mysql-work/mysql-5.0.b31081
      
      db1dc9d8
    • unknown's avatar
      Bug#31081 server crash in regexp function · d22bb713
      unknown authored
      Additional fix for valgrind warning
      
      d22bb713
    • unknown's avatar
      Merge mysql.com:/home/bar/mysql-work/mysql-5.0 · 84571cdd
      unknown authored
      into  mysql.com:/home/bar/mysql-work/mysql-5.0-rpl-mr
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/ctype_euckr.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      strings/ctype-euc_kr.c:
        Auto merged
      84571cdd