1. 15 Mar, 2022 1 commit
  2. 14 Mar, 2022 2 commits
  3. 12 Mar, 2022 1 commit
  4. 11 Mar, 2022 4 commits
  5. 10 Mar, 2022 4 commits
    • Marko Mäkelä's avatar
      77c184df
    • Vlad Lesin's avatar
      MDEV-19577 Replication does not work with innodb_autoinc_lock_mode=2 · 1766a18e
      Vlad Lesin authored
      The first step for deprecating innodb_autoinc_lock_mode(see MDEV-27844) is:
      - to switch statement binlog format to ROW if binlog format is MIXED and
      the statement changes autoincremented fields
      - issue warnings if innodb_autoinc_lock_mode == 2 and binlog format is
      STATEMENT
      1766a18e
    • Andrei's avatar
      MDEV-24617 OPTIMIZE on a sequence causes unexpected ER_BINLOG_UNSAFE_STATEMENT · e7cf871d
      Andrei authored
      The warning out of OPTIMIZE
        Statement is unsafe because it uses a system function
      was indeed counterfactual and was resulted by checking an
      insufficiently strict property of lex' sql_command_flags.
      
      Fixed with deploying an additional checking of weather
      the current sql command that modifes a share->non_determinstic_insert
      table is capable of generating ROW format events.
      The extra check rules out the unsafety to OPTIMIZE et al, while the
      existing check continues to do so to CREATE TABLE (which is
      perculiarly tagged as ROW-event generative sql command).
      
      As a side effect sql_sequence.binlog test gets corrected and
      binlog_stm_unsafe_warning.test is reinforced to add up
      an unsafe CREATE..SELECT test.
      e7cf871d
    • Daniel Black's avatar
      MDEV-28022: Debian stretch has zstd too old · 8ea08505
      Daniel Black authored
      zstd-1.1.3 is needed however stretch has only 1.1.2.
      
      Move to distro version based checks as checks against the
      apt-cache are unreliable if there is no cache.
      8ea08505
  6. 07 Mar, 2022 3 commits
  7. 04 Mar, 2022 3 commits
  8. 03 Mar, 2022 2 commits
  9. 01 Mar, 2022 4 commits
  10. 28 Feb, 2022 3 commits
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 3c58cdd9
      Marko Mäkelä authored
      3c58cdd9
    • Marko Mäkelä's avatar
      MDEV-27800: Avoid garbage TRX_UNDO_TRX_NO on TRX_UNDO_CACHED pages · 0635088d
      Marko Mäkelä authored
      In commit c7d04487 (MDEV-15132)
      MariaDB Server 10.3 stopped writing the latest transaction identifier
      to the TRX_SYS page. Instead, the transaction identifier will be
      recovered from undo log pages.
      
      Unfortunately, before commit 3926673c
      and mysql/mysql-server@dc29792ff2996aefbb6e64bb2f0bc3aa8fc879e9
      (MySQL 5.1.48 or MariaDB 5.1.48) InnoDB did not always initialize all
      data fields, but some garbage could be left behind in unused parts
      of data pages.
      
      In undo log pages that are essentially free, but added to a list for
      reuse (TRX_UNDO_CACHED) the TRX_UNDO_TRX_NO fields could contain garbage,
      instead of 0. As long as such undo pages are being reused and never
      marked completely free, the garbage contents may remain forever.
      In fact, the function trx_undo_header_create() and the record
      MLOG_UNDO_HDR_CREATE will only initialize TRX_UNDO_TRX_ID, but leave
      TRX_UNDO_TRX_NO uninitialized.
      
      trx_undo_mem_create_at_db_start(): Only read the TRX_UNDO_TRX_NO
      fields of TRX_UNDO_CACHED pages if the TRX_UNDO_PAGE_TYPE is 0,
      that is, the page was updated by MariaDB Server 10.3. Earlier versions
      would always write the TRX_UNDO_PAGE_TYPE as 1 or 2.
      
      trx_undo_header_create(): Zero out the TRX_UNDO_TRX_NO field.
      Strictly speaking, this will change the semantics of the
      MLOG_UNDO_HDR_CREATE record, but it should not do any harm to
      overwrite a potentially garbage field with zeroes.
      
      Note: This fix will only help future upgrades straight from
      MariaDB Server 10.2 or MySQL 5.6 or earlier. If such an upgrade has
      already been made, then an earlier server startup could have
      fast-forwarded the transaction ID sequence to a large value.
      If this large value cannot be represented in 48 bits (the size of
      the DB_TRX_ID column in clustered index records), then various
      strange things can happen.
      0635088d
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · 535bef86
      Marko Mäkelä authored
      535bef86
  11. 25 Feb, 2022 7 commits
  12. 24 Feb, 2022 1 commit
  13. 23 Feb, 2022 4 commits
    • Julius Goryavsky's avatar
      MDEV-26377: Stricter validation of ssl-mode values · a3da3c8a
      Julius Goryavsky authored
      This commit adds validation of the values of the ssl-mode parameter
      in SSL scripts, since now only a basic check for the presence of the
      "VERIFY_" prefix is performed there to detect "VERIFY_IDENTITY" and
      "VERIFY_CA", but all other values are not checked at all.
      
      In addition, this commit removes leading and trailing spaces from
      parameter values that SST scripts read from configuration files or
      from the command line so that they do not interfere with parameter
      checks and substitutions. Parameter substitution has been made more
      robust against characters in strings that the shell might erroneously
      interpret as regexp.
      a3da3c8a
    • Marko Mäkelä's avatar
      MDEV-27798 SIGSEGV in dict_index_t::reconstruct_fields() · 46764652
      Marko Mäkelä authored
      When recovery is rolling back an incomplete instant DROP COLUMN
      operation, it may access non-existing fields. Let us avoid
      invoking std::find_if() outside the valid bounds of the array.
      
      This bug was reproduced with the Random Query Generator, using a
      combination of instant DROP, ADD...FIRST, CHANGE (renaming a column).
      Unfortunately, we were unable to create an mtr test case for
      reproducing this, despite spending considerable effort on it.
      46764652
    • Marko Mäkelä's avatar
      WSREP: Fix GCC 12.0.1 -Wuninitialized · 0b849a44
      Marko Mäkelä authored
      GCC 12 complains if a reference to an uninitialized object is
      being passed to a constructor. The mysql_mutex_t, mysql_cond_t
      would be initialized in the constructor body, which is executed
      after the initializer list. There is no problem passing a pointer
      instead of a reference. The wrapper classes do not dereference
      the pointers in the constructor or destructor, so there does not
      appear to be any correctness issue.
      0b849a44
    • Marko Mäkelä's avatar
      MDEV-23888 fixup: GCC 12 -Wunused-value · 8b7abe21
      Marko Mäkelä authored
      8b7abe21
  14. 22 Feb, 2022 1 commit