1. 09 Oct, 2006 2 commits
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/bug17583/my41-bug17583 · 9c86b860
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/bug17583/my50-bug17583
      
      
      BitKeeper/deleted/.del-collapsed~fbec3523369aae99:
        Delete: BitKeeper/etc/collapsed
      BitKeeper/etc/collapsed:
        'Auto converge'
      client/mysql.cc:
        Auto merged
      BitKeeper/deleted/.del-mysql_client.result:
        File is gone.
      BitKeeper/deleted/.del-mysql_client.test:
        File is gone.
      9c86b860
    • unknown's avatar
      Bug#17583: mysql drops connection when stdout is not writable · 8af12677
      unknown authored
      When the client program had its stdout file descriptor closed by the calling
      shell, after some amount of work (enough to fill a socket buffer) the server 
      would complain about a packet error and then disconnect the client.
      
      This is a serious security problem.  If stdout is closed before the mysql is
      exec()d, then the first socket() call allocates file number 1 to communicate
      with the server.  Subsequent write()s to that file number (as when printing
      results that come back from the database) go back to the server instead in 
      the command channel.  So, one should be able to craft data which, upon being
      selected back from the server to the client, and injected into the command
      stream become valid MySQL protocol to do something nasty when sent /back/ to 
      the server.
      
      The solution is to close explicitly the file descriptor that we *printf() to, 
      so that the libc layer and the OS layer both agree that the file is closed.
      
      
      BitKeeper/etc/collapsed:
        BitKeeper file /home/cmiller/work/mysql/bug17583/my41-bug17583/BitKeeper/etc/collapsed
      client/mysql.cc:
        If standard output is not open (specifically, if dup() of its file number 
        fails) then we explicitly close it so that future uses of the file descriptor
        behave correctly for a closed file.
      mysql-test/r/mysql_client.result:
        Prove that the problem of writing SQL output to the command socket no longer
        exists.
      mysql-test/t/mysql_client.test:
        Prove that the problem of writing SQL output to the command socket no longer
        exists.
      8af12677
  2. 03 Oct, 2006 2 commits
    • unknown's avatar
      Merge mysql.com:/usr/home/bar/mysql-4.1-rpl.b8663 · 9207c4d8
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-5.0-rpl
      
      
      mysql-test/r/cast.result:
        null merge for bug#8663
        It will beed another fix for 5.0
        - changes in new DECIMAL instead of FLOAT
      mysql-test/r/ps.result:
        null merge
      mysql-test/t/cast.test:
        null merge
      mysql-test/t/count_distinct3.test:
        null merge
      sql/item_func.cc:
        null merge
      9207c4d8
    • unknown's avatar
      Merge mysql.com:/usr/home/bar/mysql-4.1.b8663 · f097517d
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-4.1-rpl
      
      
      mysql-test/r/cast.result:
        Auto merged
      mysql-test/r/ps.result:
        Auto merged
      sql/item_func.cc:
        Auto merged
      f097517d
  3. 02 Oct, 2006 2 commits
  4. 29 Sep, 2006 4 commits
    • unknown's avatar
      Merge mysql.com:/usr/home/bar/mysql-5.0.b6147v2 · cc56bce6
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-5.0.b6147rpl
      
      
      mysql-test/r/ps_2myisam.result:
        Auto merged
      mysql-test/r/ps_3innodb.result:
        Auto merged
      mysql-test/r/ps_4heap.result:
        Auto merged
      mysql-test/r/ps_5merge.result:
        Auto merged
      mysql-test/r/ps_6bdb.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/r/strict.result:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/r/warnings.result:
        Auto merged
      mysql-test/t/strict.test:
        Auto merged
      sql/field.cc:
        Auto merged
      cc56bce6
    • unknown's avatar
      Bug#21263 mysql client XML output does not distinguish between NULL and string 'NULL' · 18a2a02b
      unknown authored
        
        Fix: "mysql --xml" now print NULL values the same way that "mysqldump --xml" does:
        
          <field name="name" xsi:nil="true" />
        
        to distinguish from empty strings:
        
          <field name="name"></field>
        
        and from string "NULL":
        
          <field name="name">NULL</field>
      
      
      client/mysql.cc:
        Fixing to print NULLs differently from empty strings
      mysql-test/r/client_xml.result:
        Fixing test result accordingly
      18a2a02b
    • unknown's avatar
      Bug#21620 ALTER TABLE affects other columns · f4f7f5bf
      unknown authored
        Problem: for character sets having mbmaxlen==2,
        any ALTER TABLE changed TEXT column type to MEDIUMTEXT,
        due to wrong "internal length to create length" formula.
        Fix: removing rounding code introduced in early 4.1 time,
        which is not correct anymore.
      
      
      mysql-test/r/ctype_gbk.result:
        Adding test case
      mysql-test/t/ctype_gbk.test:
        Adding test case
      sql/field.cc:
        Fixing "internal length to create length" formula.
      f4f7f5bf
    • unknown's avatar
      Bug#19960 Inconsistent results when joining InnoDB tables using partial UTF8 indexes · 2cbc2e9d
      unknown authored
        Adding a multibyte-aware VARCHAR copying function, to put correct column prefix,
        taking in account number of characters (instead just limiting on number of bytes).
        For example, for a KEY(col(3)) on a UTF8 column when copying the string 'foo bar foo',
        we should put only 3 leftmost characters: 'foo'.
        9 characters were incorrectly put before this fix.
      
      
      mysql-test/r/ctype_utf8.result:
        Adding test case
      mysql-test/t/ctype_utf8.test:
        Adding test case
      sql/field_conv.cc:
        Adding multibyte aware copy function for VARCHAR
      2cbc2e9d
  5. 28 Sep, 2006 6 commits
    • unknown's avatar
      view.test: · 669d8a6f
      unknown authored
        After merge fix
      
      
      mysql-test/t/view.test:
        After merge fix
      669d8a6f
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 024f93c5
      unknown authored
      into  moonbone.local:/work/5505-bug-5.0-opt-mysql
      
      
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      mysql-test/r/view.result:
        Manual merge
      mysql-test/t/view.test:
        Manual merge
      024f93c5
    • unknown's avatar
      Fixed bug#5505: Wrong error message on INSERT into a view · 9cf17a35
      unknown authored
      On an INSERT into an updatable but non-insertable view an error message was
      issued stating the view being not updatable. This can lead to a confusion of a
      user.
      
      A new error message is introduced. Is is showed when a user tries to insert
      into a non-insertable view.
      
      
      sql/sql_base.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        The update_non_unique_table_error() function now issues proper
        error for an INSERT.
      sql/sql_insert.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Issue the ER_NON_INSERTABLE_TABLE error instead of the 
        ER_NON_UPDATABLE_TABLE on insert into a view.
      sql/sql_view.cc:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Issue the ER_NON_INSERTABLE_TABLE error instead of the
        ER_NON_UPDATABLE_TABLE on insert into a view.
      mysql-test/r/view.result:
        Added the test case for bug#5505: Wrong error message on INSERT into a view
        Corrected a few test cases after fixing bug#5505
      mysql-test/t/view.test:
        Added the test case for bug#5505: Wrong error message on INSERT into a view
        Corrected a few test cases after fixing bug#5505
      sql/share/errmsg.txt:
        Fixed bug#5505: Wrong error message on INSERT into a view
        Added the ER_NON_INSERTABLE_TABLE error definition.
      9cf17a35
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt · 1b744c77
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      1b744c77
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-5.0 · 757c5dcf
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-5.0-opt
      
      
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      757c5dcf
    • unknown's avatar
      Merge dl145s.mysql.com:/data/bk/team_tree_merge/mysql-4.1 · e2452943
      unknown authored
      into  dl145s.mysql.com:/data/bk/team_tree_merge/MERGE/mysql-4.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      e2452943
  6. 27 Sep, 2006 7 commits
  7. 26 Sep, 2006 1 commit
    • unknown's avatar
      Merge trift2.:/MySQL/M50/clone-5.0 · 67fc6bc8
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      
      mysql-test/r/func_time.result:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/r/type_date.result:
        Auto merged
      mysql-test/r/view.result:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/t/func_time.test:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      mysql-test/t/type_date.test:
        Auto merged
      mysql-test/t/view.test:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      sql/item_cmpfunc.cc:
        Null-merge, the change in the 5.0 general tree supersedes the 5.0.25 patch.
      67fc6bc8
  8. 25 Sep, 2006 7 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0-opt · 1c17642e
      unknown authored
      into  rurik.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug21646
      
      1c17642e
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-4.1-opt · 5b30853d
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/subselect.result:
        Manual merge
      mysql-test/t/subselect.test:
        Manual merge
      sql/item.cc:
        Manual merge
      5b30853d
    • unknown's avatar
      Fixed bug #21646. · fe2edf6d
      unknown authored
      Presence of a subquery in the ON expression of a join 
      should not block merging the view that contains this join.
      Before this patch the such views were converted into 
      into temporary table views.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #21646.
      mysql-test/t/view.test:
        Added a test case for bug #21646.
      sql/mysql_priv.h:
        Fixed bug #21646.
        Added a new parsing state 'IN_ON', true when
        the parser is in an ON expression of a join.
      sql/sql_lex.cc:
        Fixed bug #21646.
        Presence of a subquery in the ON expression of a join 
        should not block merging the view that contains this join.
      sql/sql_yacc.yy:
        Fixed bug #21646.
        Added a new parsing state 'IN_ON', true when
        the parser is in an ON expression of a join.
      fe2edf6d
    • unknown's avatar
      Fixed bug #21853: assert failure for a grouping query with · c492b149
      unknown authored
      an ALL/ANY quantified subquery in HAVING.
      The Item::split_sum_func2 method should not create Item_ref
      for objects of any class derived from Item_subselect.
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #21853.
      mysql-test/t/subselect.test:
        Added a test case for bug #21853.
      c492b149
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.15428 · b91735a6
      unknown authored
      into  mysql.com:/home/hf/work/mysql-5.0-mrg
      
      
      myisam/mi_check.c:
        Auto merged
      mysys/my_chsize.c:
        Auto merged
      b91735a6
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.12991 · adb7fc9b
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.15428
      
      
      myisam/mi_check.c:
        Auto merged
      adb7fc9b
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1-opt · 2833ae45
      unknown authored
      into  mysql.com:/home/hf/work/mysql-4.1.15428
      
      2833ae45
  9. 24 Sep, 2006 2 commits
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1 · df168380
      unknown authored
      into  mysql.com:/Users/kent/mysql/bk/mysql-5.0
      
      df168380
    • unknown's avatar
      mysql_config.sh: · 30109dc0
      unknown authored
        Filter out plain -O and Sun C/C++ style optimization flags, -xO<level>
        Filter out icc specific options from cflags/libs(_r)
      
      
      scripts/mysql_config.sh:
        Filter out plain -O and Sun C/C++ style optimization flags, -xO<level>
      30109dc0
  10. 23 Sep, 2006 5 commits
  11. 22 Sep, 2006 2 commits
    • unknown's avatar
      Fix for bug #19121: Windows incompatible udf_example · 3e85b24c
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        fixed path for udf_example.so when running testsuite on Windows
      sql/CMakeLists.txt:
        Added missing udf_example
      sql/Makefile.am:
        Added udf_example files for make dist
      sql/udf_example.c:
        fix for Windows: Windows doesn't have socket.h and friends
        
        Added replacements for strmov,bzero and memcpy_fixed when compiling standalone.
      sql/udf_example.def:
        BitKeeper file /home/georg/work/mysql/prod/mysql-5.0-win/sql/udf_example.def
      3e85b24c
    • unknown's avatar
      Added build rule for mysql_upgrade.exe · fa16278b
      unknown authored
      fa16278b