1. 18 Sep, 2009 1 commit
  2. 17 Sep, 2009 4 commits
  3. 16 Sep, 2009 5 commits
  4. 15 Sep, 2009 2 commits
  5. 13 Sep, 2009 2 commits
    • Luis Soares's avatar
      BUG#47016: rpl_do_grant fails on PB-2 with a failing connect · 63a81c09
      Luis Soares authored
            
      The test case rpl_do_grant fails sporadically on PB2 with "Access
      denied for user 'create_rout_db'@'localhost' ...". Inspecting the
      test case, one may find that if issues a GRANT on the master
      connection and immediately after it creates two new connections
      (one to the master and one to the slave) using the credentials
      set with the GRANT.
            
      Unfortunately, there is no synchronization between master and
      slave after the grant and before the connections are
      established. This can result in slave not having executed the
      GRANT by the time the connection is attempted.
            
      This patch fixes this by deploying a sync_slave_with_master
      between the grant and the connections attempt.
      63a81c09
    • Luis Soares's avatar
      BUG#47014: rpl_drop_temp fails on PB-2 with results mismatch · 3c916057
      Luis Soares authored
            
      The test case creates two temporary tables, then closes the
      connection, waits for it to disconnect, then syncs the slave with
      the master, checks for remaining opened temporary tables on
      slave (which should be 0) and finally drops the used
      database (mysqltest).
            
      Unfortunately, sometimes, the test fails with one open table on
      the slave. This seems to be caused by the fact that waiting for
      the connection to be closed is not sufficient. The test needs to
      wait for the DROP event to be logged and only then synchronize
      the slave with the master and proceed with the check. This is
      caused by the asynchronous nature of the disconnect wrt
      binlogging of the DROP temporary table statement.
            
      We fix this by deploying a call to wait_for_binlog_event.inc
      on the test case, which makes execution to wait for the DROP
      temp tables event before synchronizing master and slave.
      3c916057
  6. 11 Sep, 2009 3 commits
    • Mattias Jonsson's avatar
      merge · 23dc8abe
      Mattias Jonsson authored
      23dc8abe
    • Ramil Kalimullin's avatar
      Fix for bug#47130: misplaced or redundant check for null pointer? · b6c16b32
      Ramil Kalimullin authored
      Problem: LOGGER::general_log_write() relied on valid "thd" parameter passed
      but had inconsistent "if (thd)" check.
      
      Fix: as we always pass a valid "thd" parameter to the method, 
      redundant check removed.
      
      
      sql/log.cc:
        Fix for bug#47130: misplaced or redundant check for null pointer?
          - code clean-up, as we rely on the "thd" parameter in the
        LOGGER::general_log_write(), redundant "if (thd)" check removed, 
        added assert(thd) instead.
      b6c16b32
    • Marc Alff's avatar
      Post merge fixes · ea0d4516
      Marc Alff authored
      ea0d4516
  7. 10 Sep, 2009 12 commits
    • Alexander Nozdrin's avatar
    • Sergey Glukhov's avatar
      5.0-bugteam->5.1-bugteam merge · 0412a7c7
      Sergey Glukhov authored
      0412a7c7
    • Sergey Glukhov's avatar
      Bug#46815 CONCAT_WS returning wrong data · 10406ae6
      Sergey Glukhov authored
      The problem is that argument buffer can be used as result buffer
      and it leads to argument value change.
      The fix is to use 'old buffer' as result buffer only
      if first argument is not constant item.
      
      
      mysql-test/r/func_str.result:
        test result
      mysql-test/t/func_str.test:
        test case
      sql/item_strfunc.cc:
        The problem is that argument buffer can be used as result buffer
        and it leads to argument value change.
        The fix is to use 'old buffer' as result buffer only
        if first argument is not constant item.
      10406ae6
    • unknown's avatar
      BUG#45999 Row based replication fails when auto_increment field = 0 · e436b886
      unknown authored
      In RBR, There is an inconsistency between slaves and master.
      When INSERT statement which includes an auto_increment field is executed,
      Store engine of master will check the value of the auto_increment field. 
      It will generate a sequence number and then replace the value, if its value is NULL or empty.
      if the field's value is 0, the store engine will do like encountering the NULL values 
      unless NO_AUTO_VALUE_ON_ZERO is set into SQL_MODE.
      In contrast, if the field's value is 0, Store engine of slave always generates a new sequence number 
      whether or not NO_AUTO_VALUE_ON_ZERO is set into SQL_MODE.
      
      SQL MODE of slave sql thread is always consistency with master's.
      Another variable is related to this bug.
      If generateing a sequence number is decided by the values of
      table->auto_increment_field_not_null and SQL_MODE(if includes MODE_NO_AUTO_VALUE_ON_ZERO)
      The table->auto_increment_is_not_null is FALSE, which causes this bug to appear. ..
      e436b886
    • Marc Alff's avatar
      WL#2110 (SIGNAL) · 63e56390
      Marc Alff authored
      WL#2265 (RESIGNAL)
      
      Manual merge of SIGNAL and RESIGNAL to mysql-trunk-signal,
      plus required dependencies.
      63e56390
    • Sergey Glukhov's avatar
      Bug#42364 SHOW ERRORS returns empty resultset after dropping non existent table · 104d9ce7
      Sergey Glukhov authored
      partial backport of bug43138 fix
      
      
      mysql-test/r/warnings.result:
        test result
      mysql-test/t/warnings.test:
        test case
      sql/sql_class.cc:
        partial backport of bug43138 fix
      sql/sql_class.h:
        partial backport of bug43138 fix
      sql/sql_table.cc:
        partial backport of bug43138 fix
      104d9ce7
    • Sergey Vojtovich's avatar
      Merge 5.1-bugteam -> 5.1-bugteam-local. · 6d3e743d
      Sergey Vojtovich authored
      6d3e743d
    • Alexander Nozdrin's avatar
      A patch for Bug#45118 (mysqld.exe crashed in debug mode · 70972926
      Alexander Nozdrin authored
      on Windows in dbug.c) -- part 2: a patch for the DBUG subsystem
      to detect misuse of DBUG_ENTER / DBUG_RETURN macros.
      5.1 version.
      70972926
    • Sergey Vojtovich's avatar
      Local merge. · 48ecd65c
      Sergey Vojtovich authored
      48ecd65c
    • Sergey Vojtovich's avatar
      Local merge. · eb7a3fc9
      Sergey Vojtovich authored
      eb7a3fc9
    • Sergey Vojtovich's avatar
      Local merge. · 32055c1c
      Sergey Vojtovich authored
      32055c1c
    • Sergey Vojtovich's avatar
      Local merge. · 4bb22b34
      Sergey Vojtovich authored
      4bb22b34
  8. 09 Sep, 2009 5 commits
    • Georgi Kodinov's avatar
      null merge of the 5.0 test cleanup · 0d7ee91c
      Georgi Kodinov authored
      0d7ee91c
    • Joerg Bruehe's avatar
      55eb4962
    • Sergey Vojtovich's avatar
      BUG#29203 - archive tables have weird values in show table status · 04ed3c9d
      Sergey Vojtovich authored
      Archive engine returns wrong values for average record length
      and max data length.
      
      With this fix they're calculated as following:
      - max data length is 2 ^ 63 where large files are supported
        and INT_MAX32 where this is not supported;
      - average record length is data length / records in data file.
      
      mysql-test/r/archive.result:
        A test case for BUG#29203.
      mysql-test/t/archive.test:
        A test case for BUG#29203.
      storage/archive/ha_archive.cc:
        Better estimation for average row length and maximal data
        file length.
      04ed3c9d
    • Sergey Vojtovich's avatar
      BUG#45638 - Create temporary table with engine innodb fails · 3228a2be
      Sergey Vojtovich authored
      Create temporary InnoDB table fails on case insensitive
      filesystems, when lower_case_table_names is 2 (e.g. OS X)
      and temporary directory path contains upper case letters.
      
      The problem was that tmpdir prefix was converted to lower
      case when table was created, but was passed as is when
      table was opened.
      
      Fixed by leaving tmpdir prefix part intact.
      
      mysql-test/r/lowercase_mixed_tmpdir_innodb.result:
        A test case for BUG#45638.
      mysql-test/t/lowercase_mixed_tmpdir_innodb-master.opt:
        A test case for BUG#45638.
      mysql-test/t/lowercase_mixed_tmpdir_innodb-master.sh:
        A test case for BUG#45638.
      mysql-test/t/lowercase_mixed_tmpdir_innodb.test:
        A test case for BUG#45638.
      sql/handler.cc:
        Fixed get_canonical_filename() to not lowercase filesystem
        path prefix for temporary tables.
      3228a2be
    • Georgi Kodinov's avatar
      Bug #45159 Part 1 : rejuvenate the jp test suite using normal run. · 24f103e3
      Georgi Kodinov authored
      Updates the results of all the out-dated test suites and adds 
      the special mysqltest command to enable innodb for the tests that need it.
      24f103e3
  9. 08 Sep, 2009 6 commits
    • Joerg Bruehe's avatar
      Make sure that variables which are (or may be) used · 36703050
      Joerg Bruehe authored
      in an ".opt" file are defined to some value (even
      if it is empty). Without this, a test suite run
      aborted on Windows for "embedded".
      
      This fix was applied dusing the build of 5.4.2-beta.
      
      
      mysql-test/mysql-test-run.pl:
        From the code (function "envsubst()"), it is obvious
        that any variable which is used in an ".opt" file needs
        to be defined.
        If the value is wrong, starting the server may fail -
        but if the variable is undefined, the whole test suite
        will abort.
        
        So variables which are used in an ".opt" file should
        always be defined to some value, even if it is blank.
        
        This fix may be overkill, I did not check in detail
        whether all these variables are really used in an ".opt"
        file - but some are.
      36703050
    • Joerg Bruehe's avatar
      The former "Instance Manager" (program "mysqlmanager") · eb26de23
      Joerg Bruehe authored
      is not being built in 5.4.2-beta,
      so it cannot be included in a RPM:
      Remove both the program and the man page from the spec file.
      
      This patch was applied during the build of 5.4.2-beta.
      eb26de23
    • Joerg Bruehe's avatar
      Some fixes to make 5.4.2-beta compile on the less common · deab1e9c
      Joerg Bruehe authored
      platforms like AIX, HP-UX, and Solaris 8.
      
      All these are upmerges from 5.1 which came too late to be
      included when 5.4.2-beta was cloned, so they were applied
      during the build phase.
      deab1e9c
    • Joerg Bruehe's avatar
      This is the 5.4 version of the fix for bug#47007 · 29d0fa12
      Joerg Bruehe authored
         Unresolved reference to 'innodb_system_libs' in "mysql_config"
      
      In 5.4.2, we use InnoDB 1.0.4 which does file IO via separate
      threads, opposed to the use of asynchronous IO previously.
      
      So there is no InnoDB call to "aio_read()" which was searched
      in "librt", causing a "-lrt" value of "innodb_system_libs",
      that whole variable is gone.
      
      This fix was applied in the build of 5.4.2-beta.
      
      scripts/Makefile.am:
        There is no "innodb_system_libs" variable any more,
        so it cannot be replaced by its value.
      scripts/mysql_config.pl.in:
        InnoDB does not need any platform-specific libraries any more,
        "innodb_system_libs" may go.
      scripts/mysql_config.sh:
        InnoDB does not need any platform-specific libraries any more,
        "innodb_system_libs" may go.
      29d0fa12
    • Georgi Kodinov's avatar
      automerge · 0ab24bef
      Georgi Kodinov authored
      0ab24bef
    • Alexey Kopytov's avatar
      Automerge. · 0a7e4186
      Alexey Kopytov authored
      0a7e4186