1. 28 Jul, 2021 2 commits
  2. 27 Jul, 2021 7 commits
    • Nikita Malyavin's avatar
      add const qualifiers to sys_var::value_ptr functions and fix const casts · 6ed47508
      Nikita Malyavin authored
      This is important since Sys_var_typelib and its descendants return
      pointers to constant symbols from *_value_ptr, which are situated in
      write-protected-memory.
      
      * functions const-qualified:
        - value_ptr
        - session_value_ptr
        - global_value_ptr
        - default_value_ptr
        - Sys_var_vers_asof::value_ptr
        - other minor private ones
      
      * remove C-style typecasts when it discards qualifiers
      6ed47508
    • Nikita Malyavin's avatar
      MDEV-16026 MDEV-16481 refactor Sys_var_vers_asof · c6bff469
      Nikita Malyavin authored
      MDEV-16026: Forbid global system_versioning_asof in non-default time zone
      
      * store `system_versioning_asof` in unix time;
      * both session and global vars are processed in session timezone;
      * setting `default` does not copy global variable anymore. Instead, it sets
        system_time to SYSTEM_TIME_UNSPECIFIED, which means that no 'AS OF' time
        is applied and `now()` can be assumed
      
      As a regression, we cannot assign values below 1970 (UTC) anymore
      
      MDEV-16481: set global system_versioning_asof=sf() crashes in specific case
      
      * sys_vars.h: add `MYSQL_TIME` field to `set_var::save_result`
      * sys_vars.ic: get rid of calling `var->value->get_date()` from
       `Sys_var_vers_asof::update()`
      * versioning.sysvars: add test; remove double warning
      
      refactor Sys_var_vers_asof
      
      * inherit from sys_var rather than Sys_var_enum
      * remove junk "DEFAULT" keyword. There is DEFAULT in SQL grammar for it.
      * make all conversions in check() to avoid possible errors
      * avoid double var->value evaluation, which could
        consequence in undefined behavior
      c6bff469
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · f50eb0d3
      Marko Mäkelä authored
      f50eb0d3
    • Marko Mäkelä's avatar
      MDEV-25998 fixup: Avoid a hang · afe00bb7
      Marko Mäkelä authored
      btr_scrub_start_space(): Avoid an unnecessary tablespace lookup
      and related acquisition of fil_system->mutex. In MariaDB Server 10.3
      we would get deadlocks between that mutex and a crypt_data mutex.
      
      The fix was developed by Thirunarayanan Balathandayuthapani.
      afe00bb7
    • Marko Mäkelä's avatar
      e11cae71
    • Marko Mäkelä's avatar
      MDEV-24393 InnoDB disregards --skip-external-locking · da094188
      Marko Mäkelä authored
      On POSIX systems, InnoDB would unconditionally acquire advisory locks
      on the files that it opens. On Linux, this would be observable by
      a large number of entries in /proc/locks.
      
      Other storage engines would only acquire advisory locks on files
      based on the Boolean configuration parameter external_locking.
      
      Let InnoDB do the same.
      
      NOTE: The --skip-external-locking is activated by default. To have
      InnoDB acquire advisory locks, --external-locking must be specified.
      
      Reviewed by: Sergei Golubchik
      da094188
    • Marko Mäkelä's avatar
      MDEV-25594: Improve debug checks · cf1fc598
      Marko Mäkelä authored
      trx_t::will_lock: Changed the type to bool.
      
      trx_t::is_autocommit_non_locking(): Replaces
      trx_is_autocommit_non_locking().
      
      trx_is_ac_nl_ro(): Remove (replaced with equivalent assertion expressions).
      
      assert_trx_nonlocking_or_in_list(): Remove.
      Replaced with at least as strict checks in each place.
      
      check_trx_state(): Moved to a static function; partially replaced with
      individual debug assertions implementing equivalent or stricter checks.
      
      This is a backport of commit 7b51d11c
      from 10.5.
      cf1fc598
  3. 26 Jul, 2021 5 commits
    • Jan Lindström's avatar
      MDEV-26062 : InnoDB: WSREP: referenced FK check fail: Lock wait index... · 0bd9f755
      Jan Lindström authored
      MDEV-26062 : InnoDB: WSREP: referenced FK check fail: Lock wait index `PRIMARY` table `schema`.`child_table`
      
      Problem was that not all normal error codes where not handled
      after wsrep_row_upd_check_foreign_constraints() call. Furhermore,
      debug assertion did not contain all normal error cases. Changed
      ib:: calls to WSREP_ calls to use wsrep instrumentation.
      0bd9f755
    • Sergei Golubchik's avatar
      dissapear -> disappear · 2575eaa5
      Sergei Golubchik authored
      2575eaa5
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-25998 InnoDB removes the tablespace from default encrypt list early · ce870b2a
      Thirunarayanan Balathandayuthapani authored
      Problem:
      =========
      As a part of MDEV-14398 patch, InnoDB added and removed
      the tablespace from default encrypt list. But InnoDB removes
      the tablespace from the default encrypt list too early due to
      i) other encryption thread working on the tablespace
      ii) When tablespace is being flushed at the end of
      key rotation
      
      InnoDB fails to decrypt/encrypt the tablespace since
      the tablespace removed too early and it leads to
      test case failure.
      
      Solution:
      =========
      Avoid the removal of tablespace from default_encrypt_list
      only when
      1) Another active encryption thread working on tablespace
      2) Eligible for tablespace key rotation
      3) Tablespace is in flushing phase
      
      Removed the workaround in encryption.innodb_encryption_filekeys test case.
      ce870b2a
    • Eugene Kosov's avatar
      0711a53a
    • Rucha Deodhar's avatar
      MDEV-23786: Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' · af0b26f9
      Rucha Deodhar authored
      failed for TokuDB engine CREATE TABLE
      
      Analysis: Assertion failure happens because the database doesn't exist to
      create the table but ha_tokudb::create() still returns false.
      So error is not reported.
      Fix: Store the error state and report the error.
      af0b26f9
  4. 25 Jul, 2021 1 commit
    • Nayuta Yanagisawa's avatar
      MDEV-24517 follow-up: Fix for test with --ps-protocol · f52d3936
      Nayuta Yanagisawa authored
      Tests for the Spider storage engine often use the following idiom:
      
      --let $command=CREATE TABLE t1 (...);CREATE TABLE t2 (...); ...
      --eval $command
      
      However, the idiom seems to work in the normal protocol, but fails
      in the prepared statement (ps) protocol.
      As testing CREATE TABLE statements in the ps protocol, we wrap the
      idiom by --disable_ps_protocol and --enable_ps_protocol.
      f52d3936
  5. 24 Jul, 2021 2 commits
  6. 23 Jul, 2021 5 commits
  7. 22 Jul, 2021 9 commits
  8. 21 Jul, 2021 5 commits
    • Sergei Golubchik's avatar
      Merge branch '10.2' into 10.3 · 6190a02f
      Sergei Golubchik authored
      6190a02f
    • Igor Babaev's avatar
      MDEV-26189 Missing handling of unknown column in WHERE of recursive CTE · 4aeb2b1c
      Igor Babaev authored
      SQL processor failed to catch references to unknown columns and other
      errors of the phase of semantic analysis in the specification of a
      hanging recursive CTE. This happened because the function
      With_clause::prepare_unreferenced_elements() failed to detect a CTE as
      a hanging CTE if the CTE was recursive.
      Fixing this problem in the code of the mentioned function opened another
      problem: EXPLAIN started including the lines for the specifications of
      hanging recursive CTEs in its output. This problem also was fixed in this
      patch.
      
      Approved by Dmitry Shulga <dmitry.shulga@mariadb.com>
      4aeb2b1c
    • Hollow Man's avatar
      Typo fixes in item_strfunc.cc · bd711d4f
      Hollow Man authored
      bd711d4f
    • Heinz Wiesinger's avatar
      Add feature summary at the end of cmake. · 751ebe44
      Heinz Wiesinger authored
      This gives a short overview over found/missing dependencies as well
      as enabled/disabled features.
      
      Initial author Heinz Wiesinger <heinz@m2mobi.com>
      Additions by Vicențiu Ciorbaru <vicentiu@mariadb.org>
      * Report all plugins enabled via MYSQL_ADD_PLUGIN
      * Simplify code. Eliminate duplication by making use of WITH_xxx
        variable values to set feature "ON" / "OFF" state.
      
      Reviewed by: wlad@mariadb.com (code details) serg@mariadb.com (the idea)
      751ebe44
    • Vicențiu Ciorbaru's avatar
      2b017367
  9. 20 Jul, 2021 4 commits
    • Igor Babaev's avatar
      MDEV-25565 Crash on 2-nd execution of SP/PS for query calculating window functions · 4c387945
      Igor Babaev authored
                 from view
      
      A crash of the server happened when executing a stored procedure whose the
      only query calculated window functions over a mergeable view specified
      as a select from non-mergeable view. The crash could be reproduced if
      the window specifications of the window functions were identical and both
      contained PARTITION lists and ORDER BY lists. A crash also happened on
      the second execution of the prepared statement created for such query.
      If to use derived tables or CTE instead of views the problem still
      manifests itself crashing the server.
      
      When optimizing the window specifications of a window function the
      server can substitute the partition lists and the order lists for
      the corresponding lists from another window specification in the case
      when the lists are identical. This substitution is not permanent and should
      be rolled back before the second execution. It was not done and this
      ultimately led to a crash when resolving the column names at the second
      execution of SP/PS.
      4c387945
    • Igor Babaev's avatar
      MDEV-26025 Server crashes while executing query with CTE in PS/SP · 872422dc
      Igor Babaev authored
      This bug appeared after the patch for bug MDEV-23886. Due to this bug
      execution of queries with CTEs used the same CTE at least twice via
      prepared statements or with stored procedures caused crashes of the server.
      It happened because the select created for any of not the first usage of
      a CTE erroneously was not included into all_selects_list.
      This patch corrects the patch applied to fix the bug MDEV-26108.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      872422dc
    • Eugene Kosov's avatar
      7da1cfb0
    • Eugene Kosov's avatar
      MDEV-25361 innochecksum must not report errors for freed pages · 1918bdf3
      Eugene Kosov authored
      Store and maintain xdes pages always. And doesn't verify checksums for
      freed pages.
      
      innochecksum can work only with the first space file of multiple ones.
      Tell about it and abort in case of not the first file.
      1918bdf3