- 17 Aug, 2010 1 commit
-
-
Vasil Dimov authored
This is a followup to vasil.dimov@oracle.com-20100816142329-yimenbuktd416z1a which improved the sampling algorithm. I have manually checked that the new values are actually the correct ones, for example: -rows 16 +rows 32 the number of rows returned by the query is 32.
-
- 16 Aug, 2010 1 commit
-
-
Vasil Dimov authored
Improve the range estimation algorithm. Previously: For a given level the algo knows the number of pages in the requested range and the n With this change: Same idea, but peek a few (10) of the intermediate pages to get a better estimate of In the bug report one of the examples has a btree with a snippet of the leaf level li page1(899 records), page2(1 record), page3(1 record), page4(1 record) so when trying to estimate, the previous algo, assumed there are average (899+1)/2=45 Fix Bug#53761 RANGE estimation for matched rows may be 200 times different Improve the range estimation algorithm. Previously: For a given level the algo knows the number of pages in the requested range and the number of records on the leftmost and the rightmost page. Then it assumes all pages in between contain the average between the two border pages and multiplies this average number by the number of intermediate pages. With this change: Same idea, but peek a few (10) of the intermediate pages to get a better estimate of the average number of records per page. If there are less than 10 intermediate pages then all of them will be scanned and the result will be precise, not an estimation. In the bug report one of the examples has a btree with a snippet of the leaf level like this: page1(899 records), page2(1 record), page3(1 record), page4(1 record) so when trying to estimate, the previous algo, assumed there are average (899+1)/2=450 records per page which went terribly wrong. With this change page2 and page3 will be read and the exact number of records will be returned. Approved by: Sunny (rb://401)
-
- 13 Aug, 2010 2 commits
-
-
Inaam Rana authored
Note that this was originally pushed by Calvin but the was later reverted by mistake. bug#54702
-
Inaam Rana authored
-
- 12 Aug, 2010 1 commit
-
-
Sunny Bains authored
Disable the GCC visibility attribute on all sun platforms. Approved by Marko on IRC.
-
- 10 Aug, 2010 2 commits
-
-
Vasil Dimov authored
-
Marko Mäkelä authored
Reduce ibuf_mutex and ibuf_pessimistic_insert_mutex contention further. Protect ibuf->empty by the insert buffer root page latch, not ibuf_mutex. ibuf_tree_root_get(): Assert that ibuf_mutex is owned by the caller. Assert that the stamped page number is correct. Assert that ibuf->empty agrees with the root page. ibuf_size_update(): Do not update ibuf->empty. ibuf_init_at_db_start(): Update ibuf->empty while holding the root page latch. ibuf_add_free_page(): Return TRUE/FALSE instead of DB_SUCCESS/DB_STRONG_FAIL. ibuf_remove_free_page(): Release ibuf_pessimistic_insert_mutex as early as possible. ibuf_contract_ext(): Rely on a dirty read of ibuf->empty, unless the server is being shut down. Never acquire ibuf_mutex. Eliminate n_stored. ibuf_contract_after_insert(): Never acquire ibuf_mutex. Perform dirty reads of ibuf->size and ibuf->max_size. ibuf_insert_low(): Only acquire ibuf_mutex for mode==BTR_MODIFY_TREE. Perform dirty reads of ibuf->size and ibuf->max_size. Update ibuf->empty while holding the root page latch. ibuf_delete_rec(): Update ibuf->empty while holding the root page latch. ibuf_is_empty(): Release ibuf_mutex earlier.
-
- 09 Aug, 2010 1 commit
-
-
Marko Mäkelä authored
regression in Bug #54914, but it does speed up the execution for innodb_change_buffering=inserts. ibuf_add_ops(), ibuf_merge_or_delete_for_page(), ibuf_delete_for_discarded_space(): Use atomic built-ins instead of ibuf_mutex, when available. ibuf_add_free_page(), ibuf_remove_free_page(), ibuf_contract_ext(): Release ibuf_mutex earlier. ibuf_free_excess_pages(): Release ibuf_mutex before a conditional branch. ibuf_insert_low(): Release ibuf_mutex before a conditional branch. Create ibuf_entry before re-acquiring ibuf_mutex. Simplify a loop to reduce code footprint. Release ibuf_mutex before mtr_commit() [btr_pcur_close()]. ibuf_is_empty(): Release ibuf_mutex before mtr_commit().
-
- 05 Aug, 2010 2 commits
-
-
Inaam Rana authored
-
Inaam Rana authored
called on any table. This patch fixes this by only doing this full check in debug versions. bug#55716 rb://423 approved by: Marko
-
- 03 Aug, 2010 1 commit
-
-
Calvin Sun authored
-
- 30 Jul, 2010 2 commits
-
-
Inaam Rana authored
-
Inaam Rana authored
pages that it wants to flush then we should honor that value as in not going beyond that in our eagerness to flush the neighbors of the selected victim.
-
- 29 Jul, 2010 1 commit
-
-
Vasil Dimov authored
-
- 28 Jul, 2010 3 commits
-
-
Gleb Shchepa authored
DELETE statement Single-table delete ordered by a field that has a hash-type index may cause an assertion failure or a crash. An optimization added by the fix for the bug 36569 forced the optimizer to use ORDER BY-compatible indices when applicable. However, the existence of unsorted indices (HASH index algorithm for some engines such as MEMORY/HEAP, NDB) was ignored. The test_if_order_by_key function has been modified to skip unsorted indices. mysql-test/r/heap_hash.result: Test case for bug #55472. mysql-test/t/heap_hash.test: Test case for bug #55472. sql/sql_select.cc: Bug #55472: Assertion failed in heap_rfirst function of hp_rfirst.c on DELETE statement The test_if_order_by_key function has been modified to skip unsorted indices.
-
Vasil Dimov authored
-
Vasil Dimov authored
-
- 26 Jul, 2010 1 commit
-
-
Davi Arnaut authored
The problem was that the optimize method of the ARCHIVE storage engine was not preserving the FRM embedded in the ARZ file when rewriting the ARZ file for optimization. The ARCHIVE engine stores the FRM in the ARZ file so it can be transferred from machine to machine without also copying the FRM -- the engine restores the embedded FRM during discovery. The solution is to copy over the FRM when rewriting the ARZ file. In addition, some initial error checking is performed to ensure garbage is not copied over. mysql-test/t/archive.test: Add test case for Bug#45377. storage/archive/azio.c: Add error checking to ensure that the I/O operations are successful. storage/archive/ha_archive.cc: Copy over the embedded FRM.
-
- 28 Jul, 2010 1 commit
-
-
Luis Soares authored
-
- 27 Jul, 2010 1 commit
-
-
Davi Arnaut authored
Workaround a interface problem with the atomic macros that was causing warnings. The correct type is retrieved using typeof if compiling with GCC.
-
- 26 Jul, 2010 5 commits
-
-
Davi Arnaut authored
Remove ASM for MC68000 and Vax.
-
Davi Arnaut authored
Remove 32-bit SPARC specific code.
-
Matthias Leich authored
into actual tree. No conflicts.
-
Jimmy Yang authored
rb://408 approved by Sunny Bains
-
Alexander Nozdrin authored
-
- 25 Jul, 2010 1 commit
-
-
Vladislav Vaintroub authored
* Fixed obvious errors (HAVE_BROKEN_PREAD is not true for on any of systems we use, definitely not on HPUX) * Remove other junk flags for OSX and HPUX * Avoid checking type sizes in universal builds on OSX, again (CMake2.8.0 fails is different architectures return different results) * Do not compile template instantiation stuff unless EXPLICIT_TEMPLATE_INSTANTIATION is used. * Some cleanup (make gen_lex_hash simpler, avoid dependencies) * Exclude some unused files from compilation (strtol.c etc)
-
- 24 Jul, 2010 4 commits
-
-
Vladislav Vaintroub authored
Fix some issues with WiX packaging, particularly major upgrade and change scenarios. * remember binary location and data location (for major upgrade) * use custom UI, which is WiX Mondo extended for major upgrade dialog (no feature selection screen shown on major upgrade, only upgrade confirmation). This is necessary to prevent changing installation path during upgrade (services are not reregistered, so they would have invalid binary path is it is changed) * Hide datafiles that are installed into ProgramFiles, show ones that are installed in ProgramData * Make MSI buildable with nmake * Fix autotools "make dist" Makefile.am: Fix autotools "make dist" configure.in: Fix autotools "make dist" packaging/Makefile.am: Fix autotools "make dist" packaging/WiX/CMakeLists.txt: Use custom UI, for major upgrades packaging/WiX/CPackWixConfig.cmake: Show user editable datafiles in feature selection dialog, not datafiles installed into ProgramFiles directory packaging/WiX/create_msi.cmake.in: Use custom UI, fix nmake build for installer packaging/WiX/custom_ui.wxs: Use custom UI packaging/WiX/extra.wxs.in: Show user editable datafiles in feature selection dialog, not datafiles installed into ProgramFiles directory packaging/WiX/mysql_server.wxs.in: Remember install locations of binaries and user editable datafiles.
-
Davi Arnaut authored
Fix assorted warnings in order for the warning-mode to be effective.
-
Davi Arnaut authored
-
Davi Arnaut authored
Post-merge fix: remove remaining casts which are now unnecessary and are actually causing warnings.
-
- 23 Jul, 2010 10 commits
-
-
Davi Arnaut authored
Remove wrappers around inline -- static inline is used without wrappers throughout the source code. We rely on the compiler or linker to eliminate unused static functions.
-
Davi Arnaut authored
Remove workarounds for ancient systems. mysys/default.c: Make cast more explicit to ensure a correct offset.
-
Davi Arnaut authored
Remove unused string functions. include/m_string.h: Remove prototypes for unused string functions and for functions that do not exist anymore.
-
Davi Arnaut authored
Remove unused macros or macro which are always defined. include/my_global.h: Remove unused macros and move macros which aren't used globally.
-
Davi Arnaut authored
Remove the obsolete and buggy bmove512, use memcpy instead.
-
Davi Arnaut authored
Remove the ancient and dead raid code. By now, even the server side has been removed.
-
Davi Arnaut authored
Remove unused source code and associated paraphernalia.
-
Davi Arnaut authored
Remove Windows related files which aren't used anymore.
-
Davi Arnaut authored
Remove unused variables.
-
Davi Arnaut authored
Remove code that has been disabled for a long time.
-