1. 14 Nov, 2023 1 commit
  2. 13 Nov, 2023 1 commit
  3. 11 Nov, 2023 2 commits
  4. 10 Nov, 2023 1 commit
  5. 09 Nov, 2023 1 commit
    • Marko Mäkelä's avatar
      MDEV-32737 innodb.log_file_name fails on Assertion `after_apply ||... · e0c65784
      Marko Mäkelä authored
      MDEV-32737 innodb.log_file_name fails on Assertion `after_apply || !(blocks).end in recv_sys_t::clear
      
      recv_group_scan_log_recs(): Set the debug flag recv_sys.after_apply
      after actually completing the log scan.
      
      In the test, suppress some errors that may be reported when
      the crash recovery of RENAME TABLE t1 TO t2 is preceded by
      copying t2.ibd to t1.ibd.
      e0c65784
  6. 08 Nov, 2023 2 commits
  7. 04 Nov, 2023 1 commit
  8. 03 Nov, 2023 1 commit
    • Kristian Nielsen's avatar
      MDEV-32672: Don't hold LOCK_thd_data over commit_ordered · 3c1f324a
      Kristian Nielsen authored
      Partial revert of this commit:
      
        commit 6b685ea7
        Author: Sergei Golubchik <serg@mariadb.org>
        Date:   Wed Sep 28 18:55:15 2022 +0200
      
      Don't hold LOCK_thd_data over run_commit_ordered(). Holding the mutex
      is unnecessary and will deadlock if any code in a commit_ordered
      handlerton call tries to take the mutex to change THD local data.
      
      Instead, set the current_thd for the duration of the call to keep
      asserts happy around LOCK_thd_data.
      Signed-off-by: default avatarKristian Nielsen <knielsen@knielsen-hq.org>
      3c1f324a
  9. 30 Oct, 2023 4 commits
    • Anel Husakovic's avatar
      MDEV-32462: mysql_upgrade -s still checks for non system tables · b06ac9a8
      Anel Husakovic authored
      - Rename files as requested by Vicentiu:
      ```
       mysql_json_mysql_upgrade.test                    -> mysql_upgrade_mysql_json.test
       mysql_json_mysql_upgrade_with_plugin_loaded.test -> mysql_upgrade_mysql_json_with_plugin_loaded.test
       mysql_json_mysql_upgrade_system_tables.test      -> mysql_upgrade_mysql_json_system_tables.test
      ```
      - Related to PR #2790
      - Reviewer: <daniel@mariadb.org>, <vicentiu@mariadb.org>
      b06ac9a8
    • Anel Husakovic's avatar
      MDEV-32462: mysql_upgrade -s still checks for non system tables · 4eb8aeee
      Anel Husakovic authored
      - Prevent opening of any user tables in case `upgrade-system-table`
      option is used.
      - Still there may be uninstalled data types in `mysql` system table so
      allow it to perform.
      - Closes PR #2790
      - Reviewer: <daniel@mariadb.org>, <vicentiu@mariadb.org>
      4eb8aeee
    • Anel Husakovic's avatar
      MDEV-26875: Wrong user in SET DEFAULT ROLE error · ee773753
      Anel Husakovic authored
      - Regression introduced in 957cb7b7
      - Patch 4abb8216 change `mysql.user` to `mysql.global_priv` for
      `add_anonymous.inc`, update `delete_anonymous.inc`.
      - Added test case with `--skip-name-resolve`
      - Add test case with anonymous user
        - Disable this test for windows, assignes current user to anonymous
        user.
      
      Reviewed by: <serg@mariadb.com>
      ee773753
    • Oleksandr Byelkin's avatar
      Make the test more stable · c4143f90
      Oleksandr Byelkin authored
      c4143f90
  10. 28 Oct, 2023 1 commit
  11. 27 Oct, 2023 7 commits
    • Oleksandr Byelkin's avatar
      1cd8a5ef
    • Sergei Petrunia's avatar
      MDEV-32351: Significant slowdown with outer joins: Test coverage · 9bf2e5e3
      Sergei Petrunia authored
      Make ANALYZE FORMAT=JSON print block-nl-join.r_unpack_ops when
      analyze_print_r_unpack_ops debug flag is set.
      
      Then, add a testcase.
      9bf2e5e3
    • Sergei Petrunia's avatar
      ANALYZE FORMAT=JSON: Backport block-nl-join.r_unpack_time_ms from 11.0 +fix MDEV-30830. · 4ed59006
      Sergei Petrunia authored
      Also fix it to work with hashed join (MDEV-30830).
      
      Reviewed by: Monty <monty@mariadb.org>
      4ed59006
    • Igor Babaev's avatar
      MDEV-32351 Significant slowdown for query with many outer joins · 954a6dec
      Igor Babaev authored
      This patch fixes a performance regression introduced in the patch for the
      bug MDEV-21104. The performance regression could affect queries for which
      join buffer was used for an outer join such that its on expression from
      which a conjunctive condition depended only on outer tables can be
      extracted. If the number of records in the join buffer for which this
      condition was false greatly exceeded the number of other records the
      slowdown could be significant.
      
      If there is a conjunctive condition extracted from the ON expression
      depending only on outer tables this condition is evaluated when interesting
      fields of each survived record of outer tables are put into the join buffer.
      Each such set of fields for any join operation is supplied with a match
      flag field used to generate null complemented rows. If the result of the
      evaluation of the condition is false the flag is set to MATCH_IMPOSSIBLE.
      When looking in the join buffer for records matching a record of the
      right operand of the outer join operation the records with such flags
      are not needed to be unpacked into record buffers for evaluation of on
      expressions.
      
      The patch for MDEV-21104 fixing some problem of wrong results when
      'not exists' optimization by mistake broke the code that allowed to
      ignore records with the match flag set to MATCH_IMPOSSIBLE when looking
      for matching records. As a result such records were unpacked for each
      record of the right operand of the outer join operation. This caused
      significant execution penalty in some cases.
      
      One of the test cases added in the patch can be used only for demonstration
      of the restored performance for the reported query. The second test case is
      needed to demonstrate the validity of the fix.
      954a6dec
    • Oleksandr Byelkin's avatar
      fixed typo · 11abc219
      Oleksandr Byelkin authored
      11abc219
    • Marko Mäkelä's avatar
      MDEV-32578 row_merge_fts_doc_tokenize() handles parser plugin inconsistently · 15ae97b1
      Marko Mäkelä authored
      When mysql/mysql-server@0c954c2289a75d90d1088356b1092437ebf45a1d
      added a plugin interface for FULLTEXT INDEX tokenization to MySQL 5.7,
      fts_tokenize_ctx::processed_len got a second meaning, which is only
      partly implemented in row_merge_fts_doc_tokenize().
      
      This inconsistency could cause a crash when using FULLTEXT...WITH PARSER.
      A test case that would crash MySQL 8.0 when using an n-gram parser and
      single-character words would fail to crash in MySQL 5.7, because the
      buf_full condition in row_merge_fts_doc_tokenize() was not met.
      
      This change is inspired by
      mysql/mysql-server@38e9a0779aeea2d197c727e306a910c56b26a47c
      that appeared in MySQL 5.7.44.
      15ae97b1
    • Andrei's avatar
      MDEV-32593 Assertion failure upon CREATE SEQUENCE · 728bca44
      Andrei authored
      A recently added by MDEV-32593 assert conditions are corrected.
      728bca44
  12. 26 Oct, 2023 4 commits
    • Teemu Ollakka's avatar
      MDEV-32282: Galera node remains paused after interleaving FTWRLs · ef7fc586
      Teemu Ollakka authored
      After two concurrent FTWRL/UNLOCK TABLES, the node stays in paused state
      and the following CREATE TABLE fails with
      
        ER_UNKNOWN_COM_ERROR (1047): Aborting TOI: Replication paused on
        node for FTWRL/BACKUP STAGE.
      
      The cause is the use of global `wsrep_locked_seqno` to determine
      if the node should be resumed on UNLOCK TABLES. In some executions
      the `wsrep_locked_seqno` is cleared by the first UNLOCK TABLES
      after the second FTWRL gets past `make_global_read_lock_block_commit()`.
      
      As a fix, use `thd->wsrep_desynced_backup_stage` to determine
      if the thread should resume the node on UNLOCK TABLES.
      
      Add MTR test galera.galera_ftwrl_concurrent to reproduce the
      race. The test contains also cases for BACKUP STAGE which
      uses similar mechanism for desyncing and pausing the node.
      Signed-off-by: default avatarJulius Goryavsky <julius.goryavsky@mariadb.com>
      ef7fc586
    • Sergei Golubchik's avatar
      MDEV-32586 incorrect error about cyclic reference about JSON type virtual column · c9f87b88
      Sergei Golubchik authored
      remove the hack where NO_DEFAULT_VALUE_FLAG was temporarily removed
      from a field to initialize DEFAULT() functions in CHECK constraints
      while disabling self-reference field checks.
      
      Instead, initialize DEFAULT() functions in CHECK explicitly,
      don't call check_field_expression_processor() for CHECK at all.
      c9f87b88
    • Andrei's avatar
      MDEV-32365 detailize the semisync replication magic number error · 9c433432
      Andrei authored
      Semisync ack (master side) receiver thread is made to report
      details of faced errors.
      In case of 'magic byte' error, a hexdump of the received packet
      is always (level) NOTEd into the error log.
      In other cases an exact server level error is print out
      as a warning (as it may not be critical) under log_warnings > 2.
      
      An MTR test added for the magic byte error. For others existing mtr
      tests cover that, provided log_warnings > 2 is set.
      9c433432
    • Oleksandr Byelkin's avatar
      Fix --view-protocol failures · cb4c2713
      Oleksandr Byelkin authored
      cb4c2713
  13. 25 Oct, 2023 2 commits
  14. 24 Oct, 2023 3 commits
  15. 23 Oct, 2023 9 commits
    • Alexander Barkov's avatar
      MDEV-30048 Prefix keys for CHAR work differently for MyISAM vs InnoDB · df72c57d
      Alexander Barkov authored
      Also fixes: MDEV-30050 Inconsistent results of DISTINCT with NOPAD
      
      Problem:
      
      Key segments for CHAR columns where compared using strnncollsp()
      for engines MyISAM and Aria.
      
      This did not work correct in case if the engine applyied trailing
      space compression.
      
      Fix:
      
      Replacing ha_compare_text() calls to new functions:
      
      - ha_compare_char_varying()
      - ha_compare_char_fixed()
      - ha_compare_word()
      - ha_compare_word_prefix()
      - ha_compare_word_or_prefix()
      
      The code branch corresponding to comparison of CHAR column keys
      (HA_KEYTYPE_TEXT segment type) now uses ha_compare_char_fixed()
      which calls strnncollsp_nchars().
      
      This patch does not change the behavior for the rest of the code:
      - comparison of VARCHAR/TEXT column keys
        (HA_KEYTYPE_VARTEXT1, HA_KEYTYPE_VARTEXT2 segments types)
      - comparison in the fulltext code
      df72c57d
    • Alexander Barkov's avatar
      MDEV-31184 Remove parser tokens DECODE_MARIADB_SYM and DECODE_ORACLE_SYM · 09e23708
      Alexander Barkov authored
      Changing the code handling sql_mode-dependent function DECODE():
      
      - removing parser tokens DECODE_MARIADB_SYM and DECODE_ORACLE_SYM
      - removing the DECODE() related code from sql_yacc.yy/sql_yacc_ora.yy
      - adding handling of DECODE() with help of a new Create_func_func_decode
      09e23708
    • Brandon Nesterenko's avatar
      MDEV-32265: seconds_behind_master is inaccurate for Delayed replication · c5f776e9
      Brandon Nesterenko authored
      If a replica is actively delaying a transaction when restarted (STOP
      SLAVE/START SLAVE), when the sql thread is back up,
      Seconds_Behind_Master will present as 0 until the configured
      MASTER_DELAY has passed. That is, before the restart,
      last_master_timestamp is updated to the timestamp of the delayed
      event. Then after the restart, the negation of sql_thread_caught_up
      is skipped because the timestamp of the event has already been used
      for the last_master_timestamp, and their update is grouped together
      in the same conditional block.
      
      This patch fixes this by separating the negation of
      sql_thread_caught_up out of the timestamp-dependent block, so it is
      called any time an idle parallel slave queues an event to a worker.
      
      Note that sql_thread_caught_up is still left in the check for internal
      events, as SBM should remain idle in such case to not "magically" begin
      incrementing.
      
      Reviewed By:
      ============
      Andrei Elkin <andrei.elkin@mariadb.com>
      c5f776e9
    • Sergei Golubchik's avatar
      remove ./mtr --skip-im · 95177551
      Sergei Golubchik authored
      it did nothing for 14 years
      95177551
    • Sergei Golubchik's avatar
      ./mtr --skip-not-found · 78cd45b2
      Sergei Golubchik authored
      New mtr option --skip-not-found makes it to show not found tests
      as skipped
      
      main.a                                   [ skipped ]  not found
      
      (but only if the test was specified with the suite name)
      and not error out early with
      
      mysql-test-run: *** ERROR: Could not find 'a' in 'main' suite
      
      This is useful in buildbot, on builders that generate the list
      of tests dynamically.
      78cd45b2
    • Sergei Golubchik's avatar
      MDEV-32541 Assertion `!(thd->server_status & (1U | 8192U))' failed in... · b00fd50f
      Sergei Golubchik authored
      MDEV-32541 Assertion `!(thd->server_status & (1U | 8192U))' failed in MDL_context::release_transactional_locks
      
      SERVER_STATUS_IN_TRANS_READONLY should never be set without
      SERVER_STATUS_IN_TRANS.
      
      They're set together, must be removed together.
      b00fd50f
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      MDEV-32500 Information schema leaks table names and structure to unauthorized users · 547dfc0e
      Sergei Golubchik authored
      standard table KEY_COLUMN_USAGE should only show keys where
      a user has some privileges on every column of the key
      
      standard table TABLE_CONSTRAINTS should show tables where
      a user has any non-SELECT privilege on the table or on any column
      of the table
      
      standard table REFERENTIAL_CONSTRAINTS is defined in terms of
      TABLE_CONSTRAINTS, so the same rule applies. If the user
      has no rights to see the REFERENCED_TABLE_NAME value, it should be NULL
      
      SHOW INDEX (and STATISTICS table) is non-standard, but it seems
      reasonable to use the same logic as for KEY_COLUMN_USAGE.
      547dfc0e
    • Sergei Golubchik's avatar
      2eee0e9b