1. 22 Nov, 2005 12 commits
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/work-bug2-5.0 · a11b9d73
      unknown authored
      into  sanja.is.com.ua:/home/bell/mysql/bk/work-merge-5.0
      
      
      sql/item.h:
        Auto merged
      sql/protocol.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_trigger.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/sp.result:
        merge
      mysql-test/r/trigger.result:
        merge
      mysql-test/t/sp.test:
        merge
      mysql-test/t/trigger.test:
        merge
      sql/item.cc:
        merge
      sql/sp_rcontext.h:
        merge
      a11b9d73
    • unknown's avatar
      Fix for BUG#13549 "Server crash with nested stored procedures · 8152a78f
      unknown authored
      if inner routine has more local variables than outer one, and
      one of its last variables was used as argument to NOT operator".
      
      THD::spcont was non-0 when we were parsing stored routine/trigger
      definition during execution of another stored routine. This confused
      methods of Item_splocal and forced them use wrong runtime context.
      Fix ensures that we always have THD::spcont equal to zero during
      routine/trigger body parsing. This also allows to avoid problems
      with errors which occur during parsing and SQL exception handlers.
      
      
      mysql-test/r/sp.result:
        Test suite for bug#13549.
      mysql-test/r/trigger.result:
        Test suite for bug#13549.
      mysql-test/t/sp.test:
        Test suite for bug#13549.
      mysql-test/t/trigger.test:
        Test suite for bug#13549.
      sql/item.cc:
        Protection against using wrong context by SP local variable.
      sql/item.h:
        Protection against using wrong context by SP local variable.
      sql/protocol.cc:
        An incorrect macro name fixed.
      sql/protocol.h:
        An incorrect macro name fixed.
      sql/sp.cc:
        Do not allow SP which we are parsing to use other SP
        context (BUG#13549).
      sql/sp_head.cc:
        Protection against using wrong context by SP local variable.
      sql/sp_rcontext.h:
        Protection against using wrong context by SP local variable.
      sql/sql_cache.h:
        An incorrect macro name fixed.
      sql/sql_class.cc:
        Protection against using wrong context by SP local variable.
      sql/sql_class.h:
        Protection against using wrong context by SP local variable.
      sql/sql_trigger.cc:
        Do not allow Trigger which we are parsing to use
        other SP context (BUG#13549).
      sql/sql_yacc.yy:
        Protection against using wrong context by SP local variable.
      8152a78f
    • unknown's avatar
      Manual merge from 4.1, bug#15145. · a03aa0b3
      unknown authored
      a03aa0b3
    • unknown's avatar
      support-files/mysql.spec.sh · d9104d22
      unknown authored
      Fix a possible problem on RPM un-install. bug#15145
      
      
      support-files/mysql.spec.sh:
        Extend the file existence check for "init.d/mysql" on un-install
        to also guard the call to "insserv"/"chkconfig".
        bug#15145, br#5369 / 5586, csc#7129
      d9104d22
    • unknown's avatar
      Set type and default correctly for local SP variables during parsing. · f7684593
      unknown authored
      
      sql/sql_yacc.yy:
        Set type and default correctly for local SP variables.
      f7684593
    • unknown's avatar
      Post-merge fixes in sp_head.cc (print methods). · 466f645b
      unknown authored
      
      sql/sp_head.cc:
        Post-merge fixes.
        Use STRING_WITH_LEN in all print methods.
      466f645b
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 5570497c
      unknown authored
      into  mysql.com:/usr/home/pem/show-sp-code/mysql-5.0
      
      
      sql/sp_head.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/sp_head.cc:
        Merge fixes (STRING_WITH_LEN in string append calls).
      5570497c
    • unknown's avatar
      Some final cleanup of the sp_instr print methods. · 28a01490
      unknown authored
      
      sql/sp_head.cc:
        Use a #define constant for reserving string space for numbers in print methods.
        Added some comments.
      28a01490
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bkroot/mysql-5.0 · edce86ff
      unknown authored
      into  mysql.com:/users/lthalmann/bk/mysql-5.0-hexdump
      
      
      sql/log_event.cc:
        Auto merged
      edce86ff
    • unknown's avatar
      Added explicit casts, since on i686, the fprintf function does not cast my_off_t correctly. · e4604348
      unknown authored
      Changed wrong printf to fprintf.
      
      
      sql/log_event.cc:
        Added explicit casts, changed wrong printf to fprintf
      e4604348
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.0 · fa5df050
      unknown authored
      into production.mysql.com:/usersnfs/istruewing/autopush/mysql-5.0
      
      fa5df050
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · c4228d51
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-distcheck
      
      
      configure.in:
        Auto merged
      c4228d51
  2. 21 Nov, 2005 17 commits
  3. 20 Nov, 2005 1 commit
    • unknown's avatar
      Inefficient usage of String::append() fixed. · 5e047f6b
      unknown authored
      Bad examples of usage of a string with its length fixed.
      The incorrect length in the trigger file configuration descriptor
        fixed (BUG#14090).
      A hook for unknown keys added to the parser to support old .TRG files.
      
      
      sql/field.cc:
        Inefficient usage of String::append() fixed.
        Bad examples of usage of a string with its length fixed.
      sql/ha_berkeley.cc:
        A bad example of usage of a string with its length fixed.
      sql/ha_federated.cc:
        Inefficient usage of String::append() fixed.
      sql/ha_myisammrg.cc:
        Bad examples of usage of a string with its length fixed.
      sql/handler.cc:
        Inefficient usage of String::append() fixed.
      sql/item.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item.h:
        A bad example of usage of a string with its length fixed.
      sql/item_cmpfunc.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item_func.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item_strfunc.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item_subselect.cc:
        Bad examples of usage of a string with its length fixed.
      sql/item_sum.cc:
        Bad examples of usage of a string with its length fixed.
        Inefficient usage of String::append() fixed.
      sql/item_timefunc.cc:
        Inefficient using of String::append() fixed.
        Bad examples of usage of a string with its length fixed.
      sql/item_uniq.h:
        Bad examples of usage of a string with its length fixed.
      sql/key.cc:
        Bad examples of usage of a string with its length fixed.
      sql/log.cc:
        Bad examples of usage of a string with its length fixed.
      sql/log_event.cc:
        Bad examples of usage of a string with its length fixed.
      sql/mysqld.cc:
        The dummy parser hook allocated.
      sql/opt_range.cc:
        Inefficient usage of String::append() fixed.
      sql/parse_file.cc:
        Bad examples of usage of a string with its length fixed.
        A hook for unknown keys added to the parser.
      sql/parse_file.h:
        A hook for unknown keys added to the parser.
      sql/protocol.cc:
        A bad example of usage of a string with its length fixed.
      sql/repl_failsafe.cc:
        Bad examples of usage of a string with its length fixed.
      sql/share/errmsg.txt:
        A warning for old format config file.
      sql/slave.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sp.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sp_head.cc:
        Bad examples of usage of a string with its length fixed.
      sql/spatial.cc:
        A bad example of usage of a string with its length fixed.
      sql/sql_acl.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_analyse.cc:
        Bad examples of usage of a string with its length fixed.
        Inefficient usage of String::append() fixed.
      sql/sql_lex.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_load.cc:
        A bad example of usage of a string with its length fixed.
      sql/sql_parse.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_prepare.cc:
        A bad example of usage of a string with its length fixed.
      sql/sql_select.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_show.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_string.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_string.h:
        The macro definition moved to sql_string.h to
          be accessible in all parts of server.
      sql/sql_table.cc:
        Bad examples of usage of a string with its length fixed.
      sql/sql_trigger.cc:
        Bad examples of usage of a string with its length fixed.
        The incorrect length in the trigger file configuration descriptor
          fixed (BUG#14090).
        The hook for processing incorrect sql_mode record added.
      sql/sql_view.cc:
        A dummy  hook used for parsing views.
      sql/structs.h:
        The macro definition moved to sql_string.h to be
          accessible in all parts of server.
      sql/table.cc:
        A bad example of usage of a string with its length fixed.
      sql/tztime.cc:
        A bad example of usage of a string with its length fixed.
      5e047f6b
  4. 19 Nov, 2005 9 commits
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · 9f0607e3
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-distcheck
      
      9f0607e3
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 4d734e3c
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-bg13825
      
      4d734e3c
    • unknown's avatar
      A fix for Bug#14845 "mysql_stmt_fetch returns MYSQL_NO_DATA when · db869810
      unknown authored
      COUNT(*) is 0" (the test case has been pushed already)
      
      
      sql/sql_cursor.cc:
        Fix a return of an unitialized variable: return_zero_rows
        checks the return value of send_fields and in case it's 1
        doesn't call send_data. This caused creation of an empty result 
        set for the case when there is a cursor against a select with a 
        group function and no matching rows.
      db869810
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1-distcheck · 79b8883f
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-distcheck
      
      
      configure.in:
        Auto merged
      79b8883f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · b8ad76f7
      unknown authored
      into  mysql.com:/home/dlenev/src/mysql-5.0-bg13825
      
      
      sql/ha_innodb.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      b8ad76f7
    • unknown's avatar
      Fix for bug #13825 "Triggers: crash if release savepoint" and for general · 2722ebcd
      unknown authored
      handling of savepoints in stored routines.
      
      Fixed ha_rollback_to_savepoint()/ha_savepoint()/ha_release_savepoint()
      functions to properly handle savepoints inside of stored functions and
      triggers.
      Also now when we invoke stored function or trigger we create new savepoint
      level. We destroy it at the end of function/trigger execution and return back
      to old savepoint level.
      
      
      mysql-test/r/sp_trans.result:
        Added test for bug #13825 "Triggers: crash if release savepoint" and for
        general handling of savepoints in stored routines.
      mysql-test/t/sp_trans.test:
        Added test for bug #13825 "Triggers: crash if release savepoint" and for
        general handling of savepoints in stored routines.
      sql/ha_innodb.cc:
        innobase_savepoint():
          Replaced check which always failed due to similar check in caller
          with assertion.
      sql/handler.cc:
        ha_rollback_to_savepoint()/ha_savepoint()/ha_release_savepoint():
          Changed functions to properly support handling of savepoints
          inside of stored functions and triggers.
      sql/sql_class.cc:
        THD::reset_sub_statement_state()/restore_sub_statement_state():
          When we invoke stored function or trigger we should create new savepoint
          level. We should destroy it at the end of function/trigger execution and
          return back to old savepoint level. To support this behavior we should
          save and reset list of current savepoints on entering function and restore
          old list when we leave it.
      sql/sql_class.h:
        Sub_statement_state:
          When we invoke stored function or trigger we should create new savepoint
          level. We should destroy it at the end of function/trigger execution and
          return back to old savepoint level. To support this behavior added "savepoint"
          member which is used to save/restore list of current savepoints on
          entering/leaving function.
      sql/sql_parse.cc:
        mysql_execute_command():
          Changed processing of SQLCOM_SAVEPOINT so now it is not ignored when
          we are in autocommit mode and savepoint is set inside of stored
          function or trigger.
      2722ebcd
    • unknown's avatar
      configure.in: · 8d1a4986
      unknown authored
        Corrected "include/readline" link for "make distcheck"
      
      
      configure.in:
        Corrected "include/readline" linke for "make distcheck"
      8d1a4986
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · dd0ad09e
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-distcheck
      
      
      configure.in:
        Auto merged
      dd0ad09e
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · d8699ce9
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1-distcheck
      
      
      configure.in:
        Auto merged
      d8699ce9
  5. 18 Nov, 2005 1 commit
    • unknown's avatar
      Bug#13510 "Setting password local variable changes current · 826dbaec
      unknown authored
      password": additional fix, also make sure that a syntax error is 
      returned for set names="foo" when there is no such variable or no
      stored procedure.
      
      
      mysql-test/r/sp-error.result:
        Test results fixed: a new test for Bug#13510
      mysql-test/t/sp-error.test:
        A new test for Bug#13510 (set names out of an SP)
      sql/sql_yacc.yy:
        Bug#13510: fix the case when there is no stored procedure or
        no 'names' variable declared. Return a syntax error in this case.
      826dbaec