1. 19 Feb, 2008 1 commit
    • unknown's avatar
      Bug#34598 · a1915039
      unknown authored
        "crash on hpita: Invalid address alignment"
        Replace dangerous pointer arithmetic - it may occurr where sizeof(int) is
        less than size of machine alignment requirement.
      
      
      include/mysql/plugin.h:
        bug34598
          change of update func prototype
      sql/sql_plugin.cc:
        bug34598
          Avoid dangerous pointer arithmetic which can cause unaligned word access.
          Change of update function prototype
      a1915039
  2. 09 Feb, 2008 1 commit
  3. 08 Feb, 2008 1 commit
    • unknown's avatar
      BUG#33247: mysqlbinlog does not clean up after itself on abnormal termination · 5db7ee3e
      unknown authored
      Problem: mysqlbinlog does not free memory if an error happens.
      Fix: binlog-processing functions do not call exit() anymore. Instead, they
      print an error and return an error code. Error codes are propagated all
      the way back to main, and all allocated memory is freed on the way.
      
      
      client/mysqlbinlog.cc:
        - New error handling policy: functions processing binlogs don't just
          exit() anymore. Instead, they print a message and return an error
          status.
        - New policy for the global `mysql' and `glob_description_event': these
          are not passed as parameters anymore. The global pointer is used
          instead.
        - More error situations are detected and reported.
        - Better error messages: the program never terminates with exit status 1
          without explanation any more. Fixed spelling errors. Use consistent
          format of messages (a single line beginning with "ERROR: " or
          "WARNING: " and ending with "." is printed to stderr.)
        - New memory handling: memory is always freed on program termination.
        - Better comments: more functions are explained, doxygen is used, and
          more precise formulations in some existing comments.
      mysql-test/suite/binlog/r/binlog_base64_flag.result:
        Result file updated since output format of mysqlbinlog changed while the
        test was disabled.
      mysql-test/suite/binlog/t/binlog_killed.test:
        Mysqlbinlog now works as described when the binlog is open. Hence, the
        --force-if-open flag must be passed
      mysql-test/suite/binlog/t/binlog_killed_simulate.test:
        Mysqlbinlog now works as described when the binlog is open. Hence, the
        --force-if-open flag must be passed
      mysql-test/suite/binlog/t/disabled.def:
        Now that mysqlbinlog cleans up after itself on abnormal termination, we
        can enable this test again.
      5db7ee3e
  4. 07 Feb, 2008 6 commits
    • unknown's avatar
      WL#4078: Document binary format of binlog entries · 187e5c5f
      unknown authored
      Documented Table_map_log_event and packed integer format. Improved
      other documentation. No change outside comments.
      
      
      sql/log_event.h:
        Documented Table_map_log_event and packed integer format. Improved
        other documentation. No change outside comments.
      187e5c5f
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 1c48bea2
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      mysql-test/suite/binlog/t/binlog_old_versions.test:
        Auto merged
      1c48bea2
    • unknown's avatar
      Renaming some saved binary log files to avoid 99 characters · 2a482933
      unknown authored
      limit for v7 tar.
      
      
      mysql-test/suite/binlog/std_data/ver_5_1_17.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1_17.000001 -> mysql-test/suite/binlog/std_data/ver_5_1_17.001
      mysql-test/suite/binlog/std_data/ver_5_1_23.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1_23.000001 -> mysql-test/suite/binlog/std_data/ver_5_1_23.001
      mysql-test/suite/binlog/std_data/ver_5_1-telco.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-telco.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-telco.001
      mysql-test/suite/binlog/std_data/ver_5_1-wl2325_r.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-wl2325_row.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-wl2325_r.001
      mysql-test/suite/binlog/std_data/ver_5_1-wl2325_s.001:
        Rename: mysql-test/suite/binlog/std_data/binlog_old_version_5_1-wl2325_stm.000001 -> mysql-test/suite/binlog/std_data/ver_5_1-wl2325_s.001
      mysql-test/suite/binlog/std_data/bug32407.001:
        Rename: mysql-test/suite/binlog/std_data/binlog-bug32407.000001 -> mysql-test/suite/binlog/std_data/bug32407.001
      2a482933
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 3b44afb0
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      sql/slave.cc:
        Auto merged
      3b44afb0
    • unknown's avatar
      Disabling declaration of debug variable for non-debug builds. · 7144184c
      unknown authored
      
      sql/slave.cc:
        Disabling declaration in non-debug builds.
      7144184c
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 5cb34d74
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      sql/slave.cc:
        Auto merged
      sql/sql_binlog.cc:
        Auto merged
      5cb34d74
  5. 06 Feb, 2008 4 commits
    • unknown's avatar
      Merge riska.(none):/home/sven/bk/b34355-backslash_in_path_name_under_win/5.0-rpl · ea7ecda2
      unknown authored
      into  riska.(none):/home/sven/bk/b34355-backslash_in_path_name_under_win/5.1-new-rpl
      
      
      client/mysqlbinlog.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      ea7ecda2
    • unknown's avatar
      Replace windows path separator backslash by unix path separator forward · 7b82376f
      unknown authored
      slash in filenames also for Create_file_log_event.
      
      
      client/mysqlbinlog.cc:
        BUG#34355: mysqlbinlog outputs backslash as path separator for 4.1 binlogs
        Problem: When the windows version of mysqlbinlog reads 4.1 binlogs
        containing LOAD DATA INFILE, it outputs backslashes as path separators in
        filenames. However, the output is typically piped to a client, and client
        expects forward slashes.
        Fix: Replace '\\' by '/' in filenames.
      7b82376f
    • unknown's avatar
      Patch to eliminate some valgrind warnings in debug printout code. · be5a46a6
      unknown authored
      
      sql/rpl_rli.cc:
        Adding variable to mark an instance of Relay_log_info as fake.
      sql/rpl_rli.h:
        Adding variable to mark an instance of Relay_log_info as fake.
      sql/slave.cc:
        Not printing debug information if we are working with a fake
        instance of Relay_log_info. This because the result of calling
        update is nonsense, and trying to print it generates valgrind
        warnings.
      sql/sql_binlog.cc:
        Marking newly created instance of Relay_log_info as a fake instance.
      be5a46a6
    • unknown's avatar
      Removing duplicate code from mysql-test-run.pl · 6cb9dfed
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Removing duplicate code.
      6cb9dfed
  6. 05 Feb, 2008 6 commits
    • unknown's avatar
      Updating result file for rpl_loaddata_map. · 781de196
      unknown authored
      
      mysql-test/suite/rpl/r/rpl_loaddata_map.result:
        Result change.
      781de196
    • unknown's avatar
      Fixes to make tests pass on vanilla build. · f0f95695
      unknown authored
      
      mysql-test/suite/binlog/t/binlog_old_versions.test:
        Adding --local-load to 'mysqlbinlog' and --local-infile=1 to 'mysql'.
      f0f95695
    • unknown's avatar
      Bug #34305 show slave status handling segfaults when slave io is about · 3b6a71a4
      unknown authored
          to leave
      
      The artifact was caused by
      a flaw in concurrent accessing the slave's io thd by
      the io itself and a handling show slave status thread.
      Namely, show_master_info did not acquire mi->run_lock mutex that is
      specified for mi->io_thd member.
      
      Fixed with deploying the mutex locking and unlocking. The mutex is kept
      short time and without interleaving with mi->data_lock mutex.
      
      Todo: to report and fix an issue with 
          sys_var_slave_skip_counter::{methods} 
      seem to acquire incorrectly
           active_mi->rli.run_lock
      instead of the specified
           active_mi->rli.data_lock
      
      A test case is difficult to compose, so rpl_packet should continue serving
      as the indicator.
      
      
      sql/slave.cc:
        implementing a TODO left at 4.1 time:
        mending access to mi->io_thd with the specified mutex;
      sql/slave.h:
        adding a member name to the list of that run_lock guards.
      3b6a71a4
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.1-new-rpl · a63ef17f
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl
      
      
      include/my_base.h:
        Auto merged
      mysql-test/include/show_binlog_events2.inc:
        Auto merged
      mysql-test/suite/binlog/t/binlog_old_versions.test:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_tabledefs_2myisam.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_row_tabledefs_3innodb.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_loaddata_map-master.opt:
        Auto merged
      mysql-test/suite/rpl/t/rpl_loaddata_map-slave.opt:
        Auto merged
      sql/log_event_old.cc:
        Auto merged
      sql/sql_binlog.cc:
        Auto merged
      mysql-test/suite/rpl/r/rpl_loaddata_map.result:
        Manual merge.
      mysql-test/suite/rpl/r/rpl_user.result:
        Manual merge.
      mysql-test/suite/rpl/t/rpl_loaddata_map.test:
        Manual merge.
      mysql-test/suite/rpl/t/rpl_user.test:
        Manual merge.
      sql/log_event.cc:
        Manual merge.
      sql/rpl_record.cc:
        Manual merge.
      a63ef17f
    • unknown's avatar
      Adding some more filtering for tests that kills queries and · df2cf8c7
      unknown authored
      cause sporadic, but benign, errors.
      
      
      mysql-test/lib/mtr_report.pl:
        Filtering out sporadic but benign error in rpl_err_ignoredtable.
      df2cf8c7
    • unknown's avatar
      Disabling test case binlog_old_version for embedded server. · 57c599b3
      unknown authored
      
      mysql-test/lib/mtr_report.pl:
        Ignoring benign error message (killing query causes unpredictable
        error messages).
      mysql-test/suite/binlog/t/binlog_old_versions.test:
        Disabling test case for embedded server.
      sql/rpl_rli.cc:
        Inititializing uninitialized variable causing valgrind warning.
      57c599b3
  7. 04 Feb, 2008 10 commits
  8. 03 Feb, 2008 2 commits
    • unknown's avatar
      Removing expected errors from slave from the warnings file. · eca69689
      unknown authored
      
      mysql-test/lib/mtr_report.pl:
        Removing some expected warnings and errors from the slave for
        tests rpl_idempotency and rpl_skip_error.
      eca69689
    • unknown's avatar
      Bug #34244 Test ndb_binlog_log_bin fails for 'drop table if · 5d66c356
      unknown authored
                 exists t1,t2,t3'
      Bug #34245 Test ndb_binlog_multi fails for 'CREATE TABLE'
      Bug #34246 Test rpl_ndb_transaction fails with 'Failed to create
                 'mysql/ndb_apply_status'
      
      Tests cases didn't wait for cluster to come up due to a typo
      in have_multi_ndb.inc.
      
      
      mysql-test/include/have_multi_ndb.inc:
        SHOW TABLES is case-sensitive in the pattern to LIKE.
      mysql-test/suite/ndb/t/disabled.def:
        Enabling tests.
      mysql-test/suite/rpl_ndb/t/rpl_ndb_transaction.test:
        Adding include of have_debug since test requires that.
      sql/sql_repl.cc:
        Replacing 'return' with 'DBUG_RETURN' in debug-traced function.
      5d66c356
  9. 02 Feb, 2008 1 commit
    • unknown's avatar
      Disabling various tests and reporting bugs for them. · 29245b93
      unknown authored
      
      mysql-test/suite/ndb/t/disabled.def:
        Disabling tests ndb_binlog_lob_bin, ndb_binlog_multi,
        and rpl_ndb_transaction.
      mysql-test/suite/parts/t/disabled.def:
        Disabling various partition tests.
      29245b93
  10. 01 Feb, 2008 8 commits