1. 05 May, 2005 1 commit
    • unknown's avatar
      Fix for bug #9841 "Unexpected read lock when trying to update a view in · a1be4b81
      unknown authored
      a stored procedure" (version 2).
      
      To handle updates and inserts into view in SP properly we should set
      lock types for tables of the view's main select when we are opening
      view for prelocking purproses.
      
      
      mysql-test/r/sp.result:
        Added test case for bug #9841 "Unexpected read lock when trying to update
        a view in a stored procedure"
      mysql-test/t/sp.test:
        Added test case for bug #9841 "Unexpected read lock when trying to update
        a view in a stored procedure"
      sql/sql_view.cc:
        mysql_make_view():
          To handle updates and inserts into view in SP properly we should set
          lock types for tables of the view's main select when we are opening
          view for prelocking purproses.
          Also it is more correct to use LEX::select_lex::get_table_list() 
          instead of 'view_tables' variable for obtaining list of those
          tables.
      a1be4b81
  2. 04 May, 2005 13 commits
  3. 03 May, 2005 7 commits
    • unknown's avatar
      Merge book.sanja.is.com.ua:/Users/bell/mysql/bk/mysql-5.0 · 9ebb54e9
      unknown authored
      into book.sanja.is.com.ua:/Users/bell/mysql/bk/work-test-5.0
      
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      9ebb54e9
    • unknown's avatar
      Manual merge of Bug#9096 · e26fed10
      unknown authored
      e26fed10
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-4.1-root · 4e4d5ea3
      unknown authored
      into mysql.com:/opt/local/work/mysql-4.1-9096-fresh
      
      
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      4e4d5ea3
    • unknown's avatar
      A fix and test case for Bug#9096 "select doesn't return all matched · eb9e992b
      unknown authored
      records if prepared statements is used".
      This fix changes equality evaluation method of basic constants from
      by-name to by-value, thus effectively enabling use of parameter markers
      in some optimizations (constants propagation, evaluation of possible
      keys for query).
      
      
      mysql-test/r/ps.result:
        Test results for the test case for Bug#9096
      mysql-test/t/ps.test:
        A short test case for Bug#9096 "select doesn't return all matched records if
         prepared statements is used". The is enough to reproduce the
        glitch in update_ref_and_keys causing the bug to occur.
      sql/item.cc:
        Implement by-value equality evaluation of basic constants.
        This is needed to work with Item_param values. Until now
        Item_param was compared with other items by its name, which is always "?".
        The bug at hand showed up when an integer
        constant was created from one parameter marker (with value 200887 and
         name "?") and then compared by-name with another parameter marker
        (with value 860 and name "?"). True returned by this comparison resulted
        in a wrong table access method used to evaluate the query.
        Implement Item_param methods needed to emulate "basic constant" mode at 
        full.
      sql/item.h:
        Change declaration of basic_const_item(): now it also widens its 
        argument from const Item * to Item * if the argument is a basic constant.
        Declare eq() for all basic constatns, as long as now they 
        are compared by value, not by name. Each constant needs its own
        comparison method.
        Declarations of Item_param methods needed to fully emulate 
        a basic constant when parameter value is set.
      sql/item_func.cc:
        Fix wrong casts.
      eb9e992b
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0 · e4ecb68d
      unknown authored
      into mysql.com:/home/psergey/mysql-5.0-test-valgrind
      
      e4ecb68d
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0 · f5955f4d
      unknown authored
      into mysql.com:/home/psergey/mysql-5.0-test-valgrind
      
      
      sql/sql_select.cc:
        Auto merged
      f5955f4d
    • unknown's avatar
      ha_innodb.cc: · e3d2bb40
      unknown authored
        Return a value from innobase_repl_report_sent_binlog()
      
      
      sql/ha_innodb.cc:
        Return a value from innobase_repl_report_sent_binlog()
      e3d2bb40
  4. 02 May, 2005 11 commits
  5. 01 May, 2005 3 commits
  6. 30 Apr, 2005 5 commits
    • unknown's avatar
      yassl changeset 2: · 07918c8c
      unknown authored
        remove FIX_GCC_LINKING_PROBLEM and -DDEFINE_CXA_PURE_VIRTUAL
        replace echo in configure.in with AC_MSG_WARN/AC_MSG_ERROR
        don't set -DUSE_MYSYS_NEW for gcc 2.95
        set $USE_MYSYS_NEW even if CXX is g++
        yassl bugfixes
        instantiate all yassl templates explicitly
      
      
      client/Makefile.am:
        mysqlbinlog as a c++ program may need my_new.cc (if CXX=gcc)
        no FIX_GCC_LINKING_PROBLEM anymore - it's in my_new.cc
      client/mysqladmin.cc:
        no FIX_GCC_LINKING_PROBLEM anymore - it's in my_new.cc
      client/mysqlbinlog.cc:
        no FIX_GCC_LINKING_PROBLEM anymore - it's in my_new.cc
      configure.in:
        echo should be AC_MSG_WARN or AC_MSG_ERROR
        don't set -DUSE_MYSYS_NEW for gcc 2.95 (to restore old behaviour)
        set $USE_MYSYS_NEW even if CXX is g++ (for yassl, as it can be linked with C programs)
        remove -DDEFINE_CXA_PURE_VIRTUAL - -DUSE_MYSYS_NEW is enough
      extra/yassl/mySTL/list.hpp:
        bugfixes
      extra/yassl/src/Makefile.am:
        no need to mess with CXXFLAGS anymore. Instantiate all templates explicitly
      extra/yassl/src/crypto_wrapper.cpp:
        instantiate templates explicitly
      extra/yassl/src/yassl_imp.cpp:
        instantiate templates explicitly
      extra/yassl/src/yassl_int.cpp:
        instantiate templates explicitly
      extra/yassl/taocrypt/include/runtime.hpp:
        use -DUSE_MYSYS_NEW not -DDEFINE_CXA_PURE_VIRTUAL
        assert in __cxa_pure_virtual
        remove dummy (and thus dangerous) __cxa_guard_acquire/__cxa_guard_release
      extra/yassl/taocrypt/src/Makefile.am:
        no need to mess with CXXFLAGS anymore. Instantiate all templates explicitly
      extra/yassl/taocrypt/src/integer.cpp:
        instantiate templates explicitly
      extra/yassl/taocrypt/src/rsa.cpp:
        instantiate templates explicitly
      include/my_global.h:
        no FIX_GCC_LINKING_PROBLEM anymore - it's in my_new.cc
      mysys/my_new.cc:
        no FIX_GCC_LINKING_PROBLEM anymore - it's in my_new.cc
      server-tools/instance-manager/command.cc:
        no FIX_GCC_LINKING_PROBLEM anymore - it's in my_new.cc
      sql/ha_blackhole.cc:
        typo fixed
      sql/ha_innodb.cc:
        warning fixed
      sql/item_func.cc:
        use LL()
      sql/mysqld.cc:
        no FIX_GCC_LINKING_PROBLEM anymore - it's in my_new.cc
      07918c8c
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · e5a05ffe
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-test-5.0
      
      
      sql/item.h:
        Auto merged
      e5a05ffe
    • unknown's avatar
      postreview changes · d617da7c
      unknown authored
      
      sql/item.cc:
        changed parameters order
      sql/item.h:
        changed parameters order
      sql/sql_base.cc:
        fixed comment
        changed parameters order
      d617da7c
    • unknown's avatar
      After merge fixes · 8d06dc45
      unknown authored
      
      Makefile.am:
        Added target test-force
      mysql-test/r/cast.result:
        Updated results after merge
      8d06dc45
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-5.0 · b94d7b5a
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-test-5.0
      
      b94d7b5a