An error occurred fetching the project authors.
  1. 01 Apr, 2009 1 commit
  2. 18 Feb, 2009 1 commit
  3. 25 Nov, 2008 1 commit
    • Build Team's avatar
      mysql-test/r/partition.result · d2c48167
      Build Team authored
      mysql-test/t/partition.test
      sql/ha_partition.cc
        Bug#40954: Crash in MyISAM index code with concurrency test using partitioned tables
        Problem was usage of read_range_first with an empty key.
        Solution was to not to give a key if it was empty. (real author Mattias Jonsson)
      
      storage/archive/archive_reader.c
      client/mysqlslap.c
        Aligned the copyright texts output from "--version" of tools, to
        let internal tools be able to change them if needed.
      
      storage/ndb/test/tools/connect.cpp
      storage/ndb/test/run-test/atrt.hpp
        Corrected a few GPL headers not restricted to GPL version 2
      
      Makefile.am
        Added missing --report-features to the 'test-bt-fast' target
      
      support-files/mysql.spec.sh
        Reversed the removal of the "%define license GPL" in as internal
        tools depended on it
      d2c48167
  4. 24 Nov, 2008 1 commit
  5. 13 Nov, 2008 1 commit
    • Sven Sandberg's avatar
      BUG#38350: Many tests don't clean up after themselves on exit. · 78a3abec
      Sven Sandberg authored
      Problem: Many test cases don't clean up after themselves (fail
      to drop tables or fail to reset variables). This implies that:
      (1) check-testcase in the new mtr that currently lives in
      5.1-rpl failed. (2) it may cause unexpected results in
      subsequent tests.
      Fix: make all tests clean up.
      Also: cleaned away unnecessary output in rpl_packet.result
      Also: fixed bug where rpl_log called RESET MASTER with a running
      slave. This is not supposed to work.
      Also: removed unnecessary code from rpl_stm_EE_err2 and made it
      verify that an error occurred.
      Also: removed unnecessary code from rpl_ndb_ctype_ucs2_def.
      78a3abec
  6. 05 Nov, 2008 1 commit
  7. 04 Nov, 2008 1 commit
  8. 06 Oct, 2008 2 commits
    • Alexey Botchkov's avatar
      Bug#38005 Partitions: error with insert select. · acdaa9ae
      Alexey Botchkov authored
      MyISAM blocks index usage for bulk insert into zero-records tables.
      See ha_myisam::start_bulk_insert() lines from
      ...
          if (file->state->records == 0 ...
      ...
      
      That causes problems for partition engine when some partitions have records some not
      as the engine uses same access method for all partitions.
      
      Now partition engine doesn't call index_first/index_last
      for empty tables.
      
      per-file comments:
        mysql-test/r/partition.result
              Bug#38005 Partitions: error with insert select.
              test result
      
        mysql-test/t/partition.test
              Bug#38005 Partitions: error with insert select.
              test case
      
        sql/ha_partition.cc
              Bug#38005 Partitions: error with insert select.
              ha_engine::index_first and
              ha_engine::index_last not called for empty tables.
      acdaa9ae
    • Alexey Botchkov's avatar
      Bug#38083 Error-causing row inserted into partitioned table despite error · a206d672
      Alexey Botchkov authored
            
          problems are located in the sql_partition.cc where functions calculation
          partition_id don't expect error returned from item->val_int().
          Fixed by adding checks to these functions.
          Note  - it tries to fix more problems than just the reported bug.
            
      per-file comments:
      modified:
        mysql-test/r/partition.result
          Bug#38083 Error-causing row inserted into partitioned table despite error
              test result
        mysql-test/t/partition.test
          Bug#38083 Error-causing row inserted into partitioned table despite error
              test case
        sql/opt_range.cc
          Bug#38083 Error-causing row inserted into partitioned table despite error
              get_part_id() call fixed
        sql/partition_info.h
          Bug#38083 Error-causing row inserted into partitioned table despite error
              get_subpart_id_func interface changed. 
        sql/sql_partition.cc
          Bug#38083 Error-causing row inserted into partitioned table despite error
              various functions calculationg partition_id and subpart_id didn't expect
                  an error returned from item->val_int().  Error checks added.
      a206d672
  9. 01 Sep, 2008 1 commit
  10. 15 Aug, 2008 1 commit
    • Chad MILLER's avatar
      Bug#38272: timestamps fields incorrectly defaulted on \ · 224ce48a
      Chad MILLER authored
      	update accross partitions.
            
      It's not Innodb-specific bug.
      ha_partition::update_row() didn't set
      table->timestamp_field_type= TIMESTAMP_NO_AUTO_SET when
      orig_timestamp_type == TIMESTAMP_AUTO_SET_ON_INSERT.
      
      So that a partition sets the timestamp field when a record
      is moved to a different partition.
      
      Fixed by doing '= TIMESTAMP_NO_AUTO_SET' unconditionally.
      Also ha_partition::write_row() is fixed in same way as now
      Field_timestamp::set() is called twice in SET_ON_INSERT case.
      
      (Chad queues this patch on demand by Trudy/Davi.)
      224ce48a
  11. 11 Aug, 2008 1 commit
    • Mattias Jonsson's avatar
      Bug#20129: ALTER TABLE ... REPAIR PARTITION ... complains that · 07e9a6dc
      Mattias Jonsson authored
      partition is corrupt
      
      The main problem was that ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR
      PARTITION took another code path (over mysql_alter_table instead of
      mysql_admin_table) which differs in two ways:
      1) alter table opens the tables in a different way than admin tables do
         resulting in returning with error before it tried the command
      2) alter table does not start to send any diagnostic rows to the client
         which the lower admin functions continue to use -> resulting in
         assertion crash
      
      The fix:
      Remapped ALTER TABLE t ANALYZE/CHECK/OPTIMIZE/REPAIR PARTITION to use
      the same code path as ANALYZE/CHECK/OPTIMIZE/REPAIR TABLE t.
      Adding check in mysql_admin_table to setup the partition list for
      which partitions that should be used.
      
      
      Partitioned tables will still not work with
      REPAIR TABLE/PARTITION USE_FRM, since that requires moving partitions
      to tables, REPAIR TABLE t USE_FRM, and check that the data still
      fulfills the partitioning function and then move the table back to
      being a partition.
      
      NOTE: I have removed the following functions from the handler
      interface:
      analyze_partitions, check_partitions, optimize_partitions,
      repair_partitions
      Since they are not longer needed.
      THIS ALTERS THE STORAGE ENGINE API
      07e9a6dc
  12. 07 Jul, 2008 1 commit
    • Mattias Jonsson's avatar
      Bug#35745: SELECT COUNT(*) is not correct for some partitioned tables. · c499df92
      Mattias Jonsson authored
      problem was that ha_partition::records was not implemented, thus
      using the default handler::records, which is not correct if the engine
      does not support HA_STATS_RECORDS_IS_EXACT.
      Solution was to implement ha_partition::records as a wrapper around
      the underlying partitions records.
      
      The rows column in explain partitions will now include the total
      number of records in the partitioned table.
      
      (recommit after removing out-commented code)
      c499df92
  13. 17 Jun, 2008 1 commit
    • Mattias Jonsson's avatar
      Bug#35931 Index search of partitioned MyISAM table · 3345a715
      Mattias Jonsson authored
      returns erroneous results
      
      Used the wrong function when fixing 30480 which lead to
      no stop on end_key resulting in duplicate results from index scan
      
      Includes test cases for the duplicates 37327 and 37329,
      Duplicate rows and bad performance/High Handler_read_next values
      
      Recommit after merge issues
      3345a715
  14. 03 Mar, 2008 2 commits
  15. 28 Feb, 2008 1 commit
  16. 25 Feb, 2008 1 commit
    • mattiasj@witty.'s avatar
      Post push fix · 2e3ed6a2
      mattiasj@witty. authored
      Fixed a missed case in the patch for Bug#31931.
      Also makes Bug#33722 a duplicate of Bug#31931.
      Added tests for better coverage.
      Replaced some legacy function calls.
      2e3ed6a2
  17. 11 Feb, 2008 1 commit
  18. 28 Jan, 2008 1 commit
  19. 09 Jan, 2008 1 commit
    • mattiasj@client-10-129-10-137.upp.off.mysql.com's avatar
      Bug#31931 Partitions: unjustified 'mix of handlers' error message · a6a97748
      Problem was that the mix of handlers was not consistent between
      CREATE and ALTER
      
      changed so that it works like:
          - All partitions must use the same engine
            AND it must be the same as the table.
          - if one does NOT specify an engine on the table level
            then one must either NOT specify any engine on any
            partition/subpartition OR for ALL partitions/subpartitions
      
      Note: that after a table have been created, the storage engine
      is specified for all parts of the table (table/partition/subpartition)
      and so when using alter, one does not need to specify it (unless one
      wants to change the storage engine, then one have to specify it on the
      table level)
      a6a97748
  20. 04 Jan, 2008 1 commit
    • mattiasj@witty.'s avatar
      Bug#30459 Partitioning across disks failing on Windows · 5d6a65bb
      mattiasj@witty. authored
      Problem was that there are no support for symlinked files on Windows for
      mysqld. So we fail when trying to create them.
      
      Solution: Ignore the DATA/INDEX DIRECTORY clause for partitions and push
      a warning. (Just like a MyISAM table)
      5d6a65bb
  21. 06 Dec, 2007 1 commit
  22. 28 Nov, 2007 1 commit
    • sergefp@mysql.com's avatar
      BUG#32772: partition crash 1: enum column · 7d6d808b
      sergefp@mysql.com authored
      The bug was that for ordered index scans, ha_partition::index_init() did
      not put index columns into table->read_set if the underlying storage 
      engine did not have HA_PARTIAL_COLUMN_READ flag. 
      This was causing assertion failure when handle_ordered_index_scan() tried
      to sort the records according to index order.
      
      Fixed by making ha_partition::index_init() put index columns into table->read_set
      for all ordered scans. 
      7d6d808b
  23. 27 Nov, 2007 1 commit
  24. 26 Nov, 2007 1 commit
    • ramil/ram@mysql.com/ramil.myoffice.izhnet.ru's avatar
      Fix for bug #29258: Partitions: search fails for maximum unsigned bigint · beff6193
      Problems: 
        1. looking for a matching partition we miss the fact that the maximum 
           allowed value is in the PARTITION p LESS THAN MAXVALUE.
        2. one can insert maximum value if numeric maximum value is the last range.
           (should only work if LESS THAN MAXVALUE).
        3. one cannot have both numeric maximum value and MAXVALUE string as ranges 
          (the same value, but different meanings).
      
      Fix: consider the maximum value as a supremum.
      beff6193
  25. 15 Nov, 2007 1 commit
  26. 14 Nov, 2007 1 commit
    • holyfoot/hf@mysql.com/hfmain.(none)'s avatar
      Bug #31890 Partitions: ORDER BY DESC in InnoDB not working. · a2f08506
      holyfoot/hf@mysql.com/hfmain.(none) authored
      It's not InnoDB specific bug.
      Error is in QUEUE code, about the way we handle queue->max_at_top.
      It's either '0' or '-2' and we do '^' operation to get the proper
      direction. Though queue->compare() function can return '-2' as
      a result of comparison sometimes. So we'll get
      queue->compare() ^ queue->max_at_top == 0 (when max_at_top is -2)
      and _downheap() function code will go wrong way here:
      ...
          if (next_index < elements &&
              (queue->compare(queue->first_cmp_arg,
                              queue->root[next_index]+offset_to_key,
                              queue->root[next_index+1]+offset_to_key) ^
               queue->max_at_top) > 0)
            next_index++;
      ...
      
      Fixed by changing max_at_top to be either 1 or -1, doing
      '* max_at_top' to get proper direction.
      a2f08506
  27. 12 Nov, 2007 2 commits
  28. 10 Nov, 2007 1 commit
  29. 31 Oct, 2007 1 commit
  30. 23 Oct, 2007 1 commit
    • mattiasj@mattiasj-laptop.(none)'s avatar
      Bug #30695: An apostrophe ' in the comment of the ADD PARTITION · f733ea5a
      mattiasj@mattiasj-laptop.(none) authored
        causes the Server to crash.
      
      Accessing partitioned table with an apostrophe in partition options
      like DATA DIRECTORY, INDEX DIRECTORY or COMMENT causes server crash.
      
      Partition options were saved in .frm file without escaping.
      When accessing such table it is not possible to properly restore
      partition information.
      Crashed because there was no check for partition info parser failure.
      
      Fixed by escaping quoted text in the partition info when writing it to
      the frm-file and added a check that it was able to parse the partition
      info before using it 
      
      NOTE: If the comment is written by an earlier version of the server,
      the corrupted frm-file is not fixed, but left corrupted, you have to
      manually drop the table and recreate it.
      f733ea5a
  31. 22 Oct, 2007 1 commit
    • mleich@four.local.lan's avatar
      This changeset contains the following stuff: · 51fd4937
      mleich@four.local.lan authored
      - Fix for
          Bug#28827 Partition test needs archive engine
          Bug#26669 Two tests on partition fail while blackhole engine is missing
        Solution: Move ARCHIVE and BLACKHOLE sub test cases to their own main test.
      - The two bugs above + the fact that CSV could be also sometimes not
        available --> Move also CSV sub tests out.
      - Minor cleanups
        - Replace error numbers with error names
        - fix typos, wrong comments
        - remove redundant sub test cases
        - add missing drop database
        - SET GLOBAL general_log = default is wrong, = 1 is correct
      51fd4937
  32. 17 Oct, 2007 1 commit
  33. 09 Oct, 2007 1 commit
  34. 04 Oct, 2007 1 commit
  35. 02 Jul, 2007 1 commit
  36. 08 Jun, 2007 1 commit
    • gkodinov/kgeorge@magare.gmz's avatar
      Bug #27816: Log tables ran with partitions crashes the server · 949d96f1
      gkodinov/kgeorge@magare.gmz authored
       when logging is enabled.
      Currently the partition engine doesn't allow log tables to
      be partitioned. But this was not checked and the server crashed.
      Fixed by adding a check in ALTER TABLE to disable partitioning the
      log tables.
      While working on the cause of the problem improved the way the log
      thread structures are initialized before opening the log tables.
      949d96f1
  37. 07 Jun, 2007 1 commit
    • ramil/ram@mysql.com/ramil.myoffice.izhnet.ru's avatar
      Fix for bug #28806: Running SHOW TABLE STATUS during high INSERT load crashes server · 46f68b22
      Problem: getting an autoincrement value for a partition table in the ::info() method we call
      the get_auto_increment() for all partitions. That may cause a problem for at least MyISAM
      tables that rely on some table state (in this particular case table->naxt_nuber_field is 
      set to 0 in the mysql_insert() and we get a crash). 
      Moreover, calling get_auto_increment() is superfluous there.
      
      Fix: use ::info(HA_STATUS_AUTO) calls to get autoincrement values for partitions instead of
      get_auto_increment() ones in the ha_partition::info().
      46f68b22