1. 28 Apr, 2007 4 commits
    • unknown's avatar
      Merge polly.local:/home/kaa/src/maint/bug24912/my51-bug24912 · a45dc9fc
      unknown authored
      into  polly.local:/home/kaa/src/maint/mysql-5.1-maint
      
      
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      a45dc9fc
    • unknown's avatar
      Merge polly.local:/home/kaa/src/maint/bug24912/my50-bug24912 · c3b410f1
      unknown authored
      into  polly.local:/home/kaa/src/maint/bug24912/my51-bug24912
      
      
      mysql-test/r/type_newdecimal.result:
        Auto merged
      mysql-test/t/func_math.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      mysql-test/r/func_math.result:
        Manual merge.
      sql/item_strfunc.cc:
        Manual merge.
      c3b410f1
    • unknown's avatar
      Fix for bug #24912 "problems with bigint in abs() ceiling() round() truncate()... · 67a74165
      unknown authored
      Fix for bug #24912 "problems with bigint in abs() ceiling() round() truncate() mod()" and a number of related problems:
      
      - unsigned flag was not handled correctly for a number of mathematical funcions, which led to incorrect results
      - passing large values as the number of decimals to ROUND() resulted in incorrect results and even server crashes in some cases
      - reverted the fix and the testcase for bug #10083 as it violates the manual
      - fixed some testcases which relied on broken ROUND() behavior
      
      
      mysql-test/r/func_math.result:
        - Removed the testcase for bug #10083 (not a bug according to the manual)
        - Changed the testcase for bug #9837 to expect a correct ROUND() behavior
        - Added testcases for bug #24912 and all related bugs found
      mysql-test/r/type_newdecimal.result:
        Fixed a truncate() testcase which relied on broken behavior
      mysql-test/t/func_math.test:
        - Removed the testcase for bug #10083 (not a bug according to the manual)
        - Changed the testcase for bug #9837 to expect a correct ROUND() behavior
        - Added testcases for bug #24912 and all related bugs found
      sql/item_func.cc:
        Various changes to fix bug #24912 and all related bugs found:
        - honor unsigned_flag in various Item_* functions
        - correctly handle out-of-range numbers of decimals in Item_func_round::fix_length_and_dec()
        - changed the argument specifying the number of decimals in my_double_round() from int to longlong, added a new argument to pass the 'unsigned flag'
        - changed my_double_round() to correctly handle large values passed as the 'number of decimals' argument
        - added a my_double_round() analog for BIGINT UNSIGNED arguments (my_unsigned_round())
        - fixed Item_func_round()::int_op() to not overflow even when the result is within integer range
        - fixed a bug Item_founc_round()::decimal_op() which resulted in crash when a large number of decimals was passed to my_decimal_round()
      sql/item_func.h:
        Various fixed to correctly handle unsigned values.
      sql/item_strfunc.cc:
        Changed the call to my_double_round() to match the new declaration.
      sql/mysql_priv.h:
        Changed the declaration for my_double_round() to be able pass arbitrary integers as number of decimals (both signed and unsigned)
      67a74165
    • unknown's avatar
      Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50 · 586b6744
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/51
      
      
      scripts/mysql_install_db.sh:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      586b6744
  2. 27 Apr, 2007 11 commits
  3. 26 Apr, 2007 21 commits
  4. 25 Apr, 2007 4 commits
    • unknown's avatar
      Add --symbolic-links=1 for partition_not_windows-master.opt. · d9a3f931
      unknown authored
      
      mysql-test/t/partition_not_windows-master.opt:
        BitKeeper file /benchmarks/ext3/TOSAVE/tsmith/bk/maint/51/mysql-test/t/partition_not_windows-master.opt
      mysql-test/t/partition_not_windows.test:
        Tweak comments to be more meaningful
      d9a3f931
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build · 1596f9b3
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      
      mysql-test/t/sp.test:
        Auto merged
      1596f9b3
    • unknown's avatar
      Fix test case that was broken for builds without InnoDB. · 180a7f72
      unknown authored
      ```yaml
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build-work-vanilla-building
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build-work-vanilla-building
      ```
      
      Fix test cases to pass for a plain ./configure && make build. This includes disabling two test cases when certain features are not present in the server. We're not losing coverage from this because these features are usually present, and disabling them here only serves the purpose to make the test cases work in the unlikely case that they aren't.
      ---
      fixes
      
      
      mysql-test/extra/rpl_tests/rpl_extraSlave_Col.test:
        Disable this test case if we don't have partitioning
      mysql-test/t/rpl_row_basic_11bugs.test:
        Disable warnings in a number of places to make this test case work with servers that don't contain InnoDB
        ---
        make test case look better on request from reviewer
      mysql-test/t/rpl_row_mysqlbinlog.test:
        Disable this test case if the server does not have cp932 compiled in
      mysql-test/t/sp.test:
        Disable warnings during table creation in one place where engine=innodb is used, in order to make this test case work with a mysqld that was compiled without InnoDB.
      180a7f72
    • unknown's avatar
      Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50 · ea798571
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/51
      
      ea798571