1. 26 Oct, 2007 1 commit
    • unknown's avatar
      Bug#31662: 'null' is shown as type of fields for view with bad definer, breaks mysqldump · a4698b61
      unknown authored
      SHOW FIELDS FROM a view with no valid definer was possible (since fix
      for Bug#26817), but gave NULL as a field-type. This led to mysqldump-ing
      of such views being successful, but loading such a dump with the client
      failing. Patch allows SHOW FIELDS to give data-type of field in underlying
      table.
      
      
      mysql-test/r/information_schema_db.result:
        Fix test results: SHOW FIELDS FROM a view with no valid DEFINER
        gives us the field-type of the underlying table now rather than NULL.
      sql/sql_base.cc:
        In the case of SHOW FIELDS FROM <view>, do not require a valid
        DEFINER for determining underlying data-type like we usually do.
        This is needed for mysqldump.
      a4698b61
  2. 22 Oct, 2007 2 commits
  3. 21 Oct, 2007 3 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · a830e128
      unknown authored
      into  mysql.com:/scratch/tnurnberg/31588/50-31588
      
      a830e128
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug28550/my50-bug28550 · 570e20bc
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      570e20bc
    • unknown's avatar
      Bug #28550 "Potential bugs related to the return type of the CHAR function". · 0ca57427
      unknown authored
        
      Since, as of MySQL 5.0.15, CHAR() arguments larger than 255 are converted into multiple result bytes, a single CHAR() argument can now take up to 4 bytes. This patch fixes Item_func_char::fix_length_and_dec() to take this into account.
        
      This patch also fixes a regression introduced by the patch for bug21513. As now we do not always have the 'name' member of Item set for Item_hex_string and Item_bin_string, an own print() method has been added to Item_hex_string so that it could correctly be printed by Item_func::print_args().
      
      
      mysql-test/r/func_str.result:
        Import patch bug288550.patch
      mysql-test/t/func_str.test:
        Import patch bug288550.patch
      sql/item.cc:
        Import patch bug288550.patch
      sql/item.h:
        Import patch bug288550.patch
      sql/item_strfunc.h:
        Import patch bug288550.patch
      0ca57427
  4. 18 Oct, 2007 6 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 1de2823a
      unknown authored
      into  mysql.com:/scratch/tnurnberg/31588/50-31588
      
      1de2823a
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b6b71948
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31221-5.0-opt
      
      b6b71948
    • unknown's avatar
      Bug #31221: Optimizer incorrectly identifies impossible WHERE clause · 78fa5c3a
      unknown authored
       No warning was generated when a TIMESTAMP with a non-zero time part
       was converted to a DATE value. This caused index lookup to assume
       that this is a valid conversion and was returning rows that match 
       a comparison between a TIMESTAMP value and a DATE keypart.
       Fixed by generating a warning on such a truncation.
      
      
      mysql-test/r/derived.result:
        Bug #31221: fixed an existing not-precise test case
      mysql-test/r/ps_2myisam.result:
        Bug #31221: Warnings cased by existing tests
      mysql-test/r/ps_3innodb.result:
        Bug #31221: Warnings cased by existing tests
      mysql-test/r/ps_4heap.result:
        Bug #31221: Warnings cased by existing tests
      mysql-test/r/ps_5merge.result:
        Bug #31221: Warnings cased by existing tests
      mysql-test/r/ps_6bdb.result:
        Bug #31221: Warnings cased by existing tests
      mysql-test/r/ps_7ndb.result:
        Bug #31221: Warnings cased by existing tests
      mysql-test/r/type_date.result:
        Bug #31221: Warnings cased by existing tests
      mysql-test/r/type_datetime.result:
        Bug #31221: test case
      mysql-test/t/derived.test:
        Bug #31221: fixed an existing not-precise test case
      mysql-test/t/type_date.test:
        Bug #31221: test case
      sql/field.cc:
        Bug #31221: 
         - Upgraded fix for bug 29729
         - issue a warning only if the hh:mm:ss.msec is not zero consistently 
           for all the Field_newdate::store function
      sql/item_timefunc.cc:
        Bug #31221: don't ignore the errors when storing data
      78fa5c3a
    • unknown's avatar
      Bug #30638 why doesn't > 4294967295 rows work in myisam on windows. · f42094c0
      unknown authored
      The BIG_TABLES define wasn't enabled on Windows.
      #define added
      
      
      include/config-win.h:
        Bug #30638 why doesn't > 4294967295 rows work in myisam on windows.
        
        BIG_TABLES enabled on Windows
      f42094c0
    • unknown's avatar
      Merge sin.intern.azundris.com:/misc/mysql/31588/41-31588 · e72a5397
      unknown authored
      into  sin.intern.azundris.com:/misc/mysql/31588/50-31588
      
      
      sql/set_var.cc:
        Auto merged
      mysql-test/r/variables.result:
        SCCS merged
      mysql-test/t/variables.test:
        SCCS merged
      e72a5397
    • unknown's avatar
      Bug#31588: buffer overrun when setting variables · 52162bd3
      unknown authored
      Buffer used when setting variables was not dimensioned to accomodate
      trailing '\0'. An overflow by one character was therefore possible.
      CS corrects limits to prevent such overflows.
      
      
      mysql-test/r/variables.result:
        Try to overflow buffer used for setting system variables.
        Unpatched server should throw a valgrind warning here.
        Actual value and error message irrelevant, only length counts.
      mysql-test/t/variables.test:
        Try to overflow buffer used for setting system variables.
      sql/set_var.cc:
        Adjust maximum number of characters we can store in 'buff' by one
        as strmake() will write a terminating '\0'.
      52162bd3
  5. 17 Oct, 2007 1 commit
  6. 16 Oct, 2007 1 commit
  7. 15 Oct, 2007 3 commits
    • unknown's avatar
      Bug#30986 Character set introducer followed by a HEX string can return bad result(addon) · 2024dedb
      unknown authored
      issue an error if string has illegal characters
      
      
      mysql-test/r/ctype_utf8.result:
        issue an error if string has illegal characters
      mysql-test/t/ctype_utf8.test:
        issue an error if string has illegal characters
      sql/item.cc:
        issue an error if string has illegal characters
      sql/item.h:
        issue an error if string has illegal characters
      sql/sql_yacc.yy:
        issue an error if string has illegal characters
      2024dedb
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/PA/5.0-opt-31019 · fae5f532
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      fae5f532
    • unknown's avatar
      bug #29801 Federated engine crashes local server · 1376b2ef
      unknown authored
                     if remote server sends malicious response.
      
      We need to check if the SHOW TABLE STATUS query we issue inside the
      FEDERATED engine returned the result with the proper (or just sufficient)
      number of rows. Otherwise statements like row[12] can crash the server.
      
      
      sql/ha_federated.cc:
        bug #29801 Federated engine crashes local server
                       if remote server sends malicious response.
        
        Return with the error if the remote server return fewer rows than we need.
      1376b2ef
  8. 14 Oct, 2007 1 commit
    • unknown's avatar
      item_sum.cc: · e2fa4b6e
      unknown authored
        Fixed dbug macros usage errors
      
      
      sql/item_sum.cc:
        Fixed dbug macros usage errors
      e2fa4b6e
  9. 13 Oct, 2007 2 commits
  10. 12 Oct, 2007 3 commits
  11. 11 Oct, 2007 3 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/PA/5.0-opt-31471 · 5bf0a2ec
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      5bf0a2ec
    • unknown's avatar
      Bug#30981 CHAR(0x41 USING ucs2) doesn't add leading zero · 835746d0
      unknown authored
      Bug#30982 CHAR(..USING..) can return a not-well-formed string
      Bug#30986 Character set introducer followed by a HEX string can return bad result
      check_well_formed_result moved to Item from Item_str_func
      fixed Item_func_char::val_str for proper ucs symbols converting
      added check for well formed strings for correct conversion of constants with underscore
      charset
      
      
      mysql-test/r/ctype_ucs.result:
        test result
      mysql-test/r/ctype_utf8.result:
        test result
      mysql-test/t/ctype_ucs.test:
        test case
      mysql-test/t/ctype_utf8.test:
        test case
      sql/item.cc:
        check_well_formed_result() moved from Item_str_func
      sql/item.h:
        check_well_formed_result() moved from Item_str_func
      sql/item_strfunc.cc:
        check_well_formed_result moved to Item
        fixed Item_func_char::val_str for proper ucs symbols converting
      sql/item_strfunc.h:
        check_well_formed_result moved to Item
      sql/sql_yacc.yy:
        added check for well formed string
      835746d0
    • unknown's avatar
      Bug #31440: 'select 1 regex null' asserts debug server · 6bae70ba
      unknown authored
      The special case with NULL as a regular expression
      was handled at prepare time. But in this special case
      the item was not marked as fixed. This caused an assertion
      at execution time.
      Fixed my marking the item as fixed even when known to 
      return NULL at prepare time.
      
      
      mysql-test/r/func_regexp.result:
        Bug #31440: test case
      mysql-test/t/func_regexp.test:
        Bug #31440: test case
      sql/item_cmpfunc.cc:
        Bug #31440: mark the item as fixed even when 
        known to return NULL.
      6bae70ba
  12. 10 Oct, 2007 4 commits
    • unknown's avatar
      Fixed bug #31471: decimal_bin_size: Assertion `scale >= 0 && · f23d0bc7
      unknown authored
                        precision > 0 && scale <= precision'.
      
      A sign of a resulting item of the IFNULL function was not
      updated and the maximal length of this result was calculated
      improperly. Correct algorithm was copy&pasted from the IF
      function implementation.
      
      
      sql/item_cmpfunc.cc:
        Fixed bug #31471.
        The Item_func_ifnull::fix_length_and_dec method has been
        modified to update the Item_func_ifnull::unsigned_flag field
        and to take this field into account when calculating the
        Item_func_ifnull::max_length value.
        (See Item_func_if::fix_length_and_dec for reference).
      mysql-test/t/null.test:
        Added test case for bug #31471.
      mysql-test/r/null.result:
        Added test case for bug #31471.
      mysql-test/r/create.result:
        Update test case after the bugfix of bug #31471.
      f23d0bc7
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · d20c3355
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      libmysql/libmysql.c:
        Auto merged
      d20c3355
    • unknown's avatar
      Bug#28893 --relay-log variable is not exposed with SHOW VARIABLES · 8c53b726
      unknown authored
      added variables relay_log, relay_log_index, relay_log_info_file to init_vars[]
      to make them visible within SHOW VARIABLES
      
      
      mysql-test/r/rpl_flush_log_loop.result:
        test result
      mysql-test/t/rpl_flush_log_loop.test:
        test case
      sql/set_var.cc:
        added variables relay_log, relay_log_index, relay_log_info_file to init_vars[]
        to make them visible within SHOW VARIABLES
      8c53b726
    • unknown's avatar
      Bug#25359 Test 'view' is dependent on current year to be 2006 · e2ef1cfd
      unknown authored
      removed now() call to make the test to be year independent
      
      
      mysql-test/r/view.result:
        result fix
      mysql-test/t/view.test:
        removed now() call to make the test to be year independent
      e2ef1cfd
  13. 09 Oct, 2007 5 commits
  14. 08 Oct, 2007 1 commit
    • unknown's avatar
      Bug #31156: mysqld: item_sum.cc:918: virtual bool · 7b85689a
      unknown authored
        Item_sum_distinct::setup(THD*): Assertion
      
      There was an assertion to detect a bug in ROLLUP
      implementation. However the assertion is not true
      when used in a subquery context with non-cacheable
      statements.
      Fixed by turning the assertion to accepted case
      (just like it's done for the other aggregate functions). 
      
      
      mysql-test/r/func_group.result:
        Bug #31156: test case
      mysql-test/t/func_group.test:
        Bug #31156: test case
      sql/item_sum.cc:
        Bug #31156: make it OK to call setup() several times:
         done for (e.g.) scalar subquery
      7b85689a
  15. 07 Oct, 2007 1 commit
    • unknown's avatar
      Fixed bug #31019: the MOD() function and the % operator crash the server · 91dc1bb9
      unknown authored
      when a divisor is less than 1 and its fractional part is very long.
      For example:
      1 % .123456789123456789123456789123456789123456789123456789123456789123456789123456789;
      
      Stack buffer overflow has been fixed in the do_div_mod function.
      
      
      strings/decimal.c:
        Fixed bug #31019.
        Stack buffer overflow has been fixed in the do_div_mod function:
        a value of the upper bound of the buffer was increased where
        a decrement is required.
      mysql-test/t/type_decimal.test:
        Added test case for bug #31019.
      mysql-test/r/type_decimal.result:
        Added test case for bug #31019.
      91dc1bb9
  16. 05 Oct, 2007 3 commits