1. 09 Oct, 2007 4 commits
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · a4ed5f59
      unknown authored
      into  mysql.com:/home/ram/work/b31249/b31249.5.0
      
      
      mysql-test/r/type_datetime.result:
        manual merge
      mysql-test/t/type_datetime.test:
        manual merge
      a4ed5f59
    • unknown's avatar
      Fix for bug #31249: Assertion `!table || (!table->write_set || · 0602a4fe
      unknown authored
      bitmap_is_set(table->write_set, fiel
      
      Problem: creating a temporary table we allocate the group buffer if needed
      followed by table bitmaps (see create_tmp_table()). Reserving less memory for 
      the group buffer than actually needed (used) for values retrieval may lead 
      to overlapping with followed bitmaps in the memory pool that in turn leads 
      to unpredictable consequences.
      
      As we use Item->max_length sometimes to calculate group buffer size,
      it must be set to proper value. In this particular case 
      Item_datetime_typecast::max_length is too small.
      
      Another problem is that we use max_length to calculate the group buffer
      key length for items represented as DATE/TIME fields which is superfluous.
      
      Fix: set Item_datetime_typecast::max_length properly,
      accurately calculate the group buffer key length for items 
      represented as DATE/TIME fields in the buffer.
      
      
      mysql-test/r/type_datetime.result:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - test result.
      mysql-test/t/type_datetime.test:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - test case.
      sql/item_timefunc.h:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - set Item_datetime_typecast::max_length properly.
      sql/sql_select.cc:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - the group buffer key length for items represented as 
        DATE/TIME fields in the buffer should be calculated using
        the maximum pack length of such fields (== 8), using 
        max_length here is redundant.
      0602a4fe
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · edc809c5
      unknown authored
      into  alf.(none):/src/bug28774/my50-bug28774
      
      edc809c5
    • unknown's avatar
      Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and · 36773be2
      unknown authored
      doesn't clean them up
      - Make sure to cleanup temporary files after use.
      
      
      client/mysql_upgrade.c:
        Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and 
        doesn't clean them up
        - Close file handle and delete temporary file when write fails.
      36773be2
  2. 06 Oct, 2007 1 commit
  3. 05 Oct, 2007 12 commits
  4. 04 Oct, 2007 11 commits
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · ad379957
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/30444/50-30444
      
      ad379957
    • unknown's avatar
      Merge ssh://bk-internal.mysql.com//home/bk/mysql-5.0-maint · 3cee940f
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.0-maint
      
      3cee940f
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/maint/bug5731/my50-bug5731 · 1d2d4498
      unknown authored
      into  polly.(none):/home/kaa/src/maint/mysql-5.0-maint
      
      1d2d4498
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 92070942
      unknown authored
      into  mysql.com:/home/ram/work/b31070/b31070.5.0
      
      92070942
    • unknown's avatar
      Issue a warning if a user sets an option or a variable to a value that is... · 42816b97
      unknown authored
      Issue a warning if a user sets an option or a variable to a value that is greater than a defined maximum for the option/variable.
      
      This is for bug #29446 "Specifying a myisam_sort_buffer > 4GB on 64 bit machines not possible". Support for myisam_sort_buffer_size > 4 GB on 64-bit Windows will be looked at later in 5.2.
      
      
      mysql-test/r/variables.result:
        Fixed the test.
      mysql-test/t/variables.test:
        Fixed the test.
      mysys/my_getopt.c:
        Print a warning to the error log if a user sets an option to a value greater than the option's maximum value.
      sql/set_var.cc:
        Issue an SQL warning if a user assignes a value greater than the variable's maximum value.
      42816b97
    • unknown's avatar
      merging: results adjusted · 42c905e4
      unknown authored
      42c905e4
    • unknown's avatar
      Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 36f6e447
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/30444/50-30444
      
      
      client/mysqldump.c:
        Auto merged
      36f6e447
    • unknown's avatar
      Merge sin.intern.azundris.com:/home/tnurnberg/30444/41-30444 · f37fc544
      unknown authored
      into  sin.intern.azundris.com:/home/tnurnberg/30444/50-30444
      
      
      client/mysqldump.c:
        Auto merged
      f37fc544
    • unknown's avatar
      Bug #30444: 5.0 mysqldump silently allows wrong backup to be taken against a 4.0 database · 805561e4
      unknown authored
      The combination of --single-transaction and --master-data requires
      START TRANSACTION WITH CONSISTENT SNAPSHOT which is available from
      mysqld 4.1 on. When trying this against an older server, print
      diagnostic, then, if --force is not given, abort.
      
      No test-case given since it would require a mysqld < 4.1.
      
      
      client/mysqldump.c:
        Bug #30444: 5.0 mysqldump silently allows wrong backup to be taken against a 4.0 database
        
        The combination of --single-transaction and --master-data requires
        START TRANSACTION WITH CONSISTENT SNAPSHOT which is available from
        mysqld 4.1 on. When trying this against an older server, print
        diagnostic, then, if --force is not given, abort.
      805561e4
    • unknown's avatar
      Merge mysql.com:/home/ram/work/b31070/b31070.4.1 · 6c4a485e
      unknown authored
      into  mysql.com:/home/ram/work/b31070/b31070.5.0
      
      
      mysql-test/r/ctype_big5.result:
        Auto merged
      mysql-test/r/ctype_gbk.result:
        Auto merged
      mysql-test/r/ctype_uca.result:
        Auto merged
      strings/ctype-big5.c:
        Auto merged
      strings/ctype-euc_kr.c:
        Auto merged
      strings/ctype-gb2312.c:
        Auto merged
      strings/ctype-sjis.c:
        Auto merged
      BitKeeper/deleted/.del-ctype-cp932.c:
        Auto merged
      6c4a485e
    • unknown's avatar
      Fix for bug #31069: crash in 'sounds like' · b889488a
      unknown authored
      and for bug #31070: crash during conversion of charsets
      
      Problem: passing a 0 byte length string to some my_mb_wc_XXX() 
      functions leads to server crash due to improper argument check.
      
      Fix: properly check arguments passed to my_mb_wc_XXX() functions.
      
      
      mysql-test/include/ctype_common.inc:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test case.
      mysql-test/r/ctype_big5.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      mysql-test/r/ctype_euckr.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      mysql-test/r/ctype_gb2312.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      mysql-test/r/ctype_gbk.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      mysql-test/r/ctype_uca.result:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - test result.
      strings/ctype-big5.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      strings/ctype-cp932.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      strings/ctype-euc_kr.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      strings/ctype-gb2312.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      strings/ctype-sjis.c:
        Fix for bug #31069: crash in 'sounds like'
        and bug #31070: crash during conversion of charsets
          - check the string length before testing its first byte.
      b889488a
  5. 03 Oct, 2007 1 commit
  6. 02 Oct, 2007 5 commits
  7. 28 Sep, 2007 1 commit
  8. 27 Sep, 2007 2 commits
  9. 26 Sep, 2007 2 commits
  10. 25 Sep, 2007 1 commit