1. 25 Feb, 2020 4 commits
    • Sergei Petrunia's avatar
      Better comments · a662cb9b
      Sergei Petrunia authored
      a662cb9b
    • Igor Babaev's avatar
      MDEV-21554 Crash in JOIN_CACHE_BKAH::skip_index_tuple when mrr=on and · cfa0506f
      Igor Babaev authored
                 join_cache_level=6+
      
      The patch fixes two similar bugs in the commit 8eeb689e
      that added multi_range_read support to partitions. The commit opened
      a possibility to join a partition table using BKA+MRR. However in some
      cases it could lead to wrong results or even crashes.
      
      This could happened when
      - index condition pushdown was used to join the table or
      - the joined table was an inner table of an outer join and 'not exist'
        optimization was applied or
      - the join table was the inner table of a semi-join and the first match
        optimization was applied
      
      The bugs were in the code of the call-back functions
      - partition_multi_range_key_skip_record() and
      - partition_multi_range_key_skip_index_tuple().
      Each of this function consist only of an invocation of another function.
      Yet a wrong parameter was passed at this invocation.
      
      The fix was suggested by Sergey Petrunia and it is apparently in line
      with original design.
      The corresponding comprehensive test cases demonstrating the problems
      caused by the bugs were constructed by me.
      cfa0506f
    • Daniel Black's avatar
      MDEV-16662: cmake remove empty INSTALL_DEBUG_TARGET · f6b9a298
      Daniel Black authored
      No adverse effects since this was made a null function in
      6b53f9d7.
      
      This function had the last remaining cmake CMP0026 violation.
      f6b9a298
    • Daniel Black's avatar
      MDEV-16662: cmake: CMP0026 compatible for dtrace · c749eb2b
      Daniel Black authored
      cmake enabling -DENABLE_DTRACE=ON is particularlly noisy with CMP0026
      errors.
      
      Fixed in the same way as 6b53f9d7
      c749eb2b
  2. 19 Feb, 2020 1 commit
    • Sergei Petrunia's avatar
      MDEV-21628: Index condition pushdown condition ... not used with BKA · affe7fab
      Sergei Petrunia authored
      (Backport to 10.3)
      Partitioning storage now supports MRR but doesn't support Index Condition
      Pushdown (aka ICP). This causes counter-intuitive query plans for queries
      that use BKA and conditions that depend on index fields:
      - If the condition refers to other tables, BKA's variant of ICP is used
         to handle it.
      - If the condition depends on this table only, the optimizer will try to
        use regular ICP for it, which will fail because the storage engine
        doesn't support ICP.
      
      Make the optimizer be smarter in the second case: if we were not able to
      use regular ICP, use BKA's variant of ICP..
      affe7fab
  3. 13 Feb, 2020 2 commits
    • Otto Kekäläinen's avatar
      Deb: Run 'wrap-and-sort -a' so comparison across releases is easier · 85d4a45d
      Otto Kekäläinen authored
      No functional changes.
      
      Apply this in 10.3 so eventually it is merged to 10.4 and 10.5, which
      in turn will have separate wrap-and-sort runs but only for new lines,
      and not affecting badly next merges from 10.3 to 10.4 to 10.5.
      
      Also remove a duplicate line that was found thanks to wrap-and-sort.
      85d4a45d
    • Otto Kekäläinen's avatar
      Deb: Remove unnecessary manual libzstd1 dependency from RocksDB plugin · 1f0e72f8
      Otto Kekäläinen authored
      The Debian build tools add all run-time dependencies automatically. For the
      mariadb-rocksdb-plugin the "${misc:Depends}, ${shlibs:Depends}" will become
      (based on the build dependencies at build time):
      
        Depends: mariadb-server-10.4 (= 1:10.4.12-1), rocksdb-tools,
        libc6 (>= 2.29), liblz4-1 (>= 0.0~r130), libsnappy1v5 (>= 1.1.8),
        libstdc++6 (>= 7), libzstd1 (>= 1.3.3), zlib1g (>= 1:1.1.4)
      
      There is no need to manually add run-time build dependencies. Only external
      dependencies need to be defined, for example rocksdb-tools could come in
      question for mariadb-plugin-rocksdb, and it will be eventually added when
      downstream official Debian packaging is merged upstream in a later commit.
      1f0e72f8
  4. 10 Feb, 2020 5 commits
  5. 09 Feb, 2020 4 commits
  6. 08 Feb, 2020 2 commits
  7. 07 Feb, 2020 4 commits
  8. 06 Feb, 2020 3 commits
  9. 05 Feb, 2020 2 commits
  10. 04 Feb, 2020 1 commit
  11. 03 Feb, 2020 2 commits
    • Marko Mäkelä's avatar
      Cleanup: Remove mem_block_t::magic_n and mem_block_validate() · a9d13248
      Marko Mäkelä authored
      Use of freed memory is better caught by AddressSanitizer,
      especially with ASAN_POISON_MEMORY_REGION that is aliased
      by MEM_NOACCESS and UNIV_MEM_FREE.
      a9d13248
    • Marko Mäkelä's avatar
      MDEV-21636 information_schema.innodb_mutexes.name column is not populated · 37b9734c
      Marko Mäkelä authored
      The column INFORMATION_SCHEMA.INNODB_MUTEXES.NAME is not populated ever since
      commit 2e814d47 applied the InnoDB changes from
      MySQL 5.7.9 to MariaDB Server 10.2.2.
      
      Since the same commit, the view is only providing information about
      rw_lock_t, not any mutexes.
      
      For now, let us convert the source code file name and line number of
      the rw_lock_t creation into a name. A better option in the future might
      be to store the information somewhere where it can be looked up by
      mysql_pfs_key_t, and possibly to remove the CREATE_FILE and CREATE_LINE
      columns.
      37b9734c
  12. 02 Feb, 2020 5 commits
  13. 31 Jan, 2020 5 commits