1. 29 Sep, 2011 1 commit
  2. 05 Oct, 2011 7 commits
  3. 04 Oct, 2011 4 commits
    • unknown's avatar
      Fix bug lp:856152 · b17c4d3e
      unknown authored
      Analysis:
      The cause of the bug was that the method
      subselect_rowid_merge_engine::partial_match()
      was not designed for re-execution within the
      same query. Specifically, it didn't cleanup
      the bitmap of matching keys after completion.
      
      The test query requires double execution of
      the IN predicate because it first checks the
      predicate as a constant condition. The second
      execution during regular execution used the bitmap
      of matching keys produced by the first execution
      instead of starting with a clean one.
      
      Solution:
      Cleanup the bitmap of matching keys at the end of
      the partial matching procedure.
      
      b17c4d3e
    • Igor Babaev's avatar
      Made the result test of a test case platform independent · 72d05ac6
      Igor Babaev authored
      (correction for the previous patch).
      72d05ac6
    • Igor Babaev's avatar
      76d19527
    • Igor Babaev's avatar
      Fixed a bad merge. · fad504c4
      Igor Babaev authored
      Changed a test case to make its result set platform independent.
      fad504c4
  4. 03 Oct, 2011 4 commits
    • Igor Babaev's avatar
      Merge. · 58f36606
      Igor Babaev authored
      58f36606
    • Sergey Petrunya's avatar
      Merge · e9b97ef7
      Sergey Petrunya authored
      e9b97ef7
    • Sergey Petrunya's avatar
      Fix buildbot failure in previous fix (BUG#861147): · 70297fee
      Sergey Petrunya authored
      - convert_subq_to_jtbm() should always restore the used arena.
      
      70297fee
    • unknown's avatar
      Fix bug lp:858038 · c0e18a3d
      unknown authored
      Analysis:
      The cause of the bug was the changed meaning of
      subselect_partial_match_engine::has_covering_null_row.
      Previously it meant that there is row with NULLs in
      all nullable fields of the materialized subquery table.
      Later it was changed to mean a row with NULLs in all
      fields of this table.
      
      At the same time there was a shortcut in
      subselect_rowid_merge_engine::partial_match() that
      detected a special case where:
      - there is no match in any of the columns with NULLs, and
      - there is no NULL-only row that covers all columns with
        NULLs.
      With the change in the meaning of has_covering_null_row,
      the condition that detected this special case was incomplete.
      This resulted in an incorrect FALSE, when the result was a
      partial match.
      
      Solution:
      Expand the condition that detected the special case with the
      correct test for the existence of a row with NULL values in
      all columns that contain NULLs (a kind of parially covering
      NULL-row).
      c0e18a3d
  5. 01 Oct, 2011 2 commits
  6. 30 Sep, 2011 4 commits
    • Sergey Petrunya's avatar
      Merge · 7ae79ac9
      Sergey Petrunya authored
      7ae79ac9
    • Sergey Petrunya's avatar
      BUG#861147: Assertion `fixed == 1' failed in Item_func_eq::val_int() with... · 9fd37efb
      Sergey Petrunya authored
      BUG#861147: Assertion `fixed == 1' failed in Item_func_eq::val_int() with semijoin + materialization
      - convert_subq_to_jtbm() didn't check that subuqery optimization was successful. If it wasn't (in this
        example because of @@max_join_size violation), it would proceed further and eventually crash when 
        trying to execute the un-optimized subquery.
      9fd37efb
    • Sergey Petrunya's avatar
      Merge · 440a803c
      Sergey Petrunya authored
      440a803c
    • Sergey Petrunya's avatar
      BUG#860553: Crash in create_ref_for_key with semijoin + materialization · 6e236b7b
      Sergey Petrunya authored
      - The problem was that JOIN::save/restore_query_plan() did not save/restore parts of 
        the query plan that are located inside SJ_MATERIALIZATION_INFO structures. This could
        cause parts of one plan to be used with another, which led get_best_combination() to
        constructing non-sensical join plans (and crash).
        Fixed by saving/restoring SJM parts of the query plans.
      
      - check_and_do_in_subquery_rewrites() will not set SUBS_MATERIALIZATION flag when it 
        records that the subquery predicate is to be converted into semi-join. 
        If convert_join_subqueries_to_semijoins() later decides not to convert to semi-join,
        let it set SUBS_MATERIALIZATION flag, if appropriate.
      6e236b7b
  7. 29 Sep, 2011 3 commits
    • Sergey Petrunya's avatar
      Merge · 2c120604
      Sergey Petrunya authored
      2c120604
    • Sergey Petrunya's avatar
      BUG#860535: Assertion `keypart_map' failed in mi_rkey with semijoin · 828891e4
      Sergey Petrunya authored
      - are_tables_local() failed to recognize the fact that OUTER_REF_TABLE_BIT is ok 
        for SJ-Materialization. This caused zero-length ref access to be constructed, which
        led to an assert.
      828891e4
    • Vladislav Vaintroub's avatar
      Fix test suite: · c217fd6a
      Vladislav Vaintroub authored
      on Windows, kill <connection> can and almost always will return client error 2013 ("Lost connection...") on the killed connection,
      On the server side, if connection is "sleeping" KILL will close the socket, thus  socket error on client is expected.
      c217fd6a
  8. 28 Sep, 2011 3 commits
    • unknown's avatar
      Fix bug lp:858148. · 2bed41d4
      unknown authored
      Analysis:
      The crash is a result of the same cause as all similar
      bugs (lp:827416, lp:718763, lp:778413, lp:806943,
      lp:611690). The general pattern is that some optimization
      requires the evaluation of some condition (e.g. the WHERE
      clause), and this condition contains a subquery, such that
      the subquery itself requires a temporary table for its
      execution. During the subquery execution the original
      tables in the FROM clause are replaced by the temporary
      table needed for the final GROUP or ORDER operation. All
      this happens during optimization of the outer query. Later
      when EXPLAIN is run for the subquery, explain attempts to
      print the name of the tables in the FROM clause, but it
      finds there a temporary table without a corresponding
      TABLE_LIST object. The attempt to print the name of a
      NULL table list results in a crash.
      
      Solution:
      This patch extends the fix to bug lp:702301, and dissalows
      constant substitution of aggregate functions if the filter
      condition used to check MIN/MAX keys is an expensive condition.
      2bed41d4
    • Sergey Petrunya's avatar
      Merge · e1923e7f
      Sergey Petrunya authored
      e1923e7f
    • Sergey Petrunya's avatar
      BUG#860300: Second crash with get_fanout_with_deps() with semijoin + materialization · bccfb3d2
      Sergey Petrunya authored
      - Make get_post_group_estimate() take into account semi-join materialization nests.
      bccfb3d2
  9. 27 Sep, 2011 1 commit
  10. 26 Sep, 2011 4 commits
    • Michael Widenius's avatar
      Automatic merge · 068a2cf9
      Michael Widenius authored
      068a2cf9
    • Michael Widenius's avatar
      Allow one to block an account by using GRANT max_user_connections = -1 · 88b03b95
      Michael Widenius authored
      One can set @@global.max_user_connections to -1 to block anyone, except SUPER user, to login.
      If max_user_connection is 0, one can't change it without a restart (needed to get user connections counting to work correctly)
      
      
      mysql-test/r/system_mysql_db.result:
        Changed max_user_connections to handle negative numbers.
      mysql-test/r/user_limits-2.result:
        New test case that one can't change max_user_connection if it was 0
      mysql-test/r/user_limits.result:
        Fixed wrong error messages.
      mysql-test/r/variables.result:
        Store / restore max_user_connections (needed as there is now a --master.opt file that changes it)
      mysql-test/t/subselect_mat_cost-master.opt:
        Enable slow query log (as this test found some errors in slow query logging)
      mysql-test/t/user_limits-2.test:
        New test case that one can't change max_user_connection if it was 0
      mysql-test/t/user_limits-master.opt:
        Set max_user_connections (as one can't change it if it was 0)
      mysql-test/t/user_limits.test:
        Test max_user_connections -1
      mysql-test/t/variables-master.opt:
        Set max_user_connections (as one can't change it if it was 0)
      mysql-test/t/variables.test:
        Set/restore max_user_connections
      scripts/Makefile.am:
        Add a text message to mysql_fix_privilege_tables.sql that it's automaticly generated
      scripts/mysql_system_tables.sql:
        Change max_user_connections to signed
      scripts/mysql_system_tables_fix.sql:
        Change max_user_connections to signed
      sql/item_func.cc:
        Change SHOW_INT to be signed.
        (Needed for max_user_connections and it's probably a bug that it was not originally signed)
      sql/log.cc:
        Remove some code that was not needed (All these variables are reset at start of query)
      sql/mysql_priv.h:
        Made max_user_connections signed.
        Added max_user_connections_checking
      sql/mysqld.cc:
        Added max_user_connections_checking so that we know if max_user_connections was 0 at startup
        (Which means that we will not do connection counting for accounts that don't have user resource limits)
        Set thd->start_utime at same time as thr_create_utime. (Before start_utime could be < thr_create_utime which lead to wrong query counting)
      sql/set_var.cc:
        Don't allow one to change 'max_user_connections' if it was 0 at startup.
      sql/sql_acl.cc:
        Change user_connection counting to be negative.
      sql/sql_connect.cc:
        If max_user_connections is < 0 then only SUPER user can login.
        Fixed wrong variable names for error messages.
        Fixed wrong initial value for questions.
        Set thd->start_utime and thd->thr_create_utime at startup.  Needed to get time_out_user_resource_limits() to work.
      sql/sql_show.cc:
        SHOW_INT is now negative
      sql/sql_yacc.yy:
        Support negative values for MAX_USER_CONNECTIONS
      sql/structs.h:
        Make user connect counting work with signed numbers.
      88b03b95
    • Sergey Petrunya's avatar
      Merge · d86bba63
      Sergey Petrunya authored
      d86bba63
    • Sergey Petrunya's avatar
      BUG#858732: Wrong result with semijoin + loosescan + comma join · f9d56ba4
      Sergey Petrunya authored
      - Fix wrong loop bounds in setup_semijoin_dups_elimination()
      f9d56ba4
  11. 24 Sep, 2011 1 commit
  12. 23 Sep, 2011 2 commits
  13. 22 Sep, 2011 4 commits
    • Michael Widenius's avatar
      Added new options to KILL. New syntax is KILL [HARD|SOFT] [CONNECTION|QUERY] [ID | USER user_name] · 8d0c4696
      Michael Widenius authored
      - If USER is given, all threads for that user is signaled
      - If SOFT is used then the KILL will not be sent to the handler. This can be used to not interrupt critical things in the handler like 'REPAIR'.
      
      Internally added more kill signals. This gives us more information of why a query/connection was killed.
      - KILL_SERVER is used when server is going down. In this case the users gets ER_SHUTDOWN as the reason connection was killed.
      - Changed signals to number in correct order, which makes it easier to test how the signal should affect the code.
      - New error message ER_CONNECTION_KILLED if connection was killed by 'KILL CONNECTION'. Before we got error ER_SHUTDOWN.
      
      Changed names of not used parameters KILL_QUERY & KILL_CONNCTION to mysql_kill() to not conflict with defines in the server
      
      
      include/mysql.h.pp:
        Updated file
      include/mysql_com.h:
        Changed names of not used parameters KILL_QUERY & KILL_CONNCTION to mysql_kill() to not conflict with defines in the server
      mysql-test/r/kill.result:
        Added test of KILL USER
      mysql-test/suite/rpl/r/rpl_stm_000001.result:
        Updated error code
      mysql-test/suite/rpl/t/rpl_stm_000001.test:
        Updated error codes
      mysql-test/t/flush_read_lock_kill.test:
        Updated error codes
      mysql-test/t/kill.test:
        Added test of KILL USER
      plugin/handler_socket/handlersocket/database.cpp:
        Removed THD:: from KILL
      sql/debug_sync.cc:
        Removed THD:: from KILL
      sql/event_scheduler.cc:
        Removed THD:: from KILL
      sql/filesort.cc:
        Removed THD:: from KILL
      sql/ha_ndbcluster_binlog.cc:
        Removed THD:: from KILL
      sql/handler.cc:
        Removed THD:: from KILL
        Simplify code.
      sql/lex.h:
        Added new keywords HARD | SOFT
      sql/log.cc:
        Removed THD:: from KILL
        Added testing of new error ER_CONNECTION_KILLED
      sql/log_event.cc:
        Removed THD:: from KILL
        Added testing of new error ER_CONNECTION_KILLED
      sql/mysql_priv.h:
        Added new prototypes
      sql/mysqld.cc:
        Removed THD:: from KILL
        Use KILL_SERVER_HARD signal on shutdown.
      sql/scheduler.cc:
        Removed THD:: from KILL
        Simplify test if connection should be killed
      sql/share/errmsg.txt:
        New error message ER_CONNECTION_KILLED
      sql/slave.cc:
        Removed THD:: from KILL
      sql/sp_head.cc:
        Removed THD:: from KILL
      sql/sql_base.cc:
        Removed THD:: from KILL
      sql/sql_cache.cc:
        Removed THD:: from KILL
      sql/sql_class.cc:
        Removed THD:: from KILL
        Added killed_errno()
        Only signal kill to storage engine if HARD bit is set.
      sql/sql_class.h:
        Move KILL options out from THD to make them easier to use in sql_yacc.yy
      sql/sql_connect.cc:
        Removed THD:: from KILL
      sql/sql_delete.cc:
        Removed THD:: from KILL
      sql/sql_error.cc:
        Removed THD:: from KILL
      sql/sql_insert.cc:
        Removed THD:: from KILL
        Simplifed testing if thread is killed.
      sql/sql_lex.h:
        Added kill options to st_lex
      sql/sql_load.cc:
        Removed THD:: from KILL
      sql/sql_parse.cc:
        Added kill options to st_lex
        Simplifed and optimzed testing of thd->killed at end of query
        Added support for KILL USER
        Extended sql_kill() to allow use of more kill signals.
      sql/sql_repl.cc:
        Removed THD:: from KILL
      sql/sql_show.cc:
        Removed THD:: from KILL
        Simplied testing if query/connection was killed
      sql/sql_table.cc:
        Removed THD:: from KILL
      sql/sql_update.cc:
        Removed THD:: from KILL
      sql/sql_yacc.yy:
        Added support for new KILL syntax: KILL [HARD|SOFT] [CONNECTION|QUERY] [ID | USER user_name]
      storage/archive/ha_archive.cc:
        Simplify compilation
      storage/maria/ha_maria.cc:
        Removed THD:: from KILL
      8d0c4696
    • Sergey Petrunya's avatar
      Merge · ef3f4be7
      Sergey Petrunya authored
      ef3f4be7
    • Sergey Petrunya's avatar
      BUG#849776: Wrong result with semijoin + "Impossible where" · 5fd9e68b
      Sergey Petrunya authored
      - Provide fix_after_pullout() function for Item_in_optimizer and other Item_XXX classes (basically, all of them
        that have eval_not_null_tables, which means they have special rules for calculating not_null_tables_cache value)
      5fd9e68b
    • Sergei Golubchik's avatar