1. 27 Sep, 2006 2 commits
    • unknown's avatar
      Remove unused error messages (no release contains them · ac4b6623
      unknown authored
      at the moment, so we can safely do that). Update an error
      mesage to make it translateable.
      
      
      mysql-test/r/log_tables.result:
        update result file
      sql/share/errmsg.txt:
        remove unused error messages
      sql/sql_table.cc:
        Use name of the statements rather then English words.
        This way error message is translateable.
      ac4b6623
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1 · 7c59445a
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.1-bug21414
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      mysql-test/r/sp.result:
        Manual merge.
      mysql-test/t/sp.test:
        Manual merge.
      7c59445a
  2. 26 Sep, 2006 1 commit
  3. 25 Sep, 2006 5 commits
    • unknown's avatar
      Fix for bug#22662 Inconsistent values displayed for event_scheduler · 070c8e74
      unknown authored
      when set to DISABLED
        
      It was a silly ordering number error.
      
      
      
      sql/events.h:
        fix ordinal number, the cause for bug #22662
        Inconsistent values displayed for event_scheduler when set to DISABLED
      mysql-test/r/events_restart_phase0.result:
        New BitKeeper file ``mysql-test/r/events_restart_phase0.result''
      mysql-test/t/events_restart_phase0.log:
        New BitKeeper file ``mysql-test/t/events_restart_phase0.log''
      mysql-test/t/events_restart_phase0.result:
        New BitKeeper file ``mysql-test/t/events_restart_phase0.result''
      070c8e74
    • unknown's avatar
      Fix for bug#22397 Events: crash with procedure which alters events · 6c9400b9
      unknown authored
        
      ALTER EVENT in stored procedure body led to a crash during the
      procedure call. Affected was only ALTER EVENT which changed the
      interval of the event. No problems with AT, STARTS, ENDS and so on.
      
      
      
      mysql-test/r/events_bugs.result:
        fix result
      mysql-test/t/events_bugs.test:
        add test case for bug 22397 : Events, crash with procedure which alters body
      sql/event_data_objects.cc:
        fix copy&paste error in code, which resulted in bug#22397
        Events: crash with procedure which alters body
      6c9400b9
    • unknown's avatar
      cleanups - fix a test and remove unneeded declaration · 038fbc27
      unknown authored
      
      mysql-test/r/events.result:
        test result
      mysql-test/t/events.test:
        fix test
      sql/sql_show.cc:
        remove unneeded declaration
      038fbc27
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/bug22379_runtime/my50-bug22379_runtime · cd6a5b87
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug22379_runtime/my51-bug22379_runtime
      
      
      server-tools/instance-manager/guardian.cc:
        Auto merged
      server-tools/instance-manager/instance.cc:
        Auto merged
      server-tools/instance-manager/instance_options.cc:
        Auto merged
      cd6a5b87
    • unknown's avatar
      Bug #22379 im_daemon_life_cycle.test fails on merge of 5.1 -> 5.1-engines · f91b91cf
      unknown authored
      Remove race situations that occur when removing pidfiles. Primarily each process should remove its own
      pidfile, secondly it should be removed by the process that created it and _only_ if it's
      certain the process is dead. Third, mysql-test-run.pl will remove the pidfile when process has been killed.
      - Set state of an instance to STARTING _before_ calling instance->start()
      - Check that pidfile of instance has been created before changing STARTING => STARTED
      - Only remove the pidfile if IM kills an instance with SIGKILL, otherwise the instance will remove it itself
      
      
      server-tools/instance-manager/guardian.cc:
        If state of an instance is STARTING, chech that the instance pidfile has been created
        before changing state to STARTED
        Set state to STARTING before calling instance->start(), it can take some time
        before it is fully started and during that time it should be in state STARTING
      server-tools/instance-manager/instance.cc:
        Only remove the pid file of instance manager when a SIGKILL has 
        been performed sucessfully
      server-tools/instance-manager/instance_options.cc:
        Check that fscanf returns 1 which is the number of args that should be scanned from
        the pid file
      f91b91cf
  4. 15 Sep, 2006 3 commits
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 372d1c8c
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/5.1-runtime-new
      
      
      sql/handler.h:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      storage/csv/ha_tina.cc:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      372d1c8c
    • unknown's avatar
      Post-review fixes for · abbb2016
      unknown authored
      Bug #18559 "log tables cannot change engine, and
                  gets deadlocked when dropping w/ log on":
      1) Add more generic error messages
      2) Add new handlerton flag for engines, which support
         log tables
      3) Remove (log-tables related) mutex lock in myisam to
         improve performance
      
      
      mysql-test/r/log_tables.result:
        update result file to use new error messages
      mysql-test/t/log_tables.test:
        update test file with new error messages
      sql/handler.h:
        Add new handlerton flag, to mark whether engine
        supports log tables
      sql/share/errmsg.txt:
        Add more generic error messages
      sql/sql_table.cc:
        Update error messages
      storage/csv/ha_tina.cc:
        CSV supports log tables
      storage/myisam/ha_myisam.cc:
        MyISAM supports log tables
      storage/myisam/mi_write.c:
        remove mutex lock to improve performance
      abbb2016
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · bba4e89a
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-rt-merge
      
      
      bba4e89a
  5. 14 Sep, 2006 3 commits
    • unknown's avatar
      Fix an assert on AIX 5.2, 64bit. COND_queue_state wasn't · 2e583735
      unknown authored
      initialized prior to usage as well as deinitialized on shutdown.
      
      
      sql/event_queue.cc:
        Deinitialize and initialize COND_queue_state
      2e583735
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · f1e6d239
      unknown authored
      into  mockturtle.local:/home/dlenev/src/mysql-5.1-rt-merge
      
      
      BitKeeper/etc/ignore:
        auto-union
      client/mysqltest.c:
        Auto merged
      libmysqld/Makefile.am:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/CMakeLists.txt:
        Auto merged
      sql/Makefile.am:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/share/errmsg.txt:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      f1e6d239
    • unknown's avatar
      Temporary fix for a deadlock. Needed so we can go with cloning · 2d8bd876
      unknown authored
      5.1.12.
      
      
      sql/event_queue.cc:
        Temporary workaround to drop the event outside of the
        scope where LOCK_queue is locked. If it's done inside
        the scope a possible deadlock can happen, and it happens
        quite often, escpecially on Windows.
      2d8bd876
  6. 13 Sep, 2006 2 commits
  7. 12 Sep, 2006 16 commits
    • unknown's avatar
      Merge maint2.mysql.com:/data/localhome/tsmith/bk/mrg/g51 · bc053aa0
      unknown authored
      into  maint2.mysql.com:/data/localhome/tsmith/bk/mrg/51
      
      
      libmysqld/libmysqld.def:
        Auto merged
      mysql-test/t/handler.test:
        Auto merged
      sql/log.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      bc053aa0
    • unknown's avatar
      ws fix · d46921ae
      unknown authored
      
      sql/events.h:
        additional line
      d46921ae
    • unknown's avatar
      Fix for BUG#21774: Column count doesn't match value count at row x · 900e66f8
      unknown authored
      The cause of the bug was an incomplete fix for bug 18080.
      The problem was that setup_tables() unconditionally reset the
      name resolution context to its 'tables' argument, which pointed
      to the first table of an SQL statement.
      
      The bug fix limits resetting of the name resolution context in
      setup_tables() only in the cases when the context was not set
      by earlier parser/optimizer phases.
      
      
      mysql-test/r/insert_select.result:
        Test for BUG#21774.
      mysql-test/t/insert_select.test:
        Test for BUG#21774.
      sql/sql_base.cc:
        Do not reset the name resolution contect unconditionally.
        Instead set the context to 'tables' only if it was not
        set before calling setup_tables().
      sql/sql_insert.cc:
        Added asserts to make sure that in the case of INSERT ... VALUES ...
        statements it is not necessary to reset the name resolution context
        to the first table, because there is only one table in the list of
        tables anyway. The actual code is not removed in order not to
        confuse it with the actual bug fix.
      sql/sql_parse.cc:
        Removed unnecessary reset of the name resolution context.
        The context is anyway unconditionally reset in mysql_insert()
        and mysql_prepare_insert().
      900e66f8
    • unknown's avatar
      Correct faulty merge, "mysql_priv.h" must be included for the ifdef... · f320b01a
      unknown authored
      Correct faulty merge, "mysql_priv.h" must be included for the ifdef WITH_INNOBASE_STORAGE_ENGINE to work
      
      
      
      f320b01a
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-new-maint · 22ce97e3
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
      
      
      22ce97e3
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/tmp_merge · 1fff863a
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
      
      
      client/mysqldump.c:
        Auto merged
      1fff863a
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/tmp_merge · 2fb56652
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
      
      
      2fb56652
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/mysql-5.1 · bba3a1be
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.1-new-maint
      
      
      sql/share/errmsg.txt:
        Auto merged
      storage/innobase/Makefile.am:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        SCCS merged
      bba3a1be
    • unknown's avatar
      remove warning · 62188958
      unknown authored
      62188958
    • unknown's avatar
      Merge naruto.:C:/cpp/bug20789/my50-bug20789 · 381f3967
      unknown authored
      into  naruto.:C:/cpp/mysql-5.1-maint
      
      
      storage/myisam/mi_locking.c:
        Auto merged
      381f3967
    • unknown's avatar
      Bug#20789 Merge Subtable Rename Causes Crash · 3ca91645
      unknown authored
       - When an ALTER TABLE RENAME is performed on windows, the files are closed and their cached file 
         descriptors are marked invalid. Performing INSERT, UPDATE or SELECT on the associated merge
         table causes a server crash on windows. This patch adds a test for bad file descriptors when a 
         table attempts a lock. If a bad descriptor is found an error is thrown. An additional FLUSH TABLES
         will be necessary to further operate on the associated merge table.
      
      
      myisam/mi_locking.c:
        This patch prevents the windows built to crash if the file is closed.
      mysql-test/r/windows.result:
        Added test case for the windows built.
      mysql-test/t/windows.test:
        Added test case for the windows built.
      3ca91645
    • unknown's avatar
      correct prototype · c47ce44b
      unknown authored
      c47ce44b
    • unknown's avatar
      BUG#21414: SP: Procedure undroppable, to some extent · d4933af8
      unknown authored
      The problem was that if after FLUSH TABLES WITH READ LOCK the user
      issued DROP/ALTER PROCEDURE/FUNCTION the operation would fail (as
      expected), but after UNLOCK TABLE any attempt to execute the same
      operation would lead to the error 1305 "PROCEDURE/FUNCTION does not
      exist", and an attempt to execute any stored function will also fail.
      
      This happened because under FLUSH TABLES WITH READ LOCK we couldn't open
      and lock mysql.proc table for update, and this fact was erroneously
      remembered by setting mysql_proc_table_exists to false, so subsequent
      statements believed that mysql.proc doesn't exist, and thus that there
      are no functions and procedures in the database.
      
      As a solution, we remove mysql_proc_table_exists flag completely.  The
      reason is that this optimization didn't work most of the time anyway.
      Even if open of mysql.proc failed for some reason when we were trying to
      call a function or a procedure, we were setting mysql_proc_table_exists
      back to true to force table reopen for the sake of producing the same
      error message (the open can fail for number of reasons).  The solution
      could have been to remember the reason why open failed, but that's a lot
      of code for optimization of a rare case.  Hence we simply remove this
      optimization.
      
      
      mysql-test/r/sp.result:
        Add result for bug#21414: SP: Procedure undroppable, to some extent.
      mysql-test/t/sp.test:
        Remove no longer relevant comment.
        Add test case for bug#21414: SP: Procedure undroppable, to some extent.
      sql/mysql_priv.h:
        Remove declaration of mysql_proc_table_exists.
      sql/sp.cc:
        Remove references to mysql_proc_table_exists.
      sql/sql_acl.cc:
        Remove reference to mysql_proc_table_exists.
      d4933af8
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · 04a5f335
      unknown authored
      Remove SHOW SCHEDULER STATUS command and migrate the
      information output to `mysqladmin debug` (COM_DEBUG)
      
      SHOW SCHEDULER STATUS was introduced in 5.1.11, provided
      some debug information about event scheduler internals and
      was enabled only in debug builds.
      
      
      sql/event_queue.cc:
        Remove SHOW SCHEDULER STATUS. Reporting still will be
        there but through COM_DEBUG (mysqladmin debug)
      sql/event_queue.h:
        dump_internal_status cannot return an error, therefore it
        should be void.
      sql/event_scheduler.cc:
        Remove SHOW SCHEDULER STATUS. Reporting still will be
        there but through COM_DEBUG (mysqladmin debug)
      sql/event_scheduler.h:
        dump_internal_status cannot return an error, therefore it
        should be void.
      sql/events.cc:
        Change from outputting the internal data from
        the wire to the standard output. SHOW SCHEDULER STATUS was
        removed.
      sql/events.h:
        dump_internal_status() cannot return an error, therefore
        it should be void
      sql/lex.h:
        remove SCHEDULER as recognized word. This is part
        of removing SHOW SCHEDULER STATUS
      sql/sp_head.cc:
        SQLCOM_SHOW_SCHEDULER_STATUS has been removed
      sql/sql_lex.h:
        SQLCOM_SHOW_SCHEDULER_STATUS has been removed
      sql/sql_parse.cc:
        SQLCOM_SHOW_SCHEDULER_STATUS has been removed
      sql/sql_test.cc:
        Dump Events' internal information on COM_DEBUG
      sql/sql_yacc.yy:
        SQLCOM_SHOW_SCHEDULER_STATUS has been removed
      04a5f335
    • unknown's avatar
      log.cc: · 9e89ea6f
      unknown authored
        Fixing failed merge
      
      
      sql/log.cc:
        Fixing failed merge
      9e89ea6f
    • unknown's avatar
      Change stolen from the -win tree. · 3f77f0dd
      unknown authored
      More specifically, the scripts/Makefile isn't created and it doesn't
      translate mysql_fix_privilege_tables ".sh" .  So, 
      mysql-test/mysql-test-run.pl doesn't find the binary and substitutes 
      /bin/false instead.  That obviously doesn't "fix" anything and the 
      test fails because of it.
      
      
      mysql-test/t/system_mysql_db_fix.test:
        Change stolen from the -win tree.
      3f77f0dd
  8. 11 Sep, 2006 2 commits
  9. 09 Sep, 2006 2 commits
  10. 08 Sep, 2006 4 commits