- 23 Jan, 2019 6 commits
-
-
Eugene Kosov authored
Close connection handler on connection failure. This fixes 14 failing tests in main suite under clang+ASAN build. ASAN report for main.connect looks like this: ================================================================= ==25495==ERROR: LeakSanitizer: detected memory leaks Direct leak of 146280 byte(s) in 115 object(s) allocated from: #0 0x4fba47 in calloc /fun/cpp_projects/llvm_toolchain/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:138 #1 0x5a7a02 in mysql_init /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:977:26 #2 0x570a7a in do_connect(st_command*) /work/mariadb/client/mysqltest.cc:6096:26 #3 0x584c39 in main /work/mariadb/client/mysqltest.cc:9321:9 #4 0x7fd15514db96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310 Indirect leak of 7065600 byte(s) in 115 object(s) allocated from: #0 0x4fb80f in __interceptor_malloc /fun/cpp_projects/llvm_toolchain/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:129 #1 0x637a83 in my_context_init /work/mariadb/libmariadb/libmariadb/ma_context.c:367:23 #2 0x59fd16 in mysql_optionsv /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:2738:9 #3 0x5bc1d4 in mysql_options /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:3242:10 #4 0x570b94 in do_connect(st_command*) /work/mariadb/client/mysqltest.cc:6103:7 #5 0x584c39 in main /work/mariadb/client/mysqltest.cc:9321:9 #6 0x7fd15514db96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310 Indirect leak of 940240 byte(s) in 115 object(s) allocated from: #0 0x4fb80f in __interceptor_malloc /fun/cpp_projects/llvm_toolchain/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:129 #1 0x64386e in ma_init_dynamic_array /work/mariadb/libmariadb/libmariadb/ma_array.c:49:31 #2 0x649ead in _hash_init /work/mariadb/libmariadb/libmariadb/ma_hash.c:52:7 #3 0x5a3080 in mysql_optionsv /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:2938:13 #4 0x5bc20c in mysql_options4 /work/mariadb/libmariadb/libmariadb/mariadb_lib.c:3248:10 #5 0x56f63b in connect_n_handle_errors(st_command*, st_mysql*, char const*, char const*, char const*, char const*, int, char const*) /work/mariadb/client/mysqltest.cc:5874:3 #6 0x57146b in do_connect(st_command*) /work/mariadb/client/mysqltest.cc:6193:7 #7 0x584c39 in main /work/mariadb/client/mysqltest.cc:9321:9 #8 0x7fd15514db96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310 ... Closes #809
-
Sergei Golubchik authored
don't run `su - mysql` is $USER is already mysql
-
Sergei Golubchik authored
test case
-
Sreeharsha Ramanavarapu authored
Issue: ------ When a subquery contains UNION the count of the number of subquery columns is calculated incorrectly. Only the first query block in the subquery's UNION is considered and an array indexing goes out-of-bounds, and this is caught by an assert. Solution: --------- Sum up the columns from all query blocks of the query expression. Change specific to 5.6/5.5: --------------------------- The "child" points to the last query block of the UNION (as opposed to 5.7+ where it points to the first member of UNION). So "child->master_unit()->first_select()" is used to reach the first query block of UNION.
-
Aditya A authored
PROBLEM ------- Memory sanitizer reports uninitialized comparisons in log_in_use(), because strings are compared with memcmp() instead of strncmp. FIX --- Use strncmp() to compare strings
-
Marko Mäkelä authored
fil_extend_space_to_desired_size(): Invoke fsync() after posix_fallocate() in order to durably extend the file in a crash-safe file system.
-
- 21 Jan, 2019 3 commits
-
-
Sergei Golubchik authored
Avoid introducing new dependencies or new syntax. That is, don't use $(...) and don't assume dirname is present. And remove unsighty /foo/bar/../xyz from the path. Use dirname instead of ../
-
Daniel Black authored
Closes #1086
-
Sergei Golubchik authored
don't shortcut trying to test for openssl version, test what is actually needed for a code to compile
-
- 19 Jan, 2019 1 commit
-
-
Vladislav Vaintroub authored
Patch by Eugene Kosov.
-
- 16 Jan, 2019 3 commits
-
-
Alexander Kuleshov authored
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
-
Natanael Copa authored
Fix the off-by-one overflow which was introduced with commit b0fd06a6 (MDEV-15670 - unit.my_atomic failed in buildbot with Signal 11 thrown) Closes #1098.
-
Oleksandr Byelkin authored
The problem was in calculating of the mask to clear unused null bits in case of using full byte.
-
- 15 Jan, 2019 1 commit
-
-
Vladislav Vaintroub authored
-
- 11 Jan, 2019 1 commit
-
-
Vladislav Vaintroub authored
mysql_install_db.exe should not remove datadir, if it was not created by it.
-
- 02 Jan, 2019 1 commit
-
-
Sergei Golubchik authored
-
- 18 Dec, 2018 1 commit
-
-
Sergey Vojtovich authored
Workaround glibc bug: https://sourceware.org/bugzilla/show_bug.cgi?id=20116 by making unittest threads joinable. It makes code better anyway.
-
- 17 Dec, 2018 1 commit
-
-
Sergei Golubchik authored
This reverts part of c5427172
-
- 13 Dec, 2018 1 commit
-
-
Sergey Vojtovich authored
Forbid ALTER DATABASE under read_only.
-
- 28 Nov, 2018 1 commit
-
-
Sergei Golubchik authored
-
- 16 Nov, 2018 1 commit
-
-
fran authored
Closes #3
-
- 15 Nov, 2018 2 commits
-
-
Alexander Barkov authored
The fix for "MDEV-17698 MEMORY engine performance regression" previously fixed this problem. - Adding the test for MDEV-17724 - Re-recording wrong results for tests: * engines/iuds/r/insert_number * engines/iuds/r/update_delete_number which started to fail since MDEV-17698
-
Alexander Barkov authored
Also, backporting a part of: MDEV-11485 Split Item_func_between::val_int() into virtual methods in Type_handler for easier merge to 10.3.
-
- 02 Nov, 2018 1 commit
-
-
Oleksandr Byelkin authored
my_read fixed as in higher versions. my_pread made as my_read aware of partial read of huge chunks of files MY_FULL_IO enabled for file operations
-
- 01 Nov, 2018 2 commits
-
-
Sergei Golubchik authored
followup for c32f7ed2
-
Sergei Golubchik authored
reset lex->many_values for LOAD DATA, as it's used for auto-inc range size estimation.
-
- 31 Oct, 2018 1 commit
-
-
Takashi Sasaki authored
-
- 30 Oct, 2018 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
--gdb now accepts an argument, it will be passed to gdb as a command. multiple commands can be separated by a (non-standard and not escapable) delimiter - semicolon (;). Old usage with a bare --gdb continues to work too, of course. Cherry-picked c47c0ca5 5441bbd3 339b9055
-
Alexey Botchkov authored
We should clear trailing zeroes in frac part. Otherwise that tail is growing quickly and forces unnecessary truncating of arguments.
-
- 26 Oct, 2018 1 commit
-
-
Daniel Bartholomew authored
-
- 24 Oct, 2018 4 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
This reverts commit ebaacf07. Pushed by mistake. Broke tokudb on trusty-amd64.
-
Sergei Golubchik authored
-
- 23 Oct, 2018 2 commits
-
-
Sergei Golubchik authored
test case
-
Sergei Golubchik authored
-
- 20 Oct, 2018 1 commit
-
-
Sergei Golubchik authored
This reverts commit dc3a20b1. It requires GET_BIT in include/my_getopt.h, which is available only in 10.3+
-
- 19 Oct, 2018 1 commit
-
-
Sergei Golubchik authored
mysql_upgrade used to convert all columns of mysql.db to utf8_general_ci and then back to utf8_bin. In two separate ALTER's. This failed if UNIQUE indexes in mysql.db contained entries that differ only in the letter case.
-
- 17 Oct, 2018 1 commit
-
-
Sachin authored
consistently) on Replication Slave lower_case_table_names 0 -> 1 replication works, it's safe as long as mixed case names mapping to the lower case ones is one-to-one
-