1. 04 Nov, 2009 2 commits
  2. 02 Nov, 2009 1 commit
    • marko's avatar
      branches/zip: Free all resources at shutdown. Set pointers to NULL, so · dda7217e
      marko authored
      that Valgrind will not complain about freed data structures that are
      reachable via pointers.  This addresses Bug #45992 and Bug #46656.
      
      This patch is mostly based on changes copied from branches/embedded-1.0,
      mainly c5432, c3439, c3134, c2994, c2978, but also some other code was
      copied.  Some added cleanup code is specific to MySQL/InnoDB.
      
      rb://199 approved by Sunny Bains
      dda7217e
  3. 30 Oct, 2009 2 commits
    • vasil's avatar
      branches/zip: Merge r6112:6125 from branches/5.1: · 215f53bb
      vasil authored
      (skipping r6122 and r6123, Jimmy says these are already present and need
      not be merged):
      
        ------------------------------------------------------------------------
        r6122 | jyang | 2009-10-30 05:18:38 +0200 (Fri, 30 Oct 2009) | 7 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/mysql-test/innodb_bug44369.result
           M /branches/5.1/mysql-test/innodb_bug44369.test
           M /branches/5.1/mysql-test/innodb_bug46000.result
           M /branches/5.1/mysql-test/innodb_bug46000.test
        
        branches/5.1: Chnage WARN_LEVEL_ERROR to WARN_LEVEL_WARN
        for push_warning_printf() call in innodb.
        Fix Bug#47233: Innodb calls push_warning(MYSQL_ERROR::WARN_LEVEL_ERROR)
        
        rb://170 approved by Marko.
        
        
        ------------------------------------------------------------------------
        r6123 | jyang | 2009-10-30 05:43:06 +0200 (Fri, 30 Oct 2009) | 8 lines
        Changed paths:
           M /branches/5.1/os/os0proc.c
        
        branches/5.1: In os_mem_alloc_large(), if we fail to attach
        the shared memory, reset memory pointer ptr to NULL, and
        allocate memory from conventional pool. This is a port
        from branches/zip.
        Bug #48237 Error handling in os_mem_alloc_large appears to be incorrect
        rb://198  Approved by: Marko
        
        
        ------------------------------------------------------------------------
        r6125 | vasil | 2009-10-30 10:31:23 +0200 (Fri, 30 Oct 2009) | 4 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
        
        branches/5.1:
        
        White-space fixup.
        
        ------------------------------------------------------------------------
      215f53bb
    • jyang's avatar
      branches/zip: Correct the bug number for -r6109 change · db0d81d0
      jyang authored
      from # 48273 to #48237
      
      db0d81d0
  4. 29 Oct, 2009 8 commits
    • sunny's avatar
      branches/zip: This test has been problematic for sometime now. The underlying · 30e5b953
      sunny authored
      bug is that the data dictionaries get out of sync. In the AUTOINC code we
      try and apply salve to the symptoms. In the past MySQL made some unrelated
      change and the dictionaries stopped getting out of sync and this test started
      to fail. Now, it seems they have reverted that changed and the test is
      passing again. I suspect this is not he last time that this test will change.
      30e5b953
    • vasil's avatar
      branches/zip: · f054d409
      vasil authored
      * Add ChangeLog entries for latest changes
      * Obey alphabetical order in the list of the files
      * White-space fixup
      f054d409
    • vasil's avatar
      branches/zip: Merge r5912:6112 from branches/5.1: · cb4d077f
      vasil authored
      (after this merge the innodb-autoinc test starts to fail, but
      I commit anyway because it would be easier to investigate the
      failure this way)
      
        ------------------------------------------------------------------------
        r5952 | calvin | 2009-09-22 19:45:07 +0300 (Tue, 22 Sep 2009) | 7 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
        
        branches/5.1: fix bug#42383: Can't create table 'test.bug39438'
        
        For embedded server, MySQL may pass in full path, which is
        currently disallowed. It is needed to relax the condition by
        accepting full paths in the embedded case.
        
        Approved by: Heikki (on IM)
        ------------------------------------------------------------------------
        r6032 | vasil | 2009-10-01 15:55:49 +0300 (Thu, 01 Oct 2009) | 8 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
        
        branches/5.1:
        
        Fix Bug#38996 Race condition in ANALYZE TABLE
        
        by serializing ANALYZE TABLE inside InnoDB.
        
        Approved by:	Heikki (rb://175)
        
        ------------------------------------------------------------------------
        r6045 | jyang | 2009-10-08 02:27:08 +0300 (Thu, 08 Oct 2009) | 7 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           A /branches/5.1/mysql-test/innodb_bug47777.result
           A /branches/5.1/mysql-test/innodb_bug47777.test
        
        branches/5.1: Fix bug #47777. Treat the Geometry data same as
        Binary BLOB in ha_innobase::store_key_val_for_row(), since the
        Geometry data is stored as Binary BLOB in Innodb.
        
        Review: rb://180 approved by Marko Makela.
        
        
        ------------------------------------------------------------------------
        r6051 | sunny | 2009-10-12 07:05:00 +0300 (Mon, 12 Oct 2009) | 6 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/mysql-test/innodb-autoinc.result
           M /branches/5.1/mysql-test/innodb-autoinc.test
        
        branches/5.1: Ignore negative values supplied by the user when calculating the
        next value to store in dict_table_t. Setting autoincrement columns top negative
        values is undefined behavior and this change should bring the behavior of
        InnoDB closer to what users expect. Added several tests to check.
        rb://162
        
        ------------------------------------------------------------------------
        r6052 | sunny | 2009-10-12 07:09:56 +0300 (Mon, 12 Oct 2009) | 4 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/mysql-test/innodb-autoinc.result
           M /branches/5.1/mysql-test/innodb-autoinc.test
        
        branches/5.1: Reset the statement level autoinc counter on ROLLBACK. Fix
        the test results too.
        rb://164
        
        ------------------------------------------------------------------------
        r6053 | sunny | 2009-10-12 07:37:49 +0300 (Mon, 12 Oct 2009) | 6 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/mysql-test/innodb-autoinc.result
           M /branches/5.1/mysql-test/innodb-autoinc.test
        
        branches/5.1: Copy the maximum AUTOINC value from the old table to the new
        table when MySQL does a CREATE INDEX ON T. This is required because MySQL
        does a table copy, rename and drops the old table.
        Fix Bug#47125: auto_increment start value is ignored if an index is created and engine=innodb
        rb://168
        
        ------------------------------------------------------------------------
        r6076 | vasil | 2009-10-14 19:30:12 +0300 (Wed, 14 Oct 2009) | 4 lines
        Changed paths:
           M /branches/5.1/row/row0mysql.c
        
        branches/5.1:
        
        Fix typo.
        
        ------------------------------------------------------------------------
      cb4d077f
    • calvin's avatar
      branches/zip: consideration for icc compilers · aec3676c
      calvin authored
      Proposed by MySQL, and approved by Marko.
      aec3676c
    • marko's avatar
      branches/zip: Fix corruption of buf_pool->LRU_old and improve debug assertions. · 7d0ad4af
      marko authored
      This was reported as Issue #381.
      
      buf_page_set_old(): Assert that blocks may only be set old if
      buf_pool->LRU_old is initialized and buf_pool->LRU_old_len is nonzero.
      Assert that buf_pool->LRU_old points to the block at the old/new boundary.
      
      buf_LRU_old_adjust_len(): Invoke buf_page_set_old() after adjusting
      buf_pool->LRU_old and buf_pool->LRU_old_len, in order not to violate
      the added assertions.
      
      buf_LRU_old_init(): Replace buf_page_set_old() with a direct
      assignment to bpage->old, because these loops that initialize all the
      blocks would temporarily violate the assertions about
      buf_pool->LRU_old.
      
      buf_LRU_remove_block(): When setting buf_pool->LRU_old = NULL, also
      clear all bpage->old flags and set buf_pool->LRU_old_len = 0.
      
      buf_LRU_add_block_to_end_low(), buf_LRU_add_block_low(): Move the
      buf_page_set_old() call later in order not to violate the debug
      assertions.  If buf_pool->LRU_old is NULL, set old=FALSE.
      
      buf_LRU_free_block(): Replace the UNIV_LRU_DEBUG assertion with a
      dummy buf_page_set_old() call that performs more thorough checks.
      
      buf_LRU_validate(): Do not tolerate garbage in buf_pool->LRU_old_len
      even if buf_pool->LRU_old is NULL.  Check that bpage->old is monotonic.
      
      buf_relocate(): Make the UNIV_LRU_DEBUG checks stricter.
      
      buf0buf.h: Revise the documentation of buf_page_t::old and
      buf_pool_t::LRU_old_len.
      7d0ad4af
    • marko's avatar
      branches/zip: Makefile.am (INCLUDES): Merge a change from MySQL: · 466ecce5
      marko authored
      Use $(srcdir)/include instead of $(top_srcdir)/storage/innobase/include.
      466ecce5
    • jyang's avatar
      branches/zip: In os_mem_alloc_large(), if we fail to attach · b7d97860
      jyang authored
      the shared memory, reset memory pointer ptr to NULL, and
       allocate memory from conventional pool.
      Bug #48237 Error handling in os_mem_alloc_large appears to be incorrect
      rb://198  Approved by: Marko
      b7d97860
    • calvin's avatar
      branches/zip: close file handle when building with UNIV_HOTBACKUP · 4ef824ed
      calvin authored
      The change does not affect regular InnoDB engine. Confirmed by
      Marko.
      4ef824ed
  5. 28 Oct, 2009 1 commit
  6. 27 Oct, 2009 1 commit
  7. 26 Oct, 2009 2 commits
  8. 23 Oct, 2009 1 commit
  9. 22 Oct, 2009 2 commits
  10. 19 Oct, 2009 2 commits
    • vasil's avatar
      branches/zip: · 7e6a345f
      vasil authored
      Add ChangeLog entry for r6095.
      7e6a345f
    • vasil's avatar
      branches/zip: · c1ebc315
      vasil authored
      Fix Bug#47808 innodb_information_schema.test fails when run under valgrind 
      
      by using the wait_until_rows_count macro that loops until the number of
      rows becomes 14 instead of sleep 0.1, which is obviously very fragile.
      c1ebc315
  11. 15 Oct, 2009 1 commit
    • vasil's avatar
      branches/zip: · 68b1cc9e
      vasil authored
      Add ChangeLog entry for r6080.
      68b1cc9e
  12. 14 Oct, 2009 1 commit
  13. 13 Oct, 2009 2 commits
  14. 09 Oct, 2009 2 commits
    • vasil's avatar
      branches/zip: · 2c1b9d9d
      vasil authored
      Fix compilation warning in Hot Backup:
      
      innodb/fil/fil0fil.c: In function 'fil_load_single_table_tablespace':
      innodb/fil/fil0fil.c:3253: warning: format '%lld' expects type 'long long int', but argument 6 has type 'ib_int64_t'
      2c1b9d9d
    • vasil's avatar
      branches/zip: · 51ac3a0d
      vasil authored
      When scanning a directory readdir() is called and stat() after it,
      if a file is deleted between the two calls stat will fail and the
      whole precedure will fail. Change this behavior to continue with the
      next entry if stat() fails because of nonexistent file. This is
      transparent change as it will make it look as if the file was deleted
      before the readdir() call.
      
      This change is needed in order to fix
      https://svn.innodb.com/mantis/view.php?id=174
      in which we need to abort if os_file_readdir_next_file()
      encounters "real" errors.
      
      Approved by:	Marko, Pekka (rb://177)
      51ac3a0d
  15. 08 Oct, 2009 1 commit
  16. 06 Oct, 2009 1 commit
    • pekka's avatar
      branches/zip: · 4ed1a96f
      pekka authored
      Add os_file_is_same() function for Hot Backup (inside ifdef UNIV_HOTBACKUP).
      This is part of the fix for Issue #186.
      Note! The Windows implementation is incomplete.
      4ed1a96f
  17. 05 Oct, 2009 1 commit
    • inaam's avatar
      branches/zip rb://176 · 1f30efe9
      inaam authored
      Do not invalidate buffer pool while an LRU batch is active. Added
      code to buf_pool_invalidate() to wait for the running batches to finish.
      
      This patch also resets the state of buf_pool struct at invalidation. This
      addresses the concern where buf_pool->freed_page_clock becomes non-zero
      because we read in a system tablespace page for file format info at
      startup.
      
      Approved by: Marko
      1f30efe9
  18. 01 Oct, 2009 2 commits
    • calvin's avatar
      branches/zip: fix a typo in error message · 470ce00a
      calvin authored
      Reported as bug#47763.
      470ce00a
    • marko's avatar
      branches/zip: Clean up after a crash during DROP INDEX. · 64096ab5
      marko authored
      When InnoDB crashes while dropping an index, ensure that
      the index will be completely dropped during crash recovery.
      
      row_merge_drop_index(): Before dropping an index, rename the index to
      start with TEMP_INDEX_PREFIX_STR and commit the change, so that
      row_merge_drop_temp_indexes() will drop the index after crash
      recovery if the server crashes while dropping the index.
      
      fseg_inode_try_get(): New function, forked from fseg_inode_get().
      Return NULL if the file segment index node is free.
      
      fseg_inode_get(): Assert that the file segment index node is not free.
      
      fseg_free_step(): If the file segment index node is already free,
      print a diagnostic message and return TRUE.
      
      fsp_free_seg_inode(): Write a nonzero number to FSEG_MAGIC_N, so that
      allocated-and-freed file segment index nodes can be better
      distinguished from uninitialized ones.
      
      This is rb://174, addressing Issue #348.
      
      Tested by restarting mysqld upon the completion of the added
      log_write_up_to() invocation below, during DROP INDEX.  The index was
      dropped after crash recovery, and re-issuing the DROP INDEX did not
      crash the server.
      
        Index: btr/btr0btr.c
        ===================================================================
        --- btr/btr0btr.c	(revision 6026)
        +++ btr/btr0btr.c	(working copy)
        @@ -42,6 +42,7 @@ Created 6/2/1994 Heikki Tuuri
         #include "ibuf0ibuf.h"
         #include "trx0trx.h"
        +#include "log0log.h"
         
         /*
         Latching strategy of the InnoDB B-tree
         --------------------------------------
        @@ -873,6 +874,8 @@ leaf_loop:
         
         		goto leaf_loop;
         	}
        +
        +	log_write_up_to(mtr.end_lsn, LOG_WAIT_ALL_GROUPS, TRUE);
         top_loop:
         	mtr_start(&mtr);
      64096ab5
  19. 30 Sep, 2009 3 commits
  20. 29 Sep, 2009 3 commits
    • vasil's avatar
      branches/zip: · 2fe21c27
      vasil authored
      Fix the year, should be 2009.
      
      Pointed by:	Calvin
      2fe21c27
    • vasil's avatar
      branches/zip: · 732fd6c3
      vasil authored
      Add ChangeLog entry for the release of 1.0.4.
      732fd6c3
    • vasil's avatar
      branches/zip: · 2fccb1bd
      vasil authored
      ChangeLog: wrap around 78th column, not earlier.
      2fccb1bd
  21. 28 Sep, 2009 1 commit
    • marko's avatar
      branches/zip: Remove an assertion failure when the InnoDB data dictionary · cf0210a7
      marko authored
      is inconsistent with the MySQL .frm file.
      
      ha_innobase::index_read(): When the index cannot be found,
      return an error.
      
      ha_innobase::change_active_index(): When prebuilt->index == NULL,
      set also prebuilt->index_usable = FALSE.  This is not needed for
      correctness, because prebuilt->index_usable is only checked by
      row_search_for_mysql(), which requires prebuilt->index != NULL.
      
      This addresses Issue #349.  Approved by Heikki Tuuri over IM.
      cf0210a7