1. 17 Jun, 2008 5 commits
  2. 16 Jun, 2008 2 commits
  3. 13 Jun, 2008 3 commits
  4. 12 Jun, 2008 1 commit
  5. 10 Jun, 2008 1 commit
  6. 09 Jun, 2008 1 commit
  7. 04 Jun, 2008 1 commit
  8. 03 Jun, 2008 5 commits
    • Davi Arnaut's avatar
      Bug#33362: Query cache invalidation (truncate) may hang · 2100ec9e
      Davi Arnaut authored
                 if cached query uses many tables
      
      The problem was that query cache would not properly cache
      queries which used 256 or more tables but yet would leave
      behind query cache blocks pointing to freed (destroyed)
      data. Later when invalidating (due to a truncate) query cache
      would attempt to grab a lock which resided in the freed data,
      leading to hangs or undefined behavior.
      
      This was happening due to a improper return value from the
      function responsible for registering the tables used in the
      query (so the cache can be invalidated later if one of the
      tables is modified). The function expected a return value of
      type boolean (char, 8 bits) indicating success (1) or failure
      (0) but the number of tables registered (unsigned int, 32 bits)
      was being returned instead. This caused the function to return
      failure for cases where it had actually succeed because when
      a type (unsigned int) is converted to a narrower type (char),
      the excess bits on the left are discarded. Thus if the 8
      rightmost bits are zero, the return value will be 0 (failure).
      
      The solution is to simply return true (1) only if the number of
      registered table is greater than zero and false (0) otherwise.
      
      mysql-test/r/query_cache_merge.result:
        Add test case result for Bug#33362
      mysql-test/t/query_cache_merge.test:
        Add test case for Bug#33362
      sql/sql_cache.cc:
        Return 1 or 0 depending on the number of registered tables.
      2100ec9e
    • Georgi Kodinov's avatar
      null merge · 0a68dd1d
      Georgi Kodinov authored
      0a68dd1d
    • Mattias Jonsson's avatar
      Bug#31210: INSERT DELAYED crashes server when used on partitioned tables · a8af693b
      Mattias Jonsson authored
        
      Problem was an unclear error message since it could suggest that
      MyISAM did not support INSERT DELAYED.
      Changed the error message to say that DELAYED is not supported by the
      table, instead of the table's storage engine.
      The confusion is that a partitioned table is in somewhat sense using
      the partitioning storage engine, which in turn uses the ordinary
      storage engine. By saying that the table does not support DELAYED we
      do not give any extra informantion about the storage engine or if it
      is partitioned.
      
      mysql-test/r/innodb-replace.result:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/innodb-replace.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/merge.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/partition_hash.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      sql/share/errmsg.txt:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        added error message for tables not supporting DELAYED
      sql/sql_insert.cc:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      a8af693b
    • Matthias Leich mleich@mysql.com's avatar
      Upmerge of fix for · 8d7fcad1
      Matthias Leich mleich@mysql.com authored
      Bug 36788 Multiple funcs_1 'trig' tests are failing on vanilla builds
      8d7fcad1
    • Georgi Kodinov's avatar
      Bug#37069 (5.0): implement --skip-federated · da4cfa6d
      Georgi Kodinov authored
      mysql-test/r/federated_disabled.result:
        Bug#37069 (5.0): test case
      mysql-test/t/federated_disabled-master.opt:
        Bug#37069 (5.0): test case
      mysql-test/t/federated_disabled.test:
        Bug#37069 (5.0): test case
      da4cfa6d
  9. 02 Jun, 2008 1 commit
    • Matthias Leich mleich@mysql.com's avatar
      Bug#36788 Multiple funcs_1 'trig' tests are failing on vanilla builds · 15440264
      Matthias Leich mleich@mysql.com authored
      Fix for this bug and additional improvements/fixes
      In detail:
      - Remove unicode attribute from several columns
        (unicode properties were nowhere needed/tested)
        of the table tb3
        -> The runnability of these tests depends no more on
           the availibility of some optional collations.
      - Use a table tb3 with the same layout for all
        engines to be tested and unify the engine name
        within the protocols.
        -> <engine>_trig_<abc>.result have the same content
      - Do not load data into tb3 if these rows have no
        impact on result sets
      - Add tests for NDB (they exist already in 5.1)
      - "--replace_result" at various places because
        NDB variants of tests failed with "random" row
        order in results
        This fixes a till now unknown weakness within the
        funcs_1 NDB tests existing in 5.1 and 6.0
      - Fix the expected result of ndb_trig_1011ext
        which suffered from Bug 32656
        + disable this test
      - funcs_1 could be executed with the mysql-test-run.pl
        option "--reorder", which saves some runtime by
        optimizing server restarts.
        Runtimes on tmpfs (one attempt only):
        with    reorder 132 seconds
        without reorder 183 seconds
      - Adjust two "check" statements within func_misc.test
        which were incorrect (We had one run with result set
        difference though the server worked good.)
      - minor fixes in comments
      15440264
  10. 30 May, 2008 3 commits
  11. 29 May, 2008 2 commits
  12. 28 May, 2008 4 commits
  13. 27 May, 2008 4 commits
    • Patrick Crews's avatar
      Bug#36721 - Test funcs1.<engine>_func_view failing for multiple engines · 914bb34b
      Patrick Crews authored
      Bug#36724 - Test funcs_1.<engine>_storedproc_02 needs to be updated
      Bug#36726 - Test funcs_1.<engine>_storedproc failing - Needs to be updated on 5.1+
      
      func_view bug:  re-records .result files to account for addition of charset and collation data 
                      to SHOW CREATE VIEW output
      storedproc bugs:  Added expected errors for those storedprocs that use SQLSTATE:00000
                        in their handlers.  re-recorded .result files to account for these
                        expected errors.
      
      mysql-test/suite/funcs_1/r/innodb_func_view.result:
        Update result set for changes to SHOW CREATE VIEW output
      mysql-test/suite/funcs_1/r/memory_func_view.result:
        Updated result set due to changes in SHOW CREATE VIEW output
      mysql-test/suite/funcs_1/r/myisam_func_view.result:
        Updated result set due to changes in SHOW CREATE VIEW output
      914bb34b
    • Davi Arnaut's avatar
      Merge. · 52066c51
      Davi Arnaut authored
      52066c51
    • Davi Arnaut's avatar
      Add variation of compile-pentium-valgrind-max which does not build ndb. · f972dce2
      Davi Arnaut authored
      BUILD/compile-pentium-valgrind-max-no-ndb:
        Disable ndb.
      f972dce2
    • Georgi Kodinov's avatar
      Bug #36887: Typo in mysql_client_test.c uses bind instead of my_bind · ed786398
      Georgi Kodinov authored
      There was a typo in a error check causing wrong thing to be ckecked 
      and a possible error not being caught.
      Fixed by using the correct variable to test for malloc() errors. 
      
      tests/mysql_client_test.c:
        Bug #36887: fixed a typo
      ed786398
  14. 26 May, 2008 1 commit
    • Sven Sandberg's avatar
      BUG#36826: rpl_slave_status fails sporadically in pushbuild · 605ba686
      Sven Sandberg authored
      rpl_slave_status failed on pushbuild. The slave stopped with an
      error. Adding sync_slave_with_master fixes the problem. Updated
      test case. 
      
      mysql-test/suite/rpl/r/rpl_slave_status.result:
        Updated result file.
      mysql-test/suite/rpl/t/rpl_slave_status.test:
        - Added comment explaining what the test does.
        - Added sync_slave_with_master in two places where it was missing. This
          caused sporadic pushbuild errors.
        - Added wait_for_slave_to_{start,stop} after {START,STOP} SLAVE queries.
        - Removed 'drop table if exists' from setup code.
        - Replaced save_master_pos;connection slave;sync_with_master by
          sync_slave_with_master.
        - Replaced 'delete from mysql.user' by 'drop user'.
        - Wrapped 'show slave status' inside query_get_value(), so that only what
          we test is in the output.
      605ba686
  15. 25 May, 2008 1 commit
  16. 23 May, 2008 5 commits