1. 30 Mar, 2005 1 commit
    • unknown's avatar
      BUG#8807 Select crash server · af2ab040
      unknown authored
       - Add function Item_param::fix_fields which will update any subselect they are part of and indicate that the subsleect is not const during prepare phase, and thus should not be executed during prepare.
      
      
      mysql-test/include/ps_query.inc:
        Adde new test case
      mysql-test/r/ps_2myisam.result:
        Update test result
      mysql-test/r/ps_3innodb.result:
        Update test result
      mysql-test/r/ps_4heap.result:
        Update test result
      mysql-test/r/ps_5merge.result:
        Update test result
      mysql-test/r/ps_6bdb.result:
        Update test result
      mysql-test/r/ps_7ndb.result:
        Update test result
      sql/item.cc:
        Add function Item_param::fix_fields, which will mark any subselects they are part of as not being a constant expression unless the param value is specified, ie. it will be not be constant during prepare phase.
      sql/item.h:
        Adde Item_param::fix_fields
      sql/item_subselect.h:
        Make Item_param::fix_field friend of Item_subselect
      af2ab040
  2. 24 Mar, 2005 1 commit
  3. 23 Mar, 2005 4 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com://home/bk/mysql-4.1 · 2621e38b
      unknown authored
      into quadita2.mysql.com:/nfstmp1/guilhem/mysql-4.1-4ita
      
      
      2621e38b
    • unknown's avatar
      "After Monty's review" changes to the fix for BUG#8325 "Deadlock in... · 6bc324ed
      unknown authored
      "After Monty's review" changes to the fix for BUG#8325 "Deadlock in replication thread stops replication":
      s/sleep/safe_sleep (thread safe); sleep 0/1/2/3/4/5/5/5 (get slave less late);
      no message on error log (deadlock is too common sometimes), a global counter
      instead (SHOW STATUS LIKE 'slave_retried_transactions').
      Plus a fix for libmysql/Makefile.shared
      
      
      libmysql/Makefile.shared:
        When we "make clean" in libmysql/ we remove the symlinks there, so we
        need to mark that they have to be recreated later: this is done by removing
        ../linked_libmysql_sources. If we don't do this, 'make' will fail after 'cd libmysql;make clean'.
        This Makefile.shared is used by libmysql_r too.
        No reason to remove linked_client_sources as we don't remove the links in client/.
      mysql-test/r/rpl_deadlock.result:
        result fix
      mysql-test/t/rpl_deadlock.test:
        small test addition
      sql/mysqld.cc:
        if active_mi could not be alloced, die. New SHOW STATUS LIKE "slave_retried_transactions".
      sql/slave.cc:
        If slave retries automatically a transaction, no message on error log
        (too common situation); sleep 0 secs at first retry, then 1, 2, 3, 4,
        5, 5, 5... Sleeping 0 is to get the least possible late, as deadlocks
        are usually resolved at first try. New global counter rli->retried_trans
        (for SHOW STATUS: total number of times the slave had to retry
        any transaction). safe_sleep() is thread-safe, sleep() was not.
        I change the rli->trans_retries counter to go from 0 to max instead
        of the other way (better for new sleep()).
      sql/slave.h:
        new global counter rli->retried_trans
      sql/sql_show.cc:
        SHOW STATUS LIKE "slave_retried_transactions"; needs replication mutexes.
        Can't be a simple SHOW_LONG, because active_mi is unset (not alloced yet)
        when the static global status_vars is created (active_mi is set
        in init_slave()).
      sql/structs.h:
        new SHOW_SLAVE_RETRIED_TRANS
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      6bc324ed
    • unknown's avatar
      README: · d2ab1393
      unknown authored
        Fix typo.
      
      
      mysql-test/README:
        Fix typo.
      d2ab1393
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 3315fab9
      unknown authored
      into neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      3315fab9
  4. 22 Mar, 2005 8 commits
  5. 21 Mar, 2005 7 commits
    • unknown's avatar
      trx0trx.c: · 6d0d2c7e
      unknown authored
        If MySQL wrote to its binlog, but for some reason trx->update_undo and trx->insert_undo were NULL in InnoDB, then trx->commit_lsn was garbage, and InnoDB could assert in the log flush of trx_commit_complete_for_mysql() (Bug #9277)
      
      
      innobase/trx/trx0trx.c:
        If MySQL wrote to its binlog, but for some reason trx->update_undo and trx->insert_undo were NULL in InnoDB, then trx->commit_lsn was garbage, and InnoDB could assert in the log flush of trx_commit_complete_for_mysql() (Bug #9277)
      6d0d2c7e
    • unknown's avatar
      Merge · 421907e9
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      innobase/include/trx0trx.h:
        Auto merged
      innobase/trx/trx0trx.c:
        SCCS merged
      421907e9
    • unknown's avatar
      trx0trx.c, trx0trx.h: · 7656b6da
      unknown authored
        If MySQL wrote to its binlog, but for some reason trx->update_undo and trx->insert_undo were NULL in InnoDB, then trx->commit_lsn was garbage, and InnoDB could assert in the log flush of trx_commit_complete_for_mysql() (Bug #9277)
      
      
      innobase/include/trx0trx.h:
        If MySQL wrote to its binlog, but for some reason trx->update_undo and trx->insert_undo were NULL in InnoDB, then trx->commit_lsn was garbage, and InnoDB could assert in the log flush of trx_commit_complete_for_mysql() (Bug #9277)
      innobase/trx/trx0trx.c:
        If MySQL wrote to its binlog, but for some reason trx->update_undo and trx->insert_undo were NULL in InnoDB, then trx->commit_lsn was garbage, and InnoDB could assert in the log flush of trx_commit_complete_for_mysql() (Bug #9277)
      7656b6da
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1-build · 9f47e08e
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1-perl
      
      
      9f47e08e
    • unknown's avatar
      A fix for Netware. · 4da513f5
      unknown authored
      4da513f5
    • unknown's avatar
      mtr_report.pl: · a94a62ce
      unknown authored
        Made --timer work
      mtr_cases.pl:
        Added option --reorder to get less server restarts
      mysql-test-run.pl:
        Added option --reorder to get less server restarts
        Moved do_before_start_master() not to remove binlog files unless restarted
        Made --timer work
        Slave was incorrectly writing log to error log
      
      
      mysql-test/mysql-test-run.pl:
        Added option --reorder to get less server restarts
        Moved do_before_start_master() not to remove binlog files unless restarted
        Made --timer work
        Slave was incorrectly writing log to error log
      mysql-test/lib/mtr_cases.pl:
        Added option --reorder to get less server restarts
      mysql-test/lib/mtr_report.pl:
        Made --timer work
      a94a62ce
    • unknown's avatar
      BUG#9072 'Max_error_count' system variable cannot be set to zero · 11e01bfa
      unknown authored
       - Chaned min value in mysqld.cc
       - Added testcase to warnings.test
      
      
      mysql-test/r/warnings.result:
        Added testcase for testing max and min value of max_error_count
      mysql-test/t/warnings.test:
        Added testcase for testing max and min value of max_error_count
      sql/mysqld.cc:
        Change min value of max_error_count from 1 to 0
      11e01bfa
  6. 18 Mar, 2005 3 commits
  7. 17 Mar, 2005 11 commits
  8. 16 Mar, 2005 5 commits
    • unknown's avatar
      olap.result, olap.test: · 31f6b0dd
      unknown authored
        Added a test for bug #8615.
      sql_select.cc:
        Fixed bug #8615.
        This fix only removed the cause of the reported crash.
        It does not resolve other problems of rollup queries
        with DISTINCT. They were fixed in the previous patch 
        for bug 8616.
      
      
      sql/sql_select.cc:
        Fixed bug #8615.
        This fix only removed the cause of the reported crash.
        It does not resolve other problems of rollup queries
        with DISTINCT. They were fixed in the previous patch 
        for bug 8616.
      mysql-test/t/olap.test:
        Added a test for bug #8615.
      mysql-test/r/olap.result:
        Added a test for bug #8615.
      31f6b0dd
    • unknown's avatar
    • unknown's avatar
      Fixes after Sinisa and Serg comments after push of patch for BUG#9123. · 74007170
      unknown authored
      BUG#9123 is solved earlier than this patch though.
      
      
      74007170
    • unknown's avatar
      5be39a0c
    • unknown's avatar
      Add information to the log file written by 'Do-compile' that allows to calculate · 0f3b3d3a
      unknown authored
      the time spent in the various steps.
      
      
      Build-tools/Do-compile:
        Add information to the log file that allows to calculate the time spent in the
        various steps:
        
        1) Introduce a global variable 'global_step'.
        2) Before each major step, set it to some descriptive value.
        3) Expand the 'log_timestamp()' function to take a parameter (typical: "START",
           "DONE", or "ABORT") and append that to the timestamp in the log file,
           followed by the contents of 'global_step'.
        4) Add the "START" string as parameter to the 'log_timestamp' calls preceding a step.
        5) Add 'log_timestamp("DONE");' calls after the relevant steps.
        6) Add 'log_timestamp("ABORT");' calls to the error exits.
      0f3b3d3a