1. 06 Dec, 2009 1 commit
    • Michael Widenius's avatar
      Changed -1 row number in some warnings to 0 · af83ac25
      Michael Widenius authored
      (-1 doesn't make sence as a row number and when doing insert / load data, first row is 1, so 0 is free to use)
      
      
      mysql-test/r/warnings.result:
        Added test for warnings with row number
      mysql-test/suite/funcs_1/r/innodb_func_view.result:
        Updated test results
      mysql-test/suite/funcs_1/r/memory_func_view.result:
        Updated test results
      mysql-test/suite/funcs_1/r/myisam_func_view.result:
        Updated test results
      mysql-test/t/warnings.test:
        Added test for warnings with row numberAdded test for warnings with row number
      sql/my_decimal.cc:
        Don't use -1 as row number
      sql/share/errmsg.txt:
        Make row numbers unsigned
      af83ac25
  2. 04 Dec, 2009 1 commit
    • Michael Widenius's avatar
      Fixed Bug#47017 rpl_timezone fails on PB-2 with mismatch error · 7c19d664
      Michael Widenius authored
      Fixed coredump in sql_plugin.cc:intern_plugin_lock() on mysqld start with PBXT
      
      
      sql/mysqld.cc:
        Fixed coredump in sql_plugin.cc:intern_plugin_lock() on mysqld start with PBXT
      sql/share/errmsg.txt:
        Row numbers are always positive
      sql/sql_base.cc:
        Fixed race condition in lock tables when killing insert_delayed thread.
        This fixes Bug#47017 rpl_timezone fails on PB-2 with mismatch error
        (Note that the patch only adds a continue; The rest is (required) indentation changes)
      sql/sql_class.cc:
        Fixed wrong output for high end machines in outfile_loaddata.
        (Problem was that ER_TRUNCATED_WRONG_VALUE_FOR_FIELD expects ulong, not ulonglong)
      sql/sql_insert.cc:
        Ensure that if we get a lock problem with delayed_insert, the error is logged.
      7c19d664
  3. 03 Dec, 2009 4 commits
  4. 01 Dec, 2009 4 commits
  5. 30 Nov, 2009 5 commits
    • unknown's avatar
      Merge MySQL 5.1.41 into MariaDB trunk, including a number of after-merge fixes. · 7af12a0d
      unknown authored
      Also merge charset patch.
      7af12a0d
    • Michael Widenius's avatar
      Fixes after comments from last push: · f12371c8
      Michael Widenius authored
      - Removed some not needed casts
      - Change plugin.h to be 'binary compatible' with old versions
      - Added mysql_ft_size_t typedef to plugin.h to make it trivial to change string lengths to size_t on next ABI change
      - Made some fixes suggested by Kristian to make things more portable and future safe (when it comes to strict aliasing)
      
      include/ft_global.h:
        Introduced FT_WEIGTH, to handle fulltext weights in a slightly more portable manner
      include/mysql/plugin.h:
        Change plugin.h to be 'binary compatible' with old versions
        Added mysql_ft_size_t typedef to plugin.h to make it trivial to change string lengths to size_t on next ABI change
        Changed flags to unsigned (as flags should always be unsigned)
      mysql-test/t/information_schema.test:
        Fixed typo
      sql/sp_head.cc:
        Removed cast
      sql/sql_select.cc:
        Removed cast
      sql/table.cc:
        Removed cast
      storage/maria/ma_ft_boolean_search.c:
        Use mysql_ft_size_t instead of size_t for plugin.h code
        Changed some other string lengths to size_t
      storage/maria/ma_ft_nlq_search.c:
        Use FT_WEIGTH to make code more portable
      storage/maria/ma_ft_parser.c:
        Use mysql_ft_size_t instead of size_t for plugin.h code
        Changed some other string lengths to size_t
      storage/maria/ma_ftdefs.h:
        Changed some string lengths to size_t
      storage/maria/maria_ftdump.c:
        Use FT_WEIGTH to make code more portable
      storage/myisam/ft_boolean_search.c:
        Use mysql_ft_size_t instead of size_t for plugin.h code
      storage/myisam/ft_nlq_search.c:
        Use FT_WEIGTH to make code more portable
      storage/myisam/ft_parser.c:
        Use mysql_ft_size_t instead of size_t for plugin.h code
      storage/myisam/myisam_ftdump.c:
        Use FT_WEIGTH to make code more portable
      f12371c8
    • unknown's avatar
    • Michael Widenius's avatar
      Added more general support for sorting 2 characters as one (contractions) · d00be2f3
      Michael Widenius authored
      Added support for Croatian sorting orders utf8_croatian_ci and ucs2_croatian_ci.
      Patch done by Alexander Barkov. See http://www.collation-charts.org/articles/croatian.htm
      
      mysql-test/r/ctype_uca.result:
        Added testing of Croatian sort order
      mysql-test/t/ctype_uca.test:
        Added testing of Croatian sort order
      d00be2f3
    • Michael Widenius's avatar
      Automatic merge · 35ddfbf3
      Michael Widenius authored
      35ddfbf3
  6. 29 Nov, 2009 2 commits
    • Michael Widenius's avatar
      Ignore temporary directory · b77ca064
      Michael Widenius authored
      b77ca064
    • Michael Widenius's avatar
      Remove compiler warnings (Including some warnings from -Wstrict-aliasing) · d38a1519
      Michael Widenius authored
      Don't use static link by default (in compile-pentium) as some new systems doesn't have all static libraries available
      Change type for functions in plugin.h:str_mysql_ftparser_param() to const unsigned char and string lengths to size_t.
      One effect of the above change is that one needs to include mysql_global.h or define size_t before including plugin.h
      This fixes a case where mysql_client_test failed with newer gcc that enables strict-aliasing by default
      
      
      BUILD/compile-pentium:
        Don't use static link by default as some new systems doesn't have all static libraries available
      client/mysql_upgrade.c:
        Remove not used variable
      cmd-line-utils/readline/config_readline.h:
        Define some constants to get rid of compiler warnings on Linux
      cmd-line-utils/readline/display.c:
        Get rid of compiler warnings
      cmd-line-utils/readline/history.c:
        Got rid of compiler warnings:
        - Defining some strings as const
        - Added cast
      cmd-line-utils/readline/rlmbutil.h:
        Added cast to get rid of compiler warnings
      cmd-line-utils/readline/text.c:
        Remove not needed initialization to get rid of compiler warnings
      cmd-line-utils/readline/xmalloc.c:
        Changed types to 'const char* to get rid of compiler warnings
      configure.in:
        Ensure that we use MariaDB as suffix
      include/mysql/plugin.h:
        Changed types to 'const unsigned char* to get rid of compiler warnings (in other parts of the code)
        Change length for not \0 terminated string to size_t
      include/mysql/plugin.h.pp:
        Update related to plugin.h
      libmysql/libmysql.c:
        Fixed bug that caused core dump with newer gcc when strict aliasing is not turned off
      mysql-test/t/information_schema.test:
        Test is depending on innodb
      mysql-test/t/not_partition.test:
        Fixed wrong directory name
        (Not noticed before as we don't ususally run this test)
      mysys/lf_hash.c:
        Got rid of compiler warnings from -Wstrict-aliasing
      mysys/my_redel.c:
        Removed not used variable
      regex/engine.c:
        Changed types to 'const char* to get rid of compiler warnings
      regex/engine.ih:
        Changed types to 'const char* to get rid of compiler warnings
      sql/sp_head.cc:
        Got rid of compiler warning from -Wstrict-aliasing
      sql/sql_base.cc:
        Got rid of compiler warnings from -Wstrict-aliasing
        (The original code was probably wrong as nj_col->table_field was
      sql/sql_builtin.cc.in:
        plugin.h needs to have size_t defined
      sql/sql_parse.cc:
        Remove used variable
      sql/sql_select.cc:
        Got rid of compiler warnings from -Wstrict-aliasing
      sql/sql_show.cc:
        Added #ifdef to get rid of compiler warning when not using partition engine
      sql/table.cc:
        Got rid of compiler warning from -Wstrict-aliasing
      storage/maria/ha_maria.cc:
        Got rid of compiler warnings from -Wstrict-aliasing:
        - Use the thd_killed() API function
      storage/maria/lockman.c:
        Got rid of compiler warnings from -Wstrict-aliasing
      storage/maria/ma_check.c:
        Got rid of compiler warnings from -Wstrict-aliasing
        Change to use new version of _ma_killed_ptr; Don't call it as often as before
      storage/maria/ma_check_standalone.h:
        Update to compatible _ma_killed_ptr() from ha_maria.cc
      storage/maria/ma_ft_boolean_search.c:
        Changed pointers from char -> const char* and length to size_t (to get rid of compiler warnings and casts)
      storage/maria/ma_ft_nlq_search.c:
        Got rid of compiler warnings from -Wstrict-aliasing
        Ensure that 'subkeys' is 32 bit
      storage/maria/ma_ft_parser.c:
        Changed pointers from char -> const char* and length to size_t (to get rid of compiler warnings and casts)
      storage/maria/ma_ftdefs.h:
        Changed pointers from char -> const char* and length to size_t (to get rid of compiler warnings and casts)
      storage/maria/ma_sort.c:
        Change to use new version of _ma_killed_ptr; Don't call it as often as before
      storage/maria/ma_state.c:
        Got rid of compiler warnings from -Wstrict-aliasing
      storage/maria/maria_def.h:
        Redefine ma_killed_ptr()
      storage/maria/maria_ftdump.c:
        Got rid of compiler warnings from -Wstrict-aliasing
      storage/maria/trnman.c:
        Got rid of compiler warnings from -Wstrict-aliasing
      storage/myisam/ft_boolean_search.c:
        Changed pointers from char -> const char* and length to size_t (to get rid of compiler warnings and casts)
      storage/myisam/ft_nlq_search.c:
        Got rid of compiler warnings from -Wstrict-aliasing
      storage/myisam/ft_parser.c:
        Changed pointers from char -> const char* and length to size_t (to get rid of compiler warnings and casts)
      storage/myisam/ft_stopwords.c:
        Changed pointers from char -> const char* and length to size_t (to get rid of compiler warnings and casts)
      storage/myisam/ftdefs.h:
        Changed pointers from char -> const char* and length to size_t (to get rid of compiler warnings and casts)
      storage/myisam/ha_myisam.cc:
        Got rid of compiler warnings from -Wstrict-aliasing:
        - Use the thd_killed() API function
      storage/myisam/mi_check.c:
        Use new killed_ptr() function
      storage/myisam/myisam_ftdump.c:
        Got rid of compiler warnings from -Wstrict-aliasing
      storage/myisam/myisamchk.c:
        Update to compatible killed_ptr() from ha_myisam.cc
      storage/myisam/myisamdef.h:
        Redefine killed_ptr()
      storage/myisam/myisamlog.c:
        Got rid of compiler warnings from -Wstrict-aliasing
      storage/myisam/sort.c:
        Change to use new version of killed_ptr; Don't call it as often as before
      storage/xtradb/fil/fil0fil.c:
        Fixedc ompiler warning
      storage/xtradb/trx/trx0i_s.c:
        Include mysql_plugin.h later to ensure that size_t is defined
      d38a1519
  7. 27 Nov, 2009 1 commit
    • unknown's avatar
      After-merge fixes for MySQL 5.1.41 merge into MariaDB: more fixes for Buildbot problems. · ad3237ed
      unknown authored
      mysql-test/mysql-test-run.pl:
        Manually apply similar patch to the one in Bug#47983.
      mysql-test/suite/rpl/r/rpl_temporary_errors.result:
        Fix wrong failure with warning in error log due to per-test suppressions
        not being active during server shutdown.
      mysql-test/suite/rpl/t/rpl_temporary_errors.test:
        Fix wrong failure with warning in error log due to per-test suppressions
        not being active during server shutdown.
      sql/sql_select.cc:
        Manually cherry-pick fix for Bug#45989.
        For some reason, that fix was reverted in MySQL 5.1, even though it is
        necessary to plug the memory leak.
      ad3237ed
  8. 26 Nov, 2009 6 commits
  9. 25 Nov, 2009 4 commits
  10. 24 Nov, 2009 2 commits
    • unknown's avatar
      After-merge fixes for MySQL 5.1.41 merge: PBXT result file updates. · 16252b6f
      unknown authored
      mysql-test/suite/pbxt/r/func_group.result:
        Result file update.
      mysql-test/suite/pbxt/r/grant.result:
        Use --sorted_result
      mysql-test/suite/pbxt/r/group_min_max.result:
        Result file update.
      mysql-test/suite/pbxt/r/join_nested.result:
        Result file update.
      mysql-test/suite/pbxt/r/negation_elimination.result:
        Result file update.
      mysql-test/suite/pbxt/r/ps_grant.result:
        Use --sorted_result
      mysql-test/suite/pbxt/r/skip_grants.result:
        Result file update.
      mysql-test/suite/pbxt/r/subselect.result:
        Adjust test case following error message change due to fix of Bug#48293
      mysql-test/suite/pbxt/r/view_grant.result:
        Result file update.
      mysql-test/suite/pbxt/t/grant.test:
        Use --sorted_result
      mysql-test/suite/pbxt/t/ps_grant.test:
        Use --sorted_result
      mysql-test/suite/pbxt/t/subselect.test:
        Adjust test case following error message change due to fix of Bug#48293
      16252b6f
    • unknown's avatar
      After-merge fix for MySQL 5.1.41 merge: suppress some warnings during shutdown. · ec41738e
      unknown authored
      The MySQL 5.1.41 merge adds back some more warning lines in error log to be
      checked. So some suppressions for these new ones need to be added to the code
      in MariaDB that checks for warnings during server shutdown (MySQL only checks
      for warnings that occur while executing the test cases themselves).
      ec41738e
  11. 23 Nov, 2009 1 commit
    • unknown's avatar
      After-merge fixes for MySQL 5.1.41 merge into MariaDB. · e2e3e5cc
      unknown authored
      Makefile.am:
        Fix incorrect automerges.
      mysql-test/mysql-test-run.pl:
        Fix bad merge.
        We revert some of the MySQL-side changes, as the problem is that they may accidentally ignore some warnings in mysqld.err that should be reported.
        Also remove some differences between MySQL and MariaDB where there is no semantic difference (to make future merges easier).
      e2e3e5cc
  12. 18 Nov, 2009 1 commit
  13. 16 Nov, 2009 4 commits
    • unknown's avatar
      c02cdfe4
    • unknown's avatar
      Corrected a line from the patch for table elimination (WL#17) · e6206f99
      unknown authored
      to fix a problem with the test case for bug#42116. 
      
      Re-commit of Igor's fix due to re-commit of MySQL 5.1.41 merge.
      e6206f99
    • unknown's avatar
      Merge with MySQL 5.1, with following additions: · 69b8b9d6
      unknown authored
      - Moved some code from innodb_plugin to xtradb, to ensure that all tests runs
      - Did changes in pbxt and maria storage engines becasue of changes in thd->query
      - Reverted wrong code in sql_table.cc for how ROW_FORMAT is used.
      
      This is a re-commit of Monty's merge to eliminate an extra commit from
      MySQL-5.1.42 that was accidentally included in the merge.
      
      This is a merge of the MySQL 5.1.41 clone-off (clone-5.1.41-build). In
      case there are any extra changes done before final MySQL 5.1.41
      release, these will need to be merged later before MariaDB 5.1.41
      release.
      69b8b9d6
    • Michael Widenius's avatar
      Safety change to ensure read/black trees (used with heap tables) works on 64... · 40197f0f
      Michael Widenius authored
      Safety change to ensure read/black trees (used with heap tables) works on 64 bit setups where ulong <> size_t
      Don't retry test cases by default
      Fixed bug where we could (under unlikely error conditions) access not initialized variable
      
      include/my_tree.h:
        Safety change to ensure read/black trees (used with heap tables) works on 64 bit setups where ulong <> size_t
        (Pointed out by Bryan Aker)
      mysql-test/mysql-test-run.pl:
        Don't retry test cases by default
        This makes it too easy to miss failures and we have anyway to fix race conditions, not ignore them.
      mysys/tree.c:
        Safety change to ensure read/black trees (used with heap tables) works on 64 bit setups where ulong <> size_t
      sql/sql_delete.cc:
        Fixed bug where we could (under unlikely error conditions) access not initialized variable.
        (Pointed out by Bryan Aker)
      40197f0f
  14. 14 Nov, 2009 4 commits