- 12 Oct, 2021 2 commits
-
-
Oleksandr Byelkin authored
Get rid of locking "empty" plugin. This problem present in our tests in case of malformed frm-file, for example.
-
Oleksandr Byelkin authored
MDEV-26637: (explicit length) ASAN: main.metadata and user_variables.basic MTR failures after MDEV-26572 Use explicit length for hash record length
-
- 11 Oct, 2021 1 commit
-
-
Otto Kekäläinen authored
- Add libconfig-inifiles-perl to mariadb-client depends as mytop uses it https://salsa.debian.org/mariadb-team/mariadb-10.5/-/commit/7a748da87a23eb874d0bddb64114a795e9d07e6d http://bugs.debian.org/875708 - Make libzstd dependency versioned as RocksDB need at least 1.3.3 https://salsa.debian.org/mariadb-team/mariadb-10.5/-/commit/da4eb54fc0c2ded0e10243fe1d81bf7e105a25c3 However, https://github.com/facebook/rocksdb/blob/master/INSTALL.md implies that zstandard 1.1.3 would suffice. Version 1.3.x is available from Debian Stretch-backports and Ubuntu Xenial onwards.
-
- 06 Oct, 2021 8 commits
-
-
Rucha Deodhar authored
Fixed after patch MDEV-26606 because root cause was same. Analysis: m_current_row_for_warning is reset to 1 during cleanup phase of stored procedure. When we perform a copy because some statement of procedure created warning, this reset value is passed to push _warning(). Fix: Add a parameter in relevant functions to pass correct value of error index and don't use m_current_row_for_warning directly.
-
Rucha Deodhar authored
statement Not repeatable after MDEV-26606. Test case added.
-
Rucha Deodhar authored
procedure Analysis: m_current_row_for_warning is reset to 1 during cleanup phase of stored procedure. When we perform a copy because some statement of procedure created warning, this reset value is passed to push_warning(). Hence the output is always 1. Fix: Add a parameter in relevant functions to pass correct value of row_number and don't use m_current_row_for_warning directly.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
mkaruza authored
MDEV-22708 Assertion `!mysql_bin_log.is_open() || thd.is_current_stmt_binlog_format_row()' failed in Delayed_insert::handle_inserts and in Diagnostics_area::set_eof_status Function `upgrade_lock_type` should check global binlog_format variable instead of thread one. Reviewed-by:
Jan Lindström <jan.lindstrom@mariadb.com>
-
Marko Mäkelä authored
-
- 05 Oct, 2021 8 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Updated libmariadb and enable the test.
-
Marko Mäkelä authored
-
Rucha Deodhar authored
Fixup for MDEV-10075 Analysis: ERROR_INDEX implemented in MDEV-10075 was not intuitively clear. Fix: changed parser to use ROW_NUMBER instead of ERROR_INDEX. Removed ERROR_INDEX and ERROR_INDEX_SYM from related files. Changed m_error_index to m_row_number.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
GCC 4.8.5 would crash when compiling trx_purge_truncate_history(). Let us try to avoid that by disabling optimizations for the function.
-
- 04 Oct, 2021 7 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
The test was passing some uninitialized data to libmariadb. Mostly, the MemorySanitizer wrapper of send() detected that some bytes were uninitialized. The test_mdev19838() is for now disabled under MemorySanitizer, to be fixed in MDEV-26761.
-
Daniel Black authored
Fixes: 5c5ea59b
-
Daniel Black authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 03 Oct, 2021 2 commits
-
-
Vladislav Vaintroub authored
-
Marko Mäkelä authored
This is mostly working around a bad compiler optimization. The Intel 80386 processor introduced some bit operations that would be the perfect translation for atomic single-bit read-modify-and-write operations. Alas, even the latest compilers as of today (GCC 11, clang 13, Microsoft Visual C 19.29) would generate a loop around LOCK CMPXCHG instead of emitting the instructions LOCK BTS (fetch_or()), LOCK BTR (fetch_and()), LOCK BTC (fetch_xor()). fil_space_t::clear_closing(): Clear the CLOSING flag. fil_space_t::set_stopping_check(): Special variant of fil_space_t::set_stopping() that will return the old value of the STOPPING flag after atomically setting it. fil_space_t::clear_stopping(): Use fetch_sub() to toggle the STOPPING flag. The flag is guaranteed to be set upon calling this function, hence we will toggle it to clear it. On IA-32 and AMD64, this will translate into the 80486 LOCK XADD instruction. fil_space_t::check_pending_operations(): Replace a Boolean variable with a goto label, to allow more compact code generation for fil_space_t::set_stopping_check(). trx_rseg_t: Define private accessors ref_set() and ref_reset() for setting and clearing the flags. trx_lock_t::clear_deadlock_victim(), trx_lock_t::set_wsrep_victim(): Accessors for clearing and setting the flags.
-
- 02 Oct, 2021 4 commits
-
-
Marko Mäkelä authored
rw_lock::write_unlock(): Revert part of commit d46b4248 (MDEV-24142) to make the IA-32 and AMD64 implementation faster.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 01 Oct, 2021 2 commits
-
-
mkaruza authored
MDEV-22708 Assertion `!mysql_bin_log.is_open() || thd.is_current_stmt_binlog_format_row()' failed in Delayed_insert::handle_inserts and in Diagnostics_area::set_eof_status Variable wsrep_forced_binlog_format has higher priority than binlog_format. In situation where STATEMENT is used and DELAYED INSERT is executing we should fall back to non-delay INSERT. Reviewed-by:
Jan Lindström <jan.lindstrom@mariadb.com>
-
Daniel Black authored
Per review by Serg, include start row with new line. We are hoping we haven't annoyed people that prefered the old way. Adding an option for new lines seems like over-engineering in advance. So if there are complaints, let them be known (JIRA), and we'll add this under an option. Test cases updated.
-
- 30 Sep, 2021 6 commits
-
-
rmfalves authored
Currently, mysqldump --extended-insert outputs all rows on a single line, which makes it difficult to use with various Unix command-line utilities such as grep and diff. We change mysqldump to emit a linebreak between each row, that would make it easier to work with, without significantly affecting dump or restore performance, or affecting compatibility. Closes: #1865
-
mkaruza authored
Using `innodb_thread_concurrency` will call `wsrep_thd_is_aborting` to check WSREP thread state. This call should be protected by taking `LOCK_thd_data` before entering function. Applier and TOI threads should no be affected with usage of `innodb_thread_concurrency` variable so returning before any checks. Reviewed-by:
Jan Lindström <jan.lindstrom@mariadb.com>
-
sjaakola authored
If a table has no unique indexes, write set key information will be collected on all columns in the table. The write set key information has space only for max 3500 bytes for individual column, and if a varchar colummn of such non-primary key table is longer than this limit, currently a crash follows. The fix in this commit, is to truncate key values extracted from such long varhar columns to max 3500 bytes. This may potentially lead to false positive certification failures for transactions, which operate on separate cluster nodes, and update/insert/delete table rows, which differ only in the part of such long columns after 3500 bytes border. Reviewed-by:
Jan Lindström <jan.lindstrom@mariadb.com>
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
In commit 45ed9dd9 (MDEV-23855) when removing fil_system.LRU we failed to rate-limit the output for reporting violations of innodb_open_files or open_files_limit. If the server is run with a small limit of open files that is well below the number of .ibd files that are being accessed by the workload, and if at the same time innodb_log_file_size is very small so that log checkpoints will occur frequently, the process of enforcing the open files limit may be run very often. fil_space_t::try_to_close(): Display at most one message per call, and only if at least 5 seconds have elapsed since the last time a message was output. fil_node_open_file(): Only output a summary message if fil_space_t::try_to_close() displayed a message during this run. (Note: multiple threads may execute fil_node_open_file() on different files at the same time.) fil_space_t::get(): Do not dereference a null pointer if n & STOPPING. This was caught by the test case below. Unfortunately, it is not possible to create a fully deterministic test case (expecting exactly 1 message to be emitted). The following with --innodb-open-files=10 --innodb-log-file-size=4m would occasionally fail to find the message in the log: --source include/have_innodb.inc --source include/have_partition.inc --source include/have_sequence.inc call mtr.add_suppression("InnoDB: innodb_open_files=10 is exceeded"); CREATE TABLE t1 (pk INT AUTO_INCREMENT PRIMARY KEY) ENGINE=InnoDB PARTITION BY key (pk) PARTITIONS 100; INSERT INTO t1 SELECT * FROM seq_1_to_100; --disable_query_log let $n=400; while ($n) { BEGIN; DELETE FROM t1; ROLLBACK; dec $n; } --enable_query_log let SEARCH_FILE= $MYSQLTEST_VARDIR/log/mysqld.1.err; let SEARCH_PATTERN= \[Note\] InnoDB: Cannot close file; -- source include/search_pattern_in_file.inc DROP TABLE t1;
-