1. 09 Oct, 2007 5 commits
    • unknown's avatar
      Merge mysql.com:/home/ram/work/b31249/b31249.5.0 · afbf1985
      unknown authored
      into  mysql.com:/home/ram/work/b31249/b31249.5.1
      
      
      sql/item_timefunc.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/type_datetime.result:
        manual merge.
      mysql-test/t/type_datetime.test:
        manual merge.
      afbf1985
    • unknown's avatar
      Fix for bug #31249: Assertion `!table || (!table->write_set || · 0602a4fe
      unknown authored
      bitmap_is_set(table->write_set, fiel
      
      Problem: creating a temporary table we allocate the group buffer if needed
      followed by table bitmaps (see create_tmp_table()). Reserving less memory for 
      the group buffer than actually needed (used) for values retrieval may lead 
      to overlapping with followed bitmaps in the memory pool that in turn leads 
      to unpredictable consequences.
      
      As we use Item->max_length sometimes to calculate group buffer size,
      it must be set to proper value. In this particular case 
      Item_datetime_typecast::max_length is too small.
      
      Another problem is that we use max_length to calculate the group buffer
      key length for items represented as DATE/TIME fields which is superfluous.
      
      Fix: set Item_datetime_typecast::max_length properly,
      accurately calculate the group buffer key length for items 
      represented as DATE/TIME fields in the buffer.
      
      
      mysql-test/r/type_datetime.result:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - test result.
      mysql-test/t/type_datetime.test:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - test case.
      sql/item_timefunc.h:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - set Item_datetime_typecast::max_length properly.
      sql/sql_select.cc:
        Fix for bug #31249: Assertion `!table || (!table->write_set || 
        bitmap_is_set(table->write_set, fiel
          - the group buffer key length for items represented as 
        DATE/TIME fields in the buffer should be calculated using
        the maximum pack length of such fields (== 8), using 
        max_length here is redundant.
      0602a4fe
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-maint · b127976c
      unknown authored
      into  alf.(none):/src/bug28774/my51-bug28774
      
      b127976c
    • unknown's avatar
      Merge alf.(none):/src/bug28774/my50-bug28774 · e4779936
      unknown authored
      into  alf.(none):/src/bug28774/my51-bug28774
      
      
      client/mysql_upgrade.c:
        Auto merged
      e4779936
    • unknown's avatar
      Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and · 36773be2
      unknown authored
      doesn't clean them up
      - Make sure to cleanup temporary files after use.
      
      
      client/mysql_upgrade.c:
        Bug#28774 mysql_upgrade creates tempfiles in root-dir (C:\) and 
        doesn't clean them up
        - Close file handle and delete temporary file when write fails.
      36773be2
  2. 08 Oct, 2007 3 commits
  3. 06 Oct, 2007 2 commits
  4. 05 Oct, 2007 26 commits
  5. 04 Oct, 2007 4 commits