1. 20 Mar, 2008 1 commit
  2. 18 Mar, 2008 3 commits
    • unknown's avatar
      BUG#34768 - nondeterministic INSERT using LIMIT logged in stmt mode if · 5d36e601
      unknown authored
                  binlog_format=mixed
      
      Statement-based replication of DELETE ... LIMIT, UPDATE ... LIMIT,
      INSERT ... SELECT ... LIMIT is not safe as order of rows is not
      defined.
      
      With this fix, we issue a warning that this statement is not safe to
      replicate in statement mode, or go to row-based mode in mixed mode.
      
      Note that we may consider a statement as safe if ORDER BY primary_key
      is present. However it may confuse users to see very similiar statements
      replicated differently.
      
      Note 2: regular UPDATE statement (w/o LIMIT) is unsafe as well, but
      this patch doesn't address this issue. See comment from Kristian
      posted 18 Mar 10:55.
      
      
      mysql-test/suite/binlog/r/binlog_stm_ps.result:
        Updated a test case according to fix for BUG#34768:
        INSERT ... SELECT ... LIMIT is now replicated in row mode.
      mysql-test/suite/binlog/r/binlog_unsafe.result:
        A test case for BUG#34768.
      mysql-test/suite/binlog/t/binlog_unsafe.test:
        A test case for BUG#34768.
      sql/sql_delete.cc:
        Statement-based replication of DELETE ... LIMIT is not safe as order of
        rows is not defined, so in mixed mode we go to row-based.
      sql/sql_insert.cc:
        Statement-based replication of INSERT ... SELECT ... LIMIT is not safe
        as order of rows is not defined, so in mixed mode we go to row-based.
      sql/sql_update.cc:
        Statement-based replication of UPDATE ... LIMIT is not safe as order of
        rows is not defined, so in mixed mode we go to row-based.
      5d36e601
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/cov/mysql-5.0-engines · 34be4016
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/cov/mysql-5.1-engines
      
      
      sql/log_event.cc:
        Auto merged
      sql/repl_failsafe.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      34be4016
    • unknown's avatar
      Make gcov happy. · bfd4b3ce
      unknown authored
      bfd4b3ce
  3. 17 Mar, 2008 3 commits
    • unknown's avatar
      Bug#35306: partition_basic_symlink test failures · 4827ddc2
      unknown authored
      Have changed the DATA/INDEX dir to not be a database dir.
      (and made some changes for better result files.)
      
      
      mysql-test/suite/parts/inc/partition_basic_symlink.inc:
        Bug#35306: partition_basic_symlink test failures
        
        after bug 32167 it is not allowed with DATA/INDEX DIR in any database
        directory.
        
        remade the inc-files to make better use of each other (less duplicate tests)
      mysql-test/suite/parts/inc/partition_directory.inc:
        Removed disable/enable_query_log for better result files
      mysql-test/suite/parts/inc/partition_layout_check1.inc:
        changed DATA/INDEX DIR
      mysql-test/suite/parts/inc/partition_layout_check2.inc:
        added check with_directories
      mysql-test/suite/parts/inc/partition_methods1.inc:
        Removed disable/enable_query_log for better result files
      mysql-test/suite/parts/inc/partition_methods2.inc:
        Removed disable/enable_query_log for better result files
        Added with_directories for testing of DATA/INDEX DIR
      mysql-test/suite/parts/r/partition_basic_innodb.result:
        Updated test result due to test case changes
      mysql-test/suite/parts/r/partition_basic_myisam.result:
        Updated test result due to test case changes
      mysql-test/suite/parts/r/partition_basic_symlink_innodb.result:
        Updated test result due to test case changes
      mysql-test/suite/parts/r/partition_basic_symlink_myisam.result:
        Updated test result due to test case changes
      mysql-test/suite/parts/t/disabled.def:
        Bug#35306: parts.partition_basic_symlink test failures
        Enable the test again since the have been fixed
      mysql-test/suite/parts/t/partition_basic_innodb.test:
        Added check for table files.
      mysql-test/suite/parts/t/partition_basic_myisam.test:
        removing dependency of symlink
        (test exists now in parts.partition_basic_symlink_myisam)
      mysql-test/suite/parts/t/partition_basic_symlink_innodb.test:
        Bug#35306: partition_basic_symlink test failures
        
        Removed old test (since DATA/INDEX DIRECTORY is not supported in InnoDB)
        and replaced it with a simple test that altering a partitioned innodb
        with DATA/INDEX DIR to MyISAM, would use the DATA/INDEX DIR.
      4827ddc2
    • unknown's avatar
      Bug#35305: partition_symlink test failures · fdabb761
      unknown authored
      Updated the test due to bug 32167
      
      Corrected spelling of error message
      
      
      mysql-test/r/partition_not_windows.result:
        Updated test result due to test case changes and corrected spelling error
      mysql-test/r/partition_symlink.result:
        Bug#35305: partition_symlink test failure
        
        Updated test result due to test case changes
      mysql-test/r/symlink.result:
        Updated test result due to test case changes and corrected spelling error
      mysql-test/t/disabled.def:
        Bug#35305: partition_symlink test failure
        
        Enable the test after it has been fixed
      mysql-test/t/partition_not_windows.test:
        Removed disable/enable_query_log for better result files
      mysql-test/t/partition_symlink.test:
        Bug#35305: partition_symlink test failure
        
        Changes due to bug 32167
      mysql-test/t/symlink.test:
        using replace_result instead of disable_query_log
      sql/partition_info.cc:
        corrected spelling
      sql/sql_parse.cc:
        corrected spelling
      fdabb761
    • unknown's avatar
      Valgrind warnings found after bug#32943 and after merge from -main · f09fc126
      unknown authored
      into -engines tree.
      
      hander::table_share was not updated after changing table->s.
      
      
      sql/ha_partition.cc:
        Valgrind warning after merge -main -> -engines, after bug#32943
        
        change_table_ptr can happen in a middle of
        alter table rename/drop/... partition
        
        the newly created partitions must get the updated table_share too.
      sql/sql_base.cc:
        Bug#32943 was missing a call to change_table_ptr, this was found by valgrind
        after a merge from -main to -engines.
      f09fc126
  4. 15 Mar, 2008 3 commits
    • unknown's avatar
      make pushbuild green · eef61457
      unknown authored
      
      mysql-test/t/disabled.def:
        make pushbuild green, entry added to wrong disabled.def file.
      eef61457
    • unknown's avatar
      make pushbuild green · fe227c80
      unknown authored
      fe227c80
    • unknown's avatar
      fix results after merge · 4a206fcd
      unknown authored
      
      mysql-test/r/partition_not_windows.result:
        fix results from merge
      mysql-test/t/disabled.def:
        disable test partition_symlink
      4a206fcd
  5. 14 Mar, 2008 13 commits
    • unknown's avatar
      Merge acurtis@bk-internal.mysql.com:/home/bk/mysql-5.1-engines · b83a9972
      unknown authored
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/merge.20080307/mysql-5.1
      
      
      sql/sql_yacc.yy:
        Auto merged
      b83a9972
    • unknown's avatar
      Merge acurtis@bk-internal.mysql.com:/home/bk/mysql-5.0-engines · 89ba6b3f
      unknown authored
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/merge.20080307/mysql-5.0
      
      
      sql/sql_yacc.yy:
        Auto merged
      89ba6b3f
    • unknown's avatar
      BUG#28248 - mysqldump results with MERGE ... UNION=() cannot be executed · 3a23d660
      unknown authored
      After merge fix.
      
      3a23d660
    • unknown's avatar
      Merge pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/mysql-5.1-engines · 607a31f2
      unknown authored
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/merge.20080307/mysql-5.1
      
      607a31f2
    • unknown's avatar
      Merge pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/mysql-5.0-engines · e0e039bd
      unknown authored
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/merge.20080307/mysql-5.0
      
      e0e039bd
    • unknown's avatar
      Merge... · e1c6a503
      unknown authored
      Merge pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/merge.20080307/mysql-5.0
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/merge.20080307/mysql-5.1
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      e1c6a503
    • unknown's avatar
      Merge pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/mysql-5.1 · cfb8268a
      unknown authored
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/merge.20080307/mysql-5.1
      
      
      configure.in:
        Auto merged
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/r/partition.result:
        Auto merged
      mysql-test/r/partition_symlink.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      mysql-test/t/partition.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/partition_info.cc:
        Auto merged
      sql/partition_info.h:
        Auto merged
      sql/rpl_rli.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      mysql-test/r/symlink.result:
        manual merge
      mysql-test/suite/parts/inc/partition_basic.inc:
        manual merge
      mysql-test/suite/parts/r/partition_basic_innodb.result:
        manual merge
      mysql-test/suite/parts/r/partition_basic_myisam.result:
        manual merge
      mysql-test/t/partition_symlink.test:
        manual merge
      mysql-test/t/symlink.test:
        manual merge
      sql/sql_parse.cc:
        manual merge
      cfb8268a
    • unknown's avatar
      Merge pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/mysql-5.0 · c1e10141
      unknown authored
      into  pcg5ppc.xiphis.org:/Network/Servers/anubis.xiphis.org/home/antony/work/merge.20080307/mysql-5.0
      
      
      mysql-test/r/func_misc.result:
        Auto merged
      mysql-test/r/myisam.result:
        Auto merged
      mysql-test/t/func_misc.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      c1e10141
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG28248/mysql-5.0-engines · 80ed8583
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG28248/mysql-5.1-engines
      
      
      mysql-test/r/merge.result:
        Auto merged
      mysql-test/t/merge.test:
        Auto merged
      storage/myisammrg/ha_myisammrg.cc:
        Auto merged
      sql/sql_yacc.yy:
        After merge fix.
      80ed8583
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.0-engines · 02133f38
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG28248/mysql-5.0-engines
      
      02133f38
    • unknown's avatar
      BUG#28248 - mysqldump results with MERGE ... UNION=() cannot be executed · c0a50251
      unknown authored
      When there are no underlying tables specified for a merge table,
      SHOW CREATE TABLE outputs a statement that cannot be executed. The
      same is true for mysqldump (it generates dumps that cannot be
      executed).
      
      This happens because SQL parser does not accept empty UNION() clause.
      
      This patch changes the following:
      - it is now possible to execute CREATE/ALTER statement with
        empty UNION() clause.
      - the same as above, but still worth noting: it is now possible to
        remove underlying tables mapping using ALTER TABLE ... UNION=().
      - SHOW CREATE TABLE does not output UNION() clause if there are
        no underlying tables specified for a merge table. This makes
        mysqldump slightly smaller.
      
      
      mysql-test/r/merge.result:
        A test case for BUG#28248.
      mysql-test/t/merge.test:
        A test case for BUG#28248.
      sql/ha_myisammrg.cc:
        Do not output UNION clause in SHOW CREATE TABLE, when there are
        no underlying tables defined.
      sql/sql_yacc.yy:
        Make underlying table list for MERGE engine optional.
        
        As for MERGE engine empty underlying tables list is valid, it should
        be valid for the parser as well.
        
        This change is mostly needed to restore dumps made by earlier MySQL
        versions. Also with this fix it is possible to remove underlying
        tables mapping by using ALTER TABLE ... UNION=().
      c0a50251
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.0-engines · addeb300
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG13861/mysql-5.1-engines
      
      
      mysql-test/suite/rpl/r/rpl_dual_pos_advance.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_dual_pos_advance.test:
        SCCS merged
      addeb300
    • unknown's avatar
      BUG#13861 - START SLAVE UNTIL may stop 1 evnt too late if · db911b4c
      unknown authored
                  log-slave-updates and circul repl
      
      This is a test case fix for BUG#13861.
      
      
      mysql-test/r/rpl_dual_pos_advance.result:
        Fix for a test case for BUG#13861.
      mysql-test/t/rpl_dual_pos_advance.test:
        Fix for a test case for BUG#13861.
        
        master_pos_wait() requires slave sql thread running. But it is not
        guaranteed for this test case. As we use start slave until it may
        execute all events and shutdown before master_pos_wait() is started.
        
        On the other hand it is safe just to wait for slave to stop here,
        as start slave returns _after_ sql thread is started.
      db911b4c
  6. 13 Mar, 2008 2 commits
  7. 12 Mar, 2008 10 commits
    • unknown's avatar
      eefc19c5
    • unknown's avatar
      Merge ssh://bk-internal.mysql.com//home/bk/mysql-5.1-opt · 0d35eafc
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      sql/sql_show.cc:
        Auto merged
      sql/table.h:
        Auto merged
      0d35eafc
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · df7268dc
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      tests/mysql_client_test.c:
        Manual merge.
      df7268dc
    • unknown's avatar
      Post-merge fix. · 821d164b
      unknown authored
      821d164b
    • unknown's avatar
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-5.0-opt · 2d91ad60
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/r/view.result:
        Auto merged
      mysql-test/t/view.test:
        Auto merged
      scripts/mysql_config.sh:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      2d91ad60
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.1 · e38a0de2
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      client/mysqldump.c:
        Auto merged
      configure.in:
        Auto merged
      include/my_global.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/lib_sql.cc:
        Auto merged
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/innodb.result:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/select.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/create.test:
        Auto merged
      mysql-test/t/disabled.def:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      storage/ndb/src/kernel/blocks/backup/Backup.hpp:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/func_time.result:
        Manual merge.
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      scripts/mysql_config.sh:
        Manual merge.
      sql-common/client.c:
        Manual merge.
      sql/sql_parse.cc:
        Manual merge.
      e38a0de2
    • unknown's avatar
      Merge kaamos.(none):/data/src/opt/mysql-4.1-opt · ddfd9942
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      ddfd9942
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-5.0 · 242078d0
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-5.0-opt
      
      
      client/mysql.cc:
        Auto merged
      sql/filesort.cc:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      mysql-test/r/view.result:
        Manual merge.
      mysql-test/t/view.test:
        Manual merge.
      scripts/mysql_config.sh:
        Manual merge.
      242078d0
    • unknown's avatar
      Merge kaamos.(none):/data/src/mysql-4.1 · 70cc07cf
      unknown authored
      into  kaamos.(none):/data/src/opt/mysql-4.1-opt
      
      70cc07cf
  8. 11 Mar, 2008 3 commits
  9. 10 Mar, 2008 2 commits