1. 06 Jul, 2007 3 commits
  2. 05 Jul, 2007 2 commits
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/mysql/BUG27564/mysql-4.1-engines · dc308c51
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG27564/mysql-5.0-engines
      
      
      mysys/hash.c:
        Auto merged
      dc308c51
    • unknown's avatar
      BUG#27564 - Valgrind: UDF does not cleanup correctly · b7bf9725
      unknown authored
      Dropping an user defined function may cause server crash in
      case this function is still in use by another thread.
      
      The problem was that our hash implementation didn't update
      hash link list properly when hash_update() was called.
      
      
      mysys/hash.c:
        The following requirement wasn't met by hash_update() function
        causing corruption of hash links list:
        
        After a record was unlinked from the old chain during update, it
        holds random position. By the chance this position is equal to
        position for the first element in the new chain. That means
        updated record is the only record in the new chain.
      b7bf9725
  3. 03 Jul, 2007 1 commit
  4. 02 Jul, 2007 5 commits
  5. 01 Jul, 2007 2 commits
  6. 30 Jun, 2007 2 commits
  7. 29 Jun, 2007 16 commits
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/p2-bug25513.5 · 97139ca5
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/5.0-engines-merge
      
      
      97139ca5
    • unknown's avatar
      fix Visual Studio build - strictness of compiler could not cast · c268fd77
      unknown authored
      pointer into a BOOL type.
      
      
      c268fd77
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29205 · a89259fa
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      a89259fa
    • unknown's avatar
      Fixed bug #29205. · db397d16
      unknown authored
      When a UNION statement forced conversion of an UTF8
      charset value to a binary charset value, the byte
      length of the result values was truncated to the
      CHAR_LENGTH of the original UTF8 value.
      
      
      sql/item.cc:
        Fixed bug #29205.
        The calculation of data length was modified in
        the Item_type_holder::join_types method to take into
        account possible conversion of a multibyte charset
        value to a binary charset value, when each
        multibyte character is converted into a sequence
        of bytes (not to a single byte of binary charset).
      mysql-test/t/ctype_utf8.test:
        Updated test case for bug #29205.
      mysql-test/r/ctype_utf8.result:
        Updated test case for bug #29205.
      db397d16
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/mysql-5.0-engines · eda9c97e
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/5.0-engines-merge
      
      
      eda9c97e
    • unknown's avatar
      Merge anubis.xiphis.org:/usr/home/antony/work/p2-bug25511.5 · 495dfde5
      unknown authored
      into  anubis.xiphis.org:/usr/home/antony/work/p2-bug25513.5
      
      
      sql/ha_federated.cc:
        Auto merged
      495dfde5
    • unknown's avatar
      add and amend comments for clarity · b4fe5e44
      unknown authored
      
      include/my_base.h:
        amend comment for clarity
      sql/ha_federated.cc:
        add comment
      b4fe5e44
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-amain · 29d2edfa
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      
      29d2edfa
    • unknown's avatar
      Merge synthia.local:/home/mydev/mysql-5.0-ateam · b6fbbc9b
      unknown authored
      into  synthia.local:/home/mydev/mysql-5.0-axmrg
      
      
      b6fbbc9b
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 6a00ce71
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/29261-bug-5.0-opt-mysql
      
      
      6a00ce71
    • unknown's avatar
      Bug#29261: Sort order of the collation wasn't used when comparing trailing · 4772a012
      unknown authored
      spaces.
      
      When the my_strnncollsp_simple function compares two strings and one is a prefix
      of another then this function compares characters in the rest of longer key
      with the space character to find whether the longer key is greater or less.
      But the sort order of the collation isn't used in this comparison. This may
      lead to a wrong comparison result, wrongly created index or wrong order of the
      result set of a query with the ORDER BY clause.
      
      Now the my_strnncollsp_simple function uses collation sort order to compare
      the characters in the rest of longer key with the space character.
      
      
      mysql-test/t/ctype_collate.test:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      mysql-test/r/ctype_collate.result:
        Added a test case for the bug#29261: Sort order of the collation wasn't used
        when comparing trailing spaces.
      strings/ctype-simple.c:
        Bug#29261: Sort order of the collation wasn't used when comparing trailing
        spaces.
        Now the my_strnncollsp_simple function uses collation sort order to compare
        the characters in the rest of longer key with the space character.
      4772a012
    • unknown's avatar
      Update result files. · f10d930b
      unknown authored
      
      mysql-test/r/ps_6bdb.result:
        Update result file.
      mysql-test/r/ps_7ndb.result:
        Update result file.
      f10d930b
    • unknown's avatar
      Follow up to the patch for the BUG#10491. · 54c3809d
      unknown authored
      
      mysql-test/r/ps_1general.result:
        Update result file.
      mysql-test/r/ps_2myisam.result:
        Update result file.
      mysql-test/r/ps_3innodb.result:
        Update result file.
      mysql-test/r/ps_4heap.result:
        Update result file.
      mysql-test/r/ps_5merge.result:
        Update result file.
      tests/mysql_client_test.c:
        Fix test -- after field changing character set to utf8 in the server,
        length should be calculated differently.
      54c3809d
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 33eb22a3
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B27333-gcov-5.0-opt
      
      
      33eb22a3
    • unknown's avatar
      Bug#27333: subquery grouped for aggregate of outer · c2e961cf
      unknown authored
      query / no aggregate of subquery
       The optimizer counts the aggregate functions that 
       appear as top level expressions (in all_fields) in 
       the current subquery. Later it makes a list of these
       that it uses to actually execute the aggregates in
       end_send_group().
       That count is used in several places as a flag whether
       there are aggregates functions.
       While collecting the above info it must not consider
       aggregates that are not aggregated in the current 
       context. It must treat them as normal expressions 
       instead. Not doing that leads to incorrect data about
       the query, e.g. running a query that actually has no
       aggregate functions as if it has some (and hence is
       expected to return only one row).
       Fixed by ignoring the aggregates that are not aggregated
       in the current context. 
       One other smaller omission discovered and fixed in the 
       process : the place of aggregation was not calculated for
       user defined functions. Fixed by calling 
       Item_sum::init_sum_func_check() and 
       Item_sum::check_sum_func() as it's done for the rest of 
       the aggregate functions.
      
      
      mysql-test/r/subselect.result:
        Bug #27333: test case
      mysql-test/t/subselect.test:
        Bug #27333: test case
      sql/item_subselect.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.cc:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      sql/item_sum.h:
        Bug#27333: calculate the place of 
         aggregation for user defined functions.
      sql/sql_select.cc:
        Bug#27333: When counting the aggregated functions
         and collecting a list of them we must not consider
         the aggregates that are not aggregated in the local
         context as "local" : i.e. we must treat them as 
         normal functions and not add them to the aggregate
         functions list.
      sql/sql_select.h:
        Bug#27333: need select_lex to filter out
         aggregates that are not aggregated in
         the current select.
      c2e961cf
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 73023608
      unknown authored
      into  mysql.com:/home/hf/work/29247/my50-29247
      
      
      sql-common/client.c:
        Auto merged
      73023608
  8. 28 Jun, 2007 6 commits
    • unknown's avatar
      Bug#25513 · dba70720
      unknown authored
        "Federared Transactions Failure"
        Bug occurs when the user performs an operation which inserts more than 
        one row into the federated table and the federated table references a 
        remote table stored within a transactional storage engine. When the
        insert operation for any one row in the statement fails due to 
        constraint violation, the federated engine is unable to perform 
        statement rollback and so the remote table contains a partial commit. 
        The user would expect a statement to perform the same so a statement 
        rollback is expected.
        This bug was fixed by implementing  bulk-insert handling into the
        federated storage engine. This will relieve the bug for most common
        situations by enabling the generation of a multi-row insert into the
        remote table and thus permitting the remote table to perform 
        statement rollback when neccessary.
        The multi-row insert is limited to the maximum packet size between 
        servers and should the size overflow, more than one insert statement 
        will be sent and this bug will reappear. Multi-row insert is disabled
        when an "INSERT...ON DUPLICATE KEY UPDATE" is being performed.
        The bulk-insert handling will offer a significant performance boost 
        when inserting a large number of small rows.
      This patch builds on Bug29019 and Bug25511
      
      
      sql/ha_federated.cc:
        bug25513
          new member methods:
            start_bulk_insert() - initializes memory for bulk insert
            end_bulk_insert() - sends any remaining bulk insert and frees memory
            append_stmt_insert() - create the INSERT statement
      sql/ha_federated.h:
        bug25513
          new member value:
            bulk_insert
          new member methods:
            start_bulk_insert(), end_bulk_insert(), append_stmt_insert()
          make member methods private:
            read_next(), index_read_idx_with_result_set()
      mysql-test/r/federated_innodb.result:
        New BitKeeper file ``mysql-test/r/federated_innodb.result''
      mysql-test/t/federated_innodb-slave.opt:
        New BitKeeper file ``mysql-test/t/federated_innodb-slave.opt''
      mysql-test/t/federated_innodb.test:
        New BitKeeper file ``mysql-test/t/federated_innodb.test''
      dba70720
    • unknown's avatar
      Bug#25511 · 94beb7cd
      unknown authored
        "Federated INSERT failures"
        Federated does not correctly handle "INSERT...ON DUPLICATE KEY UPDATE"
        However, implementing such support is not reasonably possible without
        increasing complexity of the storage engine: checking that constraints
        on remote server match local server and parsing error messages.
        This patch causes 'ON DUPLICATE KEY' to fail with ER_DUP_KEY message
        if a conflict occurs and not to fail silently.
      
      
      include/my_base.h:
        bug25511
          new storage engine hint: HA_EXTRA_INSERT_WITH_UPDATE
      mysql-test/r/federated.result:
        test for bug25511
      mysql-test/t/federated.test:
        test for bug25511
      sql/ha_federated.cc:
        bug25511
          implement support for handling HA_EXTRA_INSERT_WITH_UPDATE hint
      sql/ha_federated.h:
        bug25511
          new property: insert_dup_update
      sql/sql_insert.cc:
        bug25511
          implement support for HA_EXTRA_INSERT_WITH_UPDATE
          When checking duplicates flag, if it is DUP_UPDATE, send hint
          to the storage engine.
      94beb7cd
    • unknown's avatar
      Fix for BUG#10491: Server returns data as charset binary · 925c33db
      unknown authored
      SHOW CREATE TABLE or SELECT FROM I_S.
      
      Actually, the bug discovers two problems:
        - the original query is not preserved properly. This is the problem
          of BUG#16291;
        - the resultset of SHOW CREATE TABLE statement is binary.
      
      This patch fixes the second problem for the 5.0.
      
      Both problems will be fixed in 5.1.
      
      
      mysql-test/r/show_check.result:
        Update result file.
      mysql-test/t/show_check.test:
        Provide test case for BUG#10491.
      sql/item.h:
        Use utf8_general_ci instead of binary collation by default,
        because for views and base tables utf8 is the character set
        in which their definition is stored. For system constants
        it's the default character set, and for other objects
        (routines, triggers), no character set is stored, and
        therefore no character set is known, so returning utf8
        is just as good as any non-binary character set.
        This latter problem is fixed in 5.1 by 16291. In 5.1
        we will return the "real" character set.
      925c33db
    • unknown's avatar
      Bug#27345 Incorrect data returned when range-read from utf8_danish_ci indexes · 54344f68
      unknown authored
      Problem: like_range() returned wrong ranges for contractions (like 'ch' in Czech').
      Fix: adding a special code to handle tricky cases:
      - contraction head followed by a wild character
      - full contraction
      - contraction part followed by another contraction part,
        but they are not a contraction together.
      
      
      mysql-test/r/ctype_uca.result:
        Adding test case
      mysql-test/t/ctype_uca.test:
        Adding test case
      strings/ctype-mb.c:
        Adding test case
      strings/ctype-uca.c:
        Allocate additional 256 bytes for flags "is contraction part".
      strings/ctype-ucs2.c:
        Adding test case
      54344f68
    • unknown's avatar
      Bug#29019 · 0e5e884b
      unknown authored
        "REPLACE/INSERT IGNORE/UPDATE IGNORE doesn't work"
        Federated does not record neccessary HA_EXTRA flags in order to
        support REPLACE/INSERT IGNORE/UPDATE IGNORE.
        Implement ::extra() to capture flags neccessary for functionality.
      New function append_ident() to better escape identifiers consistantly.
      
      
      mysql-test/r/federated.result:
        test for bug29019
      mysql-test/t/federated.test:
        test for bug29019
      sql/ha_federated.cc:
        Bug29019
          Federated does not record neccessary HA_EXTRA flags in order to
          support REPLACE/INSERT IGNORE/UPDATE IGNORE.
          Implement ::extra() to capture flags neccessary for functionality.
        New function append_ident() to better escape identifiers consistantly.
      sql/ha_federated.h:
        bug29019
          add 2 member values to ha_federated class
            ignore_duplicates and replace_duplicates.
          add 1 member method to ha_federated class
            extra()
      0e5e884b
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b728d0a6
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26642-5.0-opt
      
      
      b728d0a6
  9. 27 Jun, 2007 3 commits
    • unknown's avatar
      Merge weblab.(none):/home/marcsql/TREE/mysql-5.0-base · 6f059005
      unknown authored
      into  weblab.(none):/home/marcsql/TREE/mysql-5.0-rt-merge
      
      
      6f059005
    • unknown's avatar
      BUG#29299 - repeatable myisam fulltext index corruption · 030d98d3
      unknown authored
      Fulltext index may get corrupt by certain gbk characters.
      
      The problem was that when skipping leading non-true-word-characters,
      we assumed that these characters are always 1 byte long. This is not
      the case with gbk character set, since non-true-word-characters may
      be 2 bytes long.
      
      Affects 5.0 only.
      
      
      myisam/ft_parser.c:
        Leading non-true-word-characters may also be multi-byte (e.g. in
        gbk character set).
      mysql-test/r/fulltext2.result:
        A test case for BUG#29299.
      mysql-test/t/fulltext2.test:
        A test case for BUG#29299.
      030d98d3
    • unknown's avatar
      Merge mhansson@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 00b3d3c2
      unknown authored
      into  dl145s.mysql.com:/dev/shm/mhansson/my50-bug28677
      
      
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      00b3d3c2