1. 21 Jun, 2007 9 commits
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/51 · b3b9ea8a
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      configure.in:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/query_cache.result:
        SCCS merged
      b3b9ea8a
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/mysql-5.0-maint · 48030d81
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.1-new-maint
      
      
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      48030d81
    • unknown's avatar
      66e76447
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28769/my50-bug28769 · 91773ba7
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.1-new-maint
      
      
      mysql-test/r/innodb.result:
        Manual merge
      mysql-test/t/innodb.test:
        Manual merge
      91773ba7
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28769/my50-bug28769 · 863e3da3
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      863e3da3
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28742/my50-bug28742 · 1920e684
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.1-new-maint
      
      
      mysql-test/lib/mtr_process.pl:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Merge 5.0->5.1
      1920e684
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/bug28742/my50-bug28742 · bd099cd8
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      bd099cd8
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.1-maint · 74d918c7
      unknown authored
      into  mysql.com:/home/ram/work/b28772/b28772.5.1
      
      74d918c7
    • unknown's avatar
      Bug#24924: shared-memory-base-name that is too long causes buffer overflow · 26e9aba4
      unknown authored
      long shared-memory-base-names could overflow a static internal buffer
      and thus crash mysqld and various clients.  change both to dynamic
      buffers, show everything but overflowing those buffers still works.
      
      The test case for this would pretty much amount to
      mysqld --shared-memory-base-name=HeyMrBaseNameXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX --shared-memory=1 &
      mysqladmin --no-defaults --shared-memory-base-name=HeyMrBaseNameXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX shutdown
      
      Unfortunately, we can't just use an .opt file for the
      server. The .opt file is used at start-up, before any
      include in the actual test can tell mysqltest to skip
      this one on non-Windows. As a result, such a test would
      break on unices.
      
      Fixing mysql-test-run.pl to export full path for master
      and slave would enable us to start a server from within
      the test which is ugly and, what's more, doesn't work as
      the server blocks (mysqltest offers no fire-and-forget
      fork-and-exec), and mysqladmin never gets run.
      
      Making the test rpl_windows_shm or some such so we can
      is beyond ugly. As is introducing another file-name based
      special case (run "win*.test" only when on Windows). As is
      (yuck) coding half the test into mtr (as in, having it
      hand out a customized environment conductive to the shm-
      thing on Win only).
      
      Situation is exacerbated by the fact that .sh is not
      necessary run as expected on Win.
      
      In short, it's just not worth it. No test-case until we
      have a new-and-improved test framework.
      
      
      sql-common/client.c:
        Bug#24924: shared-memory-base-name that is too long causes buffer overflow
        
        compose shared memory name in dynamic rather than static buffer to prevent
        overflows (clients)
      sql/mysqld.cc:
        Bug#24924: shared-memory-base-name that is too long causes buffer overflow
        
        compose shared memory name in dynamic rather than static buffer to prevent
        overflows (server)
      26e9aba4
  2. 20 Jun, 2007 5 commits
    • unknown's avatar
      Enable the disabled test case for Bug#28075 (pushbuild by now · 1cbd7197
      unknown authored
      should be fixed).
      
      1cbd7197
    • unknown's avatar
      Merge bodhi.(none):/opt/local/work/mysql-5.0-runtime · 299b6c6c
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/t/ndb_index_ordered.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      mysql-test/t/greedy_optimizer.test:
        Manual merge.
      mysql-test/t/join.test:
        Manual merge.
      tests/mysql_client_test.c:
        Manual merge.
      299b6c6c
    • unknown's avatar
      Disable randomly failing tests: · 512b642b
      unknown authored
      rpl_udf -- Bug#28993 rpl_udf test causes server crash and valgrind
      warning in pushbuild
      rpl_ndb_circular -- Bug#29233 rpl_ndb_circular fails randomly
      ndb_dd_sql_features -- Bug#29102 ndb_dd_sql_features fails in
      pushbuild
      
      
      mysql-test/t/disabled.def:
        Disable randomly failing tests rpl_udf, rpl_ndb_circular, 
        ndb_dd_sql_features
      512b642b
    • unknown's avatar
      Fix a typo. · 1a48b37d
      unknown authored
      1a48b37d
    • unknown's avatar
      Bug#28742 mysql-test-run is very slow on "Stopping All Servers" step · 8c1c0ed1
      unknown authored
       - Improve shutdown algorithm 
       - Wait up to 5 seconds for processes to exit after their port is free
      
      
      mysql-test/lib/mtr_process.pl:
        Improve shutdown algorithm, shutdown the server hard
        if it hasn't responded to "mysqladmin shutdown" and it's port is free.
        Print error to servers error log indicating "hard shutdown"
        Give processes up to 5 seconds to exit after their port is free
      mysql-test/lib/mtr_report.pl:
        Indicate in what file the warning was found
      mysql-test/mysql-test-run.pl:
        Pass path of process error log to 'mtr_check_stop_servers'
      8c1c0ed1
  3. 19 Jun, 2007 20 commits
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/mysql50 · a13daf42
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql51
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/query_cache.result:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      a13daf42
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/mysql50 · f9935271
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/50_win
      
      
      sql/sql_yacc.yy:
        Auto merged
      f9935271
    • unknown's avatar
      Fix a merge mistake. · ea169f82
      unknown authored
      ea169f82
    • unknown's avatar
      Fix for bug #28772: rpl_row_until fails in pushbuild · 95e08734
      unknown authored
      Problem: we use 'sleep 2; wait_for_slave_to_stop;' to reach some slave's states
      which is buggy, wasteful of time, platform dependant etc.
      Fix: use include/wait_for_slave_***.inc's where it's possible instead.
      
      
      mysql-test/include/wait_for_slave_io_to_stop.inc:
        Fix for bug #28772: rpl_row_until fails in pushbuild
          - changed to use query_vertical so that it is easier to read the output.
      mysql-test/include/wait_for_slave_sql_to_stop.inc:
        Fix for bug #28772: rpl_row_until fails in pushbuild
          - changed to use query_vertical so that it is easier to read the output.
      mysql-test/include/wait_for_slave_to_start.inc:
        Fix for bug #28772: rpl_row_until fails in pushbuild
          - changed to use query_vertical so that it is easier to read the output.
      mysql-test/include/wait_for_slave_to_stop.inc:
        Fix for bug #28772: rpl_row_until fails in pushbuild
          - changed to use query_vertical so that it is easier to read the output.
      mysql-test/t/rpl_row_until.test:
        Fix for bug #28772: rpl_row_until fails in pushbuild
          - 'sleep 2; wait_for_slave_to_stop;' replaced with sourcing
            include/wait_for_slave_sql_to_stop.inc to be more predictable.
      mysql-test/t/rpl_stm_until.test:
        Fix for bug #28772: rpl_row_until fails in pushbuild
          - 'sleep 2; wait_for_slave_to_stop;' replaced with sourcing
            include/wait_for_slave_sql_to_stop.inc to be more predictable.
      95e08734
    • unknown's avatar
      Manual merge. · e8988810
      unknown authored
      
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/query_cache.test:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      e8988810
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · b33c622a
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.0-runtime
      
      b33c622a
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0 · b828f60d
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      
      configure.in:
        Auto merged
      b828f60d
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1 · 955beb66
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      
      configure.in:
        Auto merged
      955beb66
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0 · 1f82912e
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0
      
      
      configure.in:
        Auto merged
      1f82912e
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0 · 2acc6c35
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      2acc6c35
    • unknown's avatar
      try again. · 2c14c986
      unknown authored
      
      configure.in:
        Raise version number after cloning 5.0.44
      2c14c986
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · 87971f61
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      87971f61
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-maint · 6932c067
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/mysql-5.1-new-maint
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      BitKeeper/deleted/.del-wait_for_slave_io_to_stop.inc:
        Auto merged
      6932c067
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/wl3232/my50-wl3232 · fdc0b50a
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/wl3232/my51-wl3232
      
      
      mysql-test/r/mysqltest.result:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      fdc0b50a
    • unknown's avatar
      Merge pilot.(none):/data/msvensson/mysql/wl3232/my41-wl3232 · 798660cb
      unknown authored
      into  pilot.(none):/data/msvensson/mysql/wl3232/my50-wl3232
      
      
      mysql-test/r/mysqltest.result:
        Auto merged
      mysql-test/t/mysqltest.test:
        Auto merged
      798660cb
    • unknown's avatar
      WL#3232 mysqltest, enable --source $variables/<remaining_path_to_file> · 5d25f65d
      unknown authored
       - Add test case for this already existing feature 
      
      
      mysql-test/r/mysqltest.result:
        Update result file
      mysql-test/t/mysqltest.test:
        Add test case for this feature
      5d25f65d
    • unknown's avatar
      Bug#28769 Test case "innodb" fails with --skip-log-bin · 496e35ad
      unknown authored
       - Move binlog related tests to binlog_innodb.test
       - Remove "source include/have_log_bin.inc" from innodb.test
      
      
      mysql-test/r/innodb.result:
        Move binlog related tests to binlog_innodb.test
      mysql-test/t/innodb.test:
        Move binlog related tests to binlog_innodb.test
      mysql-test/r/binlog_innodb.result:
        Move binlog related tests to binlog_innodb.test
      mysql-test/t/binlog_innodb.test:
        Move binlog related tests to binlog_innodb.test
      496e35ad
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug28211/my51-bug28211 · a0dd6c11
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      sql/sql_cache.cc:
        Auto merged
      a0dd6c11
    • unknown's avatar
      Bug #28921 Queries containg UDF functions are cached · e8dbb8f7
      unknown authored
      Additional edits to the 5.0 ChangeSet|1.2519 that are necessary for the fix to work with the new code structure in 5.1.
      
      
      sql/item_create.cc:
        Added line to prevent a query that contains a UDF from being cached. In 5.0 this was handled in sql_yacc.cc but now the the individual Create_func builders will be responsible for clearing the flag.
      e8dbb8f7
    • unknown's avatar
      Merge damien-katzs-computer.local:/Users/dkatz/mysql50 · 719d2080
      unknown authored
      into  damien-katzs-computer.local:/Users/dkatz/mysql51
      
      
      mysql-test/r/udf.result:
        Auto merged
      mysql-test/t/udf.test:
        Auto merged
      sql/sql_yacc.yy:
        This line that marks the expression as unsafe for caching now belongs in the create() methods for builder objects inheriting from Create_func.
      719d2080
  4. 18 Jun, 2007 6 commits
    • unknown's avatar
      Bug #28921 Queries containing UDF functions are cached · 624d2d3d
      unknown authored
      Fixed runtime to no longer allow the caching of queries with UDF calls.
      
      
      mysql-test/r/udf.result:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      mysql-test/t/udf.test:
        Added a test that turns on caching and checks that querys calling UDFs don't get cached.
      sql/sql_yacc.yy:
        Fixed code to set safe_to_cache_query=0 regardless if the function call is a UDF or SP. Where it was placed previously -- at the very end of the else testing for UDFs -- it only executed the statement if the function call was a stored procedure call.
      624d2d3d
    • unknown's avatar
      Bug #29053 SQL_CACHE in UNION causes non-deterministic functions to be cached · f89957c7
      unknown authored
      Changed code to enforce that SQL_CACHE only in the first SELECT is used to turn on caching(as documented), but any SQL_NO_CACHE will turn off caching (not documented, but a useful behaviour, especially for machine generated queries). Added test cases to explicitly test the documented caching behaviour and test cases for the reported bug. 
      
      
      mysql-test/r/query_cache.result:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      mysql-test/t/query_cache.test:
        Added non-bug specific tests that ensure that only SQL_CACHE in the first SELECT is respected when encountered by the parser. These tests validate what is already documented, that only the outer most SELECTS can use the SQL_CACHE option to turn on caching. Because it would break existing SQL applications, we do not return an error if the SQL_CACHE expression is found in nested SELECTs. Also added test to validate nested SELECT can contain SQL_NO_CACHE and it will always turn off caching for the whole query. 
        
        Also added a bug specific test case to validate that the buggy behavior as reported has been fixed.
      sql/sql_yacc.yy:
        Added an explicit check to make sure "SELECT SQL_CACHE" only works on the first select in a query.
        
        The parser will always hit the outermost SELECT first, and if the SQL_CACHE option is found it sets the safe_to_query flag in the lex. Then, if there are subseqent "uncachable" subqueries or functions, as it parses those elements it sets the safe_to_query to 0. However, this cause problems if nested SELECTs also used the SQL_CACHE option, because then it would set back safe_to_query to 1, even though there are uncacheable expressions previously parsed.
        
        By adding the check to ensure only the first SELECT can turn caching on, it means a subsequent SQL_CACHE option can't turn caching back on after a uncacheable subsequery was already encountered.
      f89957c7
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/50 · 18b3e278
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      configure.in:
        Auto merged
      18b3e278
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/maint/41 · 60f23378
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      
      configure.in:
        Auto merged
      60f23378
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/51 · d6dbb003
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/51
      
      
      sql/lock.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      d6dbb003
    • unknown's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/50 · 88c218b3
      unknown authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/50
      
      88c218b3