1. 19 Jun, 2008 2 commits
    • Gleb Shchepa's avatar
      auto merge with local tree (bug #37076) · b4c59a09
      Gleb Shchepa authored
      b4c59a09
    • Gleb Shchepa's avatar
      Fixed bug #37076: TIMESTAMP/DATETIME/DATE values are not · 81d981f2
      Gleb Shchepa authored
                        replicated correctly between machines with
                        mixed endiannes
      
      
      mysql-test/extra/rpl_tests/rpl_row_basic.test:
        Added regression test for bug#37076.
      mysql-test/suite/rpl/r/rpl_row_basic_2myisam.result:
        Added regression test for bug#37076.
      mysql-test/suite/rpl/r/rpl_row_basic_3innodb.result:
        Added regression test for bug#37076.
      mysql-test/suite/rpl_ndb/r/rpl_row_basic_7ndb.result:
        Added regression test for bug#37076.
      sql/field.h:
        Fixed bug #37076: TIMESTAMP/DATETIME/DATE values are not
                          replicated correctly between machines with
                          mixed endiannes
        
        pack and unpack virtual methods have been overloaded for
        Field_timestamp (TIMESTAMP domain), Field_datetime (DATETIME
        domain) and Field_date (DATE domain) classes to replicate data
        between platforms with different endiannes in a correct way
        like in Field_long and Field_longlong classes.
        
        Common code have been moved to private handle_int32 and 
        handle_int64 private methods.
      81d981f2
  2. 18 Jun, 2008 1 commit
    • Davi Arnaut's avatar
      Bug#37003 Tests sporadically crashes with embedded server · 65969723
      Davi Arnaut authored
      The problem was that when a embedded linked version of mysqltest
      crashed there was no way to obtain a stack trace if no core file
      is available. Another problem is that the embedded version of
      libmysql was not behaving (crash) the same as the non-embedded with
      respect to sending commands to a explicitly closed connection.
      
      The solution is to generate a mysqltest's stack trace on crash
      and to enable "reconnect" if the connection handle was explicitly
      closed so the behavior matches the non-embedded one.
      
      client/CMakeLists.txt:
        Link mysys to mysqltest.
      client/Makefile.am:
        Link mysys to mysqltest.
      client/mysqltest.c:
        Add fatal signal handling with backtracing for Unix and Windows.
      configure.in:
        Add check for weak symbols support and remove a spurious word.
      include/Makefile.am:
        Add new header with prototype for stack tracing functions.
      include/my_stacktrace.h:
        Add new header with prototype for stack tracing functions.
      libmysqld/CMakeLists.txt:
        stack tracing is now part of mysys.
      libmysqld/Makefile.am:
        stack tracing is now part of mysys.
      libmysqld/lib_sql.cc:
        Re-connect if connection was explicitly closed. This is
        done to match the behavior of the non-embeded libmysql.
      mysql-test/t/sql_low_priority_updates_func.test:
        Test expects parallelism between queries that cannot be
        guaranteed under embedded.
      mysys/CMakeLists.txt:
        Add stacktrace to mysys.
      mysys/Makefile.am:
        Add stacktrace to mysys.
      mysys/stacktrace.c:
        Move stacktrace to mysys and add weak symbol for the
        C++ name de-mangling function so that it can later be
        overridden in C++ code. Also add my_ prefix to exported
        functions.
      sql/CMakeLists.txt:
        stacktrace was moved to mysys.
      sql/Makefile.am:
        stacktrace was moved to mysys.
      sql/mysqld.cc:
        Add my_ prefix to mysys functions.
      65969723
  3. 17 Jun, 2008 11 commits
    • Davi Arnaut's avatar
      Bug#33873: Fast ALTER TABLE doesn't work with multibyte character sets · e448b679
      Davi Arnaut authored
      The problem was that when comparing tables for a possible
      fast alter table, the comparison was being performed using
      the parsed information and not the final definition.
            
      The solution is to use the possible final table layout to
      compare if a fast alter is possible or not.
      
      mysql-test/include/mix1.inc:
        Disable test case for Bug 21704 as it hasn't been fixed.
      mysql-test/r/alter_table.result:
        Add test case result for Bug#33873
      mysql-test/r/innodb_mysql.result:
        Update test case result
      mysql-test/t/alter_table.test:
        Add test case for Bug#33873
      sql/sql_table.cc:
        Use updated (final) information to compare fields.
      e448b679
    • Mattias Jonsson's avatar
      auto merge · a8582a0c
      Mattias Jonsson authored
      a8582a0c
    • Georgi Kodinov's avatar
      auto merge · 94ff850b
      Georgi Kodinov authored
      94ff850b
    • Georgi Kodinov's avatar
      merge of 5.0-bugteam and 5.1 main · ec6aedd7
      Georgi Kodinov authored
      ec6aedd7
    • Mattias Jonsson's avatar
      Bug#35931 Index search of partitioned MyISAM table · 202212fa
      Mattias Jonsson authored
      returns erroneous results
      
      Used the wrong function when fixing 30480 which lead to
      no stop on end_key resulting in duplicate results from index scan
      
      Includes test cases for the duplicates 37327 and 37329,
      Duplicate rows and bad performance/High Handler_read_next values
      
      Recommit after merge issues
      
      mysql-test/r/partition.result:
        Bug#35931 List partition MyISAM table returns erroneous results
        
        added test results.
      mysql-test/t/partition.test:
        Bug#35931 List partition MyISAM table returns erroneous results
        
        added test for 35931, 37327 and 37329.
      sql/ha_partition.cc:
        Bug#35931 List partition MyISAM table returns erroneous results
        
        HA_READ_ORDER is a index_flag, not a table_flag.
        Error made in 30480.
      202212fa
    • Georgi Kodinov's avatar
      auto merge · c1a597cd
      Georgi Kodinov authored
      c1a597cd
    • Georgi Kodinov's avatar
      merge 5.1 -> 5.1-bugteam · 7027234f
      Georgi Kodinov authored
      7027234f
    • Tatiana A. Nurnberg's avatar
      Fix for Bug#16902. · 42aef642
      Tatiana A. Nurnberg authored
      42aef642
    • Tatiana A. Nurnberg's avatar
      merge · d6075874
      Tatiana A. Nurnberg authored
      configure.in:
        Raise version number after cloning 5.0.64
      mysql-test/r/federated_disabled.result:
        Bug#37069 (5.0): implement --skip-federated
      mysql-test/t/federated_disabled-master.opt:
        Bug#37069 (5.0): implement --skip-federated
      mysql-test/t/federated_disabled.test:
        Bug#37069 (5.0): implement --skip-federated
      mysys/errors.c:
        Fix for Bug#16902.
      sql/mysqld.cc:
        Bug#37069 (5.0): implement --skip-federated
      d6075874
    • Tatiana A. Nurnberg's avatar
      Bug#36492: make dist and make install fails · be3d3826
      Tatiana A. Nurnberg authored
      Ignore BitKeeper SCCS folders in make-dist
      be3d3826
    • Tatiana A. Nurnberg's avatar
      Bug#36492: make dist and make install fails · 5129d9c1
      Tatiana A. Nurnberg authored
      Ignore BitKeeper SCCS folders in make-dist
      
      mysql-test/Makefile.am:
        Ignore BitKeeper SCCS folders in make-dist
        (copy only .txt files).
      5129d9c1
  4. 16 Jun, 2008 2 commits
  5. 13 Jun, 2008 3 commits
  6. 12 Jun, 2008 1 commit
  7. 10 Jun, 2008 1 commit
  8. 09 Jun, 2008 1 commit
  9. 04 Jun, 2008 1 commit
  10. 03 Jun, 2008 5 commits
    • Davi Arnaut's avatar
      Bug#33362: Query cache invalidation (truncate) may hang · 9fca54f7
      Davi Arnaut authored
                 if cached query uses many tables
      
      The problem was that query cache would not properly cache
      queries which used 256 or more tables but yet would leave
      behind query cache blocks pointing to freed (destroyed)
      data. Later when invalidating (due to a truncate) query cache
      would attempt to grab a lock which resided in the freed data,
      leading to hangs or undefined behavior.
      
      This was happening due to a improper return value from the
      function responsible for registering the tables used in the
      query (so the cache can be invalidated later if one of the
      tables is modified). The function expected a return value of
      type boolean (char, 8 bits) indicating success (1) or failure
      (0) but the number of tables registered (unsigned int, 32 bits)
      was being returned instead. This caused the function to return
      failure for cases where it had actually succeed because when
      a type (unsigned int) is converted to a narrower type (char),
      the excess bits on the left are discarded. Thus if the 8
      rightmost bits are zero, the return value will be 0 (failure).
      
      The solution is to simply return true (1) only if the number of
      registered table is greater than zero and false (0) otherwise.
      
      mysql-test/r/query_cache_merge.result:
        Add test case result for Bug#33362
      mysql-test/t/query_cache_merge.test:
        Add test case for Bug#33362
      sql/sql_cache.cc:
        Return 1 or 0 depending on the number of registered tables.
      9fca54f7
    • Georgi Kodinov's avatar
      null merge · 40bcbf9b
      Georgi Kodinov authored
      40bcbf9b
    • Mattias Jonsson's avatar
      Bug#31210: INSERT DELAYED crashes server when used on partitioned tables · 4eace597
      Mattias Jonsson authored
        
      Problem was an unclear error message since it could suggest that
      MyISAM did not support INSERT DELAYED.
      Changed the error message to say that DELAYED is not supported by the
      table, instead of the table's storage engine.
      The confusion is that a partitioned table is in somewhat sense using
      the partitioning storage engine, which in turn uses the ordinary
      storage engine. By saying that the table does not support DELAYED we
      do not give any extra informantion about the storage engine or if it
      is partitioned.
      
      mysql-test/r/innodb-replace.result:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/innodb-replace.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/merge.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      mysql-test/t/partition_hash.test:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      sql/share/errmsg.txt:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        added error message for tables not supporting DELAYED
      sql/sql_insert.cc:
        Bug#31210: INSERT DELAYED crashes server when used on partitioned tables
        
        changed error message
      4eace597
    • Matthias Leich mleich@mysql.com's avatar
      Upmerge of fix for · 5891c6c1
      Matthias Leich mleich@mysql.com authored
      Bug 36788 Multiple funcs_1 'trig' tests are failing on vanilla builds
      5891c6c1
    • Georgi Kodinov's avatar
      Bug#37069 (5.0): implement --skip-federated · 9c5b3514
      Georgi Kodinov authored
      mysql-test/r/federated_disabled.result:
        Bug#37069 (5.0): test case
      mysql-test/t/federated_disabled-master.opt:
        Bug#37069 (5.0): test case
      mysql-test/t/federated_disabled.test:
        Bug#37069 (5.0): test case
      9c5b3514
  11. 02 Jun, 2008 1 commit
    • Matthias Leich mleich@mysql.com's avatar
      Bug#36788 Multiple funcs_1 'trig' tests are failing on vanilla builds · c21508a6
      Matthias Leich mleich@mysql.com authored
      Fix for this bug and additional improvements/fixes
      In detail:
      - Remove unicode attribute from several columns
        (unicode properties were nowhere needed/tested)
        of the table tb3
        -> The runnability of these tests depends no more on
           the availibility of some optional collations.
      - Use a table tb3 with the same layout for all
        engines to be tested and unify the engine name
        within the protocols.
        -> <engine>_trig_<abc>.result have the same content
      - Do not load data into tb3 if these rows have no
        impact on result sets
      - Add tests for NDB (they exist already in 5.1)
      - "--replace_result" at various places because
        NDB variants of tests failed with "random" row
        order in results
        This fixes a till now unknown weakness within the
        funcs_1 NDB tests existing in 5.1 and 6.0
      - Fix the expected result of ndb_trig_1011ext
        which suffered from Bug 32656
        + disable this test
      - funcs_1 could be executed with the mysql-test-run.pl
        option "--reorder", which saves some runtime by
        optimizing server restarts.
        Runtimes on tmpfs (one attempt only):
        with    reorder 132 seconds
        without reorder 183 seconds
      - Adjust two "check" statements within func_misc.test
        which were incorrect (We had one run with result set
        difference though the server worked good.)
      - minor fixes in comments
      c21508a6
  12. 30 May, 2008 3 commits
  13. 29 May, 2008 2 commits
  14. 28 May, 2008 4 commits
  15. 27 May, 2008 2 commits
    • Patrick Crews's avatar
      Bug#36721 - Test funcs1.<engine>_func_view failing for multiple engines · bbc66ccd
      Patrick Crews authored
      Bug#36724 - Test funcs_1.<engine>_storedproc_02 needs to be updated
      Bug#36726 - Test funcs_1.<engine>_storedproc failing - Needs to be updated on 5.1+
      
      func_view bug:  re-records .result files to account for addition of charset and collation data 
                      to SHOW CREATE VIEW output
      storedproc bugs:  Added expected errors for those storedprocs that use SQLSTATE:00000
                        in their handlers.  re-recorded .result files to account for these
                        expected errors.
      
      mysql-test/suite/funcs_1/r/innodb_func_view.result:
        Update result set for changes to SHOW CREATE VIEW output
      mysql-test/suite/funcs_1/r/memory_func_view.result:
        Updated result set due to changes in SHOW CREATE VIEW output
      mysql-test/suite/funcs_1/r/myisam_func_view.result:
        Updated result set due to changes in SHOW CREATE VIEW output
      bbc66ccd
    • Davi Arnaut's avatar
      Merge. · e141ea9b
      Davi Arnaut authored
      e141ea9b