1. 26 Jun, 2006 7 commits
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.0 · b4df1487
      unknown authored
      into  mysql.com:/nfstmp1/ingo/autopush-75/mysql-5.0
      
      b4df1487
    • unknown's avatar
      Merge mysql.com:/home/alik/MySQL/devel/5.0-tree · 28ed7015
      unknown authored
      into  mysql.com:/home/alik/MySQL/devel/5.0-rt
      
      28ed7015
    • unknown's avatar
      Merge istruewing@bk-internal.mysql.com:/home/bk/mysql-5.0 · bddeccf1
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-bug16986-main
      
      
      sql/sql_table.cc:
        Auto merged
      bddeccf1
    • unknown's avatar
      Merge mysql.com:/home/mydev/mysql-5.0--main · 3f672ff8
      unknown authored
      into  mysql.com:/home/mydev/mysql-5.0-bug16986-main
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      3f672ff8
    • unknown's avatar
      Bug#16986 - Deadlock condition with MyISAM tables · e6d5fe0f
      unknown authored
      Addendum fixes after changing the condition variable
      for the global read lock.
      
      The stress test suite revealed some deadlocks. Some were
      related to the new condition variable (COND_global_read_lock)
      and some were general problems with the global read lock.
      
      It is now necessary to signal COND_global_read_lock whenever 
      COND_refresh is signalled.
      
      We need to wait for the release of a global read lock if one 
      is set before every operation that requires a write lock.
      But we must not wait if we have locked tables by LOCK TABLES.
      After setting a global read lock a thread waits until all
      write locks are released.
      
      
      mysql-test/r/lock_multi.result:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Added test results.
      mysql-test/t/lock_multi.test:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Added tests for possible deadlocks that did not occur
        with the stress test suite.
      mysys/thr_lock.c:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Added a protection against an infinite loop that occurs
        with the test case for Bug #20662.
      sql/lock.cc:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Signal COND_global_read_lock whenever COND_refresh
        is signalled by using the new function broadcast_refresh().
        Added the definition of a new function that signals 
        COND_global_read_lock whenever COND_refresh is signalled.
      sql/mysql_priv.h:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Added a declaration for a new function that signals 
        COND_global_read_lock whenever COND_refresh is signalled.
      sql/sql_base.cc:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Signal COND_global_read_lock whenever COND_refresh
        is signalled by using the new function broadcast_refresh().
      sql/sql_handler.cc:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Signal COND_global_read_lock whenever COND_refresh
        is signalled by using the new function broadcast_refresh().
      sql/sql_insert.cc:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Removed global read lock handling from inside of 
        INSERT DELAYED. It is handled on a higher level now.
      sql/sql_parse.cc:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Wait for the release of a global read lock if one is set
        before every operation that requires a write lock.
        But don't wait if locked tables exist already.
      sql/sql_table.cc:
        Bug#16986 - Deadlock condition with MyISAM tables
        Addendum fixes after changing the condition variable
        for the global read lock.
        Removed global read lock handling from inside of 
        CREATE TABLE. It is handled on a higher level now.
        Signal COND_global_read_lock whenever COND_refresh
        is signalled by using the new function broadcast_refresh().
      e6d5fe0f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 0ff0cdc6
      unknown authored
      into  mysql.com:/home/tnurnberg/mysql-5.0-maint-18462
      
      
      mysql-test/r/mysqldump.result:
        Auto merged
      mysql-test/t/mysqldump.test:
        Auto merged
      client/mysqldump.c:
        SCCS merged
      0ff0cdc6
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 3b6a7ef8
      unknown authored
      into  mysql.com:/data0/bk/mysql-5.0-maint
      
      
      sql/sp_head.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      3b6a7ef8
  2. 24 Jun, 2006 2 commits
    • unknown's avatar
      Merge knielsen@10.100.52.19:/usr/local/mysql/tmp-5.0 · 1ccd344f
      unknown authored
      into  mysql.com:/data0/knielsen/tmp-5.0
      
      1ccd344f
    • unknown's avatar
      Fix race condition in test case wait_timeout. · d0d405ee
      unknown authored
      Sometimes the helper connection (that is watching for the main connection
      to time out) would itself time out first, causing the test to fail.
      
      
      mysql-test/t/wait_timeout.test:
        Increase connection timeout in connection wait_con so we will not loose
        the connection that is watching for the real wait_timeout to trigger.
      d0d405ee
  3. 23 Jun, 2006 9 commits
  4. 22 Jun, 2006 13 commits
    • unknown's avatar
      mysql.spec.sh: · 3f0032f4
      unknown authored
        Disable the simplistic auto dependency scan for test/bench (bug#20078)
      
      
      support-files/mysql.spec.sh:
        Disable the simplistic auto dependency scan for test/bench (bug#20078)
      3f0032f4
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 71019ccf
      unknown authored
      into  mysql.com:/home/tnurnberg/mysql-5.0-maint-19409
      
      71019ccf
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 774da9ec
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-runtime
      
      774da9ec
    • unknown's avatar
      Merge clam.ndb.mysql.com:/space/pekka/ndb/version/my50 · f2533800
      unknown authored
      into  clam.ndb.mysql.com:/space/pekka/ndb/version/my50-bug18781
      
      
      ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Auto merged
      ndb/src/ndbapi/ndberror.c:
        Auto merged
      f2533800
    • unknown's avatar
      #19409: Test 'func_timestamp' fails on Windows x64 · b3be4f2c
      unknown authored
      - The setting of "ENV{'TZ'}" doesn't affect the timezone
        used by MySQL Server on Windows.
      - Explicitly set timezone in test cases before doing UTC/localtime
        conversions so tests produce deterministic results
      
      
      mysql-test/r/func_timestamp.result:
        Update test results
      mysql-test/r/type_timestamp.result:
        Update test results
      mysql-test/t/func_timestamp.test:
        Specifically set timezone to make tests that do localtime/UTC conversions deterministic
      mysql-test/t/type_timestamp.test:
        Specifically set timezone to make tests that do localtime/UTC conversions deterministic
      b3be4f2c
    • unknown's avatar
      Bug#19408 Test 'func_time' fails on Windows x64 · 1f6e95d4
      unknown authored
      - The setting of "ENV{'TZ'}" doesn't affect the timezone
        used by MySQL Server on Windows.
      - Explicitly set timezone to "+03:00" in test case before
        doing the calculatiosn to check that there is three hours
        difference between utc and local time.
      (Magnus' fix)
      
      
      mysql-test/r/func_time.result:
        Update test results
      mysql-test/t/func_time.test:
        Set timezone to GMT-3, to make it possible to use "interval 3 hour"
      1f6e95d4
    • unknown's avatar
      Merge mysql.com:/home/tomash/src/mysql_ab/mysql-5.0 · ae58c588
      unknown authored
      into  mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-bug15811
      
      ae58c588
    • unknown's avatar
      Merge mysql.com:/opt/local/work/mysql-5.0-root · 453790d5
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-runtime
      
      453790d5
    • unknown's avatar
      Merge mysql.com:/home/tomash/src/mysql_ab/mysql-5.0 · d21303c0
      unknown authored
      into  mysql.com:/home/tomash/src/mysql_ab/mysql-5.0-bug15811
      
      d21303c0
    • unknown's avatar
      A fix and a test case for Bug#15217 "Using a SP cursor on a table created · 986c79e1
      unknown authored
       with PREPARE fails with weird error".
      More generally, re-executing a stored procedure with a complex SP cursor query
      could lead to a crash.
      
      The cause of the problem was that SP cursor queries were not optimized 
      properly at first execution: their parse tree belongs to sp_instr_cpush,
      not sp_instr_copen, and thus the tree was tagged "EXECUTED" when the
      cursor was declared, not when it was opened. This led to loss of optimization
      transformations performed at first execution, as sp_instr_copen saw that the
      query is already "EXECUTED" and therefore either not ran first-execution 
      related blocks or wrongly rolled back the transformations caused by 
      first-execution code.
      The fix is to update the state of the parsed tree only when the tree is
      executed, as opposed to when the instruction containing the tree is executed.
      Assignment if i->state is moved to reset_lex_and_exec_core.
      
      
      mysql-test/r/sp.result:
        Test results fixed (Bug#15217)
      mysql-test/t/sp.test:
        Add a test case for Bug#15217
      sql/sp_head.cc:
        Move assignment of stmt_arena->state to reset_lex_and_exec_core
      986c79e1
    • unknown's avatar
      Bug#15811: extremely long time for mysql client to execute long INSERT · 53944038
      unknown authored
      The problem was in redundant calls to strlen() in string functions,
      where we may then return after checking only the small number of characters.
      
      No test case is provided since it's a performance fix.
      
      
      strings/ctype-mb.c:
        Do not use strlen() where arbitrary horizon of at least
        CHARSET_INFO::mbmaxlen character is sufficient.
      53944038
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 2510411d
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      2510411d
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · f5242b2d
      unknown authored
      into  zippy.(none):/home/cmiller/work/mysql/mysql-5.0__bug19904
      
      f5242b2d
  5. 21 Jun, 2006 9 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · b6699593
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      b6699593
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 79b5658f
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/jani/mysql-5.0
      
      79b5658f
    • unknown's avatar
      Manual merge · b15ae9bd
      unknown authored
      
      mysql-test/r/ctype_utf8.result:
        Auto merged
      mysql-test/t/ctype_utf8.test:
        Auto merged
      b15ae9bd
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 90dcc30d
      unknown authored
      into moonbone.local:/work/tmp_merge-5.0-opt-mysql
      
      90dcc30d
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 0777deef
      unknown authored
      into moonbone.local:/work/tmp_merge-4.1-opt-mysql
      
      0777deef
    • unknown's avatar
      Fixed bug #14896. · a15f5736
      unknown authored
      This bug in Field_string::cmp resulted in a wrong comparison 
      with keys in partial indexes over multi-byte character fields.
      Given field a is declared as a varchar(16) collate utf8_unicode_ci
      INDEX(a(4)) gives us an example of such an index.
        
      Wrong key comparisons could lead to wrong result sets if 
      the selected query execution plan used a range scan by 
      a partial index over a utf8 character field.
      This also caused wrong results in many other cases.
      
      
      mysql-test/t/ctype_utf8.test:
        Added test cases for bug #14896.
      mysql-test/r/ctype_utf8.result:
        Added test cases for bug #14896.
      sql/field.cc:
        Fixed bug #14896.
        This bug in Field_string::cmp resulted in a wrong comparison 
        with keys in partial indexes over multi-byte character fields.
        Given field a is declared as a varchar(16) collate utf8_unicode_ci
        INDEX(a(4)) gives us an example of such an index.
             
        Wrong key comparisons could lead to wrong result sets if 
        the selected query execution plan used a range scan by 
        a partial index over a utf8 character field.
        This also caused wrong results in many other cases.
      a15f5736
    • unknown's avatar
      Merge mkindahl@bk-internal.mysql.com:/home/bk/mysql-5.0 · 0a8988ff
      unknown authored
      into  mysql.com:/home/bk/fix-mysql-5.0
      
      0a8988ff
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 3c32cc69
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/jani/mysql-5.0
      
      3c32cc69
    • unknown's avatar
      Merge bk://localhost:5559 · c83b599d
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/jani/mysql-5.0
      
      c83b599d