1. 08 Nov, 2007 7 commits
  2. 07 Nov, 2007 3 commits
    • unknown's avatar
      Fix for bug #32103: optimizer crash when join on int and mediumint with · 0a7a55d1
      unknown authored
      variable in where clause.
      
      Problem: the new_item() method of Item_uint used an incorrect
      constructor. "new Item_uint(name, max_length)" calls
      Item_uint::Item_uint(const char *str_arg, uint length) which assumes the
      first argument to be the string representation of the value, not the
      item's name. This could result in either a server crash or incorrect
      results depending on usage scenarios.
      
      Fixed by using the correct constructor in new_item():
      Item_uint::Item_uint(const char *str_arg, longlong i, uint length).
      
      
      mysql-test/r/select.result:
        Added a test case for bug #32103.
      mysql-test/t/select.test:
        Added a test case for bug #32103.
      sql/item.h:
        Use the correct constructor for Item_uint in Item_uint::new_item().
      0a7a55d1
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug25421/my51-bug31445 · 6850e37d
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      sql/opt_range.cc:
        Auto merged
      6850e37d
    • unknown's avatar
      Fix for bug #25421: MySQL threads don't respond to the kill command · dc0a59a2
      unknown authored
      Calculating the estimated number of records for a range scan may take a
      significant time, and it was impossible for a user to interrupt that
      process by killing the connection or the query.
      
      Fixed by checking the thread's 'killed' status in check_quick_keys() and
      interrupting the calculation process if it is set to a non-zero value.
      
      
      sql/opt_range.cc:
        Check the thread's 'killed' status in check_quick_keys() and
        interrupt the calculation process if it is set to a non-zero value.
      dc0a59a2
  3. 06 Nov, 2007 2 commits
  4. 05 Nov, 2007 12 commits
  5. 02 Nov, 2007 10 commits
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/mysql-5.0-opt · 608f4e7d
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      608f4e7d
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my51-bug26215 · 0d45d202
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.1-opt
      
      
      client/mysql.cc:
        Auto merged
      0d45d202
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my50-bug26215 · e397a7b0
      unknown authored
      into  polly.(none):/home/kaa/src/opt/mysql-5.0-opt
      
      
      client/mysql.cc:
        Auto merged
      e397a7b0
    • unknown's avatar
      5.1-specific changes for bug #26215 after merging the patch from 5.0: · 2048ac02
      unknown authored
      - Added trigger tests back.
      - Fixed test cases to match the extended output format of SHOW CREATE ...
      - Replaced 'gptr' with 'uchar *'.
      
      
      client/mysql.cc:
        Replaced 'gptr' with 'uchar *'.
      mysql-test/r/mysql_comments.result:
        Fixed test cases to match the extended output format of SHOW CREATE ...
        Added trigger tests back.
      mysql-test/t/mysql_comments.sql:
        Added trigger tests back.
      2048ac02
    • unknown's avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my50-bug26215 · 62f31fac
      unknown authored
      into  polly.(none):/home/kaa/src/opt/bug26215/my51-bug26215
      
      
      client/mysql.cc:
        Manual merge.
      62f31fac
    • unknown's avatar
      Fix for: · 1daa54d6
      unknown authored
        bug #26215: mysql command line client should not strip comments
                    from SQL statements
      and
        bug #11230: Keeping comments when storing stored procedures
      
      With the introduction of multiline comments support in the command line
      client (mysql) in MySQL 4.1, it became impossible to preserve
      client-side comments within single SQL statements or stored routines.
      This feature was useful for monitoring tools and maintenance.
      
      The patch adds a new option to the command line client
      ('--enable-comments', '-c') which allows to preserve SQL comments and
      send them to the server for single SQL statements, and to keep comments
      in the code for stored procedures / functions / triggers.
      
      The patch is a modification of the contributed patch from bug #11230
      with the following changes:
      - code style changes to conform to the coding guidelines
      - changed is_prefix() to my_strnncoll() to detect the DELIMITER
      command, since the first one is case-sensitive and not charset-aware
      - renamed t/comments-51.* to t/mysql_comments.*
      - removed tests for comments in triggers since 5.0 does not have SHOW
      CREATE TRIGGER (those tests will be added back in 5.1).
      
      The test cases are only for bug #11230. No automated test case for bug
      #26215 is possible due to the test suite deficiencies (though the cases
      from the bug report were tested manually).
      
      
      client/mysql.cc:
        Applied the contributed patch from bug11230 with the following changes:
        - code style changes to conform to the coding guidelines
        - changed is_prefix() to my_strnncoll() to detect the DELIMITER
        command, since the first one is case-sensitive and not charset-aware
        
        The patch adds a new option to the command line client which allows to
        preserve SQL comments and send them to the server to ensure better
        error reporting and to, keep comments in the code for stored procedures
        / functions / triggers.
      mysql-test/r/mysql_comments.result:
        Added test cases for bug11230.
      mysql-test/t/mysql_comments.sql:
        Added test cases for bug11230.
      mysql-test/t/mysql_comments.test:
        Added test cases for bug11230.
      1daa54d6
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 7524dbaa
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      7524dbaa
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · db499fbd
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31794-5.1-opt
      
      
      db499fbd
    • unknown's avatar
      Bug#31630 debug assert with explain extended select ... from i_s · dacf99b5
      unknown authored
      added 'in_rows' column value for 'describe extended' for the case 
      when 'describe' handles I_S table
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_select.cc:
        added 'in_rows' column value for 'describe extended' for the case 
        when 'describe' handles I_S table
      dacf99b5
    • unknown's avatar
      Bug#31113 mysqldump 5.1 can't handle a dash ("-") in database names · 2c6a5fd2
      unknown authored
      db name should be quoted. this code does communication with the server.
      it's always ok to quote names in this case.
      
      
      client/mysqldump.c:
        db name should be quoted. this code does communication with the server.
        it's always ok to quote names in this case.
      mysql-test/r/mysqldump.result:
        test result
      mysql-test/t/mysqldump.test:
        test case
      2c6a5fd2
  6. 01 Nov, 2007 4 commits
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B31794-5.0-opt · 4cb4a53e
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B31794-5.1-opt
      
      
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/t/func_group.test:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      4cb4a53e
    • unknown's avatar
      Bug #31794: no syntax error on SELECT id FROM t HAVING count(*)>2 · 660eb5bb
      unknown authored
      The HAVING clause is subject to the same rules as the SELECT list
      about using aggregated and non-aggregated columns.
      But this was not enforced when processing implicit grouping from
      using aggregate functions.
      Fixed by performing the same checks for HAVING as for SELECT.
      
      
      mysql-test/r/func_group.result:
        Bug #31794: test case
      mysql-test/t/func_group.test:
        Bug #31794: test case
      sql/sql_select.cc:
        Bug #31794: Check HAVING in addition to SELECT list
      660eb5bb
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.1-opt · 61bd5d0f
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B31866-5.1-opt
      
      
      61bd5d0f
    • unknown's avatar
      Bug #31866: MySQL Server crashes on SHOW CREATE TRIGGER statement · 124af3f8
      unknown authored
      SHOW CREATE TRIGGER was not checking for detected errors 
      opening/reading the trigger file. 
      Fixed to return the already generated error.
      
      
      mysql-test/r/trigger.result:
        Bug #31866: test case
      mysql-test/t/trigger.test:
        Bug #31866: test case
      sql/sql_show.cc:
        Bug #31866: test for error and return it.
      124af3f8
  7. 30 Oct, 2007 2 commits