- 04 May, 2006 13 commits
-
-
unknown authored
into ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0 mysql-test/r/gis-rtree.result: Auto merged mysql-test/r/ansi.result: Merged from 4.1 mysql-test/r/auto_increment.result: Merged from 4.1 mysql-test/r/mysqldump.result: Merged from 4.1 mysql-test/r/symlink.result: Merged from 4.1 mysql-test/t/auto_increment.test: Merged from 4.1 mysql-test/t/mysqldump.test: Merged from 4.1 sql/set_var.cc: Merged from 4.1 sql/sql_show.cc: Merged from 4.1
-
unknown authored
into ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0
-
unknown authored
is only to make sure that this will not be fixed, as it is intended behaviour. Documentation will be improved accordingly.
-
unknown authored
into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
-
unknown authored
-
unknown authored
into hundin.mysql.fi:/home/jani/mysql-4.1 sql/sql_show.cc: Auto merged
-
unknown authored
into mysql.com:/home/mysql-4.1-19025e
-
unknown authored
into mysql.com:/home/hf/work/mysql-5.0.mrg
-
unknown authored
into mysql.com:/home/hf/work/mysql-5.0.mrg mysql-test/mysql-test-run.pl: Auto merged mysql-test/r/mysqltest.result: Auto merged sql/sql_table.cc: Auto merged
-
unknown authored
mysql-test/r/mysqltest.result: result fixed
-
unknown authored
-
unknown authored
into rurik.mysql.com:/home/igor/dev/mysql-5.0-0 mysql-test/r/subselect.result: Auto merged sql/mysql_priv.h: Auto merged sql/sql_select.cc: Auto merged
-
unknown authored
mysqldump / SHOW CREATE TABLE will show the NEXT available value for the PK, rather than the *first* one that was available (that named in the original CREATE TABLE ... AUTO_INCREMENT = ... statement). This should produce correct and robust behaviour for the obvious use cases -- when no data were inserted, then we'll produce a statement featuring the same value the original CREATE TABLE had; if we dump with values, INSERTing the values on the target machine should set the correct next_ID anyway (and if not, we'll still have our AUTO_INCREMENT = ... to do that). Lastly, just the CREATE statement (with no data) for a table that saw inserts would still result in a table that new values could safely be inserted to). There seems to be no robust way however to see whether the next_ID field is > 1 because it was set to something else with CREATE TABLE ... AUTO_INCREMENT = ..., or because there is an AUTO_INCREMENT column in the table (but no initial value was set with AUTO_INCREMENT = ...) and then one or more rows were INSERTed, counting up next_ID. This means that in both cases, we'll generate an AUTO_INCREMENT = ... clause in SHOW CREATE TABLE / mysqldump. As we also show info on, say, charsets even if the user did not explicitly give that info in their own CREATE TABLE, this shouldn't be an issue. As per above, the next_ID will be affected by any INSERTs that have taken place, though. This /should/ result in correct and robust behaviour, but it may look non-intuitive to some users if they CREATE TABLE ... AUTO_INCREMENT = 1000 and later (after some INSERTs) have SHOW CREATE TABLE give them a different value (say, CREATE TABLE ... AUTO_INCREMENT = 1006), so the docs should possibly feature a caveat to that effect. It's not very intuitive the way it works now (with the fix), but it's *correct*. We're not storing the original value anyway, if we wanted that, we'd have to change on-disk representation? If we do dump/load cycles with empty DBs, nothing will change. This changeset includes an additional test case that proves that tables with rows will create the same next_ID for AUTO_INCREMENT = ... across dump/restore cycles. Confirmed by support as likely solution for client's problem. mysql-test/r/auto_increment.result: test for creation of AUTO_INCREMENT=... clause mysql-test/r/gis-rtree.result: Add AUTO_INCREMENT=... clauses where appropriate mysql-test/r/mysqldump.result: show that AUTO_INCREMENT=... will survive dump/restore cycles mysql-test/r/symlink.result: Add AUTO_INCREMENT=... clauses where appropriate mysql-test/t/auto_increment.test: test for creation of AUTO_INCREMENT=... clause mysql-test/t/mysqldump.test: show that AUTO_INCREMENT=... will survive dump/restore cycles sql/sql_show.cc: Add AUTO_INCREMENT=... to output of SHOW CREATE TABLE if there is an AUTO_INCREMENT column, and NEXT_ID > 1 (the default). We must not print the clause for engines that do not support this as it would break the import of dumps, but as of this writing, the test for whether AUTO_INCREMENT columns are allowed and wether AUTO_INCREMENT=... is supported is identical, !(file->table_flags() & HA_NO_AUTO_INCREMENT)) Because of that, we do not explicitly test for the feature, but may extrapolate its existence from that of an AUTO_INCREMENT column.
-
- 03 May, 2006 22 commits
-
-
unknown authored
into production.mysql.com:/usersnfs/svojtovich/mysql-5.0
-
unknown authored
into mysql.com:/home/hf/work/mysql-5.0.mrg sql/sql_table.cc: Auto merged
-
unknown authored
into mysql.com:/space/pekka/ndb/version/my50 mysql-test/r/ndb_blob.result: Auto merged mysql-test/t/ndb_blob.test: Auto merged ndb/include/kernel/signaldata/TcKeyReq.hpp: Auto merged ndb/include/ndbapi/NdbBlob.hpp: Auto merged ndb/src/ndbapi/NdbBlob.cpp: Auto merged ndb/test/ndbapi/testBlobs.cpp: Auto merged sql/sql_table.cc: Auto merged ndb/tools/delete_all.cpp: nuts
-
unknown authored
into mysql.com:/home/alexi/innodb/mysql-5.0-ss521
-
unknown authored
Fixed BUG#19366: "consistent_snapshot.test fails". innobase/include/dict0dict.ic: Applied innodb-5.0-ss521 snapshot. Remove too strict assertions from some dict_table_t accessor functions (bug #19366).
-
unknown authored
into mysql.com:/home/hf/work/mysql-4.1.mrg
-
unknown authored
into mysql.com:/home/alexi/innodb/mysql-4.1-ss26
-
unknown authored
into mysql.com:/home/alexi/innodb/mysql-5.0-ss521-work Null-merge. innobase/include/dict0dict.ic: Null-merge.
-
unknown authored
Fixed BUG#19366: "consistent_snapshot.test fails". innobase/include/dict0dict.ic: Applied innodb-4.1-ss26 snapshot. Remove too strict assertions from some dict_table_t accessor functions (Bug#19366).
-
unknown authored
into mysql.com:/home/hf/work/mysql-4.1.mrg mysql-test/mysql-test-run.pl: Auto merged sql/sql_table.cc: Auto merged
-
unknown authored
-
unknown authored
-
unknown authored
into mysql.com:/home/hf/work/mysql-5.0.mrg
-
unknown authored
mysql-test/t/sp_notembedded.test: Auto merged
-
unknown authored
sql/handler.h: Auto merged sql/sql_table.cc: Auto merged
-
unknown authored
into april.(none):/home/svoj/devel/mysql/BUG17810/mysql-5.0
-
unknown authored
into april.(none):/home/svoj/devel/mysql/BUG17810/mysql-5.0
-
unknown authored
mysql-test/mysql-test-run.pl: Auto merged mysql-test/mysql-test-run.sh: Auto merged mysql-test/r/analyze.result: Auto merged mysql-test/t/analyze.test: Auto merged mysql-test/t/mysql_client_test.test: Auto merged mysql-test/t/mysqltest.test: Auto merged
-
unknown authored
into mysql.com:/home/hf/work/mysql-4.1.mrg
-
unknown authored
into mysql.com:/home/hf/work/mysql-4.1.mrg
-
unknown authored
into mysql.com:/home/hf/work/mysql-4.1.mrg sql/sql_table.cc: Auto merged
-
unknown authored
This performance degradation was due to the fact that some cost evaluation code added into 4.1 in the function find_best was not merged into the code of the function best_access_path added together with other code for greedy optimizer. Added a parameter to the function print_plan. The parameter contains accumulated cost for a given partial join. The patch does not include a special test case since this performance degradation is hard to reproduse with a simple example. TODO: make the function find_best use the function best_access_path in order to remove duplication of code which might result in incomplete merges in the future. mysql-test/r/delete.result: Fixed bug #14292: performance degradation for a benchmark query. Adjusted test results. mysql-test/r/subselect.result: Fixed bug #14292: performance degradation for a benchmark query. Adjusted test results. sql/mysql_priv.h: Fixed bug #14292: performance degradation for a benchmark query. Added a parameter to the function print_plan. The parameter contains accumulated cost for a given partial join. sql/sql_select.cc: Fixed bug #14292: performance degradation for a benchmark query. This performance degradation was due to the fact that some cost evaluation code added into 4.1 in the function find_best was not merged into the code of the function best_access_path added together with other code for greedy optimizer. sql/sql_test.cc: Fixed bug #14292: performance degradation for a benchmark query. Added a parameter to the function print_plan. The parameter contains accumulated cost for a given partial join.
-
- 02 May, 2006 5 commits
-
-
unknown authored
BitKeeper/etc/config: pekka:get
-
unknown authored
into zippy.(none):/home/cmiller/work/mysql/mysql-5.0__bug17667
-
unknown authored
our sprintf()-alike in sync with our fprintf()-alike features. strings/my_vsnprintf.c: Advance the destination pointer properly. Also, pay attention to the "n" in snprintf() -- never write too much.
-
unknown authored
into mysql.com:/home/dlenev/mysql-5.0-bg11081
-
unknown authored
ndb/test/ndbapi/testBlobs.cpp: option -fac (fetch across commit) ndb/tools/delete_all.cpp: option --transactional (default remains truncate) mysql-test/r/ndb_blob.result: bug#19201 mysql-test/t/ndb_blob.test: bug#19201 ndb/include/kernel/signaldata/TcKeyReq.hpp: bug#19201 ndb/include/ndbapi/NdbBlob.hpp: bug#19201 ndb/src/ndbapi/NdbBlob.cpp: bug#19201
-