1. 14 Feb, 2018 1 commit
    • Sergey Vojtovich's avatar
      MDEV-15246 - premature history data deletion · b782971c
      Sergey Vojtovich authored
      This is regression after bc7a1dc1 of
      MDEV-15104 - Optimise MVCC snapshot.
      
      Aforementioned revision removes mutex lock around ReadView creation,
      which allows views to be created concurrently. Effectively it
      invalidates "oldest view" approach: no single view can be considered
      oldest anymore. Instead we have to iterate trx_sys.m_views to find
      min(m_low_limit_no), min(m_low_limit_id) and all transaction ids below
      min(m_low_limit_id), which would form oldest view.
      
      Second regression comes from c0d5d7c0
      of MDEV-15104 - Optimise MVCC snapshot.
      
      It removes mutex protection around trx->no assignment, which opens up
      a gap between m_max_trx_id increment and transaction serialisation
      number becoming visible through rw_trx_hash. While we're in this gap
      concurrent thread may come and do MVCC snapshot without seeing allocated
      but not yet assigned serialisation number. Then at some point purge
      thread may clone this view. As a result it won't see newly allocated
      serialisation number and may remove "unnecessary" history data of this
      transaction from rollback segments.
      b782971c
  2. 13 Feb, 2018 1 commit
  3. 12 Feb, 2018 22 commits
  4. 10 Feb, 2018 2 commits
  5. 08 Feb, 2018 8 commits
    • Marko Mäkelä's avatar
      MDEV-14663 Assertion page_is_root(block->frame) failed in innobase_add_instant_try · e3cf5779
      Marko Mäkelä authored
      innobase_add_instant_try(): If the leftmost leaf page does not contain
      other records than the 'default row', only empty the table if there
      are no successor pages.
      
      When a table or partition which was not empty during a previous
      instant ADD COLUMN became empty later, and now with this subsequent
      instant ADD COLUMN we have the opportunity to convert the empty table
      or partition to 'non-instant' format.
      
      Similarly, if the table or partition is empty to begin with, that is,
      it does not even contain a 'default row' record, we can use the
      'non-instant' format.
      e3cf5779
    • Marko Mäkelä's avatar
      Add page_has_prev(), page_has_next(), page_has_siblings() · 32170f8c
      Marko Mäkelä authored
      Until now, InnoDB inefficiently compared the aligned fields
      FIL_PAGE_PREV, FIL_PAGE_NEXT to the byte-order-agnostic value FIL_NULL.
      32170f8c
    • Jan Lindström's avatar
      MDEV-14427: encryption.innodb-bad-key-change failed in buildbot · 3969d97e
      Jan Lindström authored
      Timing problem as sometimes table is marked as encrypted but
      sometimes we are not sure and table is just marked missing.
      3969d97e
    • Vladislav Vaintroub's avatar
      Innodb, Windows : Reenable compiler optimizations for mem0mem.cc · 627d33d9
      Vladislav Vaintroub authored
      Compiler optimizations were switched off due to
      MySQL Bug #19424, #36366, #34297, due to an alleged compiler bug.
      No  proper analysis of code generation was done back then, thus proof of
      a compiler bug is missing.
      
      Even if there was a compiler bug 13 years ago, it could have been fixed.
      Will wait and see if there are any complains or crashes
      627d33d9
    • Vladislav Vaintroub's avatar
      6c5d3649
    • Marko Mäkelä's avatar
      Revert an accidental change · bbdb47ff
      Marko Mäkelä authored
      trx_undo_rec_copy(): Use a debug assertion. In a non-debug build,
      with len<0 (which this assertion is really testing for)
      we should still typically crash due to running out of memory.
      bbdb47ff
    • Marko Mäkelä's avatar
      Remove dict_table_t::is_clust() · 7660d8c9
      Marko Mäkelä authored
      Replace all occurrences of the is_clust() method with is_primary(),
      because that is what is actually meant. (Also the change buffer
      tree would count as a clustered index.)
      7660d8c9
    • Marko Mäkelä's avatar
      MDEV-14407 Assertion failure during rollback · 609d0a91
      Marko Mäkelä authored
      Rollback attempted to dereference DB_ROLL_PTR=0, which cannot possibly
      be a valid undo log pointer. A safer canonical value would be
      roll_ptr_t(1) << ROLL_PTR_INSERT_FLAG_POS
      which is what was chosen in MDEV-12288, corresponding to reset_trx_id.
      
      No deterministic test case for the bug was found. The simplest test
      cases may be related to MDEV-11415, which suppresses undo logging for
      ALGORITHM=COPY operations. In those operations, in the spirit of
      MDEV-12288, we should actually have written reset_trx_id instead of
      using the transaction identifier of the current transaction
      (and a bogus value of DB_ROLL_PTR=0). However, thanks to MySQL Bug#28432
      which I had fixed in MySQL 5.6.8 as part of WL#6255, access to the
      rebuilt table by earlier-started transactions should actually have been
      refused with ER_TABLE_DEF_CHANGED.
      
      reset_trx_id: Move the definition to data0type.cc and the declaration
      to data0type.h.
      
      btr_cur_ins_lock_and_undo(): When undo logging is disabled, use the
      safe value that corresponds to reset_trx_id.
      
      btr_cur_optimistic_insert(): Validate the DB_TRX_ID,DB_ROLL_PTR before
      inserting into a clustered index leaf page.
      
      ins_node_t::sys_buf[]: Replaces row_id_buf and trx_id_buf and some
      heap usage.
      
      row_ins_alloc_sys_fields(): Init ins_node_t::sys_buf[] to reset_trx_id.
      
      row_ins_buf(): Only if undo logging is enabled, copy trx->id
      to node->sys_buf. Otherwise, rely on the initialization in
      row_ins_alloc_sys_fields().
      
      row_purge_reset_trx_id(): Invoke mlog_write_string() with reset_trx_id
      directly. (No functional change.)
      
      trx_undo_page_report_modify(): Assert that the DB_ROLL_PTR is not 0.
      
      trx_undo_get_undo_rec_low(): Assert that the roll_ptr is valid before
      trying to dereference it.
      
      dict_index_t::is_primary(): Check if the index is the primary key.
      
      PageConverter::adjust_cluster_record(): Fix
      MDEV-15249 Crash in MVCC read after IMPORT TABLESPACE
      by resetting the system fields to reset_trx_id instead of writing
      the current transaction ID (which will be committed at the
      end of the IMPORT TABLESPACE) and DB_ROLL_PTR=0.
      This can partially be viewed as a follow-up fix of MDEV-12288,
      because IMPORT should already then have written
      DB_TRX_ID=0 and DB_ROLL_PTR=1<<55 to prevent unnecessary
      DB_TRX_ID lookups in subsequent accesses to the table.
      609d0a91
  6. 07 Feb, 2018 6 commits