1. 29 Sep, 2024 12 commits
  2. 26 Sep, 2024 28 commits
    • Sergey Vojtovich's avatar
      Fixed TRUNCATE TABLE against VECTOR indexes · 29cd7cd7
      Sergey Vojtovich authored
      This patch fixes only TRUNCATE by recreate variant, there seem to be no
      reasonable engine that uses TRUNCATE by handler method for testing.
      
      Reset index_cinfo so that mi_create is not confused by garbage passed via
      index_file_name and sets MY_DELETE_OLD flag.
      
      Review question: can we add a test case to make sure VECTOR index is empty
      indeed?
      29cd7cd7
    • Sergey Vojtovich's avatar
      62201e49
    • Sergey Vojtovich's avatar
      7d52fd1c
    • Sergey Vojtovich's avatar
      a4157e1f
    • Vicențiu Ciorbaru's avatar
      MDEV-32886 Vec_FromText and Vec_ToText · 5c831b4d
      Vicențiu Ciorbaru authored
      This commit introduces two utility functions meant to make working with
      vectors simpler.
      
      Vec_ToText converts a binary vector into a json array of numbers
      (floats).
      Vec_FromText takes in a json array of numbers and converts it into a
      little-endian IEEE float sequence of bytes (4 bytes per float).
      5c831b4d
    • Vicențiu Ciorbaru's avatar
      Introduce String::append_float · 58f7f257
      Vicențiu Ciorbaru authored
      This method will write out a float to a String object, keeping the
      charset of the original string.
      
      Also have Float::to_string make use of String::append_float
      58f7f257
    • Sergei Golubchik's avatar
      mhnsw: make the search less greedy · 446a7095
      Sergei Golubchik authored
      introduced a generosity factor that makes the search less greedy.
      it dramatically improves the recall by making the search a bit slower
      (for the same recall one can use half the M and smaller ef).
      
      had to add Queue::safe_push() method that removes one of the
      furthest elements (not necessarily the furthest) in the queue
      to keep it from overflowing.
      446a7095
    • Sergei Golubchik's avatar
      cleanup search_layer() · 4db6bfd7
      Sergei Golubchik authored
      to return only as many elements as needed, the caller no longer needs to
      overallocate result arrays for throwaway nodes
      4db6bfd7
    • Sergei Golubchik's avatar
      mhnsw: store coordinates in 16 bits, not 32 · b3c30521
      Sergei Golubchik authored
      use int16_t instead of floats, they're faster and smaller.
      but perform intermediate SIMD calculations with floats to avoid overflows.
      recall drop with such scheme is below 0.002, often none.
      
      int8_t would've been better but the precision loss is too big
      and recall degrades too much.
      b3c30521
    • Sergei Golubchik's avatar
      UPDATE/DELETE post-fixes · 3dea5ded
      Sergei Golubchik authored
      3dea5ded
    • Sergei Golubchik's avatar
      cleanup: prepare_for_insert() -> prepare_for_modify() · ee811514
      Sergei Golubchik authored
      make handler::prepare_for_insert() to be called to prepare
      the handler for writes, INSERT/UPDATE/DELETE.
      ee811514
    • Hugo Wen's avatar
      MDEV-33408 Initial support for vector DELETE and UPDATE · 385dc379
      Hugo Wen authored
      When the source row is deleted, mark the corresponding node in HNSW
      index by setting `tref` to null. An index is added for the `tref` in
      secondary table for faster searching of the to-be-marked nodes.
      
      The nodes marked as deleted will still be used for search, but will not
      be included in the final query results.
      
      As skipping deleted nodes and not adding deleted nodes for new-inserted
      nodes' neighbor list could impact the performance, we now only skip
      these nodes in search results.
      
      - for some reason the bitmap is not set for hlindex during the delete so
        I had to temporarily comment out one line
      
      All new code of the whole pull request, including one or several files
      that are either new files or modified ones, are contributed under the
      BSD-new license. I am contributing on behalf of my employer Amazon Web
      Services, Inc.
      385dc379
    • Sergei Golubchik's avatar
      non-SIMD fallback · a4920802
      Sergei Golubchik authored
      a4920802
    • Sergei Golubchik's avatar
      mhnsw: inter-statement shared cache · de90f5ae
      Sergei Golubchik authored
      * preserve the graph in memory between statements
      * keep it in a TABLE_SHARE, available for concurrent searches
      * nodes are generally read-only, walking the graph doesn't change them
      * distance to target is cached, calculated only once
      * SIMD-optimized bloom filter detects visited nodes
      * nodes are stored in an array, not List, to better utilize bloom filter
      * auto-adjusting heuristic to estimate the number of visited nodes
        (to configure the bloom filter)
      * many threads can concurrently walk the graph. MEM_ROOT and Hash_set
        are protected with a mutex, but walking doesn't need them
      * up to 8 threads can concurrently load nodes into the cache,
        nodes are partitioned into 8 mutexes (8 is chosen arbitrarily, might
        need tuning)
      * concurrent editing is not supported though
      * this is fine for MyISAM, TL_WRITE protects the TABLE_SHARE and the
        graph (note that TL_WRITE_CONCURRENT_INSERT is not allowed, because an
        INSERT into the main table means multiple UPDATEs in the graph)
      * InnoDB uses secondary transaction-level caches linked in a list in
        in thd->ha_data via a fake handlerton
      * on rollback the secondary cache is discarded, on commit nodes
        from the secondary cache are invalidated in the shared cache
        while it is exclusively locked
      * on savepoint rollback both caches are flushed. this can be improved
        in the future with a row visibility callback
      * graph size is controlled by @@mhnsw_cache_size, the cache is flushed
        when it reaches the threshold
      de90f5ae
    • Sergei Golubchik's avatar
      mhnsw: change storage format · 80a932dd
      Sergei Golubchik authored
      instead of one row per node per layer, have one row per node.
      store all neighbors for all layers in that row, and the vector itself too
      
      it completely avoids searches in the graph table and
      will allow to implement deletions in the future
      80a932dd
    • Sergei Golubchik's avatar
      6a79b349
    • Sergei Golubchik's avatar
      mhnsw: SIMD for euclidean distance · bcbbf333
      Sergei Golubchik authored
      bcbbf333
    • Sergei Golubchik's avatar
      mhnsw: configurable parameters · f579b988
      Sergei Golubchik authored
      1. introduce alpha. the value of 1.1 is optimal, so hard-code it.
      
      2. hard-code ef_construction=10, best by test
      
      3. rename hnsw_max_connection_per_layer to mhnsw_max_edges_per_node
         (max_connection is rather ambiguous in MariaDB) and add a help text
      
      4. rename hnsw_ef_search to mhnsw_min_limit and add a help text
      f579b988
    • Sergei Golubchik's avatar
      InnoDB support for hlindexes and mhnsw · adc998c7
      Sergei Golubchik authored
      * mhnsw:
        * use primary key, innodb loves and (and the index cannot have dupes anyway)
          * MyISAM is ok with that, performance-wise
        * must be ha_rnd_init(0) because we aren't going to scan
          * MyISAM resets the position on ha_rnd_init(0) so query it before
          * oh, and use the correct handler, just in case
        * HA_ERR_RECORD_IS_THE_SAME is no error
      * innodb:
        * return ref_length on create
        * don't assume table->pos_in_table_list is set
        * ok, assume away, but only for system versioned tables
      * set alter_info on create (InnoDB needs to check for FKs)
      * pair external_lock/external_unlock correctly
      adc998c7
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      bugfix: properly reset db_plugin when hlindex discovery fails · 15392aa7
      Sergei Golubchik authored
      otherwise it'll be free'd twice
      15392aa7
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      cleanups · 76ab4267
      Sergei Golubchik authored
      76ab4267
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      mhnsw: search intermediate layers with ef=1 · 9de70109
      Sergei Golubchik authored
      also add missing candidates.empty();
      9de70109
    • Sergei Golubchik's avatar
      1cd6bdb4
    • Sergei Golubchik's avatar
      f51ff23b
    • Sergei Golubchik's avatar
      mhnsw: don't create many empty layers · 42af658f
      Sergei Golubchik authored
      42af658f