1. 11 Mar, 2020 1 commit
  2. 09 Mar, 2020 4 commits
    • Monty's avatar
      Fixes for previous not-complete-push · 5c6c4b13
      Monty authored
      5c6c4b13
    • Monty's avatar
      Added keyread_time() to HEAP · c037cdad
      Monty authored
      The default keyread_time() was optimized for blocks and not suitable for
      HEAP. The effect was the HEAP prefered table scans over ranges for btree
      indexes.
      Fixed also get_sweep_read_cost() for HEAP tables.
      c037cdad
    • Monty's avatar
      Second stage of optimizer_trace optimizations · a24d0926
      Monty authored
      - Move testing of my_writer to inline functions to avoid calls
      - Made more functions inline. Especially thd->thread_started()
        is now very optimized!
      - Moved Opt_trace_stmt classe to opt_trace_context.h to get critical
        functions inline
      a24d0926
    • Monty's avatar
      Improved speed of optimizer trace · 940fcbe7
      Monty authored
      - Added unlikely() to optimize for not having optimizer trace enabled
      - Made THD::trace_started() inline
      - Added 'if (trace_enabled())' around some potentially expensive code
        (not many found)
      - Added ASSERT's to ensure we don't call expensive optimizer trace calls
        if optimizer trace is not enabled
      - Added length to Json_writer functions to speed up buffer writes
        when optimizer trace is enabled.
      - Changed LEX_CSTRING argument handling to not send full struct to writer
        function on_add_str() functions now trusts length arguments
      940fcbe7
  3. 06 Mar, 2020 4 commits
  4. 05 Mar, 2020 3 commits
  5. 02 Mar, 2020 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-21857 - Fix sporadic failure of mdev375 · f0d2542a
      Vladislav Vaintroub authored
      status threads_connected can temporarily be bigger than max_connections+1
      
      If SHOW STATUS LIKE "Threads_connected" comes after
      ER_CON_COUNT_ERROR is sent to the client, but before the counter is
      decremented, Threads_connected can differ from the expected value.
      f0d2542a
  6. 29 Feb, 2020 1 commit
  7. 28 Feb, 2020 3 commits
  8. 26 Feb, 2020 3 commits
  9. 25 Feb, 2020 6 commits
    • Alexey Bychko's avatar
      MENT-645 Undefined symbols for architecture x86_64: _pam_syslog · 42b29d41
      Alexey Bychko authored
      added cmake checks for pam_ext.h and pam_appl.h headers
      added check for pam_syslog()
      added pam_syslog() if doesn't exist
      all cmake checks performed from inside the plugin
      42b29d41
    • Sergei Petrunia's avatar
      Better comments · a662cb9b
      Sergei Petrunia authored
      a662cb9b
    • Igor Babaev's avatar
      MDEV-21554 Crash in JOIN_CACHE_BKAH::skip_index_tuple when mrr=on and · cfa0506f
      Igor Babaev authored
                 join_cache_level=6+
      
      The patch fixes two similar bugs in the commit 8eeb689e
      that added multi_range_read support to partitions. The commit opened
      a possibility to join a partition table using BKA+MRR. However in some
      cases it could lead to wrong results or even crashes.
      
      This could happened when
      - index condition pushdown was used to join the table or
      - the joined table was an inner table of an outer join and 'not exist'
        optimization was applied or
      - the join table was the inner table of a semi-join and the first match
        optimization was applied
      
      The bugs were in the code of the call-back functions
      - partition_multi_range_key_skip_record() and
      - partition_multi_range_key_skip_index_tuple().
      Each of this function consist only of an invocation of another function.
      Yet a wrong parameter was passed at this invocation.
      
      The fix was suggested by Sergey Petrunia and it is apparently in line
      with original design.
      The corresponding comprehensive test cases demonstrating the problems
      caused by the bugs were constructed by me.
      cfa0506f
    • Daniel Black's avatar
      MDEV-16662: cmake remove empty INSTALL_DEBUG_TARGET · f6b9a298
      Daniel Black authored
      No adverse effects since this was made a null function in
      6b53f9d7.
      
      This function had the last remaining cmake CMP0026 violation.
      f6b9a298
    • Daniel Black's avatar
      MDEV-16662: cmake: CMP0026 compatible for dtrace · c749eb2b
      Daniel Black authored
      cmake enabling -DENABLE_DTRACE=ON is particularlly noisy with CMP0026
      errors.
      
      Fixed in the same way as 6b53f9d7
      c749eb2b
    • Daniel Black's avatar
  10. 23 Feb, 2020 1 commit
    • seppo's avatar
      MDEV-21723 Async slave thread BF abort and replaying fixes (#1448) · 4618c974
      seppo authored
      If async replication slave thread conflicts with cluster replication,
      then the async slave transaction should be BF aborted, and depending on the
      state of async slave transaction execution, potentially also replayed.
      There were problems in such BF abort implementation and the replaying was not
      started.
      This pull request contains fixes which make sure that if async slave thread is
      marked to abort and replay, it will complete carry out the rollback and
      release all locks and resources before starting the replaying. After replaying,
      async slave transactions is treated as successful, so the slave thread will
      continue as usual, handling next replication event.
      
      There is also new mtr test: galera.galera_slave_replay, which stresses both a
      certification failure for async slave thread and a successful BF abort
      followed by replaying.
      4618c974
  11. 22 Feb, 2020 1 commit
    • Anel Husakovic's avatar
      MDEV-21374: When "--help --verbose" prints out configuration file paths, the... · b9689712
      Anel Husakovic authored
      MDEV-21374: When "--help --verbose" prints out configuration file paths, the --defaults-file option is not considered
      
      * `--defaults-file` option is showed only in `--help --verbose` if
      applied
      * `--default-extra-file` is showing correctly now in `--help --verbose`,
      previously it was treated as a directory with appended `my.cnf`
      b9689712
  12. 20 Feb, 2020 4 commits
    • Sergei Petrunia's avatar
      MDEV-21610 Different query results from 10.4.11 to 10.4.12 · e6373551
      Sergei Petrunia authored
      Part#2: cleanup:
      
      In the part 1 of the fix, DS-MRR implementation would peek into
      the JOIN_TAB to get the rowid filter from
      
        table->reginfo.join_tab->rowid_filter
      
      This doesn't look good from code isolation standpoint (why should a
      storage engine assume it is used through a JOIN_TAB?).
      
      Fixed this by storing the 'un-pushed' rowid_filter in the DsMrr_impl
      structure. The filter survives across multi_range_read_init() calls.
      
      It is discarded when somebody calls index_end() or rnd_end() and cleans
      up the DsMrr_impl.
      e6373551
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-21563 FTS thread aborts during shutdown · 3ce49a0a
      Thirunarayanan Balathandayuthapani authored
      - Add warning suppression in misc_debug2 test.
      3ce49a0a
    • Anel Husakovic's avatar
      Clean wrong cherry-pick from previous commit · 0d1dd2e7
      Anel Husakovic authored
      - Delete variable HAVE_PTHREAD_CONDATTR_SETCLOCK and check
      - Delete second HAVE_PTHREAD_KEY_DELETE
      0d1dd2e7
    • Daniel Black's avatar
      my_getncpus based on threads available · fb01cc37
      Daniel Black authored
      Detecting the cpus based on sysconf of the online CPUs can significantly
      over estimate the number of cpus available.
      
      Wheither via numactl, cgroups, taskset, systemd constraints, docker
      containers and probably other mechanisms, the number of threads mysqld
      can be run on can be quite less.
      
      As such we use the pthread_getaffinity_np function on Linux and FreeBSD
      (identical API) to get the number of CPUs.
      
      The number of CPUs is the default for the thread_pool_size and a too
      high default will resulting in large memory usage and high context
      switching overhead.
      
      Closes PR #922
      fb01cc37
  13. 19 Feb, 2020 3 commits
    • Sergei Petrunia's avatar
      MDEV-21628: Index condition pushdown condition ... not used with BKA · affe7fab
      Sergei Petrunia authored
      (Backport to 10.3)
      Partitioning storage now supports MRR but doesn't support Index Condition
      Pushdown (aka ICP). This causes counter-intuitive query plans for queries
      that use BKA and conditions that depend on index fields:
      - If the condition refers to other tables, BKA's variant of ICP is used
         to handle it.
      - If the condition depends on this table only, the optimizer will try to
        use regular ICP for it, which will fail because the storage engine
        doesn't support ICP.
      
      Make the optimizer be smarter in the second case: if we were not able to
      use regular ICP, use BKA's variant of ICP..
      affe7fab
    • Sergei Petrunia's avatar
      Fix compile failure, compare_key_parts in handler shadowed by MyRocks · adcfea71
      Sergei Petrunia authored
      The two functions have different signature.
      Use "using ..." to prevent shadowing
      adcfea71
    • Igor Babaev's avatar
      MDEV-21610 Different query results from 10.4.11 to 10.4.12 · 2fb881df
      Igor Babaev authored
      This patch fixes the following defects/bugs.
      1. If BKA[H] algorithm was used to join a table for which the optimizer
      had decided to employ a rowid filter the filter actually was not built.
      2. The patch for the bug MDEV-21356 that added the code canceling pushing
      rowid filter into an engine for the table joined with employment of
      BKA[H] and MRR was not quite correct for Innodb engine because this
      cancellation was done after InnoDB code had already bound the the pushed
      filter to internal InnoDB structures.
      2fb881df
  14. 18 Feb, 2020 2 commits
  15. 17 Feb, 2020 2 commits
  16. 16 Feb, 2020 1 commit