1. 28 Oct, 2010 1 commit
    • unknown's avatar
      MWL#116: Code simplifications for TC_LOG_MMAP. · b8cbc6d0
      unknown authored
      Make TC_LOG_MMAP (and TC_LOG_DUMMY) derive directly from TC_LOG, avoiding the
      inheritance hierarchy TC_LOG_queued->TC_LOG_unordered.
      
      Put the wakeup facility for commit_ordered() calls into the THD class.
      
      Some renaming to get better names.
      b8cbc6d0
  2. 26 Oct, 2010 2 commits
  3. 23 Oct, 2010 1 commit
    • unknown's avatar
      MWL#116: Efficient group commit: Some fixes for test failures. · 368b2891
      unknown authored
      client/mysqltest.cc:
        Apply Serg's work-around for MySQL BUG#57491.
      mysql-test/r/group_commit_binlog_pos.result:
        Accept different ways the server crash is detected.
      mysql-test/t/group_commit_binlog_pos.test:
        Accept different ways the server crash is detected.
        Skip in row-based binlogging, as otherwise the binlog offsets will be different.
      368b2891
  4. 22 Oct, 2010 1 commit
  5. 18 Oct, 2010 2 commits
    • unknown's avatar
      c3a14517
    • unknown's avatar
      MWL#116: Efficient group commit: Fix bug that binlog pos stored by XtraDB... · 704e604e
      unknown authored
      MWL#116: Efficient group commit: Fix bug that binlog pos stored by XtraDB during commit was wrong when more than one commit in group.
      
      Now the actual binlog position for each commit is stored in THD, and XtraDB
      can fetch the correct value from within commit_ordered() or commit().
      
      
      mysql-test/r/group_commit_binlog_pos.result:
        Test case for XtraDB binlog position.
      mysql-test/t/group_commit_binlog_pos-master.opt:
        Test case for XtraDB binlog position.
      mysql-test/t/group_commit_binlog_pos.test:
        Test case for XtraDB binlog position.
      sql/log.cc:
        Save binlog position corresponding to commit in THD, and make accessible to storage engine.
      sql/sql_parse.cc:
        Add generic crash point for use in test cases.
      storage/xtradb/handler/ha_innodb.cc:
        Update to use new method of getting current binlog position that works with group commit.
      storage/xtradb/handler/ha_innodb.h:
        Update to use new method of getting current binlog position that works with group commit.
      704e604e
  6. 04 Oct, 2010 1 commit
    • unknown's avatar
      MWL#116: Efficient group commit · 97f8b440
      unknown authored
      Tweak the commit_ordered() semantics. Now it is only called for transactions
      that go through 2-phase commit. This avoids forcing engines to make commits
      visible before they are durable.
      
      Also take LOCK_commit_ordered() around START TRANSACTION WITH CONSISTENT
      SNAPSHOT, to get a truly consistent snapshot.
      97f8b440
  7. 01 Oct, 2010 1 commit
  8. 30 Sep, 2010 1 commit
  9. 28 Sep, 2010 2 commits
  10. 26 Sep, 2010 2 commits
    • Igor Babaev's avatar
      Merge · 2b4cb27f
      Igor Babaev authored
      2b4cb27f
    • Igor Babaev's avatar
      Fixed bug #57024. · f21987b5
      Igor Babaev authored
      The condition over the outer tables now are extracted from
      the on condition of any outer join. This condition is
      saved in a special field of the JOIN_TAB structure for
      the first inner table of the outer join. The condition
      is checked before the first inner table is accessed. If 
      it turns out to be false the table is not accessed at all
      and a null complemented row is generated immediately.
      f21987b5
  11. 25 Sep, 2010 2 commits
  12. 23 Sep, 2010 1 commit
  13. 21 Sep, 2010 3 commits
  14. 20 Sep, 2010 3 commits
  15. 18 Sep, 2010 1 commit
  16. 15 Sep, 2010 2 commits
    • Michael Widenius's avatar
      Automatic merge · 5ca65d0d
      Michael Widenius authored
      5ca65d0d
    • Michael Widenius's avatar
      mysqltest now gives error messages with error code for my_delete, my_rename, my_copy etc. · 0f6fb883
      Michael Widenius authored
      Fixed crashing bug when doing ALTER TABLE RENAME with transactional tables.
      
      client/mysqltest.cc:
        Added errno to error message for system calls (delete, rename etc)
        Write error message for failures of system calls
      mysql-test/include/cleanup_fake_relay_log.inc:
        Disable warnings for remove_file
      mysql-test/include/diff_tables.inc:
        Disable warnings for remove_file
      mysql-test/include/maria_empty_logs.inc:
        Disable warnings for remove_file
      mysql-test/include/maria_make_snapshot.inc:
        Disable warnings for remove_file
      mysql-test/include/maria_make_snapshot_for_feeding_recovery.inc:
        Disable warnings for remove_file
      mysql-test/include/mysqlhotcopy.inc:
        Disable warnings for remove_file
      mysql-test/include/ndb_backup.inc:
        Disable warnings for remove_file
      mysql-test/include/ndb_backup_print.inc:
        Disable warnings for remove_file
      mysql-test/r/alter_table_trans.result:
        Test of crashing ALTER TABLE RENAME bug
      mysql-test/t/alter_table_trans.test:
        Test of crashing ALTER TABLE RENAME bug
      mysql-test/t/mysqltest.test:
        Disable warnings for remove_file and move_file
      mysys/my_copy.c:
        Fixed wrong error message
      sql/sql_table.cc:
        Fixed crashing bug when doing ALTER TABLE RENAME with transactional tables.
      0f6fb883
  17. 14 Sep, 2010 4 commits
  18. 13 Sep, 2010 5 commits
    • Sergei Golubchik's avatar
      merged · 6767feaf
      Sergei Golubchik authored
      6767feaf
    • Igor Babaev's avatar
    • Michael Widenius's avatar
      Merge · ce0a3934
      Michael Widenius authored
      ce0a3934
    • Michael Widenius's avatar
      Fixed Aria recovery bug: · e48f9f6b
      Michael Widenius authored
      - When reopening table during recovery, don't set file length from file sizes as file is not flushed.
      New feature in Aria recovery:
      - Create database directory if missing.
      
      
      
      storage/maria/ma_recovery.c:
        Don't print Query: twice when running maria_read_log
        Create database directory if missing. (Needed when running maria_read_log on an empty database direcory during testing)
        More DBUG_print
        Fixed bug: When reopening table during recovery, don't set file length from file sizes as file is not flushed.
      e48f9f6b
    • Igor Babaev's avatar
      Merge · 7ca61745
      Igor Babaev authored
      7ca61745
  19. 12 Sep, 2010 2 commits
  20. 11 Sep, 2010 2 commits
    • Igor Babaev's avatar
      Fixed bug #49600. · 02ee96f0
      Igor Babaev authored
      The problem could be demonstrated with an outer join of two single-row
      tables where the values of the join attributes were null. Any query
      with such a join could return a wrong result set if the where
      condition of the query was not empty. For queries with empty
      where conditions the result sets were correct.
      This was the consequence of two bugs in the code:
       - Item_equal objects for on conditions of outer joins were
         not built if the processed query had no where condition
       - the check for null values in the code that evaluated constant 
         Item_equal objects was incorrect.
      Fixed both above problems.
      Added a test case for the bug and adjusted results for some other
      test cases.
      02ee96f0
    • Sergei Golubchik's avatar
      to simpliy and unify the code · 17f3a094
      Sergei Golubchik authored
      17f3a094
  21. 10 Sep, 2010 1 commit
    • Michael Widenius's avatar
      Fix for LP#634943 "marked as crashed", "zerofilling" and "wrong data in... · 06e6244e
      Michael Widenius authored
      Fix for LP#634943 "marked as crashed", "zerofilling" and "wrong data in bitmap" when recovering Aria tables
      This was an interaction of several bugs:
      - Tables marked as opened was not properly unmarked on recovery if there was not changes since checkpoint
      - zerofill of tables put wrong data in bitmap if directory for page was full
      - Tables was thought as 'moved' during recovery if they had a create_lsn bigger than the lsn in the control file.
      
      
      storage/maria/ha_maria.cc:
        If table is moved and crashed, threat it as crashed.
        (Not a related to this bug, but still good to have fixed)
      storage/maria/ma_blockrec.c:
        Make enough_free_entries_on_page() global
      storage/maria/ma_blockrec.h:
        Make enough_free_entries_on_page() global
      storage/maria/ma_check.c:
        If directory is full, mark page full. Fixes bug in zerofill
      storage/maria/ma_open.c:
        Don't marke files as MOVED during recovery if create_trid > trnman_max_trid, as this fails for tables created after checkpoint.
      storage/maria/ma_recovery.c:
        Reset open_count in file that was open during crash and was part of checkpoint.
        Fixed wrong warning of 'open count' after recovery of files that was not touched since checkpoint.
      storage/maria/maria_chk.c:
        Changed not documented option --log-dir to --logdir
        Document more of the options.
        Clean up output for --help
      storage/maria/trnman.c:
        Added DBUG_PRINT
      06e6244e