1. 10 Oct, 2007 4 commits
    • unknown's avatar
      Bug #30825: Problems when putting a non-spatial index on a GIS column · ba373ba5
      unknown authored
       Fixed the usage of spatial data (and Point in specific) with 
       non-spatial indexes.
       Several problems :
         - The length of the Point class was not updated to include the 
           spatial reference system identifier. Fixed by increasing with 4 
           bytes.
         - The storage length of the spatial columns was not accounting for
           the length that is prepended to it. Fixed by treating the 
           spatial data columns as blobs (and thus increasing the storage
           length)
         - When creating the key image for comparison in index read wrong
           key image was created (the one needed for and r-tree search,
           not the one for b-tree/other search). Fixed by treating the
           spatial data columns as blobs (and creating the correct kind of
           image based on the index type). 
      
      
      mysql-test/r/bdb_gis.result:
        Bug #30825: bdb tests
      mysql-test/r/gis-rtree.result:
        Bug #30825: key length changed
      mysql-test/r/gis.result:
        Bug #30825: MyISAM tests
      mysql-test/r/innodb_gis.result:
        Bug #30825: InnoDB tests
      mysql-test/t/bdb_gis.test:
        Bug #30825: bdb tests
      mysql-test/t/gis.test:
        Bug #30825: MyISAM tests
      mysql-test/t/innodb_gis.test:
        Bug #30825: InnoDB tests
      sql/field.cc:
        Bug #30825: Removed Field_geom::get_key_image as Field_blog::get_key_image 
          takes type parameter into consideration and is a superset of 
          Field_geom::get_key_image()
      sql/field.h:
        Bug #30825: Removed Field_geom::get_key_image as Field_blog::get_key_image 
          takes type parameter into consideration and is a superset of 
          Field_geom::get_key_image()
      sql/sql_select.h:
        Bug #30825: Geometry data are a blob derivate
      sql/sql_table.cc:
        Bug #30825: Increased key length to accomodate for
          spatial reference system identifier (srid)
      sql/sql_yacc.yy:
        Bug #30825: Increased key length to accomodate for
          spatial reference system identifier (srid)
      sql/table.cc:
        Bug #30825: It stores a length for spatial data
         as well, so increase the storage length (as it's
         done for blobs).
      mysql-test/include/gis_keys.inc:
        Bug #30825: Test file for spatial data and non-spatial indexes
      ba373ba5
    • unknown's avatar
      Merge mysql.com:/home/gluh/MySQL/Merge/5.0 · d20c3355
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      
      libmysql/libmysql.c:
        Auto merged
      d20c3355
    • unknown's avatar
      Bug#28893 --relay-log variable is not exposed with SHOW VARIABLES · 8c53b726
      unknown authored
      added variables relay_log, relay_log_index, relay_log_info_file to init_vars[]
      to make them visible within SHOW VARIABLES
      
      
      mysql-test/r/rpl_flush_log_loop.result:
        test result
      mysql-test/t/rpl_flush_log_loop.test:
        test case
      sql/set_var.cc:
        added variables relay_log, relay_log_index, relay_log_info_file to init_vars[]
        to make them visible within SHOW VARIABLES
      8c53b726
    • unknown's avatar
      Bug#25359 Test 'view' is dependent on current year to be 2006 · e2ef1cfd
      unknown authored
      removed now() call to make the test to be year independent
      
      
      mysql-test/r/view.result:
        result fix
      mysql-test/t/view.test:
        removed now() call to make the test to be year independent
      e2ef1cfd
  2. 09 Oct, 2007 5 commits
  3. 05 Oct, 2007 10 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · fd9d709a
      unknown authored
      into  mysql.com:/home/hf/work/30286/my50-30286
      
      fd9d709a
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.0-opt · b3900154
      unknown authored
      into  dl145s.mysql.com:/data0/mhansson/bug30942/my50-bug30942
      
      b3900154
    • unknown's avatar
      Merge mysql.com:/home/hf/work/30286/my41-30286 · 6c799e0f
      unknown authored
      into  mysql.com:/home/hf/work/30286/my50-30286
      
      
      mysql-test/t/gis.test:
        Auto merged
      sql/gstream.cc:
        Auto merged
      mysql-test/r/gis.result:
        SCCS merged
      6c799e0f
    • unknown's avatar
      Merge mysql.com:/home/hf/work/30955/my41-30955 · b340abe7
      unknown authored
      into  mysql.com:/home/hf/work/30286/my41-30286
      
      b340abe7
    • unknown's avatar
      Merge mysql.com:/home/hf/work/30286/my41-30286 · 3ab86f83
      unknown authored
      into  mysql.com:/home/hf/work/30286/my50-30286
      
      3ab86f83
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1-opt · ec48fce4
      unknown authored
      into  mysql.com:/home/hf/work/30286/my41-30286
      
      ec48fce4
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 23a04585
      unknown authored
      into  mysql.com:/home/hf/work/30286/my50-30286
      
      23a04585
    • unknown's avatar
      Merge mysql.com:/home/hf/work/30286/my41-30286 · ba0449d9
      unknown authored
      into  mysql.com:/home/hf/work/30286/my50-30286
      
      
      myisam/rt_index.c:
        Auto merged
      myisam/rt_mbr.c:
        Auto merged
      mysql-test/t/gis-rtree.test:
        Auto merged
      mysql-test/r/gis-rtree.result:
        merging
      ba0449d9
    • unknown's avatar
      Bug #30286 spatial index cause corruption and server crash! · ffdd1f61
      unknown authored
      As the result of DOUBLE claculations can be bigger
      than DBL_MAX constant we use in code, we shouldn't use this constatn
      as a biggest possible value.
      Particularly the rtree_pick_key function set 'min_area= DBL_MAX' relying
      that any rtree_area_increase result will be less so we return valid
      key. Though in rtree_area_increase function we calculate the area
      of the rectangle, so the result can be 'inf' if the rectangle is
      huge enough, which is bigger than DBL_MAX.
      
      Code of the rtree_pick_key modified so we always return a valid key.
      
      
      myisam/rt_index.c:
        Bug #30286 spatial index cause corruption and server crash!
        
        always set the best_key with the first key we get, so we always return
        somthing valid.
      myisam/rt_mbr.c:
        Bug #30286 spatial index cause corruption and server crash!
        
        function comment extended
      mysql-test/r/gis-rtree.result:
        Bug #30286 spatial index cause corruption and server crash!
        test result
      mysql-test/t/gis-rtree.test:
        Bug #30286 spatial index cause corruption and server crash!
        test case
      ffdd1f61
    • unknown's avatar
      test fix(to satisfy WIN) · c1eaaa6e
      unknown authored
      
      mysql-test/r/information_schema.result:
        result fix
      c1eaaa6e
  4. 04 Oct, 2007 6 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 711be53b
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      711be53b
    • unknown's avatar
      Bug#30079 A check for "hidden" I_S tables is flawed · 53fb65b5
      unknown authored
      added check for hidden I_S tables for 'show columns|keys' commands
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_parse.cc:
        added check for hidden I_S tables for 'show columns|keys' commands
      53fb65b5
    • unknown's avatar
      Merge production.mysql.com:/usersnfs/jperkin/bk/build/5.0 · 270011cb
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/bug-27692/5.0
      
      270011cb
    • unknown's avatar
      Restore creation of test databases and the anonymous user which · 4d1a88e8
      unknown authored
      were accidentally removed during a previous rototill of this
      code.  Fixes bug#27692.
        
      While it can be argued we should strive to provide a 'secure by
      default' installation, this happens to be the setup currently
      documented in the manual as the default, so defer changes that
      improve security out of the box to a co-ordinated effort later
      on.
        
      For now, make a note about the test databases and anonymous user
      in mysql_install_db and recommend that mysql_secure_installation
      be ran for users wishing to remove these defaults.
      
      [..re-commit of previously lost change..]
      
      
      scripts/mysql_system_tables_data.sql:
        Add anonymous accounts.
      scripts/mysql_install_db.sh:
        Point users at the mysql_secure_installation script.
      mysql-test/mysql-test-run.pl:
        Add a comment where removing anonymous users.
      4d1a88e8
    • unknown's avatar
      Merge mhansson@bk-internal:/home/bk/mysql-5.0-opt · de5273e2
      unknown authored
      into  dl145s.mysql.com:/data0/mhansson/bug30942/my50-bug30942
      
      de5273e2
    • unknown's avatar
      Bug #30942: select str_to_date from derived table returns varying results · e74faf9b
      unknown authored
      The function str_to_date has a field to say whether it's invoked constant 
      arguments. But this member was not initialized, causing the function to
      think that it could use a cache of the format type when said cache was in 
      fact not initialized.
      Fixed by initializing the field to false.
      
      
      mysql-test/r/type_date.result:
        Bug#30942: Test result
      mysql-test/t/type_date.test:
        Bug#30942: Test case
      sql/item_timefunc.h:
        Bug#30942: Initialized const_item to false
      e74faf9b
  5. 03 Oct, 2007 3 commits
    • unknown's avatar
      Bug #30955 geomfromtext() crasher. · 56c8fc86
      unknown authored
      end-of-line check missed in Gis_read_stream::get_next_word,
      what can lead to crashes (expecially with NULL strings).
      
      End-of-line check added
      
      
      sql/gstream.cc:
        Bug #30955 geomfromtext() crasher
      mysql-test/r/gis.result:
        Bug #30955 geomfromtext() crasher.
        
        test result
      mysql-test/t/gis.test:
        Bug #30955 geomfromtext() crasher.
        
        test case
      56c8fc86
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-31077 · baeb40c9
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      baeb40c9
    • unknown's avatar
      mysqldump.test, mysqldump.result: · 2908ce1c
      unknown authored
        Bug #31077: post-commit fix.
      
      
      mysql-test/t/mysqldump.test:
        Bug #31077: post-commit fix.
      mysql-test/r/mysqldump.result:
        Bug #31077: post-commit fix.
      2908ce1c
  6. 02 Oct, 2007 9 commits
  7. 01 Oct, 2007 3 commits
    • unknown's avatar
      Bug#31095: Unexpected NULL constant caused server crash. · 11a54ec9
      unknown authored
      The Item_func_rollup_const class is used for wrapping constants to avoid
      wrong result for ROLLUP queries with DISTINCT and a constant in the select
      list. This class is also used to wrap up a NULL constant but its null_value
      wasn't set accordingly. This led to a server crash.
      
      Now the null_value of an object of the Item_func_rollup_const class is set
      by its fix_length_and_dec member function.
      
      
      mysql-test/t/olap.test:
        Added a test case for the bug#31095: Unexpected NULL constant caused server crash.
      mysql-test/r/olap.result:
        Added a test case for the bug#31095: Unexpected NULL constant caused server crash.
      sql/item_func.h:
        Bug#31095: Unexpected NULL constant caused server crash. 
        Now the null_value of an object of the Item_func_rollup_const class is set
        by its fix_length_and_dec member function.
      11a54ec9
    • unknown's avatar
      Fixed bug #31077. · f90c2d05
      unknown authored
      mysqldump adds the "-- Dump completed on YYYY-MM-DD hh:mm:ss" string
      to the end of output if the --comments switch is on.
      The only way to suppress this line is to use --skip-comments/--compact
      switch.
      
      New switch has been added to the mysqldump client command line:
      --dump-date.
      
      For the compatibility with previous releases, by default the --dump-date
      is on.
      The --dump-date switch forces mysqldump to add date to the
      "-- Dump completed on ..." string at the end of output.
      The --skip-dump-date switch supresses the output of date string
      and uses short form of that commentary: "-- Dump completed".
      --skip-comments or --compact switches disable the whole commentary
      as usual.
      
      
      client/client_priv.h:
        Fixed bug #31077.
        New OPT_DUMP_DATE option has been added to implement
        the mysqldump client --dump-date switch.
      client/mysqldump.c:
        Fixed bug #31077.
        The opt_dump_date variable has been added to imlements
        the mysqldump cliemt --dump-date switch.
        By default this switch is on (for compatibility with previous
        releases).
        The --dump-date switch forces mysqldump to add date to the
        "-- Dump completed on ..." string at the end of output.
        The --skip-dump-date switch supresses the output of date string
        and uses short form of that commentary: "-- Dump completed".
        --skip-comments or --compact switches disable the whole commentary
        as usual.
      mysql-test/t/mysqldump.test:
        Added test case for bug #31077.
      mysql-test/r/mysqldump.result:
        Added test case for bug #31077.
      f90c2d05
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 1b96170f
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      1b96170f