1. 21 Jul, 2020 1 commit
  2. 16 Jul, 2020 2 commits
    • Nikita Malyavin's avatar
      fix result · adcddca8
      Nikita Malyavin authored
      adcddca8
    • Nikita Malyavin's avatar
      MDEV-16039 Crash when selecting virtual columns generated using functions with DAYNAME() · 96644b3b
      Nikita Malyavin authored
      * Allocate items on thd->mem_root while refixing vcol exprs
      * Make vcol tree changes register and roll them back after the statement is executed.
      
      Explanation:
      Due to collation implementation specifics an Item tree could change while fixing.
      The tricky thing here is to make it on a proper arena.
      It's usually not a problem when a field is deterministic, however, makes a pain vice-versa, during allocation allocating.
      A non-deterministic field should be refixed on each statement, since it depends on the environment state.
      Changing the tree will be temporary and therefore it should be reverted after the statement execution.
      96644b3b
  3. 09 Jul, 2020 1 commit
    • Eugene Kosov's avatar
      fix compilation with gcc-10 · 24ed08c3
      Eugene Kosov authored
      ../sql/sql_class.cc: In constructor ‘start_new_trans::start_new_trans(THD*)’:
      ../include/m_string.h:61:49: error: ‘void* memset(void*, int, size_t)’ clearing an object of non-trivial type ‘struct Ha_data’; use assignment or value-initialization instead [-Werror=class-memaccess]
         61 | # define bzero(A,B)             memset((A),0,(B))
            |                                                 ^
      ../sql/sql_class.cc:5805:3: note: in expansion of macro ‘bzero’
       5805 |   bzero(thd->ha_data, sizeof(thd->ha_data));
            |   ^~~~~
      In file included from ../sql/sql_class.cc:33:
      ../sql/sql_class.h:2003:8: note: ‘struct Ha_data’ declared here
       2003 | struct Ha_data
            |        ^~~~~~~
      24ed08c3
  4. 08 Jul, 2020 2 commits
  5. 07 Jul, 2020 1 commit
  6. 06 Jul, 2020 2 commits
  7. 05 Jul, 2020 2 commits
    • Marko Mäkelä's avatar
      Fix cmake -DWITH_MSAN=ON · 79c166c5
      Marko Mäkelä authored
      commit ab406990 accidentally
      misplaced #endif directives.
      79c166c5
    • Marko Mäkelä's avatar
      After-merge fix for ASAN and MSAN · ab406990
      Marko Mäkelä authored
      The merge commit 0fd89a1a
      of commit b6ec1e8b
      seems to cause occasional MemorySanitizer failures,
      because it failed to replace some MEM_UNDEFINED() calls
      with MEM_MAKE_ADDRESSABLE().
      
      my_large_free(): Correctly invoke MEM_MAKE_ADDRESSABLE() after
      freeing memory. Failure to do so could cause bogus
      AddressSanitizer failures for memory allocated by my_large_malloc().
      On MemorySanitizer, we will do nothing.
      
      buf_pool_t::chunk_t::create(): Replace the MEM_MAKE_ADDRESSABLE()
      that had been added in commit 48493132
      to work around the issue.
      ab406990
  8. 04 Jul, 2020 5 commits
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 90d5d906
      Marko Mäkelä authored
      90d5d906
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · b99fa1e7
      Marko Mäkelä authored
      b99fa1e7
    • Marko Mäkelä's avatar
      Fixup the parent commit for MSAN and Valgrind · 453dc4b3
      Marko Mäkelä authored
      commit 48493132 was a necessary
      fix for the buffer pool resizing tests in 10.5 in
      AddressSanitizer. However, that change would break the tests
      innodb.innodb_buffer_pool_resize and
      innodb.innodb_buffer_pool_resize_with_chunks
      when run in MemorySanitizer, or presumably in Valgrind as well.
      (Those tests run "forever" in Valgrind.)
      
      buf_pool_resize(): Cancel the effect of MEM_NOACCESS() in Valgrind
      and ASAN. In MSAN, MEM_NOACCESS() is a no-op, and hence we must do
      nothing special here.
      
      MEM_MAKE_ADDRESSABLE() would declare the memory contents undefined.
      In this particular case, we must actually declare the contents
      defined for Valgrind.
      453dc4b3
    • Marko Mäkelä's avatar
      MDEV-22535 fixup: Define a single-caller function inline · a85f81af
      Marko Mäkelä authored
      Let us avoid any overhead in release builds, for an empty function.
      a85f81af
    • Marko Mäkelä's avatar
      After-merge fixes for ASAN · 2d00e003
      Marko Mäkelä authored
      The merge commit 0fd89a1a
      of commit b6ec1e8b
      was slightly incomplete.
      
      ReadView::mem_valid(): Use the correct primitive
      MEM_MAKE_ADDRESSABLE(), because MEM_UNDEFINED() now has
      no effect on ASAN.
      
      recv_sys_t::alloc(), recv_sys_t::add(): Use MEM_MAKE_ADDRESSABLE()
      instead of MEM_UNDEFINED(), to get the correct behaviour for ASAN.
      For Valgrind and MSAN, there is no change in behaviour.
      
      recv_sys_t::free(), recv_sys_t::clear(): Before freeing memory to
      buf_pool.free_list, invoke MEM_MAKE_ADDRESSABLE() on the entire
      buf_block_t::frame, to cancel the effect of MEM_NOACCESS() in
      recv_sys_t::alloc().
      2d00e003
  9. 03 Jul, 2020 20 commits
  10. 02 Jul, 2020 4 commits