1. 21 Mar, 2005 5 commits
  2. 20 Mar, 2005 3 commits
    • unknown's avatar
      Fix for spurious failures of sp.test on many platforms (aka Bug #9161 · f472e0fd
      unknown authored
      "Warnings on 'drop procedure' platform-specific").
      
      In mysqltest we should not issue "SHOW WARNINGS" until we have not 
      read results from all statements in multi-statement.
      
      Otherwise such "SHOW WARNINGS" will either cause "Packets out of order"
      error and thus will ruin current connection (but we may not notice this as
      it happened in sp.test because we ignore errors from such auxilary
      SHOW WARNINGS and use auto-reconnecting connections) or will
      succeed but consume first packet from next statement in multi-statement
      sequence (this happens if "SHOW WARNINGS" is issued when this packet
      is already received by client. Packet is thrown away by net_clear()
      call which is issued when "SHOW WARNINGS" is sent to server).
      
      In our case sp.test failed because usually we had first situation
      but sometimes second situation occured causing warning to pop-up.
      
      
      client/mysqltest.c:
        We should not issue "SHOW WARNINGS" if we have not processed all 
        results from multi-statement.
      f472e0fd
    • unknown's avatar
      e33182eb
    • unknown's avatar
      func_group.test, func_group.result: · b450786c
      unknown authored
        Added a test case for bug #9210.
      sql_select.cc:
        Fixed bug #9210.
        The function calc_group_buffer did not cover the case
        when the GROUP BY expression was decimal.
        Slightly optimized the other code.
      
      
      sql/sql_select.cc:
        Fixed bug #9210.
        The function calc_group_buffer did not cover the case
        when the GROUP by expression was decimal.
        Slightly optimized the other code.
      mysql-test/t/func_group.test:
        Added a test case for bug #9210.
      b450786c
  3. 19 Mar, 2005 7 commits
    • unknown's avatar
      Clean up the warning inside sanity():decimal.c in valgrind-max builds. · 3a8fbde2
      unknown authored
      
      sql/my_decimal.h:
        HAVE_purify is defined in valgrind-max build as well: one possible 
        solution is to disable the sanity check in decimal.c in the valgrind-max
        build, but it's better to have more checks than less, for
        valgrind-max builds are not always used in conjunction with valgrind.
      3a8fbde2
    • unknown's avatar
      Cleanup, remove some -ansi -pedancit warnings (mysql_client_test.c) · b864c19b
      unknown authored
      
      tests/mysql_client_test.c:
        Cleanup, remove some -ansi -pedancit warnings.
      b864c19b
    • unknown's avatar
      Manually import InnoDB fix into build tree. · d5be75f6
      unknown authored
      
      innobase/include/data0type.ic:
        Fix for sorting of innodb TEXT columns.
      d5be75f6
    • unknown's avatar
      Fix 'kill' test to actually test that the connection has · 488da795
      unknown authored
      been killed.
      
      
      mysql-test/r/kill.result:
        Update results
      mysql-test/t/kill.test:
        Fix 'ping' to be '--ping' and make test that this is a new
        connection actually test that.
      488da795
    • unknown's avatar
      Fix Windows compile errors. · 56083273
      unknown authored
      
      sql/item_sum.cc:
        Remove C_MODE_START/END around function, add cast
      56083273
    • unknown's avatar
      Removed MyISAM RAID from the Linux "Max" RPMs · d300b592
      unknown authored
      (patch from lenz, reapplied by jimw)
      
      
      support-files/mysql.spec.sh:
        removed MyISAM RAID from the Linux "Max" RPMs
      d300b592
    • unknown's avatar
      Eliminate warnings noticed by VC7. This includes fixing my_mmap() on · 22234f31
      unknown authored
      Windows to call CreateFileMapping() with correct arguments, and
      propogating the introduction of query_id_t to everywhere query ids are
      passed around. (Bug #8826)
      
      
      libmysql/libmysql.c:
        Make implicit cast explicit
      myisam/mi_open.c:
        Make cast of value to smaller data size explicit
      myisam/mi_packrec.c:
        Cast file size (my_off_t) to size_t for mmap
      mysys/my_mmap.c:
        Fix Windows version of my_mmap() to use the right parameters
        for call to CreateFileMapping()
      sql/field.cc:
        Use temporary value of correct type
      sql/field.h:
        Use query_id_t for query_id value
      sql/ha_berkeley.cc:
        Fix flag check
      sql/ha_innodb.h:
        Use query_id_t for query_id value
      sql/handler.cc:
        Explain opt_using_transactions calculation, and add cast
      sql/handler.h:
        Fix forward declaration of COND
      sql/item.cc:
        Fix val_bool() tests of val_int() to avoid implicit cast
      sql/item_cmpfunc.cc:
        Fix typo in switch label
      sql/item_func.cc:
        Make implicit cast explicit
      sql/item_strfunc.cc:
        Now that query_id is a query_id_t, need to cast it to a ulong here
      sql/item_subselect.cc:
        Fix test of value
      sql/log.cc:
        Cast my_off_t used for file size to size_t for memory allocation
        Also cast my_off_t when using it to calculate the number of pages for TC log
        Cast total_ha_2pc to uchar when saving it
      sql/mysql_priv.h:
        Move up query_id definition so it can be used more widely
      sql/opt_range.cc:
        Add unused delete operator to prevent compiler warning
      sql/set_var.cc:
        Cast value for max_user_connections
      sql/sql_cache.cc:
        Remove unused label
      sql/sql_class.h:
        Fix query id values to be of type query_id_t
      sql/sql_db.cc:
        Move variable only used inside #ifdef within the #ifdef
      sql/sql_help.cc:
        Remove unused label
      sql/sql_insert.cc:
        Use query_id_t for query id values
      sql/sql_lex.h:
        Add unused delete operator to prevent compiler warning
      sql/sql_select.cc:
        Remove unused variable
        Make cast of value explicit
      sql/sql_select.h:
        Use query_id_t for query id values
      sql/sql_table.cc:
        Make comparison to function pointer explicit
      sql/sql_update.cc:
        Use query_id_t for query id values
      sql/table.h:
        Use query_id_t for query id values
      strings/ctype-simple.c:
        Add cast of long value to (char) in expression
      strings/ctype-ucs2.c:
        Add cast of long value to (char) in expression
      strings/ctype-utf8.c:
        Make cast to smaller size explicit
      22234f31
  4. 18 Mar, 2005 25 commits
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · 892d7580
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      892d7580
    • unknown's avatar
      data0type.h: · 3f6d8ca8
      unknown authored
        The missing DATA_BINARY_TYPE in BLOBs created with < 4.0.14 does not cause any harm, because there were no indexes on such BLOBs
      
      
      innobase/include/data0type.h:
        The missing DATA_BINARY_TYPE in BLOBs created with < 4.0.14 does not cause any harm, because there were no indexes on such BLOBs
      3f6d8ca8
    • unknown's avatar
      data0type.ic: · ba3da184
      unknown authored
        Change the sorting order of TEXT columns in InnoDB: pad with spaces at the end in comparisons; we MUST UPDATE the MySQL MANUAL to warn about the need to rebuild tables (also MyISAM) in certain cases in an upgrade to 5.0.3; TODO: study what complications the missing DATA_BINARY_TYPE flag in InnoDB < 4.0.14 causes: we would compare then also BLOBs with space padding, not just TEXT
      
      
      innobase/include/data0type.ic:
        Change the sorting order of TEXT columns in InnoDB: pad with spaces at the end in comparisons; we MUST UPDATE the MySQL MANUAL to warn about the need to rebuild tables (also MyISAM) in certain cases in an upgrade to 5.0.3; TODO: study what complications the missing DATA_BINARY_TYPE flag in InnoDB < 4.0.14 causes: we would compare then also BLOBs with space padding, not just TEXT
      ba3da184
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-5.0 · f857f147
      unknown authored
      into a193-229-222-105.elisa-laajakaista.fi:/home/my/bk/mysql-5.0
      
      
      sql/sql_parse.cc:
        Auto merged
      f857f147
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · dbc39ac3
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      dbc39ac3
    • unknown's avatar
      Merge lgrimmer@bk-internal.mysql.com:/home/bk/mysql-5.0 · 6fdc7b55
      unknown authored
      into mysql.com:/space/my/mysql-5.0
      
      
      Build-tools/Do-compile:
        Auto merged
      6fdc7b55
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-5.0-build · 8efae531
      unknown authored
      into mysql.com:/space/my/mysql-5.0
      
      
      Build-tools/Do-compile:
        Auto merged
      8efae531
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · b3a958d6
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-compile
      
      b3a958d6
    • unknown's avatar
      - removed MyISAM RAID from the Linux "Max" RPMs · cd04f43f
      unknown authored
      cd04f43f
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · e92a6a5a
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-compile
      
      
      Build-tools/Do-compile:
        Auto merged
      e92a6a5a
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-5.0-build · fd69055c
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-compile
      
      fd69055c
    • unknown's avatar
      Merge mysql.com:/usr/local/bk/mysql-5.0 · 704e60f7
      unknown authored
      into mysql.com:/home/pem/work/mysql-5.0
      
      704e60f7
    • unknown's avatar
      Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.0 · e2c92089
      unknown authored
      into mysql.com:/M50/mysql-5.0
      
      
      Build-tools/Do-compile:
        Auto merged
      e2c92089
    • unknown's avatar
      Fixed BUG#6600: Stored procedure crash after repeated calls with check table · 91f8f7a6
      unknown authored
      
      mysql-test/r/sp.result:
        New test case for BUG#6600.
      mysql-test/t/sp.test:
        New test case for BUG#6600.
      sql/sp_head.cc:
        Added yet another multiple result set statement to the list.
      sql/sql_parse.cc:
        Have to invalidate SP caches in CHECK TABLE, or it will produce very
        strange results when called in SPs.
      91f8f7a6
    • unknown's avatar
      mysql-test-run.sh: · 7787215d
      unknown authored
        Disabled old feature to disable test cases
      
      
      mysql-test/mysql-test-run.sh:
        Disabled old feature to disable test cases
      7787215d
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-5.0-build · aff88736
      unknown authored
      into mysql.com:/M50/build-5.0.3
      
      
      Build-tools/Do-compile:
        Auto merged
      aff88736
    • unknown's avatar
      Did some SP test style changes and added explanatory comments, · f0fd4e4c
      unknown authored
      and removed a have_innodb.inc inclusion which was left by mistake
      in an earlier change.
      
      
      mysql-test/r/sp_trans.result:
        Changed procedure name and delimiter setting to follow the style of the other SP test files.
      mysql-test/t/sp-error.test:
        Added comment with hint for bug test case style.
      mysql-test/t/sp-threads.test:
        Added comments, with hint for bug test case style.
      mysql-test/t/sp.test:
        Removed have_innodb.inc inclusion.
        Added comments about different SP test files, table usage and
        hint for bug test case style.
      mysql-test/t/sp_trans.test:
        Changed procedure name and delimiter setting to follow the style of the other SP test files.
      f0fd4e4c
    • unknown's avatar
      Merge · c207b0ca
      unknown authored
      
      Build-tools/Do-compile:
        SCCS merged
      c207b0ca
    • unknown's avatar
      1078d38f
    • unknown's avatar
      Added more tests to grant2. Fixed some previous tests. · 0f29a348
      unknown authored
      Added new logic to ACL system:
      
      1) If GRANT OPTION (not mysql db):
         Ok to update existing user, but not password.
         Not allowed to make a new user.
      
      2) If UPDATE_ACL to mysql DB:
         Ok to update current user, but not make a new one.
      
      3) If INSERT_ACL to mysql DB:
         Ok to add a new user, but not modify existing.
      
      4) If GRANT OPTION to mysql DB:
         All modifications OK.
      
      
      mysql-test/r/grant2.result:
        Added more ACL tests and fixed results in some old tests.
      mysql-test/t/grant2.test:
        Added more ACL tests and fixed results in some old tests.
      sql/sql_acl.h:
        Made check_acl_user() visible to sql_parse.cc
      sql/sql_parse.cc:
        Added new logic to ACL system:
        
        1) If GRANT OPTION (not mysql db):
           Ok to update existing user, but not password.
           Not allowed to make a new user.
        
        2) If UPDATE_ACL to mysql DB:
           Ok to update current user, but not make a new one.
        
        3) If INSERT_ACL to mysql DB:
           Ok to add a new user, but not modify existing.
        
        4) If GRANT OPTION to mysql DB:
           All modifications OK.
      0f29a348
    • unknown's avatar
      Merge heikki@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8c69d59a
      unknown authored
      into hundin.mysql.fi:/home/heikki/mysql-5.0
      
      8c69d59a
    • unknown's avatar
      Manual merge · 4ef1272b
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      mysql-test/r/olap.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      BitKeeper/deleted/.del-isamchk.1.in~9d44303f6d951962:
        Auto merged
      BitKeeper/deleted/.del-isamlog.1.in~416d91adbf665b19:
        Auto merged
      4ef1272b
    • unknown's avatar
      olap.test: · c5c5810d
      unknown authored
        Added a test case for bug #8617.
      sql_select.cc:
        Fixed bug #8617.
        Queries with ROLLUP and LIMIT n returned more than n rows
        if SQL_CALC_FOUND_ROWS was used.
      
      
      sql/sql_select.cc:
        Fixed bug #8617.
        Queries with ROLLUP and LIMIT n returned more than n rows
        if SQL_CALC_FOUND_ROWS was used.
      mysql-test/t/olap.test:
        Added a test case for bug #8617.
      c5c5810d
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 9592f901
      unknown authored
      into mysql.com:/home/jimw/my/mysql-5.0-clean
      
      9592f901
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-5.0-build · 2be4208e
      unknown authored
      into mysql.com:/home/jimw/my/mysql-5.0-clean
      
      2be4208e