1. 15 Feb, 2023 4 commits
  2. 14 Feb, 2023 5 commits
  3. 13 Feb, 2023 1 commit
  4. 12 Feb, 2023 6 commits
  5. 10 Feb, 2023 24 commits
    • Sergei Petrunia's avatar
      MDEV-30569: Assertion ...ha_table_flags() in Duplicate_weedout_picker::check_qep · a7666952
      Sergei Petrunia authored
      DuplicateWeedout semi-join optimization requires that the tables in
      the parent subquery provide rowids that can be compared across table
      scans. Most engines support this, federated is the only exception.
      
      DuplicateWeedout is the default catch-all semi-join strategy, which
      must be always available. If it is not available for some edge case,
      it's better to disable semi-join conversion altogether.
      
      This is what was done in the fix for MDEV-30395. However that fix
      has put the check before the view processing, so it didn't detect
      federated tables inside mergeable VIEWs.
      
      This patch moves the check to be done at a later phase, when mergeable
      views are already merged.
      a7666952
    • Sergei Petrunia's avatar
      MDEV-30568: Assertion `cond_selectivity <= 1.000000001' failed in get_range_limit_read_cost · d6616966
      Sergei Petrunia authored
      In get_range_limit_read_cost(), handle the case where range_rows=0.
      d6616966
    • Sergei Petrunia's avatar
      MDEV-30529: Assertion `rnd_records <= s->found_records' failed in best_access_path · cc81ea1c
      Sergei Petrunia authored
      best_access_path() has an assertion:
      
         DBUG_ASSERT(rnd_records <= s->found_records);
      
      make it rounding-safe.
      cc81ea1c
    • Sergei Petrunia's avatar
      MDEV-30525: Assertion `ranges > 0' fails in IO_AND_CPU_COST handler::keyread_time · 5faf2ac0
      Sergei Petrunia authored
      Make get_best_group_min_max() exit early if the table has
      table->records()=0. Attempting to compute loose scan over 0
      groups eventually causes an assert when trying to get the
      cost of reading 0 ranges.
      5faf2ac0
    • Monty's avatar
      Fixed bug in extended key handling when there is no primary key · 00704aff
      Monty authored
      Extended keys works by first checking if the engine supports extended
      keys.
      If yes, it extends secondary key with primary key components and mark the
      secondary keys as HA_EXT_NOSAME (unique).
      If we later notice that there where no primary key, the extended key
      information for secondary keys in share->key_info is reset. However the
      key_info->flag HA_EXT_NOSAME was not reset!
      
      This causes some strange things to happen:
      - Tables that have no primary key or secondary index that contained the
        primary key would be wrongly optimized as the secondary key could be
        thought to be unique when it was not and not unique when it was.
      - The problem was not shown in EXPLAIN because of a bug in
        create_ref_for_key() that caused EQ_REF to be displayed by EXPLAIN as REF
        when extended keys where used and the secondary key contained the primary
        key.
      
      This is fixed with:
      - Removed wrong test in make_join_select() which did not detect that key
        where unique when a secondary key contains the primary.
      - Moved initialization of extended keys from create_key_infos() to
        init_from_binary_frm_image() after we know if there is a usable primary
        key or not. One disadvantage with this approach is that
        key_info->key_parts may have not used slots (for keys we thought could
        be extended but could not). Fixed by adding a check for unused key_parts
        to copy_keys_from_share().
      
      Other things:
      - Simplified copying of first key part in create_key_infos().
      - Added a lot of code comments in code that I had to check as part of
        finding the issue.
      - Fixed some indentation.
      - Replaced a couple of looks using references to pointers in C
        context where the reference does not give any benefit.
      - Updated Aria and Maria to not assume the all key_info->rec_per_key
        are in one memory block (this could happen when using dervived
        tables with many keys).
      - Fixed a bug where key_info->rec_per_key where not allocated
      - Optimized TABLE::add_tmp_key() to only call alloc() once.
        (No logic changes)
      
      Test case changes:
      - innodb_mysql.test changed index as an index the optimizer thought
        was unique, was not. (Table had no primary key)
      
      TODO:
      - Move code that checks for partial or too long keys to the primary loop
        earlier that initally decides if we should add extended key fields.
        This is needed to ensure that HA_EXT_NOSAME is not set for partial or
        too long keys. It will also shorten the current code notable.
      00704aff
    • Monty's avatar
      MDEV-30486 Table is not eliminated in bb-11.0 · fe1f4ca8
      Monty authored
      Some tables where not eliminated when they could have been.
      This was caused because HA_KEYREAD_ONLY is not set anymore for InnoDB
      clustered index and the elimination code was depending on
      field->part_of_key_not_clustered which was not set if HA_KEYREAD_ONLY
      is not present.
      
      Fixed by moving out field->part_of_key and
      field->part_of_key_not_clustered from under HA_KEYREAD_ONLY (which
      they should never have been part of).
      
      Other things:
      - Fixed a bug in make_join_select() that caused range to be used when
        there where elminiated or constant tables present (Caused wrong
        change of plans in join_outer_innodb.test). This also affected
        show_explain.test and subselct_sj_mat.test where wrong 'range's where
        replaced with index scans.
      
      Reviewer: Sergei Petrunia <sergey@mariadb.com>
      fe1f4ca8
    • Monty's avatar
      Removed /2 of InnoDB ref_per_key[] estimates · 01c82173
      Monty authored
      The original code was there to favor index search over table scan.
      This is not needed anymore as the cost calculations for table scans
      and index lookups are now more exact.
      01c82173
    • Sergei Petrunia's avatar
    • Sergei Golubchik's avatar
      remove GET_ADJUST_VALUE · 2010cfab
      Sergei Golubchik authored
      avoid contaminating my_getopt with sysvar implementation details.
      adjust variable values after my_getopt, like it's done for others.
      this fixes --help to show correct values.
      2010cfab
    • Sergei Golubchik's avatar
      remove SHOW_OPTIMIZER_COST · d10b3b01
      Sergei Golubchik authored
      avoid contaminating SHOW code with sysvar implementation details.
      And no hard-coded factor either.
      d10b3b01
    • Sergei Golubchik's avatar
      remove Feature_into_old_syntax · affab99c
      Sergei Golubchik authored
      it doesn't provide any information we'll use.
      No matter what the value is, we don't remove the non-standard
      syntax unless we have to
      affab99c
    • Sergei Golubchik's avatar
      typos in comments, etc · 7e465aeb
      Sergei Golubchik authored
      7e465aeb
    • Monty's avatar
      Selectivity: apply found_constraint heuristic only to post-join #rows. · 5e5988db
      Monty authored
      matching_candidates_in_table() computes the number of rows one
      gets from the current table after applying the WHERE clause on
      just this table
      
      The function had a "found_counstraint heuristic" which reduced the
      number of rows after WHERE check by 25% if there were comparisons
      between key parts in table T and previous tables, like WHERE
      T.keyXpartY= func(prev_table.cols)
      
      Note that such comparisons can only be checked when the row of
      table T is joined with rows of the previous tables. It is wrong
      to apply the selectivity before the join operation.
      
      Fixed by moving the 'found_constraint' code to a separate function
      and only reducing the #rows in 'records_out'.
      
      Renamed matching_candidates_in_table() to apply_selectivity_for_table() as
      the function now either applies selectivity on the rows (depending
      on the value of thd->variables.optimizer_use_condition_selectivity)
      or uses the selectivity from the available range conditions.
      5e5988db
    • Monty's avatar
      Updated comments in best_access_path() · 33af691f
      Monty authored
      33af691f
    • Monty's avatar
      MDEV-30080 Wrong result with LEFT JOINs involving constant tables · 0eca91ab
      Monty authored
      The reason things fails in 10.5 and above is that test_quick_select()
      returns -1 (impossible range) for empty tables if there are any
      conditions attached.
      
      This didn't happen in 10.4 as the cost for a range was more than for
      a table scan with 0 rows and get_key_scan_params() did not create any
      range plans and thus did not mark the range as impossible.
      
      The code that checked the 'impossible range' conditions did not take
      into account all cases of LEFT JOIN usage.
      
      Adding an extra check if the table is used with an ON condition in case
      of 'impossible range' fixes the issue.
      0eca91ab
    • Monty's avatar
      Code cleanups and add some caching of functions to speed up things · 3316a54d
      Monty authored
      Detailed description:
      - Added more function comments and fixed types in some old comments
      - Removed an outdated comment
      - Cleaned up some functions in records.cc
        - Replaced "while" with "if"
        - Reused error code
        - Made functions similar
      - Added caching of pfs_batch_update()
      - Simplified some rowid_filter code
        - Only call build_range_rowid_filter() if rowid filter will be used
        - Replaced tab->is_rowid_filter_built with need_to_build_rowid_filter.
          We only have to test need_to_build_rowid_filter to know if we have
          to build the filter. Old code needed two tests
        - Added function 'clear_range_rowid_filter' to disable rowid filter.
          Made things simpler as we can now clear all rowid filter variables
          in one place.
      - Removed some 'if' in sub_select()
      3316a54d
    • Monty's avatar
      MDEV-30360 Assertion `cond_selectivity <= 1.000000001' failed in ... · 65da5645
      Monty authored
      The problem was that make_join_select() called test_quick_select() outside
      of best_access_path(). This could use indexes that where not taken into
      account before and this caused changes to selectivity and 'records_out'.
      
      Fixed by updating records_out if test_quick_select() was called.
      65da5645
    • Monty's avatar
      MDEV-30328 Assertion `avg_io_cost != 0.0 || index_cost.io + row_cost.io == 0'... · 0a7d2917
      Monty authored
      MDEV-30328 Assertion `avg_io_cost != 0.0 || index_cost.io + row_cost.io == 0' failed in Cost_estimate::total_cost()
      
      The assert was there to check that engines reports sensible numbers for IO.
      However this does not work in case of optimizer_disk_read_ratio=0.
      
      Fixed by removing the assert.
      0a7d2917
    • Monty's avatar
      MDEV-30327 Client crashes in print_last_query_cost · 1a13dbff
      Monty authored
      Fixed by calling init_pager() before tee_fprintf()
      1a13dbff
    • Monty's avatar
      MDEV-30313 Sporadic assertion `cond_selectivity <= 1.0' failure in get_range_limit_read_cost · 8d4bccf3
      Monty authored
      The bug was related to floating point rounding. Fixed the assert to take
      that into account.
      8d4bccf3
    • Monty's avatar
      Added sys.optimizer_switch_on() and sys.optimizer_switch_off() · 5de734da
      Monty authored
      These are helpful tools to quickly see what optimizer switch options
      are on or off.  The different options are displayed alphabetically
      5de734da
    • Monty's avatar
    • Monty's avatar
      MDEV-30310 Assertion failure in best_access_path upon IN exceeding... · 02b7735b
      Monty authored
      MDEV-30310 Assertion failure in best_access_path upon IN exceeding IN_PREDICATE_CONVERSION_THRESHOLD, derived_with_keys=off
      
      The bug was some old code that, without any explanation, reset
      PART_KEY_FLAG from fields in temporary tables. This caused
      join_tab->key_dependent to not be updated properly, which caused
      an assert.
      02b7735b
    • Monty's avatar
      Simplified code in generate_derived_keys() and when using pos_in_tables · 4be0bfad
      Monty authored
      Added comments that not used keys of derivied tables will be deleted.
      Added some comments about checking if pos_in_table_list is 0.
      
      Other things:
      - Added a marker (DBTYPE_IN_PREDICATE) in TABLE_LIST->derived_type
        to indicate that the table was generated from IN (list). This is
        useful for debugging and can later be used by explain if needed.
      - Removed a not needed test of table->pos_in_table_list as it should
        always be valid at this point in time.
      4be0bfad