1. 07 Dec, 2007 5 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · bd7e299d
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      bd7e299d
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 0eb84b33
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      0eb84b33
    • unknown's avatar
      Merge trift2.:/MySQL/M51/embedtest-5.1 · b512a29c
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      b512a29c
    • unknown's avatar
      Merge trift2.:/MySQL/M51/mysql-5.1 · c584b458
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      mysql-test/t/disabled.def:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      c584b458
    • unknown's avatar
      Makefile.am · 4a955058
      unknown authored
          In the "test-bt" target, replace the call "$(MAKE) test-embedded" by the actions of that target.
      
      
      Makefile.am:
        In the "test-bt" target, replace the call "$(MAKE) test-embedded" by the actions of that target.
        
        Reason:
        For release builds, we run the tests in a tree that contains just a binary installation.
        So the Makefile is not in the test tree, and we explicitly address it in the build tree.
        This explicit path is not kept by "make", so it is missing in the sub-make.
        There seems to be no way to solve this with (portable!) "make" features -
        we could add a new variable and use it in the sub-make, but it is easier to duplicate these few lines.
      4a955058
  2. 05 Dec, 2007 2 commits
  3. 04 Dec, 2007 3 commits
    • unknown's avatar
      configure.in: · e4936a35
      unknown authored
        Removed the auto detection and use of Solaris "libmtmalloc", as it
        cause regression on bug#18322. The code removed also prevented
        a build without using this library. Users can still compile with
        "libmtmalloc", if configuring with "--with-mysqld-libs=-lmtmalloc"
      
      
      configure.in:
        Removed the auto detection and use of Solaris "libmtmalloc", as it
        cause regression on bug#18322. The code removed also prevented
        a build without using this library. Users can still compile with
        "libmtmalloc", if configuring with "--with-mysqld-libs=-lmtmalloc"
      e4936a35
    • unknown's avatar
      Bug#32966 main.status fails. · 6a842299
      unknown authored
      Disable failing test case.
      
      
      mysql-test/t/disabled.def:
        Disable main.status test case.
      6a842299
    • unknown's avatar
      Bug#32965 main.ctype_create fails. · 8fcb6eb2
      unknown authored
      Disable failing test case.
      
      
      mysql-test/t/disabled.def:
        Disable main.ctype_create test case.
      8fcb6eb2
  4. 30 Nov, 2007 18 commits
    • unknown's avatar
      Merge four.local.lan:/work/trees/mysql-5.0-build-src-clean · eda09234
      unknown authored
      into  four.local.lan:/work/trees/mysql-5.1-build-src-clean
      
      eda09234
    • unknown's avatar
      Merge four.local.lan:/work/merge/mysql-5.1-dev · c6294a62
      unknown authored
      into  four.local.lan:/work/trees/mysql-5.1-build-src-clean
      
      c6294a62
    • unknown's avatar
      Merge four.local.lan:/work/trees/mysql-4.1-build-src-clean · 4e3f57b9
      unknown authored
      into  four.local.lan:/work/trees/mysql-5.0-build-src-clean
      
      4e3f57b9
    • unknown's avatar
      Merge four.local.lan:/work/merge/mysql-5.0-dev · 7008c647
      unknown authored
      into  four.local.lan:/work/trees/mysql-5.0-build-src-clean
      
      7008c647
    • unknown's avatar
      Merge four.local.lan:/work/merge/mysql-4.1-dev · 01c3ccc5
      unknown authored
      into  four.local.lan:/work/trees/mysql-4.1-build-src-clean
      
      01c3ccc5
    • unknown's avatar
      Merge four.local.lan:/work/merge/mysql-5.0-dev · 70276d15
      unknown authored
      into  four.local.lan:/work/merge/mysql-5.1-dev
      
      
      mysql-test/suite/rpl/r/rpl_000015.result:
        Auto merged
      mysql-test/suite/rpl/t/rpl_000015.test:
        Auto merged
      70276d15
    • unknown's avatar
      Merge four.local.lan:/work/merge/mysql-4.1-dev · b0dd0708
      unknown authored
      into  four.local.lan:/work/merge/mysql-5.0-dev
      
      
      BitKeeper/deleted/.del-disabled.def:
        SCCS merged
      mysql-test/r/rpl000015.result:
        Bug does not apply to 5.0 and up
      mysql-test/t/rpl000015.test:
        Bug does not apply to 5.0 and up.
      b0dd0708
    • unknown's avatar
      Fix for · e86d38ab
      unknown authored
         Bug#31030 rpl000015.test fails if $MYSQL_TCP_PORT != 3306
      Note:
        This bug does not occur in MySQL 5.0 and up, because
        ChangeSet 1.2328.2.1 2006/11/27 for MySQL 5.0 prevents this.
        The 5.0 fix uses the environment variable DEFAULT_MASTER_PORT
        which is set by mysql-test-run.pl.
        mysql-test-run.pl in 4.1 does not set this variable.
        There are two alternatives:
        1) Backport the 5.0 fix for this test including modifications
           to mysql-test-run.pl and mysql-test-run-shell.
           This is a not acceptable impact on an old MySQL version.
        2) Fix the problem different than in 5.0 like in the current
           ChangeSet + do not apply these changes when upmerging to 5.0
      
      
      mysql-test/r/rpl000015.result:
        Updated result
      mysql-test/t/disabled.def:
        Enable rpl000015
      mysql-test/t/rpl000015.test:
        Unify the MASTER_PORT number
      e86d38ab
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 2894364f
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      2894364f
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/22312-5.1 · ce524ead
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      ce524ead
    • unknown's avatar
      A patch for BUG#32148: killing a query may be ineffective. · 0f0addf2
      unknown authored
      The problem was that THD::killed was reset after a command was
      read from the socket, but before it was actually handled. That lead
      to a race: if another KILL statement was issued for this connection
      in the middle of reading from the socket and processing a command,
      THD::killed state would be cleaned.
      
      The fix is to move this cleanup into net_send_error() function.
      
      A sample test case exists in binlog_killed.test:
        - connection 1: start a new transaction on table t1;
        - connection 2: send query to the server (w/o waiting for the
          result) to update data in table t1 -- this query will be blocked
          since there is unfinished transaction;
        - connection 1: kill query in connection 2 and finish the transaction;
        - connection 2: get result of the previous query -- it should be
          the "query-killed" error.
      
      This test however contains race condition, which can not be fixed
      with the current protocol: there is no way to guarantee, that the
      server will receive and start processing the query in connection 2
      (which is intended to get blocked) before the KILL command (sent in
      the connection 1) will arrive. In other words, there is no way to
      ensure that the following sequence will not happen:
      
        - connection 1: start a new transaction on table t1;
        - connection 1: kill query in connection 2 and finish the transaction;
        - connection 2: send query to the server (w/o waiting for the
          result) to update data in table t1 -- this query will be blocked
          since there is unfinished transaction;
        - connection 2: get result of the previous query -- the query will
          succeed.
      
      So, there is no test case for this bug, since it's impossible
      to write a reliable test case under the current circumstances.
      
      
      sql/protocol.cc:
        Move thd->killed cleanup from dispatch_command() to net_send_error().
      sql/sql_parse.cc:
        Move thd->killed cleanup from dispatch_command() to net_send_error().
      0f0addf2
    • unknown's avatar
      BUG#32723 (grant3.test fails) can not be reproduced. · 0dd233d9
      unknown authored
      Enabling the test case.
      
      
      mysql-test/t/disabled.def:
        Enable grant3.test.
      0dd233d9
    • unknown's avatar
      Bug#22312 Syntax error in expression with INTERVAL() · 2981af2a
      unknown authored
      Parser rejects valid INTERVAL() expressions when associated with
      arithmetic operators. The problem is the way in which the expression
      and interval grammar rules were organized caused shift/reduce conflicts.
      
      The solution is to tweak the interval rules to avoid shift/reduce
      conflicts by removing the broken interval_expr rule and explicitly
      specify it's content where necessary.
      
      Original fix by Davi Arnaut, revised and improved rules by Marc Alff
      
      
      mysql-test/r/parser.result:
        Add test case result for Bug#22312
      mysql-test/t/parser.test:
        Add test case for Bug#22312
      sql/sql_yacc.yy:
        Resolve shift/reduce conflicts by reorganizing the interval
        expression rules.
      2981af2a
    • unknown's avatar
      A test case for BUG#26676: VIEW using old table schema in a session. · 8bf6c19d
      unknown authored
      The following clarification should be made in The Manual:
      
      Standard SQL is quite clear that, if new columns are added
      to a table after a view on that table is created with
      "select *", the new columns will not become part of the view.
      In all cases, the view definition (view structure) is frozen
      at CREATE time, so changes to the underlying tables do not
      affect the view structure.
      
      
      mysql-test/r/view.result:
        Update result file.
      mysql-test/t/view.test:
        Add a test case for BUG#26676: VIEW using old table schema in a session.
      8bf6c19d
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mac-os-x-universal/mysql-5.0-build · 14f7373f
      unknown authored
      into  mysql.com:/home/kent/bk/mac-os-x-universal/mysql-5.1-build
      
      
      include/my_global.h:
        Auto merged
      14f7373f
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mac-os-x-universal/mysql-4.1-build · c7fdd55f
      unknown authored
      into  mysql.com:/home/kent/bk/mac-os-x-universal/mysql-5.0-build
      
      
      include/my_global.h:
        Auto merged
      c7fdd55f
    • unknown's avatar
      my_global.h: · cd1b2db4
      unknown authored
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      
      
      include/my_global.h:
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      cd1b2db4
    • unknown's avatar
  5. 29 Nov, 2007 7 commits
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mac-os-x-universal/mysql-5.0-build · f5e5ea91
      unknown authored
      into  mysql.com:/home/kent/bk/mac-os-x-universal/mysql-5.1-build
      
      
      include/my_global.h:
        Auto merged
      f5e5ea91
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/mac-os-x-universal/mysql-4.1-build · 0a1be3d7
      unknown authored
      into  mysql.com:/home/kent/bk/mac-os-x-universal/mysql-5.0-build
      
      
      include/my_global.h:
        Auto merged
      0a1be3d7
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.0 · 894d3961
      unknown authored
      into  mysql.com:/home/kent/bk/mac-os-x-universal/mysql-5.0-build
      
      894d3961
    • unknown's avatar
      my_global.h: · ef2dbb8b
      unknown authored
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      
      
      include/my_global.h:
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      ef2dbb8b
    • unknown's avatar
      Merge chorlton.adsl.perkin.org.uk:/Users/jonathan/work/bk/mysql-5.0 · 742fad6e
      unknown authored
      into  chorlton.adsl.perkin.org.uk:/Users/jonathan/work/bk/mysql-5.1
      
      742fad6e
    • unknown's avatar
      Shell portability fix. · 7173a3d9
      unknown authored
      
      scripts/mysql_install_db.sh:
        Use "test !" instead of "! test", as the
        latter does not work on certain shells.
      7173a3d9
    • unknown's avatar
      Bug#23713 LOCK TABLES + CREATE TRIGGER + FLUSH TABLES WITH READ LOCK = deadlock · 09e83e9e
      unknown authored
      This bug is actually two bugs in one, one of which is CREATE TRIGGER under
      LOCK TABLES and the other is CREATE TRIGGER under LOCK TABLES simultaneous
      to a FLUSH TABLES WITH READ LOCK (global read lock). Both situations could
      lead to a server crash or deadlock.
      
      The first problem arises from the fact that when under LOCK TABLES, if the
      table is in the set of locked tables, the table is already open and it doesn't
      need to be reopened (not a placeholder). Also in this case, if the table is
      not write locked, a exclusive lock can't be acquired because of a possible
      deadlock with another thread also holding a (read) lock on the table. The
      second issue arises from the fact that one should never wait for a global
      read lock if it's holding any locked tables, because the global read lock
      is waiting for these tables and this leads to a circular wait deadlock.
      
      The solution for the first case is to check if the table is write locked
      and upgraded the write lock to a exclusive lock and fail otherwise for non
      write locked tables. Grabbin the exclusive lock in this case also means
      to ensure that the table is opened only by the calling thread. The second
      issue is partly fixed by not waiting for the global read lock if the thread
      is holding any locked tables.
      
      The second issue is only partly addressed in this patch because it turned
      out to be much wider and also affects other DDL statements. Reported as
      Bug#32395
      
      
      mysql-test/r/trigger.result:
        Add test case result for Bug#23713
      mysql-test/r/trigger_notembedded.result:
        Add test case result for Bug#23713
      mysql-test/t/trigger.test:
        Add test case for Bug#23713
      mysql-test/t/trigger_notembedded.test:
        Add test case for Bug#23713
      sql/mysql_priv.h:
        Locally export wait_while_table_is_used and name_lock_locked_table
        and add flag to mysql_ha_rm_tables to signal that LOCK_open is locked.
      sql/sql_base.cc:
        Introduce name_lock_locked_table function and match
        close_old_data_files function declaration and definition.
      sql/sql_handler.cc:
        Add flag to mysql_ha_rm_tables to signal that LOCK_open is locked.
      sql/sql_rename.cc:
        Fix mysql_ha_rm_tables caller.
      sql/sql_table.cc:
        Export wait_while_table_is_used and assert that LOCK_open is locked
        and fix mysql_ha_rm_tables caller.
      sql/sql_trigger.cc:
        Upgrade write locked tables to a exclusive lock and fail if
        the table is not write locked. Also, don't wait for the global
        read lock if under LOCK TABLES.
      09e83e9e
  6. 28 Nov, 2007 5 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 22bec7d9
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      
      client/mysql.cc:
        Auto merged
      configure.in:
        Auto merged
      mysql-test/lib/mtr_report.pl:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/suite/rpl/include/rpl_mixed_dml.inc:
        Auto merged
      mysql-test/t/disabled.def:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_table.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/table.h:
        Auto merged
      22bec7d9
    • unknown's avatar
      use --builddir option for mysql_install_db · f732fe49
      unknown authored
      f732fe49
    • unknown's avatar
      fix make distcheck in a different way · 4fa71559
      unknown authored
      
      scripts/mysql_install_db.sh:
        apply different patch for make distcheck failure
      4fa71559
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 5c771296
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1-build
      
      
      scripts/mysql_install_db.sh:
        Auto merged
      5c771296
    • unknown's avatar
      Merge lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.0-runtime · 6a0b54c3
      unknown authored
      into  lambda.hsd1.co.comcast.net.:/home/malff/TREE/mysql-5.1-rt-merge
      
      
      sql/item_func.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql-common/client.c:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      6a0b54c3