- 06 Nov, 2018 2 commits
-
-
Marko Mäkelä authored
Remove trailing white space, and use lower case for "eval" and "let". Add an "End of 10.2 tests" marker to ease future merges.
-
Marko Mäkelä authored
-
- 05 Nov, 2018 4 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
The relevant InnoDB/XtraDB fixes up to 5.6.42 had already been applied to MariaDB in commit 30c3d6db. Revert some changes that appeared in the merge commit 87d852f1.
-
Marko Mäkelä authored
-
Eugene Kosov authored
Problem affects INPLACE ALTER rename columns. innobase_rename_column_try(): some strcmp() was replaced with my_strcasecmp(), queries to update data dictionary was updated to not match column name case.
-
- 04 Nov, 2018 1 commit
-
-
Sergei Golubchik authored
MDEV-17349 Assertion `!table || (!table->read_set || bitmap_is_set(table->read_set, field_index))' failed on concurrent SELECT and DELETE after RENAME from table with index on virtual column Race condition. field->flags were copied from s->field->flags during field->clone(), early in open_table_from_share(). But s->field->flags were getting their PART_INDIRECT_KEY_FLAG bit much later in TABLE::mark_columns_used_by_virtual_fields() and only once per share. If two threads were executing the code between field->clone() and mark_columns_used_by_virtual_fields() at the same time, only one would get PART_INDIRECT_KEY_FLAG bits in field[].
-
- 03 Nov, 2018 1 commit
-
-
Alexey Botchkov authored
LOCK view WRITE shouldn't block FLUSH view. So we set the view's mdl_request type to it's tables.
-
- 02 Nov, 2018 4 commits
-
-
Marko Mäkelä authored
thd_rpl_stmt_based(): A new predicate to check if statement-based replication is active. (This can also hold when replication is not in use, but binlog is.) que_thr_stop(), row_ins_duplicate_error_in_clust(), row_ins_sec_index_entry_low(), row_ins(): On a duplicate key error, only lock all index records when statement-based replication is in use.
-
Daniel Bartholomew authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
- 01 Nov, 2018 9 commits
-
-
Vicențiu Ciorbaru authored
Users expect window functions to produce a certain ordering of rows in the final result set. Although the standard does not require this, we already have the filesort result done for when we computed the window function. If there is no ORDER BY attached to the query, just keep it till the SELECT is completely evaluated and use that to print the result. Update test cases as many did not take care to guarantee a stable result.
-
Daniel Bartholomew authored
-
Sergei Golubchik authored
set both `password` and `authentication_string` columns in `mysql`.`user` table for now. Suppress the "password was ignored" warning if the password is the same as the authentication string
-
Andrei Elkin authored
which did not always correctly simulated io-cache::end_of_file. The error was caused by implicit cast to unsigned of an intemediate term in a formula.
-
Marko Mäkelä authored
The parameters bool sync=true, bool read_only=false of mtr_t::start() were added in https://github.com/mysql/mysql-server/commit/eca5b0fc17a5bd6d4833d35a0d08c8549dd3b5ec (MySQL 5.7.3). The parameter read_only was never used anywhere. The parameter sync was only copied around, and would be returned by the unused function mtr_t::is_async(). We do not need this dead code in MariaDB.
-
Marko Mäkelä authored
At the start of the function, we already dereferenced node, so the checks for NULL are unnecessary and redundant.
-
Varun Gupta authored
For index merge union[or sort union], the estimates are not taken into account while calculating the selectivity of a condition. So instead of showing the estimates of the index merge union[or sort union], it shows estimates equal to all the records of the table. The fix for the issue is to include the selectivity of index merge union[or sort union] while calculating the selectivity of a condition.
-
Jan Lindström authored
branch.
-
Jan Lindström authored
-
- 31 Oct, 2018 8 commits
-
-
Elena Stepanova authored
-
Sergei Golubchik authored
-
Vladislav Vaintroub authored
Query INFORMATION_SCHEMA.INNODB_SYS_TABLES only once, and cache results. As a small cleanup, remove mdl_lock_con_mutex, the MDL handling connection is never accessed by multiple threads at the same time.
-
Alexander Barkov authored
-
Marko Mäkelä authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 30 Oct, 2018 10 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
--gdb now accepts an argument, it will be passed to gdb as a command. multiple commands can be separated by a (non-standard and not escapable) delimiter - semicolon (;). Old usage with a bare --gdb continues to work too, of course. Cherry-picked c47c0ca5 5441bbd3 339b9055
-
Elena Stepanova authored
-
Alexey Botchkov authored
We should clear trailing zeroes in frac part. Otherwise that tail is growing quickly and forces unnecessary truncating of arguments.
-
Sergei Golubchik authored
-
Marko Mäkelä authored
row_drop_table_for_mysql(): Avoid accessing non-existing dictionary tables. dict_create_or_check_foreign_constraint_tables(): Add debug instrumentation for creating and dropping a table before the creation of any non-core dictionary tables. trx_purge_add_update_undo_to_history(): Adjust a debug assertion, so that it will not fail due to the test instrumentation.
-
Shinnok authored
Also change Jira link to actual domain. The mariadb.org/jira web server redirect might not be maintained at some point.
-
Daniel Black authored
-
Marko Mäkelä authored
row_drop_table_for_mysql(): Avoid accessing non-existing dictionary tables. dict_create_or_check_foreign_constraint_tables(): Add debug instrumentation for creating and dropping a table before the creation of any non-core dictionary tables. trx_purge_add_update_undo_to_history(): Adjust a debug assertion, so that it will not fail due to the test instrumentation.
-
- 29 Oct, 2018 1 commit
-
-
Sergei Golubchik authored
if -DWITH_SSL=yes and system ssl cannot be used, bundled ssl should be auto-selected. That's how it worked in 10.0, and it was unintentionally broken in 10.1.
-