1. 10 Jul, 2006 4 commits
    • unknown's avatar
      more 4.1->5.0 merge fixes for bug#14553 · be148b34
      unknown authored
      
      mysql-test/r/rpl_insert_id.result:
        more merge fixes for bug#14553
      mysql-test/t/rpl_insert_id.test:
        more merge fixes for bug#14553
      be148b34
    • unknown's avatar
      Merge macbook.gmz:/Users/kgeorge/mysql/work/B14553-4.1-opt · 4a723e73
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B14553-5.0-opt
      
      
      mysql-test/r/odbc.result:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/rpl_insert_id.result:
        merge the test at the end of 4.1 test
      mysql-test/t/rpl_insert_id.test:
        merge the test at the end of 4.1 test
      sql/sql_class.cc:
        merged
      sql/sql_class.h:
        merged
      4a723e73
    • unknown's avatar
      Merge rakia:mysql/4.1/B14553 · 3cb187a8
      unknown authored
      into  macbook.gmz:/Users/kgeorge/mysql/work/B14553-4.1-opt
      
      
      sql/sql_class.cc:
        SCCS merged
      sql/sql_select.cc:
        SCCS merged
      3cb187a8
    • unknown's avatar
      BUG#14553: NULL in WHERE resets LAST_INSERT_ID · cc6a70e7
      unknown authored
      To make MySQL compatible with some ODBC applications, you can find
      the AUTO_INCREMENT value for the last inserted row with the following query:
       SELECT * FROM tbl_name WHERE auto_col IS NULL.
      This is done with a special code that replaces 'auto_col IS NULL' with
      'auto_col = LAST_INSERT_ID'.
      However this also resets the LAST_INSERT_ID to 0 as it uses it for a flag
      so as to ensure that only the first SELECT ... WHERE auto_col IS NULL
      after an INSERT has this special behaviour.
      In order to avoid resetting the LAST_INSERT_ID a special flag is introduced
      in the THD class. This flag is used to restrict the second and subsequent
      SELECTs instead of LAST_INSERT_ID.
      
      
      mysql-test/r/odbc.result:
        test suite for the bug
      mysql-test/r/rpl_insert_id.result:
        test for the fix in replication
      mysql-test/t/odbc.test:
        test suite for the bug
      mysql-test/t/rpl_insert_id.test:
        test for the fix in replication
      sql/sql_class.cc:
        initialize the flag
      sql/sql_class.h:
        flag's declaration and set code when setting the last_insert_id
      sql/sql_select.cc:
        the special flag is used instead of last_insert_id
      cc6a70e7
  2. 07 Jul, 2006 1 commit
  3. 06 Jul, 2006 6 commits
    • unknown's avatar
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-4.1-opt · 885807f4
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/item_strfunc.h:
        Auto merged
      885807f4
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 118a47cf
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-4.1-opt
      
      118a47cf
    • unknown's avatar
      Fixed bug #18243. · 77e7f2ac
      unknown authored
      The implementation of the method Item_func_reverse::val_str
      for the REVERSE function modified the argument of the function.
      This led to wrong results for expressions that contained
      REVERSE(ref) if ref occurred somewhere else in the expressions.
      
      
      mysql-test/r/func_str.result:
        Added a test case for bug #18243.
      mysql-test/t/func_str.test:
        Added a test case for bug #18243.
      sql/item_strfunc.cc:
        Fixed bug #18243.
        The implementation of the method Item_func_reverse::val_str
        for the REVERSE function modified the argument of the function.
        This led to wrong results for expressions that contained
        REVERSE(ref) if ref occurred somewhere else in the expressions.
        
        The implementation of Item_func_reverse::val_str has been changed
        to make the argument intact.
      sql/item_strfunc.h:
        Fixed bug #18243.
        Added tmp_value to the Item_func_reverse class to store
        the result of the function. It erroneously replaced the 
        argument before this fix.
      77e7f2ac
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 0d9d4474
      unknown authored
      into  rakia.(none):/home/kgeorge/mysql/autopush/test
      
      0d9d4474
    • unknown's avatar
      Bug #20569 Garbage in DECIMAL results from some mathematical functions · fb917563
      unknown authored
        Adding decimal "digits" in multiplication resulted in signed overflow and
      producing wrong results.
      
        Fixed by using large enough buffers and intermediary result types :
      dec2 (currently longlong) to hold result of adding decimal "digits" 
      (currently int32). 
      
      
      mysql-test/r/select.result:
        Bug #20569 Garbage in DECIMAL results from some mathematical functions
          * test suite for the bug
      mysql-test/t/select.test:
        Bug #20569 Garbage in DECIMAL results from some mathematical functions
          * test suite for the bug
      strings/decimal.c:
        Bug #20569 Garbage in DECIMAL results from some mathematical functions
          * fixed the overflow in adding decimal "digits"
      fb917563
  4. 04 Jul, 2006 3 commits
    • unknown's avatar
      Better comments for void Item::top_level_item() · 5370c919
      unknown authored
      5370c919
    • unknown's avatar
      Merge mysql.com:/home/kgeorge/mysql/5.0/teamclean · 3325855f
      unknown authored
      into  mysql.com:/home/kgeorge/mysql/5.0/B16110
      
      
      mysql-test/r/view.result:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      3325855f
    • unknown's avatar
      Bug #16110: insert permitted into view col w/o default value · 5d0a1a1e
      unknown authored
      When compiling INSERT statements the check whether columns are provided values
      depends on the flag whether a field is used in that query (Field::query_id).
      However the check for updatability of VIEW columns (check_view_insertability())
      was calling fix_fields() and thus setting the Field::query_id even for the 
      view fields that are not referenced in the current INSERT statement.
      So the correct check for columns without default values 
      ( check_that_all_fields_are_given_values() ) is assuming that all the VIEW
      columns were mentioned in the INSERT field list and was issuing no 
      warnings or errors.
      Fixed check_view_insertability() to turn off the flag whether or not to set
      Field::query_id (THREAD::set_query_id) before calling fix fields and restore
      it when it's done.
      
      
      mysql-test/r/view.result:
        Bug #16110: insert permitted into view col w/o default value
          * test case
      mysql-test/t/view.test:
        Bug #16110: insert permitted into view col w/o default value
          * test case
      sql/sql_insert.cc:
        Bug #16110: insert permitted into view col w/o default value
          * avoid setting the "field used" flag for fields when checking view columns 
            for updatability.
          * a missing DBUG_RETURN added.
      5d0a1a1e
  5. 29 Jun, 2006 26 commits