1. 03 Nov, 2003 1 commit
    • unknown's avatar
      Simplified 'wrong xxx name' error messages by introducing 'general' ER_WRONG_NAME error · bee5d9d4
      unknown authored
      Cleaned up (and disabled part of) date/time/datetime format patch. One can't anymore change default read/write date/time/formats.
      This is becasue the non standard datetime formats can't be compared as strings and MySQL does still a lot of datetime comparisons as strings
      Changed flag argument to str_to_TIME() and get_date() from bool to uint
      Removed THD from str_to_xxxx functions and Item class.
      Fixed core dump when doing --print-defaults
      Move some common string functions to strfunc.cc
      Dates as strings are now of type my_charset_bin instead of default_charset()
      Introduce IDENT_QUOTED to not have to create an extra copy of simple identifiers (all chars < 128)
      Removed xxx_FORMAT_TYPE enums and replaced them with the old TIMESTAMP_xxx enums
      Renamed some TIMESTAMP_xxx enums to more appropriate names
      Use defines instead of integers for date/time/datetime string lengths
      Added to build system and use the new my_strtoll10() function.
      
      
      
      BUILD/compile-pentium-valgrind-max:
        Remove double printing of warning
      VC++Files/libmysqld/libmysqld.dsp:
        Added strfunc.cc
      VC++Files/sql/mysqld.dsp:
        Added strfunc.cc
      VC++Files/sql/mysqldmax.dsp:
        Added strfunc.cc
      VC++Files/strings/strings.dsp:
        added my_strtoll10.c
      include/m_ctype.h:
        Removed MY_LEX_FOUND_IDENT (not used)
      include/m_string.h:
        Added my_strtoll10()
      include/mysqld_error.h:
        simplified 'wrong xxx name' error messages
      include/sql_state.h:
        simplified 'wrong xxx name' error messages
      libmysqld/Makefile.am:
        Added strfunc.cc
      mysql-test/mysql-test-run.sh:
        Simplified some options
        changed $@ to "$@" in an attempt to handle options with space (Didn't succeed;  Problem will disappear when mysql-test-run is rewritten in C)
      mysql-test/r/ctype_latin1_de.result:
        Added new tests
      mysql-test/r/ctype_recoding.result:
        Extended tests
      mysql-test/r/date_formats.result:
        Cleaned up tests
        Disabled some tests that can't yet be run
      mysql-test/r/func_compress.result:
        New error message
      mysql-test/r/rpl_temporary.result:
        Added new test
      mysql-test/t/create.test:
        Changed error numbers
      mysql-test/t/ctype_latin1_de.test:
        New tests
      mysql-test/t/ctype_recoding.test:
        Extended tests
      mysql-test/t/date_formats-master.opt:
        Removed datetime_format as we can't handle options with space in mysql-test-run
      mysql-test/t/date_formats.test:
        Cleaned up tests
        Disabled some tests that can't yet be run
      mysql-test/t/rpl_temporary.test:
        Added testing of open temporary table on slave shutdown
      mysql-test/t/symlink.test:
        Fixed error numbers
      mysys/default.c:
        Fixed core dump when doing --print-defaults
      sql/Makefile.am:
        Added strfunc.cc
      sql/derror.cc:
        Fixed compiler warning
      sql/field.cc:
        Changed argument to str_to_TIME() from bool to uint
        Removed THD argument from str_to_TIME()
        Moved find_enum() and find_set() to strfunc.cc
      sql/field.h:
        Changed type of last argument to get_date() to be able to handle more options
      sql/init.cc:
        Remove not used variable dayord
      sql/item.cc:
        Changed type of last argument to get_date() to be able to handle more options
        Removed THD* element from item.
        Don't use make_date_time() to generate date/time/datetimes
      sql/item.h:
        Changed type of last argument to get_date() to be able to handle more options
        Removed THD* from Item
      sql/item_create.cc:
        Indentation cleanup
      sql/item_func.cc:
        Use new find_type()
      sql/item_func.h:
        Changed type of last argument to get_date() to be able to handle more options
      sql/item_strfunc.h:
        space change
      sql/item_timefunc.cc:
        Changed month_names[] to be easier to use
        Moved check_names[] to strfunc.cc
        Added back old make_datetime() function
        Optimized extract_date_time()
        Use my_strtoll10() insetad of my_strntoll()
        Optimized make_date_time()
        Replaced short variable names with long ones.
        Use new functions make_time(), make_date() and make_datetime()
        Dates as strings are now of type my_charset_bin instead of default_charset()
        Changed Item_func_str_to_date() to by default return a date.
      sql/item_timefunc.h:
        Changed charset for date string from default_charset() to my_charset_bin
        Changed type of last argument to get_date() to be able to handle more options
        Use defines instead of integers for date/time/datetime string lengths
      sql/mysql_priv.h:
        Fixed/added new prototypes
      sql/mysqld.cc:
        Removed opt_datetime_format_names
        Cleaned up handling of date_time format handling. (Fixed core dump when mysqld had error on startup)
        Removed some unnecessary double init of collation variables
      sql/protocol.cc:
        Changed back protocol functions to always return dates in ISO format
      sql/set_var.cc:
        Added variables time_format, date_format and datetime_format
        This had to be recoded becasue checking was done in 'update' method and not in 'check' method.
      sql/set_var.h:
        Removed class sys_var_datetime_format() as this defined a variable (which doesn't work) instead of updating a variable
      sql/share/czech/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/danish/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/dutch/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/english/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/estonian/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/french/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/german/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/greek/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/hungarian/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/italian/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/japanese/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/korean/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/norwegian-ny/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/norwegian/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/polish/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/portuguese/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/romanian/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/russian/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/serbian/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/slovak/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/spanish/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/swedish/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/share/ukrainian/errmsg.txt:
        simplified 'wrong xxx name' error messages
      sql/sql_base.cc:
        Use new find_type()
      sql/sql_class.cc:
        Allocate/free date_time format variables
      sql/sql_class.h:
        Define datetime_format variables
      sql/sql_db.cc:
        Use new ER_WRONG_NAME error
      sql/sql_lex.cc:
        Change lex to generate IDENT_QUOTED for quoted identifiers or identifers that are using characters > 128.
        This enabled us to not have to copy and convert the identifier to utf8 for simpe identifiers
      sql/sql_parse.cc:
        Use new ER_WRONG_NAME error
        Use new find_type() function
      sql/sql_prepare.cc:
        Use new defines
      sql/sql_table.cc:
        Use new ER_WRONG_NAME error
      sql/sql_yacc.yy:
        Don't copy and convert simple identifiers to utf8.
        Replace __FORMAT_TYPE defines with TIMESTAMP... defines
      sql/structs.h:
        Renamed DATETIME_FORMAT to DATE_TIME format to indicate that it's for date/time/datetime formats
        Renamed WRONT_TIMESTAMP_FULL to TIMESTAMP_DATETIME_ERROR and TIMESTAMP_FULL to TIMESTAMP_DATETIME
        Added KNOWN_DATE_TIME_FORMAT struct for Item_func_get_format
      sql/time.cc:
        Prepare str_to_TIME and str_to_time() for general date/time handling
        Removed THD from str_to... functions
        Renamed date/time/datetime functions to use 'date_time' instead of 'datetime'
        Added functions to make and copy DATE_TIME_FORMAT's
        Added trivial functions 'make_time()', 'make_date()' and 'make_datetime()'
      strings/Makefile.am:
        Added my_strtoll10()
      strings/ctype-bin.c:
        Cleared upper part of binary state map to be able to easily identify simple identifiers
      strings/my_vsnprintf.c:
        F
      bee5d9d4
  2. 26 Oct, 2003 1 commit
  3. 25 Oct, 2003 4 commits
  4. 24 Oct, 2003 8 commits
    • unknown's avatar
      sql_parse.cc: · 7f6d7aa1
      unknown authored
        URGENT: MONTY AND SERGEI should check this patch! The patch fixes the memory corruption reported by a user. It happened because the code did not keep correct a count of how many connections a user has, and the user object got freed too soon if the same user had more than 1 connection. Also fix a typo by Sanja: 'and' is not a C operator, I think it should be &&
      
      
      sql/sql_parse.cc:
        URGENT: MONTY AND SERGEI should check this patch! The patch fixes the memory corruption reported by a user. It happened because the code did not keep correct a count of how many connections a user has, and the user object got freed too soon if the same user had more than 1 connection. Also fix a typo by Sanja: 'and' is not a C operator, I think it should be &&
      7f6d7aa1
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1/ · d8d64231
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.1-bug
      
      
      sql/sql_parse.cc:
        Auto merged
      d8d64231
    • unknown's avatar
      removed one more hack that - as usual - almost always worked · ea47b72d
      unknown authored
      (but broke permission handling for *some* IP's after we started to compare in utf8)
      Bug #1636
      
      
      ea47b72d
    • unknown's avatar
      after merge fix · f38d7894
      unknown authored
      f38d7894
    • unknown's avatar
      made 'TODO' · 1ba35900
      unknown authored
      1ba35900
    • unknown's avatar
      Merge · 1f32eb5f
      unknown authored
      
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      1f32eb5f
    • unknown's avatar
      added comment · 4ed1b23c
      unknown authored
      4ed1b23c
    • unknown's avatar
      support 'parallel' updates and rallback of whole statement in case of error in... · ce2c46dd
      unknown authored
      support 'parallel' updates and rallback of whole statement in case of error in evalueting value which should be assigned
      (BUG#1484)
      
      
      mysql-test/r/variables.result:
        test of swaping variables
      mysql-test/t/variables.test:
        test of swaping variables
      sql/item_func.cc:
        new method of user variables to pre-fetch value
      sql/item_func.h:
        new method of user variables to pre-fetch value
      sql/set_var.cc:
        check() methods fetch & store value
      sql/set_var.h:
        check() methods fetch & store value
      ce2c46dd
  5. 23 Oct, 2003 6 commits
    • unknown's avatar
      added check of cardinality to IN/ALL/ANY subquery transformer · e5386bcb
      unknown authored
      (BUG#1638)
      
      
      mysql-test/r/subselect.result:
        test for BUG#1638
      mysql-test/t/subselect.test:
        test for BUG#1638
      sql/item_subselect.cc:
        always check cardinality first
      e5386bcb
    • unknown's avatar
      Merge · 5ee2807c
      unknown authored
      
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      5ee2807c
    • unknown's avatar
      Merge · fdc78a76
      unknown authored
      
      sql/mysql_priv.h:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      fdc78a76
    • unknown's avatar
      Merge · e94666f8
      unknown authored
      
      sql/item.cc:
        Auto merged
      mysql-test/r/subselect.result:
        SCCS merged
      mysql-test/t/subselect.test:
        SCCS merged
      e94666f8
    • unknown's avatar
      ufter review fix (BUG#1444) · d3d001fd
      unknown authored
      
      sql/item.cc:
        used variable to avoid using prev_unit->item which should be more clean
      sql/item_subselect.cc:
        uncachable tested on fix fields and correct bits set
      d3d001fd
    • unknown's avatar
      cd9b28f0
  6. 21 Oct, 2003 2 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 9a4aa997
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.1.clean
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      9a4aa997
    • unknown's avatar
      Fix for Windows bug reported throuhg Miguel · 8d94e500
      unknown authored
      
      libmysqld/lib_sql.cc:
        This code seems to be superfluous
      sql/derror.cc:
        in embedded server these functions should return the sign of the error
        instead of halting the program
      sql/init.cc:
        my_abort_hook left unchanged
      sql/mysql_priv.h:
        declaration of init_errmessage changed
        unireg_abort was replaced with DBUG_RETURN for embedded server
      sql/mysqld.cc:
        these functions don't work in embedded server thus #ifdef-ed
      8d94e500
  7. 20 Oct, 2003 6 commits
  8. 19 Oct, 2003 2 commits
    • unknown's avatar
      made more fine error message in scripts/fill_help_tables.sh · 2a98f294
      unknown authored
      
      scripts/fill_help_tables.sh:
        made more fine error message
      2a98f294
    • unknown's avatar
      correct table name assigned to temporary table field: · be4e254b
      unknown authored
       - correct table name shown in EXPLAIN Iindex reference)
       - pointer on freed memmory (reallocation of table name in reusing table entry) can't be used in EXPLAIN
      (BUG#1584)
      
      
      mysql-test/r/derived.result:
        test moved to derived table tests
        added test of BUG#1584
      mysql-test/r/subselect.result:
        test moved to derived table tests
      mysql-test/t/derived.test:
        test moved to derived table tests
        added test of BUG#1584
      mysql-test/t/subselect.test:
        test moved to derived table tests
      sql/item.cc:
        layout fix
      sql/sql_select.cc:
        correct table name assigned to temporary table field
      be4e254b
  9. 17 Oct, 2003 2 commits
    • unknown's avatar
      thr0loc.c, srv0start.c, srv0srv.c, srv0srv.h, os0thread.h: · 6713bb09
      unknown authored
        Reduce InnoDB memory allocation if buffer pool < 8 MB
      
      
      innobase/include/os0thread.h:
        Reduce InnoDB memory allocation if buffer pool < 8 MB
      innobase/include/srv0srv.h:
        Reduce InnoDB memory allocation if buffer pool < 8 MB
      innobase/srv/srv0srv.c:
        Reduce InnoDB memory allocation if buffer pool < 8 MB
      innobase/srv/srv0start.c:
        Reduce InnoDB memory allocation if buffer pool < 8 MB
      innobase/thr/thr0loc.c:
        Reduce InnoDB memory allocation if buffer pool < 8 MB
      6713bb09
    • unknown's avatar
      fixed deleting derived table tree after using (BUG#1536) · 6795b264
      unknown authored
      
      mysql-test/r/subselect.result:
        fixed drop table statement
        test for BUG#1536
      mysql-test/t/subselect.test:
        fixed drop table statement
        test for BUG#1536
      sql/sql_derived.cc:
        all tree of derived table should be deleted
      sql/sql_lex.cc:
        delete subtree method
      sql/sql_lex.h:
        delete subtree method
      6795b264
  10. 16 Oct, 2003 8 commits
    • unknown's avatar
      fixed support of used_tables() and const_item() in subqueries · e4b7aaac
      unknown authored
      (BUG#1444)
      
      
      mysql-test/r/subselect.result:
        BUG#1444 test
      mysql-test/t/subselect.test:
        BUG#1444 test
      sql/item.cc:
        storing used tables in Item_subselect
      sql/item_subselect.cc:
        fixed support of used_tables() and const_item() in subqueries
      sql/item_subselect.h:
        fixed support of used_tables() and const_item() in subqueries
      e4b7aaac
    • unknown's avatar
      - portability fix: fix compile bug on HP-UX (thanks to acurtis for the · d894f233
      unknown authored
         patch)
        (BUG#1440: Redundant class name confusing hpux compiler)
      
      
      d894f233
    • unknown's avatar
      fixed sqlstate for ER_WRONG_INDEX_NAME · 0d28ff84
      unknown authored
      removed unnesessary code from create.test
      
      
      include/sql_state.h:
        added sqlstate for ER_WRONG_INDEX_NAME
      mysql-test/r/create.result:
        changed sqlstate for ER_WRONG_INDEX_NAME
        remove unnesesary warning
      mysql-test/t/create.test:
        remove unnesessary drop table
      0d28ff84
    • unknown's avatar
      added checking for empty index name (fixed bug #1419) · ff50211d
      unknown authored
      
      include/mysqld_error.h:
        added error "Incorrect index name"
      mysql-test/r/create.result:
        added test for empty index name
      mysql-test/t/create.test:
        added test for empty index name
      sql/share/czech/errmsg.txt:
        added error "Incorrect index name"
      sql/share/danish/errmsg.txt:
        added error "Incorrect index name"
      sql/share/dutch/errmsg.txt:
        added error "Incorrect index name"
      sql/share/english/errmsg.txt:
        added error "Incorrect index name"
      sql/share/estonian/errmsg.txt:
        added error "Incorrect index name"
      sql/share/french/errmsg.txt:
        added error "Incorrect index name"
      sql/share/german/errmsg.txt:
        added error "Incorrect index name"
      sql/share/greek/errmsg.txt:
        added error "Incorrect index name"
      sql/share/hungarian/errmsg.txt:
        added error "Incorrect index name"
      sql/share/italian/errmsg.txt:
        added error "Incorrect index name"
      sql/share/japanese/errmsg.txt:
        added error "Incorrect index name"
      sql/share/korean/errmsg.txt:
        added error "Incorrect index name"
      sql/share/norwegian-ny/errmsg.txt:
        added error "Incorrect index name"
      sql/share/norwegian/errmsg.txt:
        added error "Incorrect index name"
      sql/share/polish/errmsg.txt:
        added error "Incorrect index name"
      sql/share/portuguese/errmsg.txt:
        added error "Incorrect index name"
      sql/share/romanian/errmsg.txt:
        added error "Incorrect index name"
      sql/share/russian/errmsg.txt:
        added error "Incorrect index name"
      sql/share/serbian/errmsg.txt:
        added error "Incorrect index name"
      sql/share/slovak/errmsg.txt:
        added error "Incorrect index name"
      sql/share/spanish/errmsg.txt:
        added error "Incorrect index name"
      sql/share/swedish/errmsg.txt:
        added error "Incorrect index name"
      sql/share/ukrainian/errmsg.txt:
        added error "Incorrect index name"
      sql/sql_table.cc:
        added checking for wrong index name
      ff50211d
    • unknown's avatar
      Fix test after merge · e83a7c2c
      unknown authored
      
      mysql-test/r/create.result:
        update test results
      e83a7c2c
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 9c9ff4cc
      unknown authored
      into mashka.mysql.fi:/home/my/mysql-4.1
      
      
      9c9ff4cc
    • unknown's avatar
      Update results after merge · a474f8c3
      unknown authored
      a474f8c3
    • unknown's avatar
      Merge · 48d49976
      unknown authored
      
      sql/set_var.cc:
        SCCS merged
      48d49976