1. 03 Feb, 2023 2 commits
  2. 30 Jan, 2023 1 commit
  3. 27 Jan, 2023 1 commit
  4. 25 Jan, 2023 2 commits
    • Daniel Black's avatar
      CREDITS: re-instate Tencent Cloud · 765291d6
      Daniel Black authored
      This was an accidential deletion looking at an outdated list.
      765291d6
    • Yuchen Pei's avatar
      MDEV-30370 Fixing spider hang when server aborts · 284810b3
      Yuchen Pei authored
      This is Kentoku's patch for MDEV-22979 (e6e41f04 + 22a00977),
      which fixes 30370.
      
      It changes the wait to a timed wait for the first sts thread, which
      waits on server start to execute the init queries for spider. It also
      flips the flag init_command to false when the sts thread is being
      freed. With these changes the sts thread can check the flag regularly
      and abort the init_queries when it finds out the init_command is
      false. This avoids the deadlock that causes the problem in MDEV-30370.
      
      It also fixes MDEV-22979 for 10.4, but not 10.5. I have not tested
      higher versions for MDEV-22979.
      
      A test has also been done on MDEV-29904 to avoid regression, given
      MDEV-27233 is a similar problem and its patch caused the
      regression. The test passes for 10.4-11.0.
      
      However, this adhoc test only works consistently when placed in the
      main testsuite. We should not place spider tests in the main suite, so
      we do not include it in this commit. A patch for MDEV-27912 should fix
      this problem and allow a proper test for MDEV-29904. See comments in
      the jira ticket MDEV-30370/29904 for the adhoc testcase used for this
      commit.
      284810b3
  5. 23 Jan, 2023 1 commit
  6. 20 Jan, 2023 14 commits
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      MDEV-26817 runtime error: index 24320 out of bounds for type... · 0c275599
      Sergei Golubchik authored
      MDEV-26817 runtime error: index 24320 out of bounds for type 'json_string_char_classes [128] *and* ASAN: global-buffer-overflow on address ... READ of size 4 on SELECT JSON_VALID
      
      protect from out-of-bound array access
      
      it was already done in all other places, this one was the only one missed
      0c275599
    • Sergei Golubchik's avatar
      MDEV-29199 Unique hash key is ignored upon INSERT ... SELECT into non-empty MyISAM table · fc292f42
      Sergei Golubchik authored
      disable bulk insert optimization if long uniques are used, because they
      need to read the table (index_read) after every inserted now. And bulk
      insert optimization might disable indexes.
      
      bulk insert is already disabled in other cases when there are chances
      that the table will be read duing the bulk insert.
      fc292f42
    • Sergei Golubchik's avatar
      MDEV-27631 Assertion `global_status_var.global_memory_used == 0' failed in mysqld_exit · db50919f
      Sergei Golubchik authored
      plugin_vars_free_values() was walking plugin sysvars and thus
      did not free memory of plugin PLUGIN_VAR_NOSYSVAR vars.
      
      * change it to walk all plugin vars
      * add the pluginname_ prefix to NOSYSVARS var names too,
        so that plugin_vars_free_values() would be able to find their
        bookmarks
      db50919f
    • Jan Lindström's avatar
    • Oleg Smirnov's avatar
      MDEV-29294 Assertion `functype() == ((Item_cond *) new_item)->functype()'... · b2b9d916
      Oleg Smirnov authored
      MDEV-29294 Assertion `functype() == ((Item_cond *) new_item)->functype()' failed in Item_cond::remove_eq_conds on SELECT
      
      Item_singlerow_subselect may be converted to Item_cond during
      optimization. So there is a possibility of constructing nested
      Item_cond_and or Item_cond_or which is not allowed (such
      conditions must be flattened).
      This commit checks if such kind of optimization has been applied
      and flattens the condition if needed
      b2b9d916
    • Alexander Barkov's avatar
      MDEV-27653 long uniques don't work with unicode collations · eea9f2a1
      Alexander Barkov authored
      There are no source code changes in this commit!
      This is an empty follow-up commit for
        284ac6f2
      to comment what was done, as the patch itself did not have
      change comments.
      
      Problems solved in this patch:
      
      1. The function calc_hash_for_unique() erroneously takes into account
      the string length, so equal strings (in terms of the collation)
      with different lengths got different hash value.
      
      For example:
      - LATIN LETTER A             - 1 byte
      - LATIN LETTER A WITH ACUTE  - 2 bytes
      
      are equal in utf8_general_ci, but as their lengths
      are different, calc_hash_for_unique() returned
      different hash values.
      
      2. calc_hash_for_unique() also erroneously used val_str()
      result to calculate hashes. This may not be correct for
      some data types, e.g. TIMESTAMP, as its string
      value depends on the session environment (e.g. @@time_zone).
      
      Change summary:
      
      Instead of doing Item::val_str(), we should always call
      Field::hash() of the underlying Field. It properly
      handles both cases (equal strings with different
      lengths, as well as tricky data types like TIMESTAMP).
      
      Detailed change description:
      
      Non-functional changes (make the code cleaner):
      
      - Adding a helper class Hasher, to pass hash parts
        nr1 and nr2 through function arguments easier.
      - Splitting virtual Field::hash() into non-virtual
        wrapper Field::hash() and virtual Field::hash_not_null().
        This helps to get rid of duplicate code handling SQL NULL,
        as it was equal in all Field_xxx implementations.
      - Adding a new method THD::my_ok_with_recreate_info().
      
      Actual fix changes (make new tables work properly):
      
      - Adding a virtual method Item::hash_not_null()
        This helps to handle hashes on full fields (Item_field)
        and hashes on prefix fields (Item_func_left(Item_field))
        in a polymorphic way.
        Implementing overrides for Item_field and Item_func_left.
      
      - Rewriting Item_func_hash::val_int() to use Item::hash_not_null(),
        instead of the combination of val_str() and alc_hash_for_unique().
      
      Backward compatibility changes (make old tables work in the new server):
      
      - Adding a new class Item_func_hash_mariadb_100403.
        Moving the old version of Item_func_hash::val_int()
        into Item_func_hash_mariadb_100403::val_int().
        The old class Item_func_hash_mariadb_100403 is still needed,
        to open old tables before upgrade is done.
      
      - Adding TABLE_SHARE::old_long_hash_function() and
        handler::check_long_hash_compatibility() to test
        if a table is using an old hash function.
      
      - Adding a helper method TABLE_SHARE::make_long_hash_func()
        to instantiate either Item_func_hash_mariadb_100403 (for old
        not upgraded tables) or Item_func_hash (for new tables).
      
      Upgrade changes (make old tables upgrade in the new server properly):
      
      Upgrading an old table to a new hash can be done using either
      of these two statements:
      
        ALTER IGNORE TABLE t1 FORCE;
        REPAIR TABLE t1;
      
      !!! These statements find and filter out erreneous duplicates!!!
      The table after these statements will have less records
      if there were erroneous duplicates (such and A and A WITH ACUTE).
      
      The information about filtered out records is reported in both statements.
      
      - Adding a new class Recreate_info to return out information
        about copied and duplucate rows from these functions:
        - mysql_alter_table()
        - mysql_recreate_table()
        - admin_recreate_table()
        This helps to print a warning during REPAIR:
      
      MariaDB [test]> repair table mdev27653_100422_text;
      +----------------------------+--------+----------+------------------------------------+
      | Table                      | Op     | Msg_type | Msg_text                           |
      +----------------------------+--------+----------+------------------------------------+
      | test.mdev27653_100422_text | repair | Warning  | Number of rows changed from 2 to 1 |
      | test.mdev27653_100422_text | repair | status   | OK                                 |
      +----------------------------+--------+----------+------------------------------------+
      2 rows in set (0.018 sec)
      eea9f2a1
    • Daniele Sciascia's avatar
      ae96e21c
    • Yuchen Pei's avatar
      MDEV-26541 Make UBSAN builds work with spider again. · 0253a2f4
      Yuchen Pei authored
      When built with ubsan and trying to load the spider plugin, the hidden
      visibility of mysqld compiling flag causes ha_spider.so to be missing
      the symbol ha_partition. This commit fixes that, as well as some
      memcpy null pointer issues when built with ubsan.
      Signed-off-by: default avatarYuchen Pei <yuchen.pei@mariadb.com>
      0253a2f4
    • Alexander Barkov's avatar
    • Oleg Smirnov's avatar
      MDEV-29294 Assertion `functype() == ((Item_cond *) new_item)->functype()'... · afb5deb9
      Oleg Smirnov authored
      MDEV-29294 Assertion `functype() == ((Item_cond *) new_item)->functype()' failed in Item_cond::remove_eq_conds on SELECT
      
      Item_singlerow_subselect may be converted to Item_cond during
      optimization. So there is a possibility of constructing nested
      Item_cond_and or Item_cond_or which is not allowed (such
      conditions must be flattened).
      This commit checks if such kind of optimization has been applied
      and flattens the condition if needed
      afb5deb9
    • Alexander Barkov's avatar
      MDEV-27653 long uniques don't work with unicode collations · c256998b
      Alexander Barkov authored
      There are no source code changes in this commit!
      This is an empty follow-up commit for
        284ac6f2
      to comment what was done, as the patch itself did not have
      change comments.
      
      Problems solved in this patch:
      
      1. The function calc_hash_for_unique() erroneously takes into account
      the string length, so equal strings (in terms of the collation)
      with different lengths got different hash value.
      
      For example:
      - LATIN LETTER A             - 1 byte
      - LATIN LETTER A WITH ACUTE  - 2 bytes
      
      are equal in utf8_general_ci, but as their lengths
      are different, calc_hash_for_unique() returned
      different hash values.
      
      2. calc_hash_for_unique() also erroneously used val_str()
      result to calculate hashes. This may not be correct for
      some data types, e.g. TIMESTAMP, as its string
      value depends on the session environment (e.g. @@time_zone).
      
      Change summary:
      
      Instead of doing Item::val_str(), we should always call
      Field::hash() of the underlying Field. It properly
      handles both cases (equal strings with different
      lengths, as well as tricky data types like TIMESTAMP).
      
      Detailed change description:
      
      Non-functional changes (make the code cleaner):
      
      - Adding a helper class Hasher, to pass hash parts
        nr1 and nr2 through function arguments easier.
      - Splitting virtual Field::hash() into non-virtual
        wrapper Field::hash() and virtual Field::hash_not_null().
        This helps to get rid of duplicate code handling SQL NULL,
        as it was equal in all Field_xxx implementations.
      - Adding a new method THD::my_ok_with_recreate_info().
      
      Actual fix changes (make new tables work properly):
      
      - Adding a virtual method Item::hash_not_null()
        This helps to handle hashes on full fields (Item_field)
        and hashes on prefix fields (Item_func_left(Item_field))
        in a polymorphic way.
        Implementing overrides for Item_field and Item_func_left.
      
      - Rewriting Item_func_hash::val_int() to use Item::hash_not_null(),
        instead of the combination of val_str() and alc_hash_for_unique().
      
      Backward compatibility changes (make old tables work in the new server):
      
      - Adding a new class Item_func_hash_mariadb_100403.
        Moving the old version of Item_func_hash::val_int()
        into Item_func_hash_mariadb_100403::val_int().
        The old class Item_func_hash_mariadb_100403 is still needed,
        to open old tables before upgrade is done.
      
      - Adding TABLE_SHARE::old_long_hash_function() and
        handler::check_long_hash_compatibility() to test
        if a table is using an old hash function.
      
      - Adding a helper method TABLE_SHARE::make_long_hash_func()
        to instantiate either Item_func_hash_mariadb_100403 (for old
        not upgraded tables) or Item_func_hash (for new tables).
      
      Upgrade changes (make old tables upgrade in the new server properly):
      
      Upgrading an old table to a new hash can be done using either
      of these two statements:
      
        ALTER IGNORE TABLE t1 FORCE;
        REPAIR TABLE t1;
      
      !!! These statements find and filter out erreneous duplicates!!!
      The table after these statements will have less records
      if there were erroneous duplicates (such and A and A WITH ACUTE).
      
      The information about filtered out records is reported in both statements.
      
      - Adding a new class Recreate_info to return out information
        about copied and duplucate rows from these functions:
        - mysql_alter_table()
        - mysql_recreate_table()
        - admin_recreate_table()
        This helps to print a warning during REPAIR:
      
      MariaDB [test]> repair table mdev27653_100422_text;
      +----------------------------+--------+----------+------------------------------------+
      | Table                      | Op     | Msg_type | Msg_text                           |
      +----------------------------+--------+----------+------------------------------------+
      | test.mdev27653_100422_text | repair | Warning  | Number of rows changed from 2 to 1 |
      | test.mdev27653_100422_text | repair | status   | OK                                 |
      +----------------------------+--------+----------+------------------------------------+
      2 rows in set (0.018 sec)
      c256998b
    • Daniele Sciascia's avatar
      c4f5128d
    • Yuchen Pei's avatar
      MDEV-26541 Make UBSAN builds work with spider again. · a68b9dd9
      Yuchen Pei authored
      When built with ubsan and trying to load the spider plugin, the hidden
      visibility of mysqld compiling flag causes ha_spider.so to be missing
      the symbol ha_partition. This commit fixes that, as well as some
      memcpy null pointer issues when built with ubsan.
      Signed-off-by: default avatarYuchen Pei <yuchen.pei@mariadb.com>
      a68b9dd9
  7. 19 Jan, 2023 2 commits
  8. 17 Jan, 2023 3 commits
    • Oleksandr Byelkin's avatar
      v5.5.4-stable · 9924466b
      Oleksandr Byelkin authored
      9924466b
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 2b3423c4
      Marko Mäkelä authored
      2b3423c4
    • Marko Mäkelä's avatar
      MDEV-30422 Merge new release of InnoDB 5.7.41 to 10.3 · 489b5569
      Marko Mäkelä authored
      MySQL 5.7.41 includes one InnoDB change
      mysql/mysql-server@d2d6b2dd00f709bc528386009150d4bc726e25a0
      that seems to be applicable to MariaDB Server 10.3 and 10.4.
      Even though commit 5b9ee8d8
      seems to have fixed sporadic failures on our CI systems, it is
      theoretically possible that another race condition remained.
      
      buf_flush_page_cleaner_coordinator(): In the final loop,
      wait also for buf_get_n_pending_read_ios() to reach 0.
      In this way, if a secondary index leaf page was read into the
      buffer pool and ibuf_merge_or_delete_for_page() modified that
      page or some change buffer pages, the flush loop would execute
      until the buffer pool really is in a clean state.
      
      This potential data corruption bug does not affect MariaDB Server 10.5
      or later, thanks to commit b42294bc
      which removed change buffer merges that are not explicitly requested.
      489b5569
  9. 16 Jan, 2023 1 commit
  10. 15 Jan, 2023 1 commit
  11. 14 Jan, 2023 1 commit
  12. 13 Jan, 2023 5 commits
    • sjaakola's avatar
      10.4-MDEV-29684 Fixes for cluster wide write conflict resolving · 0ff7f33c
      sjaakola authored
      The rather recent thd_need_ordering_with() function does not take
      high priority transactions' order in consideration. Chaged this
      funtion to compare also transaction seqnos and favor earlier transaction.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      0ff7f33c
    • sjaakola's avatar
      MDEV-29512 deadlock between commit monitor and THD::LOCK_thd_data mutex · 68cfcf9c
      sjaakola authored
      This commit contains only a mtr test for reproducing the issue in MDEV-29512
      The actual fix will be pushed in wsrep-lib repository
      
      The hanging in MDEV-29512 happens when binlog purging is attempted, and there is
      one local BF aborted transaction waiting for commit monitor.
      
      The test will launch two node cluster and enable binlogging with expire log days,
      to force binlog purging to happen.
      A local transaction is executed so that will become BF abort victim, and has advanced
      to replication stage waiting for commit monitor for final cleanup (to mark position in innodb)
      after that, applier is released to complete the BF abort and due to binlog configuration,
      starting the binlog purging. This is where the hanging would occur, if code is buggy
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      68cfcf9c
    • sjaakola's avatar
      MDEV-30317 Transaction savepoint may cause failure in galera replaying · cd97523d
      sjaakola authored
      Created mtr test for reproducing the crash
      
      Developed actual fix for the issue.
      Setting THD::system_thread_info.rpl_sql_info for replayer thread,
      same way as it is handled for appliers.
      
      Recorded test result, with the fix
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      cd97523d
    • sjaakola's avatar
      MDEV-29684 Fixes for cluster wide write conflict resolving · 66c05326
      sjaakola authored
      Cluster conflict victim's THD is marked with wsrep_aborter.
      THD::wsrep_aorter holds the thread ID of the hight priority tread,
      which is currently carrying out BF aborting for this victim.
      
      However, the BF abort operation is not always successful,
      and in such case the wsrep_aborter mark should be removed.
      In the old code, this wsrep_aborter resetting did not happen,
      and this could lead to a situation where the sticky wsrep_aborter
      mark prevents any further attempt to BF abort this transaction.
      
      This commit fixes this issue, and resets wsrep_aborter after
      unsuccesful BF abort attempt.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      66c05326
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 71e8e493
      Marko Mäkelä authored
      71e8e493
  13. 12 Jan, 2023 5 commits
  14. 11 Jan, 2023 1 commit