- 23 Aug, 2021 8 commits
-
-
Marko Mäkelä authored
trx_purge_rseg_get_next_history_log(): Fix a race condition that was introduced in commit e46f76c9 (MDEV-15912). The buffer pool page contents must not be accessed while not holding a page latch. The page latch was released by mtr_t::commit(). This race resulted in an ASAN heap-use-after-poison during a stress test.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Eugene Kosov authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
To avoid potential race conditions between concurrent access to dict_table_t::freed_indexes, let us consistently use dict_table_t::autoinc_mutex. dict_table_remove_from_cache_low(): To avoid extensive hold time of table->autoinc_mutex, unconditionally free the FTS data structures.
-
Marko Mäkelä authored
ha_innobase::check_if_supported_inplace_alter(): Do not invoke innobase_table_is_empty() if the tablespace has been discarded. That is, native ALTER TABLE in InnoDB will treat an empty table in the same way as a tablespace whose tablespace has been discarded. (Note: ALTER TABLE...ALGORITHM=COPY will fail if the tablespace has been discarded.) This fixes a crash that was introduced in commit c7559747 (MDEV-19611).
-
Marko Mäkelä authored
TABLE_LIST::calc_md5(): Remove an untruthful const qualifier. thd_get_query_start_data(): Pass empty_clex_str instead of an uninitialized LEX_CSTRING.
-
- 21 Aug, 2021 1 commit
-
-
Thirunarayanan Balathandayuthapani authored
Problem: ======= The last AHI page for two indexes of an dropped table is being freed at the same time by two threads. One thread frees the table heap and other thread tries to access table heap again. It leads to asan failure in btr_search_lazy_free(). Solution: ======== InnoDB uses autoinc_mutex to avoid the race condition in btr_search_lazy_free()
-
- 20 Aug, 2021 2 commits
-
-
Faustin Lammler authored
The "$mysql_statedir/debian-$MAJOR_VER.flag" is not used by any maintainer script ("$mysql_datadir/debian-$MAJOR_VER.flag" is used, https://github.com/MariaDB/server/blob/10.6/debian/mariadb-server-10.6.postinst#L164). See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985870 Fix also some minor typo.
-
Marko Mäkelä authored
Designated initializers were introduced in ISO/IEC 9899:1999 (C99), but the C code base of MariaDB is supposed to be compatible with the 1990 version of the standard. The InnoDB code based was switched from C to C++ in MySQL 5.6 and MariaDB 10.0. C++ did not introduce syntax for designated initializers until ISO/IEC 14882:2020. Our C++ code base is still stuck with the 2011 or earlier version of that standard. Therefore, this check as well as the macro STRUCT_FLD are best removed.
-
- 19 Aug, 2021 1 commit
-
-
danielnachun authored
-
- 18 Aug, 2021 8 commits
-
-
Marko Mäkelä authored
-
Marko Mäkelä authored
PageConverter::update_index_page(): Always validate the PAGE_INDEX_ID. Failure to do so could cause a crash when iterating secondary index pages. This was caught by the 10.4 test innodb.full_crc32_import.
-
Marko Mäkelä authored
-
Aleksey Midenkov authored
Delete-marked record is on the secondary index and the clustered index already purged the corresponding record. We cannot detect if such record is historical and we should not: the algorithm of row_ins_check_foreign_constraint() skips such record anyway.
-
Aleksey Midenkov authored
Do swap_blobs() for new partition_read_multi_range mode.
-
Daniel Black authored
Due to an integer overflow an invalid size of ref_pointer_array could be allocated. Using size_t allows this continue. Allocation failures are handled gracefully if the value is too big. Thanks to Zuming Jiang for the bug report and fuzzing MariaDB. Reviewer: Sanja
-
Marko Mäkelä authored
MDEV-18734 FIXME: vcol.partition triggers ASAN heap-use-after-free
-
Marko Mäkelä authored
-
- 17 Aug, 2021 2 commits
-
-
Eugene Kosov authored
Main idea: don't log-and-crash but propogate error to the upper layers of stack to handle it and show to a user.
-
Vlad Lesin authored
If lock type is LOCK_GAP or LOCK_ORDINARY, and the transaction holds implicit lock for the record, then explicit gap-lock will not be set for the record, as lock_rec_convert_impl_to_expl() returns true and lock_rec_convert_impl_to_expl() bypasses lock_rec_lock() call. The fix converts explicit lock to implicit one if requested lock type is not LOCK_REC_NOT_GAP. innodb_information_schema test result is also changed as after the fix the following statements execution: SET autocommit=0; INSERT INTO t1 VALUES (5,10); SELECT * FROM t1 FOR UPDATE; leads to additional gap lock requests.
-
- 16 Aug, 2021 3 commits
-
-
Thirunarayanan Balathandayuthapani authored
Import operation without .cfg file fails when there is mismatch of index between metadata table and .ibd file. Moreover, MDEV-19022 shows that InnoDB can end up with index tree where non-leaf page has only one child page. So it is unsafe to find the secondary index root page. This patch does the following when importing the table without .cfg file: 1) If the metadata contains more than one index then InnoDB stops the import operation and report the user to drop all secondary indexes before doing import operation. 2) When the metadata contain only clustered index then InnoDB finds the index id by reading page 0 & page 3 instead of traversing the whole tablespace.
-
Marko Mäkelä authored
pars_info_bind_id(): Remove the parameter copy_name. It was always being passed as constant TRUE or true. It turns out that copying the string is completely unnecessary. In all calls except the one in fts_get_select_columns_str() and fts_doc_fetch_by_doc_id(), the parameter is being passed as a compile-time constant, and therefore the pointer cannot become stale. In that special call, the string that is being passed is allocated from the same memory heap that pars_info_bind_id() would have been using. pars_info_add_id(): Remove (unused declaration).
-
Julius Goryavsky authored
This commit fixes a call to the sockstat utility for FreeBSD, where this utility requires an extra "-s" parameter to display the connection status and prints one extra column.
-
- 15 Aug, 2021 2 commits
-
-
Julius Goryavsky authored
This commit fixes a mistake where the --whole-file option is used by rsync SST in WAN mode instead of LAN.
-
Julius Goryavsky authored
This commit adds support for reading new SSL configuration options (ssl-ca, ssl-cert and ssl-key) if the [sst] section with old options (tca, tcert and tkey) is missing in the config file, even if not specified authentication mode via the ssl-mode option. Before this change, new parameters were read only if the ssl-mode option was present in the configuration file and it was not equal to the 'DISABLED' value. Also added diagnostics (information level) which warns the user that due to the presence of the tca, tcert and/or tkey parameters in the [sst] section, new SSL configuration options will be ignored (if their values do not match the old ones).
-
- 14 Aug, 2021 1 commit
-
-
Daniel Black authored
Observed in 10.4 however same code in 10.2 mariadb-server-10.4/tests/mysql_client_test.c:18209:5: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 18209 | if (!opt_silent) | ^~ In file included from mariadb-server-10.4/tests/mysql_client_test.c:38: mariadb-server-10.4/tests/mysql_client_fw.c:133:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ 133 | ((void) ((expr) ? 0 : (die(__FILE__, __LINE__, #expr), 0))) | ^ mariadb-server-10.4/tests/mysql_client_test.c:18212:7: note: in expansion of macro ‘DIE_UNLESS’ 18212 | DIE_UNLESS(tm[i].year == 0); | ^~~~~~~~~~ $ /usr/bin/cc --version cc (GCC) 11.2.1 20210728 (Red Hat 11.2.1-1)
-
- 09 Aug, 2021 1 commit
-
-
Vladislav Vaintroub authored
CMake Warning (dev) at cmake/plugin.cmake:288 (GET_TARGET_PROPERTY): Policy CMP0045 is not set: Error on non-existent target... Also, fix condition argument in ADD_FEATURE_INFO. It is not a string but boolean
-
- 05 Aug, 2021 4 commits
-
-
Aleksey Midenkov authored
ha_partition stores records in array of m_ordered_rec_buffer and uses it for prio queue in ordered index scan. When the records are restored from the array the blob buffers may be already freed or rewritten. The solution is to take temporary ownership of cached blob buffers via String::swap(). When the record is restored from m_ordered_rec_buffer the ownership is returned to table fields. Cleanups: init_record_priority_queue(): removed needless !m_ordered_rec_buffer check as there is same assertion few lines before. dbug_print_row() for arbitrary row pointer
-
Daniel Bartholomew authored
-
Daniel Bartholomew authored
-
Yongxin Xu authored
JSON_REPLACE() function executed with an error on Spider SE. This patch fixes the problem, and it also fixes the MDEV-24541. The problem is that Item_func_json_insert::func_name() returns the wrong function name "json_update". The Spider SE reconstructs a query based on the return value in some cases. Thus, if the return value is wrong, the Spider SE may generate a wrong query.
-
- 03 Aug, 2021 1 commit
-
-
Sergei Golubchik authored
1. rename option DEPENDENCIES in MYSQL_ADD_PLUGIN() to DEPENDS to be consistent with other cmake commands and macros 2. use this DEPENDS option in plugins 3. add dependencies to the plugin embedded target too 4. plugins don't need to add GenError dependency explicitly, all plugins depend on it automatically
-
- 02 Aug, 2021 3 commits
-
-
Oleksandr Byelkin authored
-
Nikita Malyavin authored
Server crashes in Field::register_field_in_read_map upon select from partitioned table with indexed by prefix virtual column. After several read-mark fixes a problem has surfaced: Since KEY (c(10),a) uses only a prefix of c, a new field is created, duplicated from table->field[3], with a new length. However, vcol_inco->expr is not copied. Therefore, (*key_info)->key_part[i].field->vcol_info->expr was left NULL in ha_partition::index_init(). Solution: copy vcol_info from table field when it's set up.
-
Oleksandr Byelkin authored
This reverts commit 9b8e207c.
-
- 31 Jul, 2021 1 commit
-
-
Sergei Golubchik authored
fix main.processlist_notembedded test * before EXPLAINing `select sleep` wait for select to start (fixes "Target is not running an EXPLAINable command") * after killing sleep, wait for it to die (fixes test failures on --repeat when old sleep shows on a test rerun) * unify with 10.3, copy minor changes from there (`--echo End of 5.5` vs `--echo # End of 5.5`, etc)
-
- 29 Jul, 2021 2 commits
-
-
Oleksandr Byelkin authored
-
Oleksandr Byelkin authored
-