1. 19 Feb, 2008 3 commits
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/inno/feb18/51 · c0f0a2f9
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/51
      
      c0f0a2f9
    • unknown's avatar
      fixes for build failures due to my yesterday's changeset forbidding · 001320a4
      unknown authored
      bool in C.
      
      
      client/get_password.c:
        fix for build failure
      include/thr_alarm.h:
        fix for build failure
      libmysql/dll.c:
        fix for build failure
      libmysql/get_password.c:
        fix for build failure
      mysys/thr_alarm.c:
        fix for build failure
      001320a4
    • unknown's avatar
      Applied InnoDB snapshot innodb-5.1-ss2298 · 3858e96a
      unknown authored
      Fixes the following bugs:
      
      - Bug #33349: possible race condition revolving around data dictionary and repartitioning
        Introduce retry/sleep logic as a workaround for a transient bug
        where ::open fails for partitioned tables randomly if we are using
        one file per table.
      
      - Bug #34053: normal users can enable innodb_monitor logging
        In CREATE TABLE and DROP TABLE check whether the table in question is one
        of the magic innodb_monitor tables and whether the user has enough rights
        to mess with it before doing anything else.
      
      - Bug #22868: 'Thread thrashing' with > 50 concurrent conns under an upd-intensive workloadw
      - Bug #29560: InnoDB >= 5.0.30 hangs on adaptive hash rw-lock 'waiting for an X-lock'
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
      
      - Bug #30930: Add auxiliary function to retrieve THD::thread_id
        Add thd_get_thread_id() function.  Also make check_global_access() function
        visible to InnoDB under INNODB_COMPATIBILITY_HOOKS #define.
      
      
      include/mysql/plugin.h:
        Add thd_get_thread_id() accessor function
      mysql-test/r/innodb.result:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2261:
        branches/5.1: Merge a change from MySQL AB:
        
        ChangeSet@2007-10-13 15:49:42+03:00, aelkin@koti.dsl.inet.fi
        
        Bug #29136 erred multi-delete on trans table does not rollback the statement
        
        innodb.test, innodb.result: trans table specific test added
      mysql-test/t/innodb.test:
        Applied InnoDB snapshot innodb-5.1-ss2298
      sql/mysql_priv.h:
        Make check_global_access() declaration available if when
        INNODB_COMPATIBILITY_HOOKS is defined.
      sql/sql_class.cc:
        Add thd_get_thread_id() accessor function.
        
        Add 'extern "C"' to definition for thd_get_xid().  Not strictly
        needed, but in keeping with our coding style.
      storage/innobase/btr/btr0cur.c:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2295:
        branches/5.1:
        
        Merge r2294 from branches/5.0:
        
        Fix typo and add comma in comment.
      storage/innobase/handler/ha_innodb.cc:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        - But remove the declaration of check_global_access() from ha_innodb.cc,
          because it is now visible in mysql_priv.h under INNODB_COMPATIBILITY_HOOKS
        
        Revision r2270:
        branches/5.1:
        
        Rename the user visible parameter innodb-use-adaptive-hash-indexes to
        innodb-adaptive-hash-index so that it is in sync with MySQL 5.0.
        
        Suggested by:	Heikki
        Approved by:	Heikki
        
        
        Revision r2236:
        branches/5.1: bug#33349
        
        Introduce retry/sleep logic as a workaround for a transient bug
        where ::open fails for partitioned tables randomly if we are using
        one file per table.
        
        
        Reviewed by: Heikki
        
        
        Revision r2282:
        branches/5.1:
        
        Fix Bug#34053:
        * In CREATE TABLE and DROP TABLE check whether the table in question is one
          of the magic innodb_monitor tables and whether the user has enough rights
          to mess with it before doing anything else.
        * Implement a mysql-test testcase.
        
        Approved by:	Heikki
        
        
        Revision r2246:
        branches/5.1:
        
        Fix formatting of the autoinc-lock-mode command line parameter.
        
        Old view (./mysqld --help --verbose):
        
          --innodb-autoinc-lock-mode=#
                              The AUTOINC lock modes supported by InnoDB:
          0 => Old
                              style AUTOINC locking (for backward compatibility)
          1 =>
                              New style AUTOINC locking
          2 => No AUTOINC locking
                              (unsafe for SBR)
        
        New view:
        
          --innodb-autoinc-lock-mode=#
                              The AUTOINC lock modes supported by InnoDB:
                              0 => Old style AUTOINC locking (for backward
                              compatibility)
                              1 => New style AUTOINC locking
                              2 => No AUTOINC locking (unsafe for SBR)
        
        Looks like these strings are "automatically" wrapped by MySQL in the
        following way:
        * newlines (\n) in the string are ignored
        * newline separator (\n) is inserted every 57 or so characters.
        * lots of white space is appended to each inserted new line.
        
        Approved by:	Heikki
      storage/innobase/include/os0sync.h:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/include/read0read.h:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2188:
        branches/5.1: Remove unused field can_be_too_old from read_view_struct.
      storage/innobase/include/row0mysql.h:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2282:
        branches/5.1:
        
        Fix Bug#34053:
        * In CREATE TABLE and DROP TABLE check whether the table in question is one
          of the magic innodb_monitor tables and whether the user has enough rights
          to mess with it before doing anything else.
        * Implement a mysql-test testcase.
        
        Approved by:	Heikki
        
        
        Revision r2272:
        branches/5.1:
        
        Fix typo in comment.
      storage/innobase/include/sync0arr.h:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/include/sync0rw.h:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/include/sync0rw.ic:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/include/sync0sync.h:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/include/sync0sync.ic:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/os/os0sync.c:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/read/read0read.c:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2188:
        branches/5.1: Remove unused field can_be_too_old from read_view_struct.
      storage/innobase/row/row0mysql.c:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2282:
        branches/5.1:
        
        Fix Bug#34053:
        * In CREATE TABLE and DROP TABLE check whether the table in question is one
          of the magic innodb_monitor tables and whether the user has enough rights
          to mess with it before doing anything else.
        * Implement a mysql-test testcase.
        
        Approved by:	Heikki
        
        
        Revision r2272:
        branches/5.1:
        
        Fix typo in comment.
      storage/innobase/srv/srv0srv.c:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/sync/sync0arr.c:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/sync/sync0rw.c:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      storage/innobase/sync/sync0sync.c:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2268:
        branches/5.1: Port of r2267
        
        This is a combination of changes that forward port the scalability fix applied to 5.0
        through r1001.
        It reverts changes r149 and r122 (these were 5.1 specific changes made in lieu of
        scalability fix of 5.0)
        Then it applies r1001 to 5.0 which is the original scalability fix.
        Finally it applies r2082 which fixes an issue with the original fix.
        
        Reviewed by: Heikki
      mysql-test/r/innodb_bug34053.result:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2282:
        branches/5.1:
        
        Fix Bug#34053:
        * In CREATE TABLE and DROP TABLE check whether the table in question is one
          of the magic innodb_monitor tables and whether the user has enough rights
          to mess with it before doing anything else.
        * Implement a mysql-test testcase.
        
        Approved by:	Heikki
      mysql-test/t/innodb_bug34053.test:
        Applied InnoDB snapshot innodb-5.1-ss2298
        
        Revision r2282:
        branches/5.1:
        
        Fix Bug#34053:
        * In CREATE TABLE and DROP TABLE check whether the table in question is one
          of the magic innodb_monitor tables and whether the user has enough rights
          to mess with it before doing anything else.
        * Implement a mysql-test testcase.
        
        Approved by:	Heikki
      3858e96a
  2. 18 Feb, 2008 9 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.1-build · a94d5d53
      unknown authored
      into  gbichot4.local:/home/mysql_src/mysql-5.1-build-gca
      
      
      client/mysqltest.c:
        Auto merged
      include/my_sys.h:
        Auto merged
      mysys/thr_lock.c:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_plugin.cc:
        Auto merged
      a94d5d53
    • unknown's avatar
      Fix for server bug experienced in Maria (wrong "Truncated incorrect <var_name> · e2103aaf
      unknown authored
      value" error even though the value was correct): a C function in my_getopt.c
      was taking bool* in parameter and was called from C++ sql_plugin.cc,
      but on some Mac OS X sizeof(bool) is 1 in C and 4 in C++, giving funny
      mismatches. Fixed, all other occurences of bool in C are removed, future
      ones are blocked by a "C-bool-catcher" in my_global.h (use my_bool).
      
      
      client/mysqldump.c:
        my_bool for C
      client/mysqltest.c:
        my_bool for C
      extra/replace.c:
        my_bool for C
      include/my_getopt.h:
        my_bool for C
      include/my_global.h:
        Prevent people from using bool in C, it causes real bugs.
      include/my_sys.h:
        my_bool for C
      include/my_time.h:
        my_bool for C
      include/thr_lock.h:
        my_bool for C
      libmysql/libmysql.c:
        my_bool for C
      mysys/charset.c:
        my_bool for C
      mysys/my_getopt.c:
        my_bool for C
      mysys/queues.c:
        my_bool for C
      mysys/thr_lock.c:
        my_bool for C
      regex/reginit.c:
        my_bool for C
      sql/set_var.cc:
        C functions use my_bool so we must use my_bool too.
      sql/sql_plugin.cc:
        C functions use my_bool so we must use my_bool too.
        This fixes a real observed bug of Maria, because on some Mac OS X,
        sizeof(bool) is 1 in C and 4 in C++, so the bool* does wrong.
        Removing useless line.
      storage/heap/hp_update.c:
        my_bool for C
      storage/myisam/mi_check.c:
        my_bool for C
      storage/myisam/mi_dynrec.c:
        my_bool for C
      storage/myisam/mi_search.c:
        my_bool for C
      storage/myisam/mi_update.c:
        my_bool for C
      storage/myisam/mi_write.c:
        my_bool for C
      storage/myisam/myisamdef.h:
        my_bool for C
      storage/myisam/myisamlog.c:
        my_bool for C
      storage/myisam/myisampack.c:
        my_bool for C
      tests/mysql_client_test.c:
        my_bool for C
      unittest/mysys/bitmap-t.c:
        my_bool for C
      vio/viosslfactories.c:
        my_bool for C
      e2103aaf
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 9c09c049
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/51
      
      9c09c049
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/build/50 · 9cf3730f
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/51
      
      
      scripts/mysql_config.sh:
        Auto merged
      support-files/mysql.spec.sh:
        Manual merge
      9cf3730f
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/50-b28555 · 82e9eb76
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/50
      
      82e9eb76
    • unknown's avatar
      Merge ramayana.hindu.god:/home/tsmith/m/bk/b21158/50 · 1c9a285e
      unknown authored
      into  ramayana.hindu.god:/home/tsmith/m/bk/build/50
      
      1c9a285e
    • unknown's avatar
      Bug #28555 Upgrading MySQL Fails to shut down old server and kills socket file · 1b642127
      unknown authored
      Check for an existing MySQL server package from a different vendor or
      major MySQL version.  In such a case, refuse to install the server and
      recommend how to safely remove the old packages before installing the
      new ones.
      
      
      support-files/mysql.spec.sh:
        Add to the %pre server scriptlet checks to ensure that we're not
        upgrading from another vendor's package, or that this is not a
        major version upgrade.  If an automatic upgrade isn't safe, print
        basic instructions on how to do a manual upgrade, and bail out.
      1b642127
    • unknown's avatar
      Merge mysql.com:/home/kent/bk/maria/mysql-maria-gca · 6702a87b
      unknown authored
      into  mysql.com:/home/kent/bk/build/mysql-5.1-build
      
      6702a87b
    • unknown's avatar
      CMakeLists.txt: · 20d2ce58
      unknown authored
        Missing "sql_profile.cc" was added
      
      
      libmysqld/CMakeLists.txt:
        Missing "sql_profile.cc" was added
      20d2ce58
  3. 14 Feb, 2008 3 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-build · 9a4d72a0
      unknown authored
      into  pcrews-mac-local.local:/Users/pcrews/usr/local/bin/data0/34468/mysql-5.1-build-34468
      
      9a4d72a0
    • unknown's avatar
      Bug#34468 - csv_not_null fails · 40c0a1c5
      unknown authored
      Altered test to expect error on UPDATE SET <not_null_col> = NULL instead
      of expecting warning and re-recorded .result file.
      
      
      mysql-test/r/csv_not_null.result:
        Bug#34468 - csv_not_null fails
        Altered test to expect error on UPDATE SET <not_null_col> = NULL instead
        of expecting warning and re-recorded .result file.  New results file passes
      mysql-test/t/csv_not_null.test:
        Bug#34468 - csv_not_null fails
        Altered test to expect error on UPDATE SET <not_null_col> = NULL instead
        of expecting warning and re-recorded .result file.  Also cleaned up comments
      40c0a1c5
    • unknown's avatar
      Bug #21158 mysql_config doesn't include -lmygcc · 0cbe3b6a
      unknown authored
      Add -lmygcc to mysql_config output for libs, libs_r, and embedded_libs.
      
      Required when linking against our static libs, if yassl is used, and gcc
      used to build library is significantly different from that which is using
      the library.
      
      
      scripts/mysql_config.sh:
        Add -lmygcc to --libs, --libs_r, and --embedded-libs output, if libmygcc.a
        is found in the pkglibdir.
        
        This works around a problem when linking against the static client
        libs which were built with a different GCC than the current compiler.
        In this case, without -lmygcc, several builtin functions (e.g.,
        __pure_virtual, __builtin_delete) are left undefined.  Currently it
        is yassl which pulls in these symbols.
        
        This isn't a problem when linking against shared libraries, or when
        using the same compiler version.
        
        Currently it shows up with libs built on build.mysql.com with gcc 2.95.3,
        when using them on more recent systems.
        
        
        Also strip the -mcpu, -mtune, and -march cflags.  The calling package can
        determine what optimization parameters to choose.
      0cbe3b6a
  4. 13 Feb, 2008 9 commits
  5. 12 Feb, 2008 1 commit
    • unknown's avatar
      ha_ndbcluster.m4: · a7babafb
      unknown authored
        If the third number in version is followed by a letter, include it
        in NDB_VERSION_STATUS, but not in numeric NDB_VERSION_BUILD
      
      
      config/ac-macros/ha_ndbcluster.m4:
        If the third number in version is followed by a letter, include it
        in NDB_VERSION_STATUS, but not in numeric NDB_VERSION_BUILD
      a7babafb
  6. 11 Feb, 2008 4 commits
    • unknown's avatar
      Make this build on Windows. · 6cc89659
      unknown authored
      
      extra/resolveip.c:
        Regrettably, Windows does not have inet_aton. We still don't want to use inet_addr on all platforms, because it is inaccurate and deprecated on many.
      6cc89659
    • unknown's avatar
      Disable sporadically failing test cases (Bug#34454). · c36f69b9
      unknown authored
      
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Disable sporadically failing test cases.
      c36f69b9
    • unknown's avatar
      Disabling declaration of debug variable for non-debug builds. · 189961c5
      unknown authored
      (originally from Mats)
      
      
      sql/slave.cc:
        Disabling declaration in non-debug builds.
      189961c5
    • unknown's avatar
      Patch to eliminate some valgrind warnings in debug printout code. · a1f1d260
      unknown authored
      (originally from Mats)
      
      
      sql/rpl_rli.cc:
        Adding variable to mark an instance of Relay_log_info as fake.
      sql/rpl_rli.h:
        Adding variable to mark an instance of Relay_log_info as fake.
      sql/slave.cc:
        Not printing debug information if we are working with a fake
        instance of Relay_log_info. This because the result of calling
        update is nonsense, and trying to print it generates valgrind
        warnings.
      sql/sql_binlog.cc:
        Marking newly created instance of Relay_log_info as a fake instance.
      a1f1d260
  7. 09 Feb, 2008 3 commits
  8. 08 Feb, 2008 8 commits