1. 28 Apr, 2007 2 commits
    • unknown's avatar
      Merge polly.local:/home/kaa/src/maint/bug24912/my50-bug24912 · c3b410f1
      unknown authored
      into  polly.local:/home/kaa/src/maint/bug24912/my51-bug24912
      
      
      mysql-test/r/type_newdecimal.result:
        Auto merged
      mysql-test/t/func_math.test:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      mysql-test/r/func_math.result:
        Manual merge.
      sql/item_strfunc.cc:
        Manual merge.
      c3b410f1
    • unknown's avatar
      Fix for bug #24912 "problems with bigint in abs() ceiling() round() truncate()... · 67a74165
      unknown authored
      Fix for bug #24912 "problems with bigint in abs() ceiling() round() truncate() mod()" and a number of related problems:
      
      - unsigned flag was not handled correctly for a number of mathematical funcions, which led to incorrect results
      - passing large values as the number of decimals to ROUND() resulted in incorrect results and even server crashes in some cases
      - reverted the fix and the testcase for bug #10083 as it violates the manual
      - fixed some testcases which relied on broken ROUND() behavior
      
      
      mysql-test/r/func_math.result:
        - Removed the testcase for bug #10083 (not a bug according to the manual)
        - Changed the testcase for bug #9837 to expect a correct ROUND() behavior
        - Added testcases for bug #24912 and all related bugs found
      mysql-test/r/type_newdecimal.result:
        Fixed a truncate() testcase which relied on broken behavior
      mysql-test/t/func_math.test:
        - Removed the testcase for bug #10083 (not a bug according to the manual)
        - Changed the testcase for bug #9837 to expect a correct ROUND() behavior
        - Added testcases for bug #24912 and all related bugs found
      sql/item_func.cc:
        Various changes to fix bug #24912 and all related bugs found:
        - honor unsigned_flag in various Item_* functions
        - correctly handle out-of-range numbers of decimals in Item_func_round::fix_length_and_dec()
        - changed the argument specifying the number of decimals in my_double_round() from int to longlong, added a new argument to pass the 'unsigned flag'
        - changed my_double_round() to correctly handle large values passed as the 'number of decimals' argument
        - added a my_double_round() analog for BIGINT UNSIGNED arguments (my_unsigned_round())
        - fixed Item_func_round()::int_op() to not overflow even when the result is within integer range
        - fixed a bug Item_founc_round()::decimal_op() which resulted in crash when a large number of decimals was passed to my_decimal_round()
      sql/item_func.h:
        Various fixed to correctly handle unsigned values.
      sql/item_strfunc.cc:
        Changed the call to my_double_round() to match the new declaration.
      sql/mysql_priv.h:
        Changed the declaration for my_double_round() to be able pass arbitrary integers as number of decimals (both signed and unsigned)
      67a74165
  2. 20 Mar, 2007 10 commits
  3. 19 Mar, 2007 6 commits
  4. 17 Mar, 2007 2 commits
    • unknown's avatar
      dbug/dbug.c: unused variable removed · fc9c22db
      unknown authored
      include/config-win.h: SIZEOF_INT
      include/my_global.h: win64 fix
      support-files/Makefile.am: automake magic
      
      
      dbug/dbug.c:
        unused variable removed
      include/config-win.h:
        SIZEOF_INT
      include/my_global.h:
        win64 fix
      support-files/Makefile.am:
        automake magic
      fc9c22db
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · e0e860d8
      unknown authored
      into  janus.mylan:/usr/home/serg/Abk/mysql-5.1
      
      
      sql/sql_insert.cc:
        Auto merged
      e0e860d8
  5. 16 Mar, 2007 20 commits
    • unknown's avatar
      wl#3700 - post-review fixes: · ce4c93bf
      unknown authored
      s/ulonglong/key_part_map/, comments
      
      
      include/heap.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      include/my_base.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      include/myisam.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      include/myisammrg.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      sql/event_db_repository.cc:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      sql/ha_partition.cc:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      sql/ha_partition.h:
        wl#3700 - post-review fixes:
        s/ulonglong/key_part_map/
      sql/sql_select.h:
        wl#3700 - post-review fixes:
        remove tab_to_keypart_map()
      ce4c93bf
    • unknown's avatar
      sql_insert.cc: · 3cc5e86f
      unknown authored
        Post-merge fix.
      
      
      sql/sql_insert.cc:
        Post-merge fix.
      3cc5e86f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · ec8c7219
      unknown authored
      into  janus.mylan:/usr/home/serg/Abk/mysql-5.1
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_help.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/table.h:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      ec8c7219
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/27006-bug-5.0-opt-mysql · 7ee6ebbe
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/test-5.1-opt-mysql
      
      
      mysql-test/r/trigger.result:
        Auto merged
      mysql-test/t/trigger.test:
        Auto merged
      sql/sql_insert.cc:
        Manually merged
      7ee6ebbe
    • unknown's avatar
      remove unnecessary line · b7c57129
      unknown authored
      b7c57129
    • unknown's avatar
      merging · 9e2a1d9c
      unknown authored
      9e2a1d9c
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 1579e852
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/insert_update.result:
        Auto merged
      mysql-test/t/insert_update.test:
        Auto merged
      mysql-test/t/skip_grants.test:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_insert.cc:
        merging
      1579e852
    • unknown's avatar
      Merge polly.local:/tmp/maint/bug23775/my50-bug23775 · 7c147038
      unknown authored
      into  polly.local:/tmp/maint/bug23775/my51-bug23775
      
      
      sql/slave.cc:
        Manual merge.
      7c147038
    • unknown's avatar
      Fix for bug #23775 "Replicated event larger that max_allowed_packet infinitely re-transmits". · 3d2c08fe
      unknown authored
      Problem: to handle a situation when the size of event on the master is greater than max_allowed_packet on slave, we checked for the wrong constant (ER_NET_PACKET_TOO_LARGE instead of CR_NET_PACKET_TOO_LARGE).
      
      Solution: test for the client "packet too large" error code instead of the server one in slave I/O thread.
      
      
      mysql-test/r/rpl_packet.result:
        Added test case for bug #23775 "Replicated event larger that max_allowed_packet infinitely re-transmits"
      mysql-test/t/rpl_packet.test:
        Added test case for bug #23775 "Replicated event larger that max_allowed_packet infinitely re-transmits"
      sql/slave.cc:
        Test for the client "packet too large" error code instead of the server one in slave I/O thread.
      3d2c08fe
    • unknown's avatar
      Bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY · 1238f850
      unknown authored
      UPDATE if the row wasn't actually changed.
      
      This bug was caused by fix for bug#19978. It causes AFTER UPDATE triggers
      not firing if a row wasn't actually changed by the update part of the
      INSERT .. ON DUPLICATE KEY UPDATE.
      
      Now triggers are always fired if a row is touched by the INSERT ... ON
      DUPLICATE KEY UPDATE.
      
      
      sql/sql_insert.cc:
        Bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY
        UPDATE if the row wasn't actually changed.
        Now triggers are always fired if a row is touched by the INSERT ... ON
        DUPLICATE KEY UPDATE.
      mysql-test/r/trigger.result:
        Added a test case for the bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY
        UPDATE if the row wasn't actually changed.
      mysql-test/t/trigger.test:
        Added a test case for the bug#27006: AFTER UPDATE triggers not fired with INSERT ... ON DUPLICATE KEY
        UPDATE if the row wasn't actually changed.
      1238f850
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 0dab9a38
      unknown authored
      into  janus.mylan:/usr/home/serg/Abk/mysql-5.1
      
      
      include/my_global.h:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/ha_partition.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/sp.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_servers.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      sql/table.h:
        Auto merged
      sql/tztime.cc:
        Auto merged
      storage/heap/ha_heap.cc:
        Auto merged
      storage/innobase/handler/ha_innodb.cc:
        Auto merged
      storage/myisam/ha_myisam.cc:
        Auto merged
      storage/myisammrg/ha_myisammrg.h:
        Auto merged
      0dab9a38
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 0583358e
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26261-5.0-opt
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      mysql-test/r/insert_update.result:
        SCCS merged
      mysql-test/t/insert_update.test:
        SCCS merged
      0583358e
    • unknown's avatar
      Bug #26261: · 6c2b21ba
      unknown authored
       INSERT uses query_id to verify what fields are
       mentioned in the fields list of the INSERT command.
       However the check for that is made after the 
       ON DUPLICATE KEY is processed. This causes all
       the fields mentioned in ON DUPLICATE KEY to be 
       considered as mentioned in the fields list of 
       INSERT.
       Moved the check up, right after processing the
       fields list.
      
      
      mysql-test/r/insert_update.result:
        Bug #26261: test case
      mysql-test/t/insert_update.test:
        Bug #26261: test case
      sql/mysql_priv.h:
        Bug #26261: moved the check inside mysql_prepare_insert
      sql/sql_insert.cc:
        Bug #26261: move the check inside mysql_prepare_insert
        before setting up the ON DUPLICATE KEY part
      sql/sql_prepare.cc:
        Bug #26261: moved the check inside mysql_prepare_insert
      6c2b21ba
    • unknown's avatar
      Merge sgluhov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · ed685138
      unknown authored
      into  mysql.com:/home/gluh/MySQL/Merge/5.0-opt
      
      ed685138
    • unknown's avatar
      Bug#26285 selecting information_schema crahes server · 723bac48
      unknown authored
      The crash happens when 'skip-grant-tables' is enabled.
      We skip the filling of I_S privilege tables 
      if acl_cache is not initialized.
      
      
      mysql-test/r/skip_grants.result:
        test result
      mysql-test/t/skip_grants.test:
        test case
      sql/sql_acl.cc:
        skip filling of I_S privilege tables
        if acl_cache is not initialized
      723bac48
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · d59530cb
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      d59530cb
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 0d851a4f
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      0d851a4f
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1-opt · f1389ad0
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      f1389ad0
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 01fde8e1
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      sql/sql_parse.cc:
        Auto merged
      01fde8e1
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · e09cfa30
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      sql/sql_parse.cc:
        Auto merged
      e09cfa30