1. 22 May, 2020 1 commit
  2. 20 May, 2020 6 commits
  3. 19 May, 2020 12 commits
  4. 18 May, 2020 5 commits
  5. 17 May, 2020 3 commits
  6. 16 May, 2020 1 commit
  7. 15 May, 2020 9 commits
    • Marko Mäkelä's avatar
      MDEV-13626: Make test more robust · 3f12a596
      Marko Mäkelä authored
      In commit b1742a5c we forgot
      FLUSH TABLES, potentially causing errors for MyISAM system tables.
      3f12a596
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · fc0960aa
      Marko Mäkelä authored
      fc0960aa
    • Marko Mäkelä's avatar
      MDEV-22544 Inconsistent and Incorrect rw-lock stats · c8dd4117
      Marko Mäkelä authored
      The rw_lock_stats were incorrectly updated.
      While global statistics have limited usefulness, we cannot
      remove them from a GA version. This contribution is slightly
      improving performance in write workloads.
      c8dd4117
    • Alexander Barkov's avatar
      MDEV-22579 No error when inserting DEFAULT(non_virtual_column) into a virtual column · 3df29727
      Alexander Barkov authored
      The code erroneously allowed both:
      INSERT INTO t1 (vcol) VALUES (DEFAULT);
      INSERT INTO t1 (vcol) VALUES (DEFAULT(non_virtual_column));
      
      The former is OK, but the latter is not.
      Adding a new virtual method in Item:
      
      virtual bool vcol_assignment_allowed_value() const { return false; }
      
      Item_null, Item_param and Item_default_value override it.
      
      Item_default_value overrides it in the way to:
      - allow DEFAULT
      - disallow DEFAULT(col)
      3df29727
    • Marko Mäkelä's avatar
      MDEV-22456 Dropping the adaptive hash index may cause DDL to lock up InnoDB · ad6171b9
      Marko Mäkelä authored
      If the InnoDB buffer pool contains many pages for a table or index
      that is being dropped or rebuilt, and if many of such pages are
      pointed to by the adaptive hash index, dropping the adaptive hash index
      may consume a lot of time.
      
      The time-consuming operation of dropping the adaptive hash index entries
      is being executed while the InnoDB data dictionary cache dict_sys is
      exclusively locked.
      
      It is not actually necessary to drop all adaptive hash index entries
      at the time a table or index is being dropped or rebuilt. We can let
      the LRU replacement policy of the buffer pool take care of this gradually.
      For this to work, we must detach the dict_table_t and dict_index_t
      objects from the main dict_sys cache, and once the last
      adaptive hash index entry for the detached table is removed
      (when the garbage page is evicted from the buffer pool) we can free
      the dict_table_t and dict_index_t object.
      
      Related to this, in MDEV-16283, we made ALTER TABLE...DISCARD TABLESPACE
      skip both the buffer pool eviction and the drop of the adaptive hash index.
      We shifted the burden to ALTER TABLE...IMPORT TABLESPACE or DROP TABLE.
      We can remove the eviction from DROP TABLE. We must retain the eviction
      in the ALTER TABLE...IMPORT TABLESPACE code path, so that in case the
      discarded table is being re-imported with the same tablespace identifier,
      the fresh data from the imported tablespace will replace any stale pages
      in the buffer pool.
      
      rpl.rpl_failed_drop_tbl_binlog: Remove the test. DROP TABLE can
      no longer be interrupted inside InnoDB.
      
      fseg_free_page(), fseg_free_step(), fseg_free_step_not_header(),
      fseg_free_page_low(), fseg_free_extent(): Remove the parameter
      that specifies whether the adaptive hash index should be dropped.
      
      btr_search_lazy_free(): Lazily free an index when the last
      reference to it is dropped from the adaptive hash index.
      
      buf_pool_clear_hash_index(): Declare static, and move to the
      same compilation unit with the bulk of the adaptive hash index
      code.
      
      dict_index_t::clone(), dict_index_t::clone_if_needed():
      Clone an index that is being rebuilt while adaptive hash index
      entries exist. The original index will be inserted into
      dict_table_t::freed_indexes and dict_index_t::set_freed()
      will be called.
      
      dict_index_t::set_freed(), dict_index_t::freed(): Note that
      or check whether the index has been freed. We will use the
      impossible page number 1 to denote this condition.
      
      dict_index_t::n_ahi_pages(): Replaces btr_search_info_get_ref_count().
      
      dict_index_t::detach_columns(): Move the assignment n_fields=0
      to ha_innobase_inplace_ctx::clear_added_indexes().
      We must have access to the columns when freeing the
      adaptive hash index. Note: dict_table_t::v_cols[] will remain
      valid. If virtual columns are dropped or added, the table
      definition will be reloaded in ha_innobase::commit_inplace_alter_table().
      
      buf_page_mtr_lock(): Drop a stale adaptive hash index if needed.
      
      We will also reduce the number of btr_get_search_latch() calls
      and enclose some more code inside #ifdef BTR_CUR_HASH_ADAPT
      in order to benefit cmake -DWITH_INNODB_AHI=OFF.
      ad6171b9
    • Marko Mäkelä's avatar
      Amend af784385: Avoid vtable overhead · ff66d65a
      Marko Mäkelä authored
      When neither MSAN nor Valgrind are enabled, declare
      Field::mark_unused_memory_as_defined() as an empty inline function,
      instead of declaring it as a virtual function.
      ff66d65a
    • Eugene Kosov's avatar
      span cleanup · 1cac6d48
      Eugene Kosov authored
      1cac6d48
    • Monty's avatar
      Fix for using uninitialized memory · af784385
      Monty authored
      MDEV-22073 MSAN use-of-uninitialized-value in
      collect_statistics_for_table()
      
      Other things:
      innodb.analyze_table was changed to mainly test statistic
      collection. Was discussed with Marko.
      af784385
    • Monty's avatar
      Fixed bugs found by valgrind · 277aa85c
      Monty authored
      Other things:
      - Removed innodb_encryption_tables.test from valgrind as it
        takes a REALLY long time
      277aa85c
  8. 14 May, 2020 3 commits
    • Varun Gupta's avatar
      MDEV-22498: SIGSEGV in Bitmap<64u>::merge on SELECT · efd68f5e
      Varun Gupta authored
      For the case when the optimizer does the IN-EXISTS transformation,
      the equality condition is injected in the WHERE OR HAVING clause of
      the subquery. If the select list of the subquery has a reference to
      the parent select make sure to use the reference and not the original
      item.
      efd68f5e
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 1b165720
      Marko Mäkelä authored
      1b165720
    • Marko Mäkelä's avatar
      MDEV-22070 MSAN use-of-uninitialized-value in encryption.innodb-redo-badkey · ee5152fc
      Marko Mäkelä authored
      On a checksum failure of a ROW_FORMAT=COMPRESSED page,
      buf_LRU_free_one_page() would invoke buf_LRU_block_remove_hashed()
      which will read the uncompressed page frame, although it would not
      be initialized. With bad enough luck, fil_page_get_type(page)
      could return an unrecognized value and cause the server to abort.
      
      buf_page_io_complete(): On the corruption of a ROW_FORMAT=COMPRESSED
      page, zerofill the uncompressed page frame.
      ee5152fc