1. 16 Sep, 2010 1 commit
    • unknown's avatar
      MWL#89: Cost-based choice between Materialization and IN->EXISTS transformation · c571f653
      unknown authored
      - Corrected a wrong result that was recorded by the MySQL fix for BUG#39069.
      
      - Removed Item_func_isnull::cached_value and all the logic around this custom-made
        caching of the NULL result because MWL#89 optimizes subqueries before the outer
        query is being executed, and this cache cannot be made easily to work for all
        kinds of Items (specifically Item_sum_sum, but others too).
      c571f653
  2. 06 Sep, 2010 2 commits
    • unknown's avatar
      e8bbf995
    • unknown's avatar
      MWL#89: Cost-based choice between Materialization and IN->EXISTS transformation · 2f12caa6
      unknown authored
      Fixed a crash in Item_equal::fix_length_and_dec that was a result of the
      architecture of the MWL#89 subquery optimization.
      
      The injection of IN->EXISTS predicates for subqueries happened inside
      make_join_statistics, after constant substitution, but before multiple
      equality substitution done by substitute_for_best_equal_field. As a
      result, when we called fix_fields for the WHERE clause after the injection
      of IN->EXISTS predicates, Item_equal was not fixed, and it was in a state
      not anticipated by Item_equal::fix_length_and_dec - the Item_equal
      containted only a constant, and no fields at all.
      
      The fix takes into account this new possible state when calling fix_fields.
      2f12caa6
  3. 05 Sep, 2010 1 commit
  4. 18 Jul, 2010 2 commits
    • unknown's avatar
      MWL#89: Cost-based choice between Materialization and IN->EXISTS transformation · 024fe1c3
      unknown authored
        
      Step2 in the separation of the creation of IN->EXISTS equi-join conditions from
      their injection. The goal of this separation is to make it possible that the
      IN->EXISTS conditions can be used for cost estimation without actually modifying
      the subquery.
        
      This patch separates row_value_in_to_exists_transformer() into two methods:
      - create_row_value_in_to_exists_cond(), and
      - inject_row_value_in_to_exists_cond()
      The patch performs minimal refactoring of the code so that it is easier to solve
      problems resulting from the separation. There is a lot to be simplified in this
      code, but this will be done separately.
      024fe1c3
    • unknown's avatar
      MWL#89: Cost-based choice between Materialization and IN->EXISTS transformation · c0a96d2a
      unknown authored
      Step1 in the separation of the creation of IN->EXISTS equi-join conditions from
      their injection. The goal of this separation is to make it possible that the
      IN->EXISTS conditions can be used for cost estimation without actually modifying
      the subquery.
      
      This patch separates single_value_in_to_exists_transformer() into two methods:
      - create_single_value_in_to_exists_cond(), and
      - inject_single_value_in_to_exists_cond()
      The patch performs minimal refactoring of the code so that it is easier to solve
      problems resulting from the separation. There is a lot to be simplified in this
      code, but this will be done separately.
      c0a96d2a
  5. 16 Jul, 2010 7 commits
    • unknown's avatar
      Merge main 5.3 into 5.3-mwl89. · 6c79986f
      unknown authored
      6c79986f
    • unknown's avatar
      Fixed a problem where the temp table of a materialized subquery · ce0b598a
      unknown authored
      was not cleaned up between PS re-executions. The reason was two-fold:
      - a merge with mysql-6.0 missed select_union::cleanup() that should
        have cleaned up the temp table, and
      - the subclass of select_union used by materialization didn't call
        the base class cleanup() method.
      ce0b598a
    • unknown's avatar
      MWL#89: Cost-based choice between Materialization and IN->EXISTS transformation · 5ab66ffd
      unknown authored
      1. Changed the lazy optimization for subqueries that can be
         materialized into bottom-up optimization during the optimization of
         the main query.
      
         The main change is implemented by the method
         Item_in_subselect::setup_engine.
        
         All other changes were required to correct problems resulting from
         changing the order of optimization. Most of these problems followed
         the same pattern - there are some shared structures between a
         subquery and its parent query. Depending on which one is optimized
         first (parent or child query), these shared strucutres may get
         different values, thus resulting in an inconsistent query plan.
      
      2. Changed the code-generation for subquery materialization to be
         performed in runtime memory for each (re)execution, instead of in
         statement memory (once per prepared statement).
         - Item_in_subselect::setup_engine() no longer creates materialization
           related objects in statement memory.
         - Merged subselect_hash_sj_engine::init_permanent and
           subselect_hash_sj_engine::init_runtime into
           subselect_hash_sj_engine::init, which is called for each
           (re)execution.
         - Fixed deletion of the temp table accordingly.
      
      
      mysql-test/r/subselect_mat.result:
        Adjusted changed EXPLAIN because of earlier optimization of subqueries.
      5ab66ffd
    • Sergey Petrunya's avatar
      Merge · 201e124d
      Sergey Petrunya authored
      201e124d
    • Sergey Petrunya's avatar
      Fix @@optimizer_switch support · aed88ae2
      Sergey Petrunya authored
      - Let "mysqld  --help --verbose" list all optimizer options
      - Make it possible to add new @@optimizer_switch flags w/o causing .result 
        changes all over the testsuite:
        = Remove "select @@optimizer_switch" from tests that do not need all switches
        = Move @@optimizer_switch-specific tests to t/optimizer_switch.test
      aed88ae2
    • Michael Widenius's avatar
      Merge with new queue code. · 6b161f65
      Michael Widenius authored
      Updated configure.in to have version 5.3
      
      configure.in:
        Updated to version 5.3.0
      6b161f65
    • Michael Widenius's avatar
      Improved speed of thr_alarm from O(N) to O(1). thr_alarm is used to handle... · 772afcc4
      Michael Widenius authored
      Improved speed of thr_alarm from O(N) to O(1). thr_alarm is used to handle timeouts and kill of connections.
      Fixed compiler warnings.
      queues.h and queues.c are now based on the UNIREG code and thus made BSD.
      Fix code to use new queue() interface. This mostly affects how you access elements in the queue.
      If USE_NET_CLEAR is not set, don't clear connection from unexpected characters. This should give a speed up when doing a lot of fast queries.
      Fixed some code in ma_ft_boolean_search.c that had not made it from myisam/ft_boolean_search.c
      
      
      include/queues.h:
        Use UNIREG code base (BSD)
        Changed init_queue() to take all initialization arguments.
        New interface to access elements in queue
      include/thr_alarm.h:
        Changed to use time_t instead of ulong (portability)
        Added index_in_queue, to be able to remove random element from queue in O(1)
      mysys/queues.c:
        Use UNIREG code base (BSD)
        init_queue() and reinit_queue() now takes more initialization arguments. (No need for init_queue_ex() anymore)
        Now one can tell queue_insert() to store in the element a pointer to where element is in queue. This allows one to remove elements from queue in O(1) instead of O(N)
      mysys/thr_alarm.c:
        Use new option in queue() to allow fast removal of elements.
        Do less inside LOCK_alarm mutex.
        This should give a major speed up of thr_alarm usage when there is many threads
      sql/create_options.cc:
        Fixed wrong printf
      sql/event_queue.cc:
        Use new queue interface()
      sql/filesort.cc:
        Use new queue interface()
      sql/ha_partition.cc:
        Use new queue interface()
      sql/ha_partition.h:
        Fixed compiler warning
      sql/item_cmpfunc.cc:
        Fixed compiler warning
      sql/item_subselect.cc:
        Use new queue interface()
        Removed not used variable
      sql/net_serv.cc:
        If USE_NET_CLEAR is not set, don't clear connection from unexpected characters.
        This should give a speed up when doing a lot of fast queries at the disadvantage that if there is a bug in the client protocol the connection will be dropped instead of being unnoticed.
      sql/opt_range.cc:
        Use new queue interface()
        Fixed compiler warnings
      sql/uniques.cc:
        Use new queue interface()
      storage/maria/ma_ft_boolean_search.c:
        Copy code from myisam/ft_boolean_search.c
        Use new queue interface()
      storage/maria/ma_ft_nlq_search.c:
        Use new queue interface()
      storage/maria/ma_sort.c:
        Use new queue interface()
      storage/maria/maria_pack.c:
        Use new queue interface()
        Use queue_fix() instead of own loop to fix queue.
      storage/myisam/ft_boolean_search.c:
        Use new queue interface()
      storage/myisam/ft_nlq_search.c:
        Use new queue interface()
      storage/myisam/mi_test_all.sh:
        Remove temporary file from last run
      storage/myisam/myisampack.c:
        Use new queue interface()
        Use queue_fix() instead of own loop to fix queue.
      storage/myisam/sort.c:
        Use new queue interface()
      storage/myisammrg/myrg_queue.c:
        Use new queue interface()
      storage/myisammrg/myrg_rnext.c:
        Use new queue interface()
      storage/myisammrg/myrg_rnext_same.c:
        Use new queue interface()
      storage/myisammrg/myrg_rprev.c:
        Use new queue interface()
      772afcc4
  6. 15 Jul, 2010 2 commits
  7. 10 Jul, 2010 1 commit
    • unknown's avatar
      Subquery cache (MWL#66) added. · ea1b32a3
      unknown authored
      
      libmysqld/Makefile.am:
        The new file added.
      mysql-test/r/index_merge_myisam.result:
        subquery_cache optimization option added.
      mysql-test/r/myisam_mrr.result:
        subquery_cache optimization option added.
      mysql-test/r/subquery_cache.result:
        The subquery cache tests added.
      mysql-test/r/subselect3.result:
        Subquery cache switched off to avoid changing read statistics.
      mysql-test/r/subselect3_jcl6.result:
        Subquery cache switched off to avoid changing read statistics.
      mysql-test/r/subselect_no_mat.result:
        subquery_cache optimization option added.
      mysql-test/r/subselect_no_opts.result:
        subquery_cache optimization option added.
      mysql-test/r/subselect_no_semijoin.result:
        subquery_cache optimization option added.
      mysql-test/r/subselect_sj.result:
        subquery_cache optimization option added.
      mysql-test/r/subselect_sj_jcl6.result:
        subquery_cache optimization option added.
      mysql-test/t/subquery_cache.test:
        The subquery cache tests added.
      mysql-test/t/subselect3.test:
        Subquery cache switched off to avoid changing read statistics.
      sql/CMakeLists.txt:
        The new file added.
      sql/Makefile.am:
        The new files added.
      sql/item.cc:
        Expression cache item (Item_cache_wrapper) added.
        Item_ref and Item_field fixed for correct usage of result field and fast resolwing in SP.
      sql/item.h:
        Expression cache item (Item_cache_wrapper) added.
        Item_ref and Item_field fixed for correct usage of result field and fast resolwing in SP.
      sql/item_cmpfunc.cc:
        Subquery cache added.
      sql/item_cmpfunc.h:
        Subquery cache added.
      sql/item_subselect.cc:
        Subquery cache added.
      sql/item_subselect.h:
        Subquery cache added.
      sql/item_sum.cc:
        Registration of subquery parameters added.
      sql/mysql_priv.h:
        subquery_cache optimization option added.
      sql/mysqld.cc:
        subquery_cache optimization option added.
      sql/opt_range.cc:
        Fix due to subquery cache.
      sql/opt_subselect.cc:
        Parameters of the function cahnged.
      sql/procedure.h:
        .h file guard added.
      sql/sql_base.cc:
        Registration of subquery parameters added.
      sql/sql_class.cc:
        Option to allow add indeces to temporary table.
      sql/sql_class.h:
        Item iterators added.
        Option to allow add indeces to temporary table.
      sql/sql_expression_cache.cc:
        Expression cache for caching subqueries added.
      sql/sql_expression_cache.h:
        Expression cache for caching subqueries added.
      sql/sql_lex.cc:
        Registration of subquery parameters added.
      sql/sql_lex.h:
        Registration of subqueries and subquery parameters added.
      sql/sql_select.cc:
        Subquery cache added.
      sql/sql_select.h:
        Subquery cache added.
      sql/sql_union.cc:
        A new parameter to the function added.
      sql/sql_update.cc:
        A new parameter to the function added.
      sql/table.cc:
        Procedures to manage temporarty tables index added.
      sql/table.h:
        Procedures to manage temporarty tables index added.
      storage/maria/ha_maria.cc:
        Fix of handler to allow destoy a table in case of error during the table creation.
      storage/maria/ha_maria.h:
        .h file guard added.
      storage/myisam/ha_myisam.cc:
        Fix of handler to allow destoy a table in case of error during the table creation.
      ea1b32a3
  8. 06 Jul, 2010 1 commit
    • Sergey Petrunya's avatar
      Fix buildbot valgrind failure · e7f5faf6
      Sergey Petrunya authored
      - Item_in_subselect::init_left_expr_cache() should not try to 
        guess whether the left expression is accessed "over the grouping operation"
        (i.e. the subselect is evaluated after the grouping while the left_expr is
         an Item_ref that wraps an expression from before the grouping). Instead, 
        let new_Cached_item not to try accessing item->real_item() when creating 
        left expr cache.
      e7f5faf6
  9. 02 Jul, 2010 1 commit
  10. 27 Jun, 2010 1 commit
  11. 26 Jun, 2010 7 commits
  12. 14 Jun, 2010 1 commit
  13. 07 Jun, 2010 2 commits
  14. 05 Jun, 2010 1 commit
    • Sergei Golubchik's avatar
      few small MySQL bugs/issues that impact the engines, as discussed in the SE summit · 4b977e4c
      Sergei Golubchik authored
      * remove handler::index_read_last()
      * create handler::keyread_read_time() (was get_index_only_read_time() in opt_range.cc)
      * ha_show_status() allows engine's show_status() to fail
      * remove HTON_FLUSH_AFTER_RENAME
      * fix key_cmp_if_same() to work for floats and doubles
      * set table->status in the server, don't force engines to do it
      * increment status vars in the server, don't force engines to do it
      
      mysql-test/r/status_user.result:
        correct test results - innodb was wrongly counting internal
        index searches as handler_read_* calls.
      sql/ha_partition.cc:
        compensate for handler incrementing status counters -
        we want to count only calls to underlying engines
      sql/handler.h:
        inline methods moved to sql_class.h
      sql/key.cc:
        simplify the check
      sql/opt_range.cc:
        move get_index_only_read_time to the handler class
      sql/sp.cc:
        don't use a key that's stored in the record buffer -
        the engine can overwrite the buffer with anything, destroying the key
      sql/sql_class.h:
        inline handler methods that need to see THD and TABLE definitions
      sql/sql_select.cc:
        no ha_index_read_last_map anymore
      sql/sql_table.cc:
        remove HTON_FLUSH_AFTER_RENAME
      sql/table.cc:
        set HA_CAN_MEMCMP as appropriate
      sql/tztime.cc:
        don't use a key that's stored in the record buffer -
        the engine can overwrite the buffer with anything, destroying the key
      storage/myisam/ha_myisam.cc:
        engines don't need to update table->status or use ha_statistic_increment anymore
      storage/myisam/ha_myisam.h:
        index_read_last_map is no more
      4b977e4c
  15. 03 Jun, 2010 2 commits
    • Sergei Golubchik's avatar
      include guards · 5eb46fe8
      Sergei Golubchik authored
      5eb46fe8
    • Sergei Golubchik's avatar
      fixes for test suite · e9548f58
      Sergei Golubchik authored
      mysql-test/suite/pbxt/r/mysqlshow.result:
        update the forgotten test results
      sql/table.cc:
        add defensive asserts.
        fix the code that didn't in MySQL > 5.2.0 with frm's created before 5.1.10
      e9548f58
  16. 02 Jun, 2010 1 commit
  17. 01 Jun, 2010 1 commit
  18. 31 May, 2010 1 commit
  19. 28 May, 2010 1 commit
  20. 27 May, 2010 3 commits
    • Sergei Golubchik's avatar
      ac0bf0f4
    • Sergei Golubchik's avatar
    • Michael Widenius's avatar
      Fixed compiler warnings · b9ef7ca1
      Michael Widenius authored
      Fixed failing test innodb.innodb-autoinc.test
      Enabled innodb test suite
      
      mysql-test/mysql-test-run.pl:
        Enabled innodb test suite
      mysql-test/r/innodb-autoinc.result:
        Removed test as it exists in suite innodb
      mysql-test/suite/innodb/t/disabled.def:
        Removed innodb-autoinc
      mysql-test/suite/innodb/t/innodb-autoinc.test:
        Update to be able to run with plugin
      mysql-test/t/innodb-autoinc.test:
        Removed test as it exists in suite innodb
      sql/filesort.cc:
        Removed not used variable
      sql/slave.cc:
        Remove compiler warnings
      storage/pbxt/src/ha_pbxt.cc:
        Removed not used variable
      storage/xtradb/dict/dict0crea.c:
        Fixed compiler warning about unsigned comparison
      support-files/compiler_warnings.supp:
        Disable some not relevant warnings
      b9ef7ca1
  21. 26 May, 2010 1 commit
    • Michael Widenius's avatar
      Added macros to inform valgrind that memory is uninitialized · 03adc61d
      Michael Widenius authored
      include/Makefile.am:
        Make my_valgrind.h global (as it's used by my_global.h)
      include/my_global.h:
        Include my_valgrind.h
      include/my_sys.h:
        TRASH() moved to my_valgrind.h
      include/my_valgrind.h:
        Add VALGRIND defines to mark memory
      mysys/my_alloc.c:
        Mark internal freed memory as undefined
      03adc61d